- 16 Nov, 2020 4 commits
-
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1cda495274bb..1f2fcddd3963 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I58eb5b7305b9a8d810445c24a5b3f779abea337b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2539736Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/128608f6da3a..9d3ef3258715 2020-11-13 pankratz@ualberta.ca layers: Removed duplicate type declaration 2020-11-13 mark@lunarg.com scripts: Suppress warning for empty difflist 2020-11-13 mark@lunarg.com scripts: Remove format checking shell scripts 2020-11-13 mark@lunarg.com scripts: Add python format-checking script and update travis 2020-11-11 mark@lunarg.com tests: Add oldSwapchain-from-different-device test 2020-11-11 mark@lunarg.com threading: Make swapchain objects traceable to parent 2020-11-10 mark@lunarg.com tests: Added specialuse extension BP tests 2020-11-10 mark@lunarg.com practices: Add checking of specialuse extensions 2020-11-10 mark@lunarg.com practices: Check for specialuse extensions and warn 2020-11-10 mark@lunarg.com practices: Added specialuse extension table 2020-11-10 karl@lunarg.com layers: Fix typedef and spelling 2020-11-10 jeremyg@lunarg.com syncval: Convert enum SyncStageAccessFlags to a std::bitset 2020-11-10 jeremyg@lunarg.com syncval: Change generated lookup tables to be const. 2020-11-10 marshall@sanctuary.ai tests: Test queue retirement over timeline semaphores 2020-11-10 marshall@sanctuary.ai layers: Fix queue retirement via waited-on timeline semaphores 2020-11-06 rgarcia@igalia.com layers: Check nullDescriptor when validating vertex attributes 2020-11-05 shannon@lunarg.com build: Update known-good files for 1.2.159 header 2020-11-05 orbea@riseup.net cmake: Install the header files into the vulkan directory 2020-11-05 liyl@google.com build: Allow generating layers json file for cross-compiling 2020-11-05 courtneygo@google.com Fix missing source reference 2020-11-05 s.fricke@samsung.com layers: Change copy2 VU from int to string 2020-11-05 orbea@riseup.net cmake: Silence warnings 2020-11-05 orbea@riseup.net cmake: Add BUILD_WERROR 2020-11-05 s.fricke@samsung.com layers: Add VUID 01591 2020-11-05 s.fricke@samsung.com tests: Add VUID 04113 and 04114 2020-11-05 s.fricke@samsung.com layers: Add VUID 04113 and 04114 2020-11-04 s.fricke@samsung.com layers: Label 04101 and 04010 2020-11-04 s.fricke@samsung.com layers: Add Android 24 and 25 support 2020-11-04 tony@lunarg.com docs: Fix enabling debug printf 2020-11-04 skdkksfadkadkk@gmail.com layers: Fix checks for 01508 and 01509 2020-11-04 neel.bedekar@gmail.com layers: Remove unnecessary FDM tiling check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ia46d51356fa2642e00945fb27a1e2c45e9079ce8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2539737Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/28c8eb1aa6b4..089f5a3ecbe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/cc35ecde81..aae1d0b405 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/206a91f987..6e80ad9688 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/57b05d3c2e..e3626aae54 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f92a7636da * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0d3a3334ed..5f49307749 No update to Clang. Bug: angleproject:5338 Tbr: timvp@google.com Change-Id: I06724ce0a056b0522425995de6290d7e13b86ce5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2538727Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Xiaoxuan Liu authored
How to enable: add below args config to args.gn in linux build ``` use_x11=false use_ozone=false angle_vulkan_display_mode="headless" ``` Bug: angleproject:5260 Change-Id: Iec931e74c061b56376ef028814859aa58af07f2f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2536518 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
- 14 Nov, 2020 4 commits
-
-
Tim Van Patten authored
The feature names were recently updated to match their member variables, however a few instances of "emulated_prerotation_" were missed, which breaks using the --emulated-pre-rotation flag for dEQP tests. Bug: b/172704839 Change-Id: I6af5cd866bff0752964e193132280f5e8fcf1528 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2536902Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/e2b55419a370..be6ccb9ecaf7 2020-11-13 shabbyx@gmail.com Reland "Generate libvulkan.so.1 on Linux instead of libvulkan.so" Bug: angleproject:5216 Tbr: timvp@google.com,syoussefi@google.com Change-Id: I235a2ba30600a23b7d9a617c40f88e1d2015d473 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2538430Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
If glTexBuffer is used, the width should be calculated based on the buffer size. Since ES doesn't have immutable buffers, EXT_texture_buffer allows mutable buffers to be attached to the texture. This means that updates to the buffer must update the image description. This is done by having the texture observe the attached buffer. Bug: angleproject:3573 Bug: angleproject:5334 Test: dEQP-GLES31.functional.state_query.texture_level.texture_buffer.width_* Test: TextureBufferTestES31.QueryWidthAfterBufferResize Change-Id: I7d9e5344a3d4ea70da7ba525f13b5876481a70a3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533495 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
Suppress TransformFeedbackTest::BufferOutOfMemory() for Metal on Intel and AMD. Bug: angleproject:5345 Test: TransformFeedbackTest.BufferOutOfMemory/ES3_Metal Change-Id: Ic873e2e83786d610db891e92cd3b9ac3057ec0ec Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2536903 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 13 Nov, 2020 23 commits
-
-
Shahbaz Youssefi authored
- Fixes a crash with glTexBuffer given 0 as buffer. - Fixes query of TEXTURE_BUFFER_SIZE. If glTexBuffer is used to bind a buffer, and the buffer is modified, the result of this query must adapt to the new buffer size. The spec mentions that unlike Desktop GL, ES doesn't have immutable buffers, and so they had no choice but to allow mutable buffers. Bug: angleproject:3573 Test: KHR-GLES31.core.texture_buffer.texture_buffer_parameters Test: dEQP-GLES31.functional.texture.texture_buffer.state_query.texture_buffer_size_integer Change-Id: Iec77c14ccf0e9ee11a171dbe2c7386678304bcc8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533494 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Stephen White authored
Bug: angleproject:5343 Change-Id: I27735c814ab5e4cafe1f1a9e9577e27a2d5ad6a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537237 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Stephen White authored
Bug: angleproject:5343 Change-Id: Ib3dcdf640a4d7f097c5e094bb18acb96f0a5510b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537233 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
Suppress the following erroneous VVL error: VUID-VkSubpassDescriptionDepthStencilResolve-depthResolveMode-parameter Bug: angleproject:5331 Change-Id: I010d5c56e668eb1e1c500fece570d6e20d3c5a54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537918Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Tim Van Patten authored
Add the following flag to the test runner to aid debugging: --delay-test-start=<number of seconds> This delays the start of each test by <number of seconds>. This is useful when using debuggers, like RenderDoc, that need some extra time to attach to the process before capturing data. Bug: angleproject:5312 Change-Id: Ie1aab155e780dfae7311e046af0a7702904cd9eb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2522504Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Stephen White authored
Bug: angleproject:5343 Change-Id: I8d24e27df052ea6f811ea5ed15c7ee5256d516ef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537232Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org>
-
Jamie Madill authored
This reverts commit e3e964f9. Reason for revert: Crashing in ANGLE. See: https://github.com/KhronosGroup/glslang/issues/2452 Original change's description: > Roll glslang from 142cb87f803d to beec2e4a7c4d (12 revisions) > > https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/142cb87f803d..beec2e4a7c4d > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/glslang-angle-autoroll > Please CC timvp@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: None > Tbr: timvp@google.com > Change-Id: Id080fa0082678bbd1c5cf0e2a80b6f274b6fdb1c > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537654 > Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> TBR=timvp@google.com,angle-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I74df7e875299dfd12ed4d91aec8513218ef54c7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537234Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*real_commando_secret_mission*" Bug: b/172979023 Change-Id: Ifcb283d06bea78732d0f5daf9b1dfbb915fb9fab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2530458Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/df1edd1738a6..67d0fc6389ff 2020-11-12 charles@lunarg.com vulkaninfo: Make json output print extensions 2020-11-12 shannon@lunarg.com build: Update known-good files for 1.2.160 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I4bd5b9c9e9ae6b58979c977413ba59c92a2a8bb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537656Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/142cb87f803d..beec2e4a7c4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Id080fa0082678bbd1c5cf0e2a80b6f274b6fdb1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537654Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4ed9d3498dcf..e4c1a25cc679 2020-11-13 capn@google.com Use LLVM JIT for MemorySanitizer GN builds 2020-11-12 srisser@google.com Update vulkan headers to 1.2.160 2020-11-12 swiftshader.regress@gmail.com Regres: Update test lists @ 4804ac87 2020-11-12 zzyiwei@google.com Disable VK_KHR_external_memory_fd for Android build 2020-11-12 natsu@google.com Handle image properties from external device memory 2020-11-12 capn@google.com Fix conditionally enabling Reactor MSan instrumentation 2020-11-12 capn@google.com Implement MemorySanitizer instrumentation of Reactor routines 2020-11-11 nicolascapens@google.com Fix backslash interpreted as part of URL 2020-11-11 srisser@google.com Implement VK_KHR_shader_float_controls 2020-11-11 amaiorano@google.com Subzero: clang-format crosstest, pnacl-llvm, runtime, and unittest 2020-11-11 amaiorano@google.com Subzero: clang-format src 2020-11-11 capn@google.com Fix LLVM host triple for ORCv2 JIT 2020-11-11 srisser@google.com Add SPIR-V tools dependency to BUILD.gn files 2020-11-11 natsu@google.com Fix Android build 2020-11-11 amaiorano@google.com Add a unit test for bug fixed by swiftshader-cl/50008 2020-11-10 srisser@google.com Track SPIR-V version in VkConfig.hpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:4482 Tbr: timvp@google.com Change-Id: I691bca1adfb2dbd6e8dbf264a75c8cf6611f3037 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537655Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/a927c079f7db..28c8eb1aa6b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b666d10c4b..cc35ecde81 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/df93979064..206a91f987 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..f92a7636da * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/3aa688cdf8..013c5b992a * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/cfce7ca8c9..0d3a3334ed No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: I67cab2f05aaa50c7993eab6adf52bf7fdcdeb8f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2537083Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
If a clear is deffered on the swapchain image, then the clear should be applied before swap takes effect. Bug: angleproject:5262 Change-Id: I61aa8ab2983258a02c25a150e6d8c2d2bdbdf97a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2506780Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
For angle_deqp_gles3*_rotateN_tests, this change defaults --emulated-pre-rotation to N. Bug: angleproject:4901 Change-Id: I24d1b93d6601b85e608c9632de546283f519632a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2535675Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
Previously addr2line was called for every symbol separately. This was glacially slow as every module's debug info was repeatedly reloaded. With this change, contiguous symbols from the same module are batched together and one call to addr2line is done. Potential future optimization is to batch every symbol from the same module, but capture the output of addr2line calls and interleave them to match the stack. For example, currently 4 calls to addr2line are made for the following stack trace: moduleA(+addr1) moduleA(+addr2) moduleB(+addr3) moduleB(+addr4) moduleA(+addr5) moduleA(+addr6) moduleB(+addr7) moduleB(+addr8) while technically only two calls are necessary. Bug: angleproject:5239 Change-Id: I58742b85409b0b74bb87272bc63e251a2d0fe0e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2535682 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Shahbaz Youssefi authored
Take the following situation, a simple copy from image to buffer: ANGLE_TRY(contextVk->onBufferTransferWrite(buffer)); ANGLE_TRY(contextVk->onImageTransferRead(aspectFlags, image)); CommandBuffer &commandBuffer = contextVk->getOutsideRenderPassCommandBuffer(); commandBuffer.copyImageToBuffer(imageHandle, layout, bufferHandle, 1, regions); Both `onBufferTransferWrite` and `onImageTransferRead` may flush either the outsideRP or insideRP command buffers. If buffer is not previously used, but image is used: - onBufferTransferWrite: buffer usage is recorded in outsideRP1 - onImageTransferREad: outsiderRP1 is flushed, outsideRP2 is started - copyImageToBuffer: recorded on outsideRP2, but buffer usage not recorded there - A following command that uses the buffer and requires barrier doesn't close outsideRP2 as it believes it was not used there Bug: angleproject:5319 Change-Id: Ib8994083fbc21969a538cda3784adee57b089415 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2523388 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This closes a few more places where the asynchronous abstraction was leaking through. We can no longer access VkQueues directly from RendererVk. Bug: b/172704839 Change-Id: Idc06ee73816147cf602f21723e75bc5ee842d3e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525145 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This merges the 'commandProcessor' and 'asyncCommandProcessing' features into one new 'asyncCommandQueue' features. Conceptually the command processor is asynchronous use of the CommandQueue. This renaming updates the code to reflect the usage. Bug: b/172704839 Change-Id: I1d7ca1187f802eed48823a01b57fb520527f2540 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525144 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This consolidates all relevant logic in a single place. We no longer need to interact with ContextVk in the worker thread. This switches the fixed pointer array size to a dynamically sized vector. Some of the EGL and ANGLE tests would use a large number of Contexts and we were consistently running out of available command buffers which would cause a deadlock situation. We can trust other parts of the code to throttle the application if it starts to get too far ahead of the device and dispense with the hard coded limit in the command buffer allocator itself. The resulting code is also quite a bit simpler and doesn't need a condition variable. Also fixes missing initialization in SecondaryCommandBuffer. Bug: b/172704839 Change-Id: Icc3a3daf5d6b272db556c0e4c93fb793583966a5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525143 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Jamie Madill authored
Bug: b/172704839 Change-Id: I43a40e6a3e1eb00a7ddebfba6e915437aa69aeb6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525141 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Shahbaz Youssefi authored
Bug: angleproject:3573 Test: dEQP.KHR_GLES31/core_texture_buffer_texture_buffer_errors Change-Id: I031abd94d6c06e539a2a89a82f2af604a6f3b5b8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533493Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
The intent is to merge these two classes and remove redundant code. Bug: b/172704839 Change-Id: I6eb66d7b4ddea3633b08df99464975cd59773b4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524550 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Tim Van Patten authored
Suppress the following erroneous VVL error: VUID-VkSubpassDescriptionDepthStencilResolve-stencilResolveMode-parameter Bug: angleproject:5331 Change-Id: I403b7e4beaa17fd36e6a8e572c55ec22353e6b80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2534394Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
- 12 Nov, 2020 9 commits
-
-
Charlie Lao authored
Instead of using uniform, use flip/rotation specialization constant when available. This allows matrix multiplication calculated at compile time instead of shader execution time. Bug: angleproject:4901 Bug: angleproject:3589 Change-Id: I5a8a82b1cffbbbeba2617cb7e9a0ec38f9984d50 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2530457 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com>
-
Jamie Madill authored
This progresses the goal of merging TaskProcessor and CommandQueue. Moving the serial management out of RendererVk allows these classes to have finer control over when thread synchronization locks happen. Note: device lost handling seems untested currently. Bug: b/172704839 Change-Id: I0cc61e1ffe41aad0b898d4146c8dbd08a2cebd3c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525140 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Jamie Madill authored
This change should aid further refactorings. In the future if we need to support waiting for individual queue idle we can add that back in a way that's supported by both synchronous and async queue operation. Bug: b/172704839 Change-Id: I9c9900ac81af60a37719439fe9db6135fcb17d46 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2525146 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Tim Van Patten authored
The dEQP tests KHR-GLES3.copy_tex_image_conversions.* are crashing on Pixel 2 after outputting many VVL errors: VUID-vkAllocateMemory-maxMemoryAllocationCount-04101 Skipping the tests for now to unblock the VVL rolls. Bug: angleproject:5340 Change-Id: I8e7606da5262454bbc8c8658886e03f05265c24f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2534403Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Tim Van Patten <timvp@google.com>
-
Charlie Lao authored
This is a reland of 47b3db22 Original change's description: > Vulkan: Let shader use rotation specialized constant > > If use rotation specialized constant is enabled via compiler options, > this CL will use rotation specialized constant to generate flipXY, > rotation matrix and negFlipXY. This allows the driver to optimize for > the minimum instructions for rotation. > > Bug: b/171750979 > Change-Id: I9851ac999d4d35b9f230f796e5445bca0dcb1e77 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2514773 > Commit-Queue: Charlie Lao <cclao@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Tim Van Patten <timvp@google.com> Bug: b/171750979 Change-Id: I9efde40eb138bacb161cce483a30ec01fee0983b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533933 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Charlie Lao authored
The driver uniform code is used by various tree_ops functions. But all driver uniform code are defined and implemented in the TranslatorVulkan.cpp file. There is dependency rule that tree_ops code can not call into vulkan specific function. Right now we are working around this problem by always having TranslatorVulkan creates uniform and pass it down to tree_ops. This creates inefficiency for cases that dFdy/dFdx where we don't know if we will need the driver uniform or not, until we walk the tree and see the dFdx node. This CL refactors driver uniform code into its own file and class under tree_utils so that everybody can use. Mean time we can also make it much easier for metal to expand it to have its own uniform structure. Bug: b/173047182 Change-Id: I06bd9a005ccd6dc0a21321a3010dda1eab9d6fdb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2533443 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This is no longer necessary with the removal of the submit fence. Bug: b/172704839 Change-Id: If8c2795d7e3c73453a235498ed6caac727bdaca5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524549 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
This consolidates most of the command processor vs queue logic in one place. It also has a number of incidental changes related to fences: - syncs now do not store a shared fence. instead they call command apis to wait for a particular serial with a timeout. this is not yet fully implemented in CommandProcessor. - surface swap history stores a serial instead of a fence. because the RendererVk class stores the command batches, we no longer have to do messy things with ContextVk. - it is no longer possible to ask for a wait on a serial that isn't in the command queue. Also adds mutex synchronization around the RendererVk methods. Bug: angleproject:5217 Bug: b/172704839 Change-Id: I5faf0e24bb6ede79a927ab149b80bfa8baca4620 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2524548 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Mohan Maiya authored
The spec for OES_shader_multisample_interpolation requires support for OES_sample_variables. Disable support until the changes related to OES_sample_variables land. Bug: angleproject:3589 Bug: angleproject:3588 Change-Id: I94408a4f4fd74c19922c011242a515cc457910cf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2535075Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-