Commits · 91f44a9a1c768a080c49b8238dacb48937deded8 · Chen Yisong / angle

20 Mar, 2020 13 commits

ASTC: LDR support doesn't imply HDR support · 91f44a9a

authored Mar 20, 2020

There are SwiftShader related failures related to enabling the
textureCompressionASTCHDRKHR feature without properly checking if the
VK_EXT_texture_compression_astc_hdr extension is available, so HDR support
shouldn't be enabled only based on the LDR support being enabled.

Bug: angleproject:4447
Change-Id: Icde34892c9e2efff4b71e8c4e960c2fcff786700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080594
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

91f44a9a

Suppress two -Wunreachable-code warnings on Fuchsia in Angle. · cd6028de

authored Mar 20, 2020

Bug: chromium:346399
Change-Id: Ibf9cefdee52e487d9e73b9dff98a12267ac82af6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112281
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cd6028de

Vulkan: Fix Framebuffer cache depth/stencil issue. · 4fb3c28f

authored Mar 19, 2020

The DrawBuffers resetting logic didn't update the depth/stencil serial.
Fix this and add a regression test that would crash in this situation.
Note that the Manhattan benchmark could trigger this under some cases.

Bug: angleproject:4322
Bug: angleproject:4490
Change-Id: Ie4b24efeb5991ecaa85bf8f964f77476bd6f167d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111333
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

4fb3c28f

Add optimized rendering feedback loop tracking. · 1c88cf27

authored Mar 18, 2020

This can be used both for WebGL and the Vulkan back-end workaround for
Manhattan. Uses the recently added tracking for Textures being bound as
samplers. Then caches this information in the Framebuffer using the
Subject/Observer pattern.

Bug: angleproject:4490
Change-Id: I08bef0a1b95c4333da19c2dae1f02a993e5835e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109335
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

1c88cf27

Perf: Limit TracePerfTest to single compressed TRex · a4337121

authored Mar 19, 2020

Update the TRex trace to:
* Incorporate recent fixes for compressed textures
* Incorporate support for compressing the trace
* Simplify the tag on the trace (drop the end frame)

Update TracePerfTest to:
* Temporarily support only a single trace (TRex200).

Test: angle_perftests --gtest_filter="*Trace*"
Bug: angleproject:4484
Bug: angleproject:4488
Bug: angleproject:4496
Change-Id: Ice0c4ee9de3ad9ae4596305a93c51c6eac842123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112629
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a4337121

Add support for EXT_EGL_image_external_wrap_modes · 62b72552

authored Mar 20, 2020

Allows for more wrap modes to TEXTURE_EXTERNAL_OES textures

Test: angle_end2end_tests --gtest_filter=ExternalWrapTest.*
Bug: angleproject:4443
Change-Id: I37bde091b166d7471c13c14fd6b0174136b52ecf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103433
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

62b72552

Remove util.gni. · 32c1bf54

authored Mar 19, 2020

This file was no longer referenced and is dead code.

Bug: None
Change-Id: Id4469b9575a14e31c6f715c2d290f2f8945cd25b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2110331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

32c1bf54

Revert "Refactor BitCount" · 26f8f1a9

authored Mar 20, 2020

This reverts commit baecb7d5.

Reason for revert: Broke Skia Win/ARM builder. See issue for details.

Original change's description:
> Refactor BitCount
> 
> POPCNT intrinsics cannot be used without hardware support, so a CPUID
> check and polyfills are required for some CPUs when using MSVC to
> avoid runtime failure.
> 
> Other changes include:
> - Clang: use builtins on all platforms to provide exact intent to the
> compiler;
> - MSVC on ARM: use dedicated intrinsics;
> - x86/x64 fallback is now branchless and works in constant time.
> 
> Bug: angleproject:4462
> Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Commit-Queue: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,lexa.knyazev@gmail.com

Change-Id: Ia1756abdf7da2aa9574149eb388915f97758bba0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4462
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112276Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

26f8f1a9

Skip updating viewport and scissor info if the same · 2709f40f

authored Mar 17, 2020

If glViewport() or glScissor() is called with same
info, skip updating viewport or scissor info and
related dirty bits.

Bug: angleproject:4487
Change-Id: I9a0f3eb0df789beb99447ebc98383f502fbc763d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105528
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2709f40f

Roll third_party/spirv-tools/src 18d3896a15fc..60104cd97446 (2 commits) · 12a1c373

authored Mar 20, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/18d3896a15fc..60104cd97446


Created with:
  gclient setdep -r third_party/spirv-tools/src@60104cd97446

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I3dcd66069fea3caf8aca5e10bc0dad5eb9d661dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111884Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

12a1c373

Roll third_party/SwiftShader bc98fbeec99b..1c9f24263e6c (2 commits) · 92941f2c

authored Mar 20, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/bc98fbeec99b..1c9f24263e6c

git log bc98fbeec99b..1c9f24263e6c --date=short --first-parent --format='%ad %ae %s'
2020-03-19 sugoi@google.com Fix float to r11g11b10 conversion
2020-03-19 amaiorano@google.com marl: manually apply partial patch to fix x86 crashes

Created with:
  gclient setdep -r third_party/SwiftShader@1c9f24263e6c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: I6c49a595ffe084fbf6d80f57638011c96384384e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111883Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

92941f2c

Skip SwANGLE GLES31 tests which crash with 32-bit Subzero only on Windows · 0e069b42

authored Mar 19, 2020

Linux 32-bit crashes were fixed.

Bug: angleproject:4482
Change-Id: I3efd7c760dfec1f8b909eee2ed84f5f9ebc33c3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111970Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

0e069b42

Skip flaky TransformFeedbackTest.MultiContext on Win Intel Vulkan · ca45852d

authored Mar 19, 2020

Bug: angleproject:4497
Change-Id: I92e7ad9f0c34fe0b5f67318271ececc218c20757
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2111781Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

ca45852d

19 Mar, 2020 9 commits

Track if a Texture is bound as a sampler. · b1eb44bf

authored Mar 18, 2020

This will more easily allow us to detect rendering feedback loops.
We'll need to support feedback loops to enable Manhattan.

Bug: angleproject:4490
Change-Id: I442deebd89dcf0139411688eaa204c5e5b2c2799
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109334
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

b1eb44bf

Refactor BitCount · baecb7d5

authored Mar 14, 2020

POPCNT intrinsics cannot be used without hardware support, so a CPUID
check and polyfills are required for some CPUs when using MSVC to
avoid runtime failure.

Other changes include:
- Clang: use builtins on all platforms to provide exact intent to the
compiler;
- MSVC on ARM: use dedicated intrinsics;
- x86/x64 fallback is now branchless and works in constant time.

Bug: angleproject:4462
Change-Id: I00fcabda1c842677d8cb4bfd280d932d0d10c0a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102811Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

baecb7d5

Vulkan: Use device local memory for conversion buffers that can be converted with the GPU · 7daf31d8

authored Mar 18, 2020

When converting a vertex buffer by using GPU, the conversion buffer
doesn't need to be host mappable. Hence the conversion buffer can
be allocated on device local memory for faster GPU access times.

Bug: angleproject:3534
Change-Id: I2efabec20186992479920bddd3abd36f9c13babc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108706
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7daf31d8

Vulkan: Remove public FramebufferVk::getFramebuffer. · 9d812d35

authored Mar 18, 2020

Goal: enable rendering feedback loop detection for Manhattan.

Making getFramebuffer private prevents direct access to the Framebuffer
internals. Hiding access lets the FramebufferVk class switch up its
implementation to support different VkFramebuffers for feedback loop
cases.

Also this is a general code cleanup.

Bug: angleproject:4490
Change-Id: Ib4f5e34d476ccd8fc43a1adb031933ab347ca7b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109333Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9d812d35

Roll third_party/spirv-tools/src 25ede1ced679..18d3896a15fc (2 commits) · bff3b200

authored Mar 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/25ede1ced679..18d3896a15fc


Also rolling transitive DEPS:
  third_party/spirv-headers/src a17e17e36da4..f8bf11a0253a

Created with:
  gclient setdep -r third_party/spirv-tools/src@18d3896a15fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Idc630e487903f425e849f1bed5997bb88875a328
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109619Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bff3b200

Skip some tests on Mali because of a known issue · 8aa20069

authored Mar 18, 2020

Type decorations may be ignored when using multiple OpAccessChains.

Bug: angleproject:4492
Change-Id: I2e51af600394a69cb5f7e02228ca7e4fd1c826e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2105529Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8aa20069

Roll third_party/SwiftShader 440fc9959f06..bc98fbeec99b (3 commits) · a38e20e4

authored Mar 19, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/440fc9959f06..bc98fbeec99b

git log 440fc9959f06..bc98fbeec99b --date=short --first-parent --format='%ad %ae %s'
2020-03-18 amaiorano@google.com Subzero: fix external function calls on x86-32
2020-03-18 amaiorano@google.com Subzero: fix partially initialized ManagedStatic assert
2020-03-17 digit@google.com [vulkan]: Support multiple external semaphore implementations.

Created with:
gclient setdep -r third_party/SwiftShader@bc98fbeec99b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4482
Tbr: courtneygo@google.com
Change-Id: I09384435c826f4dd4eb3003006da8a8315e7c959
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109617Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a38e20e4

Capture/Replay: Fix stride in compressed texture caching. · dadeffa3

authored Mar 18, 2020

We were saving "width" bytes instead of "width * pixelSize". This was
causing incorrect rendering in T-Rex and Manhattan.

Bug: angleproject:4488
Change-Id: Ib5d38aaf813fb26905aedc155cc13b9d1597ec4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2109336Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

dadeffa3

Roll chromium_revision 86e00b5dd2..fa9d5805c4 (743688:750702) · f955fb45

authored Mar 16, 2020

Change log: https://chromium.googlesource.com/chromium/src/+log/86e00b5dd2..fa9d5805c4
Full diff: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5d6bdfc4f1..a1cbf6469a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/feb2d0c562..4164a30562
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/74854b3f7b..3e21eec53c
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/703ca235f0..c96dc32110
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2eb8a7f7a..156be8c52f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eeaa53b76f..d60a6a8084
DEPS diff: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4/DEPS

Clang version changed c29003813ab9bd6ea7b6de40ea8f1fe21979f13f:9284abd0040afecfd619dbcf1b244a8b533291c9
Details: https://chromium.googlesource.com/chromium/src/+/86e00b5dd2..fa9d5805c4/tools/clang/scripts/update.py

TBR=jmadill@chromium.org,

Bug: angleproject:4484
Change-Id: I4e7bcd3f184ad29a7d9cffc125d58387445052af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106453
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f955fb45

18 Mar, 2020 7 commits

Roll third_party/vulkan-validation-layers/src 6cd8cbdaab99..caeb15a056a0 (15 commits) · 9817f9ad

authored Mar 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/6cd8cbdaab99..caeb15a056a0

git log 6cd8cbdaab99..caeb15a056a0 --date=short --first-parent --format='%ad %ae %s'
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01762
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01762
2020-03-17 s.fricke@samsung.com layers: Add support for Map Memory VUIDs
2020-03-17 s.fricke@samsung.com layers: Removed redundant looping in graphics pipeline
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 02801
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 02801
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01510
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01510
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01442
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01442
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 01188
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 01188
2020-03-17 s.fricke@samsung.com tests: Add support for VUID 00968
2020-03-17 s.fricke@samsung.com layers: Add support for VUID 00968
2020-03-17 jmadill@chromium.org Fix Chromium warning about copying iterators.

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@caeb15a056a0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com,jmadill@google.com
Change-Id: Ib1b355f9b47418f1f360d7a7bbd277a2b548893a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108103Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

9817f9ad

Vulkan: Must call vkFlush while memory is mapped · 4422d298

authored Mar 18, 2020

Update to Vulkan validation layers pointed out that
vkFlushMappedMemoryRanges needs to be called when the memory is mapped.

Bug: b:151820847
Change-Id: I3860306080bca435c063046f9ae20943a8601d17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2108705Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

4422d298

Vulkan:Set one-time bit on all command buffers · 4119f033

authored Mar 17, 2020

All Vulkan command buffers are only submitted once so we can set the
VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT which may help performance.

Bug: angleproject:4304
Change-Id: Ibd116dcac4e78a2c058eb3da54489057d6fa8f44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107800Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

4119f033

Be sure to clear all program state at unlink · 4df67871

authored Mar 17, 2020

At Program::unlink we clear out the program's state but forgot
mBufferVariables. That was causing us to hit an assert when trying to
load a shader from cache.
Only see the issue on Android as that's the only platform where shader
caching is supported.

Test: KHR-GLES31.core.explicit_uniform_location.uniform-loc
Bug: angleproject:4132
Change-Id: Iae9c26a3e3b2d11983cc7d90bcd54a10c0fa9934
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107235Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

4df67871

Capture/Replay: Fix MEC Query capture. · 23d63fc3

authored Mar 17, 2020

In Manhattan the test generates a bunch of queries that it doesn't
start until later frames. In ANGLE these queries will be stored as
nullptr entries in the QueryMap. By default the QueryMap Iterator skips
over nullptr entries. This manifested later as GL errors during replay.

Fix this by adding a new Iterator type to ResourceMap that does not
skip over nullptr values.

Bug: angleproject:4489
Change-Id: If56b908fb233de0df0445f9ea19fc322f2c42976
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107762
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

23d63fc3

Capture/Replay: Fix compressed texture subImage caching. · e54f7ed7

authored Mar 17, 2020

The prior code was caching the last subImage data. In fact we should be
caching and updating a pixel rectangle. Multiple subImage calls will
update the same rectangle until the final capture call sets up the
replay with the complete initial data.

This was causing an issue with Manhattan and the initial data for 3D
compressed textures. Manhattan uploads these one layer at a time. So
the prior code was trying to pass a single layer's data to the subImage
call for the entire level.

Bug: angleproject:4488
Change-Id: I76765dcea884f9d8ea07908c44e97578ddb0ff0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107761
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

e54f7ed7

Capture/Replay: Use zlib to compress data files. · 7e453a25

authored Mar 15, 2020

Gives about a 2-3x reduced data file size. Should help reduce the time
we spent transferring trace files on Android.

This feature is implemented as a parameter to the capture/replay tool.
This keeps backwards compatiblity if we ever need to integrate a cpp
replay into an environment that doesn't have access to zlib for
decompression.

We'll need to update the traces to take advantage of the compression.

Bug: angleproject:4484
Change-Id: Id7994efe3c0d529b85fa7e7f1b00444e630dd2cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7e453a25

17 Mar, 2020 9 commits

Vulkan: Request device local memory for glBuffer with GL_STATIC* usage · 78a85f2c

authored Mar 16, 2020

glBuffer objects with GL_STATIC_* usage patterns will now request
the storage to be allocated in device local memory. For glBuffer
objects with GL_DYNAMIC_* usage patterns we request a host cached
memory.

Bug: angleproject:4480
Change-Id: I7ca968f5ddfb59e4df3ecd07ae65df2bbf734190
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2102958
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

78a85f2c

Fix ShaderStorageBufferReadWriteOffset end2end test · f98084ed

authored Mar 12, 2020

Test: ShaderStorageBufferTest31.ShaderStorageBufferReadWriteOffset.
Align kBufferOffset to bufferAlignOffset correctly.

Bug: angleproject:4471
Change-Id: I71084839a845138b32d58d8bd2cf6fed2633a9be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2100047
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f98084ed

Roll third_party/SwiftShader 3a50a43df988..440fc9959f06 (1 commits) · 273f9c7c

authored Mar 17, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/3a50a43df988..440fc9959f06

git log 3a50a43df988..440fc9959f06 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 swiftshader.regress@gmail.com Regres: Update test lists @ 3a50a43d

Created with:
  gclient setdep -r third_party/SwiftShader@440fc9959f06

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I95262d4bfe2eafab7865082de2d7d0fd6a60a69c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107107Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

273f9c7c

Roll third_party/glslang/src 9b620aa0c12d..4b2483ee88ab (1 commits) · af0891b5

authored Mar 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9b620aa0c12d..4b2483ee88ab


Created with:
  gclient setdep -r third_party/glslang/src@4b2483ee88ab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic397f97c031c67c88ddbf2be63ae1f4dbea05401
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107108Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

af0891b5

Roll third_party/vulkan-validation-layers/src be663d752e45..6cd8cbdaab99 (7 commits) · f748ee6c

authored Mar 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/be663d752e45..6cd8cbdaab99

git log be663d752e45..6cd8cbdaab99 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 jbolz@nvidia.com scripts: Add aliased types to handle_types
2020-03-16 jbolz@nvidia.com layers: Fix RayTracing VUIDs to use buffer->createInfo.size
2020-03-16 jbolz@nvidia.com tests: Disable a test case in VkLayerTest.ValidateGeometryNV
2020-03-16 s.fricke@samsung.com tests: Extra test to check multi-planar copies
2020-03-16 s.fricke@samsung.com layers: Add support for 01548
2020-03-16 mark@lunarg.com docs: Update layer config and overview doc
2020-03-16 jakub@okonski.org tracker: Fix work retiring for queue submissions

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@6cd8cbdaab99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Id80bddb98cd6236ed7d7d29e96d03c307726bda7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107106Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f748ee6c

Roll third_party/vulkan-loader/src f1d9f12a19de..64c36933d4f2 (2 commits) · 8bc374dd

authored Mar 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/f1d9f12a19de..64c36933d4f2

git log f1d9f12a19de..64c36933d4f2 --date=short --first-parent --format='%ad %ae %s'
2020-03-16 joshua@froggi.es loader: Handle no surface for surface caps 2 funcs
2020-03-16 joshua@froggi.es loader: Migrate get surface caps 2 funcs to wsi

Created with:
gclient setdep -r third_party/vulkan-loader/src@64c36933d4f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I9a716acb93ba63d7a7b3c2898dd7896b53a4dc14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2107105Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8bc374dd

Roll third_party/zlib/ c2eb8a7f7..156be8c52 (1 commit) · a8acd779

authored Mar 16, 2020

https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c2eb8a7f7a0f..156be8c52f80

$ git log c2eb8a7f7..156be8c52 --date=short --no-merges --format='%ad %ae %s'
2020-03-16 jmadill Fix zlib build on UWP.

Created with:
  roll-dep third_party/zlib

Bug: angleproject:4484
Change-Id: I182ff15c092ed1b327f9622429aa97bdebe45c84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106795Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a8acd779

Capture/Replay: Write to single binary data file. · d24752e6

authored Mar 15, 2020

Previously the tool would save to a separate file for every frame and
one additional file for the setup function. Frames without binary data
would not get an "angledata" binary file.

Using a single file has a few advantages:

 - makes it simpler to track the data dependencies in GN
 - should be easier to compress and decompress for speed up transfers
 - no need to wonder if we have frames with missing data files
 - less overhead reading from the HDD since the whole trace is buffered

We might need to worry about extemely huge memory use cases. For now
buffering the whole file into memory on startup is simple and fast.

Also makes the binary data loader function more robust.

Bug: angleproject:4484
Change-Id: Ia74fb0bc65200adf7a21c3143f98aa4da86457b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2104554
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

d24752e6

Re-enable optimization for angle_perftests. · 7c334c56

authored Mar 15, 2020

This CL restricts the workaround to the trace perf tests. These trace
tests are too big to optimize.

Also includes a fix for a 32-bit Windows warnings. We'll need to update
the build file to remove a suppression once the traces are updated.

Bug: angleproject:3630
Change-Id: Id13a0050fc2a645aa572b8c9079908023b232f28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103084
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

7c334c56

16 Mar, 2020 2 commits

Move perf test common files to a source set. · 42c453fe

authored Mar 15, 2020

Similarly to a prior patch this organizes the common perf test sources
into a single target. This will allow us to more easily support setting
compiler flags on particular perf test sources.

This also fixes some build errors that popped up when new warnings were
enabled.

Bug: angleproject:3630
Change-Id: I866885199f93a5055e8d160e39f72d1f8209bc75
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103086
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

42c453fe

Refactor ANGLE common test utils. · 5df2c9ea

authored Mar 15, 2020

This reduces code duplication by including a common set of sources in a
single place. New test sets will be a bit easier to add. It also
encapsulates the dependencies a bit better when we pull the test utils
out of the test targets.

Unblocks a follow-up CL that moves the trace perf test sources into
their own file so we can re-enable optimizations in the main perf test
target.

New warnings popped up in a few of the files because of the new source
set enabling more warnings. This CL also fixes all of those.

Bug: angleproject:3630
Change-Id: Ic30cb30fb4288c4dbbbd29f9bdf04be51e8a6b30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2103083
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

5df2c9ea