- 02 Jun, 2021 4 commits
-
-
John Plate authored
Add kernel object to back end and implement creation and info query. Bug: angleproject:6001 Change-Id: I6e3fdd2b35d7e73ed56144dc938bf21436d3559f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2922150 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/6be0134d13be..682cfc04ad59 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9646c733e9..8b3dc6bbed * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1dfbd17905..5d97074c3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: I8012bc0be17eec6d6452a8d37c237b2be144322c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2931783 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
John Plate authored
Improve validation readablity by introducing a bit field class and by changing how the CL error code is returned. Bug: angleproject:6001 Change-Id: I51deb745454e5281de725481edef85eb30be28c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919690Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/9fc71f2e66f4..1413aecd34bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/2b0e673533..e49989e141 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/fba2905150..cd7b8c0c22 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/345bb3dfa9..f19fe5f36c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..053e386fd4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0694fa65f8..cd3696cf7e * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d0e636edaa..00ade15d94 * tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:d8815e36ea7b66a4b8c9d69fcc2322012d25715f * tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:d8815e36ea7b66a4b8c9d69fcc2322012d25715f * tools/luci-go: git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab..git_revision:d8815e36ea7b66a4b8c9d69fcc2322012d25715f * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/0679044e60..26afa3ac97 No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ie9b3751bc6417dbc067011175cdc36d57c170a27 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2932656 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 01 Jun, 2021 9 commits
-
-
Geoff Lang authored
Mac drivers are hanging and crashing after large glTexSubImage uploads. Chunk those uploads to avoid this problematic path in the driver. Bug: chromium:1181068 Change-Id: I7dca0b8e49420f015ff7830283c14283a0515826 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2928098Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
Cody Northrop authored
Tbr: jmadill@google.com Bug: angleproject:6018 Change-Id: Ie27b82b4716aaf5164c65e890cd2d6fad3f2b836 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2930817Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b46b97c10c10..90c0551ca547 2021-05-31 capn@google.com Regres: Roll dEQP to 1.2.6-master revision 8010f59 2021-05-29 swiftshader.regress@gmail.com Regres: Update test lists @ 21f81124 2021-05-29 capn@google.com Regres: Use 'default' dEQP target and skip GLES daily tests 2021-05-27 srisser@google.com Update git-hooks to latest revision 2021-05-27 capn@google.com Marl: Suppress MemorySanitizer false-positive 2021-05-27 srisser@google.com Bring git-hooks in as a submodule 2021-05-27 capn@google.com Regres: Recursively load chunked mustpass lists 2021-05-26 chonggu@google.com Update references for ANGLE submodule If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ie1d2d2873bb7e68697e622cd8c4cf0da71fb6e59 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2929585 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*subway_princess_runner*" Tbr: jmadill@google.com,timvp@google.com Bug: b/189794097 Change-Id: I79ed00da91e0f304bf3899a0ab9ebfd2c1426739 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2929460Reviewed-by:
-
Shahbaz Youssefi authored
Useful to construct a FastVector out of a subrange of another container. Bug: angleproject:4889 Change-Id: I0e62b601c7d171167343d526d198fa21ba52f0f9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920191Reviewed-by:
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*cookie_run_kingdom*" Tbr: jmadill@google.com,timvp@google.com Bug: b/189788024 Bug: angleproject:6017 Change-Id: I5cd9912d099d1749b5677cf43e25fe73ee38d17c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927509Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/f7463350a894..6be0134d13be Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec1bc3e2e5..9646c733e9 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/daa3490ea4..6149e30699 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4ce9838c23..1dfbd17905 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ic055298fe3c54f731a1711da04ef59455f19cf6e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2929938 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/b1a19ff2a440..9fc71f2e66f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/068753b025..2b0e673533 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/73587aa74e..345bb3dfa9 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..12d96cda9c No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: Ib61adfbbc6a5fc0cf840577c70fb86b70ec86533 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2928905 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Cody Northrop authored
Genshin Impact is using EGL_KHR_create_context_no_error to create a context that exposes GL_KHR_no_error. If it successfully creates the context, it sends down call sequences that check query results available immediately after genning query objects: glGenQueries(1, reinterpret_cast<GLuint *>(gReadBuffer)); UpdateQueryID(415, 0); glGetQueryObjectuiv(gQueryMap[415], GL_QUERY_RESULT_AVAILABLE, ...); This throws errors on every platform I have access to, with either native or ANGLE as the driver. The spec is ambiguous as to whether this should cause an error, but practically we can't allow this if we want error free playback of traces. To support this, we will force validation on in the context when FrameCapture is enabled. When the app submits invalid calls, they will be dropped by FrameCapture. Test: Genshin Impact MEC Bug: b/181794064 Change-Id: If882d27d74661cd95bc23687eff3056a0f64e3cc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921068 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
- 31 May, 2021 5 commits
-
-
Jonah Ryan-Davis authored
Disable the use of this extension on Mesa 20/intel, it's causing GPU hangs. Bug: chromium:1187475 Change-Id: Ic7029b1f72bd0b0f4a2c11a7fceb0a59f51be8aa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920811Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/8ea5e4dc6455..f7463350a894 Changed dependencies: * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/4e4619ae69..daa3490ea4 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8a22bcf6bf..4ce9838c23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com Change-Id: Ia8778eafd1e559e675a5c63a250b3fea82f0fc11 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927391 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a318ef0ca26e..2e0ecf9812ba 2021-05-31 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,ynovikov@google.com Change-Id: I45c8d8e40236690a0c94ee1c7e5b01aeca6cee5c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927393 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/ed36a7408427..b1a19ff2a440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/862b91b57a..068753b025 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/0f50062689..73587aa74e * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..edf4e0e88f No update to Clang. Bug: None Tbr: ynovikov@google.com Change-Id: I53f50543ea22403143f1f7c8a853f352a13303cb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927388 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dd333551c971..a318ef0ca26e 2021-05-31 alexander.galazin@arm.com Merge pull request #258 from asimiklit/fix/arrayed-tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com Change-Id: Id138f3c4f7a9d0c97bac4c27e99902a9bf41d65a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2927387 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 30 May, 2021 1 commit
-
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ea6189a7a67e..dd333551c971 2021-05-29 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master 2021-05-28 alexander.galazin@arm.com Update OpenGL mustpass 2021-05-28 alexander.galazin@arm.com Add AOSP tests to the GL4.5 mustpass 2021-05-28 rgarcia@igalia.com Check supportedAlpha is never zero 2021-05-28 siglesias@igalia.com Do not clamp ambiguous snorms values on vkCmdCopy*() functions 2021-05-28 juha.heiskanen@siru.fi Add writing to invalid multisample indices tests 2021-05-27 lexa.knyazev@gmail.com Add GL_EXT_texture_sRGB_RG8 support 2021-05-27 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests 2021-05-27 venni.ihanakangas@siru.fi Add permutations of different cases on existing test 2021-05-27 siglesias@igalia.com Add multiple statistics query tests 2021-05-27 rgarcia@igalia.com Use arrays of pointers with non-identity matrices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com Change-Id: Id1c5be98d90c0d6013fb18955dd9c333f93055b4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2926637 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 28 May, 2021 3 commits
-
-
Yuly Novikov authored
Previously artifacts were not reset for a new trace in a batch Bug: angleproject:5966 Change-Id: Ia6ed8c070eaaeca7e6cea887419666f630648df8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925218Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/012f2ef00731..8ea5e4dc6455 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6fe560f74f..6bdcb4be34 * spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/ff61890722..a6ce49ca24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I49582b8058df2eed78cc73c3fc6a739ad0ad1772 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925140 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/9e607ee51d46..ed36a7408427 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/b5063cfbea..862b91b57a * testing: https://chromium.googlesource.com/chromium/src/testing/+log/b014545e6c..0f50062689 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dca1c9711a * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6fc394f93d..0694fa65f8 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4dfe812639..0679044e60 No update to Clang. Bug: None Tbr: jmadill@google.com Change-Id: Id6add386fb8c1189bdb6e97cbc508af6dda1c623 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925139 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 27 May, 2021 12 commits
-
-
Yuly Novikov authored
Uploading to Gold used to stop after the first failure in the batch Bug: angleproject:5966 Change-Id: Iff89c106b18a9aab5a43742a6085c5f9a3c9a188 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923784Reviewed-by:
-
Charlie Lao authored
Gfxbench Manhattan uses depth attachment as texture in the same render pass, which creates a feedback loop. The layout we are using for this has kAllShadersPipelineStageFlags even though it only used by fragment shader. This creates an unnecessary vertex/fragment dependency that hurts performance on some mobile GPUs. This CL split DepthStencilReadOnly to DSAttachmentReadAndFragmentShaderRead, DSAttachmentReadAndAllShadersRead, and DepthStencilAttachmentReadOnly, so that if it is used by fragment shader, we only barrier against fragment stage. If not used by any shader, we don't block any shader stages. To make names consistent, this CL also renames DepthStencilAttachmentAndFragmentShaderRead to DSAttachmentWriteAndFragmentShaderRead, renames DepthStencilAttachmentAndAllShadersRead to DSAttachmentWriteAndAllShadersRead. Bug: b/169891513 Change-Id: Iede497e8af028861f9166a32d122f26dc7aa864a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453599 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Charlie Lao authored
For PixelUnpack, if the feature is enabled, it always create a shadow CPU mapped memory. Then when mapBuffer is called, it let user write to the shadow memory. At unmapBuffer time, it memcpy the shadow buffer data to context's staging buffer and then issue a vkCmdCopyBuffer from context staging buffer to the PixelUnpack buffer. This involves too many data copies. The proper way to do it is simply make sure to create the buffer as CPU map-able and let user directly write to it. If we find cases that CPU waiting for GPU to finish is causing performance issues, there are two ways to improve/fix it: 1)Add event at end of each renderpass or FBO so that we know if GPU access is finished or not without have to wait for entire frame to finish rendering. 2) Create multiple buffers and ping-pong between them, at least there will be no VkCmdCopyBuffer call involved like shadow buffers do. But we will leave that to future time when we find such need. Bug: angleproject:5986 Change-Id: Ib8300e46e779d20533c1f7f81624de0ce003788b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2909758 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/b6af002ef64a..9e607ee51d46 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/74f9de2dfa..b5063cfbea * testing: https://chromium.googlesource.com/chromium/src/testing/+log/256e043811..b014545e6c * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4c713c1163..7949d87093 * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/46f611a284..c422ce7b84 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e83a92e7b8 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72bc20ef29..6fc394f93d * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e4c7c48174..d0e636edaa * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/31bd71668d..4dfe812639 No update to Clang. Bug: None Tbr: jmadill@google.com,ynovikov@google.com Change-Id: I0008f18e7c0a0e2240947db223e3961ae6218a47 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923322 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Alexis Hetu authored
MSAN currently detects false positives on global/static thread_local variables which are created at library load time. This CL mutes the false positive in order to unblock running blink_web_tests with SwANGLE on MSAN bots. Bug: chromium:1211047 Change-Id: I7cd103d470177d783df7f73ca6ceeedc0774b163 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920486 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
-
Yuly Novikov authored
Added in crrev.com/c/2921449 Bug: angleproject:6008, chromium:1214047 Change-Id: Icb42e438fc87271d1c5abbe2201d6c2bf597a4e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923782Reviewed-by:
-
Charlie Lao authored
ImageHelper::generateMipmapsWithBlit() implements glGenerateMipmap using vkCmdBlitImage. For each level it changes layout to VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL and issue a blit. In order to keep all mipmap levels' layout consistent, it issues a vkCmdPipelineBarrier call for the the very last mipmap level to change it to VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL as well. This creates an unnecessary barrier for the next operation, that now it sees a barrier against transfer stage. This CL changes all levels to VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL so that the whole image will have consistent layout. After glGenerateMipmap call, the next reasonable usage is use it in fragment shader, so the barrier is not wasted. Bug: angleproject:5986 Change-Id: I3690ae8417d97bc504fcf036d016f289e6370526 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2909757 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
Jamie Madill authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8010f59c7034..ea6189a7a67e 2021-05-26 mikko.tiusanen@siru.fi Remove empty subtest 2021-05-26 mikko.tiusanen@siru.fi Lower vector constructor test shader version 2021-05-26 mikko.tiusanen@siru.fi Test framebuffer completeness when layered rendering 2021-05-26 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC jmadill@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: angleproject:6008 Change-Id: I580ddda1ac7fa4614fcf00b834f51b9dc725392c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921449Reviewed-by:
-
Cody Northrop authored
Test: Genshin Impact MEC Bug: b/181794064 Change-Id: Ib0edfa8d1c063d43c34a65be0144bc5efc4cf19b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921067Reviewed-by:
-
Cody Northrop authored
Test: Genshin Impact MEC Bug: b/181794064 Change-Id: I69e2c78678b8e279478ae946131b7e1730070cb0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921066Reviewed-by:
-
Cody Northrop authored
Bug: angleproject:6006 Change-Id: I56d21a9d9df343fbf805c10307265cab929914c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920087 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/89ab6280369d..012f2ef00731 Changed dependencies: * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/00ce2bb474..ec1bc3e2e5 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5274701761..8a22bcf6bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I5b6edf04e95609beefe3aa8e9b632c307bf00180 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920090 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 26 May, 2021 6 commits
-
-
Jamie Madill authored
This should speed up test runs on Android, which are currently much slower than the other platforms. Bug: angleproject:5966 Change-Id: I57890522b64d1d195ea0be56b4f68b6d54192d64 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919888Reviewed-by:
-
Kenneth Russell authored
This reverts commit 7a38f3f5. Reason for revert: caused numerous test failures on FYI waterfall per http://crbug.com/1213507 . Original change's description: > GL: Skip redundant flushes. > > Skip flushes when there is no work submitted since the last > flush. > > Clone of geofflang's: > https://chromium-review.googlesource.com/2911879 > > Bug: chromium:1181068 > Change-Id: Idd8a1c61b814d746bf1e0225cfc4ca375a7bb224 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915675 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> Bug: chromium:1181068 Bug: chromium:1213507 No-Try: True Change-Id: Icd1662e4ea541375b44bddaa839a5241cdad5302 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919503 Commit-Queue: Kenneth Russell <kbr@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Jamie Madill authored
Reduces shard time from 50+ min to <10 min per shard. Bug: angleproject:5966 Change-Id: Ia230d71a66ac9a273a10e0389cc04d8c5737bc4a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915566 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jonah Ryan-Davis authored
This function may be called without checking the pointer. Speculative fix for a crash in GetSystemInfoVulkan. Bug: chromium:1211839 Change-Id: Ia7fa55fc328d02bdcd6d48e9b93f552aaea2b284 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2917353Reviewed-by:
-
Geoff Lang authored
Bug: angleproject:2894, angleproject:5988 Change-Id: I17b55f0655d32d9f41cb55a0467b93a00fba751b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841084 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Geoff Lang authored
ANGLE's program hash iterates over hash maps which do not guarantee a determinisitic iteration order. Copy these maps to std::map before iteration. It's unclear what must change to make these maps iterate differently, EGLBlobCacheTest.Functional does cover this path but doesn't trigger any issues. Bug: angleproject:5913 Change-Id: Ib5f2c0a0a4e05cbaeeec5d9c889718d53c5fcf1c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892254Reviewed-by:
Sunny Sun <sunny.sun@arm.com> Reviewed-by:
-
