Commits · 9cac3c5823e76cb3c0c08e4d2f0ea6cbb5ecf46d · Chen Yisong / angle

30 Apr, 2020 5 commits

Capture/Replay: Disable default uniform updates for arrays · 9cac3c58

authored Apr 30, 2020

We aren't properly handling them, were already firing UNIMPLEMENTED,
but can't continue with the loop.  Will follow up with real support.

Test: MEC capture of Manhattan on Windows
Bug: angleproject:3662
Change-Id: I7b77350b39971fda702eac8b19c6f29f36f78146
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2171759Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

9cac3c58

Roll third_party/SwiftShader 941293d512fe..98d2cab108ce (2 commits) · e07cb6e9

authored Apr 30, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/941293d512fe..98d2cab108ce

git log 941293d512fe..98d2cab108ce --date=short --first-parent --format='%ad %ae %s'
2020-04-30 capn@google.com Fix JIT on separate thread
2020-04-29 capn@google.com Avoid implicitly destructing thread-locals

Created with:
  gclient setdep -r third_party/SwiftShader@98d2cab108ce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I9f34d4153d60788ae26d8c3a346969bf69ffa83a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174147Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e07cb6e9

Roll third_party/glslang/src f03cb290ac10..39281fb710c3 (1 commits) · 50449339

authored Apr 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f03cb290ac10..39281fb710c3


Created with:
  gclient setdep -r third_party/glslang/src@39281fb710c3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Id6a5efedddadc2e087cfb56793b46c9d54544808
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174148Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

50449339

Roll third_party/vulkan-validation-layers/src f0f3d8b75af9..70eeffc7ca3d (10 commits) · 24af09f7

authored Apr 30, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f0f3d8b75af9..70eeffc7ca3d

git log f0f3d8b75af9..70eeffc7ca3d --date=short --first-parent --format='%ad %ae %s'
2020-04-30 s.fricke@samsung.com tests: Add support for vkBindImageMemory2 VUID
2020-04-30 s.fricke@samsung.com layers: Add support for vkBindImageMemory2 VUID
2020-04-29 souravp@nvidia.com tests: VK_NV_device_diagnostic_checkpoints
2020-04-29 souravp@nvidia.com layers: VK_NV_device_diagnostic_checkpoints
2020-04-29 s.fricke@samsung.com tests: Add support for VUID 02634
2020-04-29 s.fricke@samsung.com layers: Add support for VUID 02634
2020-04-29 s.fricke@samsung.com tests: Add VUID 01658 and 01659
2020-04-29 s.fricke@samsung.com layers: Add VUID 01658 and 01659
2020-04-29 tony@lunarg.com layers: Fix ValidateClearAttachmentExtent
2020-04-29 mark@lunarg.com practices: Fix ValidateReturnCodes parameters

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@70eeffc7ca3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I93578945ba81e478303f9984854f5af24dd120e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174149Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

24af09f7

Vulkan: use fine grain stage for buffer barriers · f07d0072

authored Apr 27, 2020

We are using VK_PIPELINE_STAGE_ALL_COMMANDS_BIT for
mGlobalMemoryBarrierStages, which is used for both src and dst. This
will cause a full pipeline stall whenever a buffer object introduces a
barrier. This CL will let the caller pass in the specific stage it
will be used for, allowing us to track write and read stage dependencies
separately and request the corresponding barriers.

Bug: b/155122200
Change-Id: I8b8bd291a03b77d07cfbcbe7c3cda2d3771588b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169014
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f07d0072

29 Apr, 2020 13 commits

Validation fix for draw with primcount <= 0 · 95741743

authored Apr 27, 2020

A buffer size validation check was returning an invalid
operation error based on buffer size, even when primcount
is <= 0 (so the buffer isn't used).

Fixes the following WebGL 1.0.4 test with SwANGLE:
conformance/extensions/angle-instanced-arrays-out-of-bounds.html

Bug: b/154628007
Change-Id: Ibfe4eb57f17cd07100fb8dfbe8069e9ec7515160
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168546Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

95741743

GL loaders: Add 'ANGLE' symbol prefix. · 5540a307

authored Apr 29, 2020

This should prevent debuggers like RenderDoc from getting confused
about symbol names. It's also generally good practice to avoid
overloading names.

Change-Id: Ie9fd3f77f45479bdf6925dae3e03fb4ac85bdb8a
Bug: angleproject:4596
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2171684Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5540a307

Add gles1 covegl test compile · 78f2e4b8

authored Mar 24, 2020

Covegl test is hard to suit gtest, so just compile it without gtest
(angle_gles1_covegl_no_gtest), we can get the test result by exit code.

Bug: angleproject:2303
Change-Id: I67a930c91f23c02e72022329c712a0749e4a903c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126587
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

78f2e4b8

Vulkan: Use DynamicBuffer for BufferVk · fa03eb9d

authored Feb 05, 2020

When there is glBufferData API call, if the current
VkBuffer is in use, we copy to a staging buffer to
be gpu copied later. Instead of doing this second copy,
write directly to a new buffer that will be used for
subsequent gpu operations.

BufferVk now has a DynamicBuffer to handle
the logic of acquiring a new/free buffer to be used.

Bug: angleproject:4380
Change-Id: I207f334013ae944090eb48c26c692a09e8815f74
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040513Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

fa03eb9d

Capture/Replay: Generate code integration. · 92b3a720

authored Apr 27, 2020

This sources the trace list from a json file and uses that to make the
"glue" that works with each individual trace test.

Bug: angleproject:4590
Change-Id: I40808cbd0e00f9ed01f93c4cfbd678401db3fec0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168539
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

92b3a720

Vulkan: Add debug label commands to SecondaryCommandBuffer · 45bb2b9c

authored Apr 22, 2020

Add begin/end/insert DebugUtilsLabel commands to SecondaryCommandBuffer.
Switch use of these commands to the outside renderpass command buffer
instead of directly in the primary command buffer.

This change should maintain the exact same sequence of commands but
avoids some direct use of the primary command buffer. This is
desirable for the threaded refactor where a worker thread will
process the SecondaryCommandBuffer into a primary and the main
thread will no longer use the primary command buffer directly.

Note that because the debug utils label has an arbitrarily long
string that we need to adjust the command allocation to allow for
the string size exceeding the default allocation size. In this case
we just make a single larger allocation to accommodate the command
with the large string.

Bug: b/154030403
Change-Id: Iab7832ffc3d38ce168da2d624bd5b5d5b33ec11b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2161955
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

45bb2b9c

Translate uniform block with large matrix array to StructuredBuffer · d93b9559

authored Apr 16, 2020

There is a slow compiling issue if translate a uniform block with
a large matrix array member to cbuffer, so translate the uniform
block to StructuredBuffer. But pack_matrix pragma directive is
invalid for matrix element of StructuredBuffer, so pack the matrix
into a structure firstly, and then specifies packing alignment for
the matrix in this structure, last the structure is used as
StructuredBuffer element.

Bug: angleproject:4206
Change-Id: I5a2a512e57b37dcdb88c3060d0d078b46f72eb5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154525
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

d93b9559

Roll third_party/SwiftShader 2717702e9a1f..941293d512fe (4 commits) · 853a03f9

authored Apr 29, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/2717702e9a1f..941293d512fe

git log 2717702e9a1f..941293d512fe --date=short --first-parent --format='%ad %ae %s'
2020-04-28 amaiorano@google.com Eliminate use of Vulkan header BEGIN_RANGE/END_RANGE/RANGE_SIZE enums
2020-04-28 amaiorano@google.com Run clang-format on renamed headers
2020-04-28 amaiorano@google.com Rename Vulkan-source .h to .hpp
2020-04-28 bclayton@google.com ReactorUnitTests: Speed up multithreaded tests

Created with:
gclient setdep -r third_party/SwiftShader@941293d512fe

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie90659ca1cee43f320b77a907e01805c97508e5c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172069Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

853a03f9

Roll third_party/vulkan-validation-layers/src 72b2a3b275e5..f0f3d8b75af9 (7 commits) · 8f040314

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/72b2a3b275e5..f0f3d8b75af9

git log 72b2a3b275e5..f0f3d8b75af9 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 s.fricke@samsung.com tests: Add VUID 02682 and 02683
2020-04-28 s.fricke@samsung.com layers: Add VUID 02682 and 02683
2020-04-28 s.fricke@samsung.com tests: Fix unexpected errors for AHB test
2020-04-28 mark@lunarg.com practices: Fix fcn names and revamp manual fcn handling
2020-04-28 tony@lunarg.com gpu: Stop using deprecated spirv-tools var
2020-04-28 jzulauf@lunarg.com tests: Add persitant storage for renderpass info
2020-04-28 tony@lunarg.com practices: Don't validate swapchain memory

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@f0f3d8b75af9

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Idf104c2d928c1fa07de7ac7fe36bbe61f895f4fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172070Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8f040314

Roll third_party/vulkan-tools/src 30eb0a301c33..c0f34c020d9d (1 commits) · 48987242

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/30eb0a301c33..c0f34c020d9d

git log 30eb0a301c33..c0f34c020d9d --date=short --first-parent --format='%ad %ae %s'
2020-04-28 petr_kraus@email.cz vulkaninfo: Meet extension version dependencies

Created with:
  gclient setdep -r third_party/vulkan-tools/src@c0f34c020d9d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I8effcdb9f56c3a85efd5c9e2ac51de0ed2a83c1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172702Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

48987242

Roll third_party/vulkan-loader/src 3336e65e8801..f39209eb4402 (1 commits) · a4975d8b

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/3336e65e8801..f39209eb4402

git log 3336e65e8801..f39209eb4402 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 petr_kraus@email.cz docs: Fix typo

Created with:
  gclient setdep -r third_party/vulkan-loader/src@f39209eb4402

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6a1a921bec69cafaa6da4ef63d5735ce37d8bfbd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172701Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a4975d8b

Roll third_party/spirv-tools/src 23d68608b007..49ca250b44c6 (3 commits) · cd2d62c9

authored Apr 29, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/23d68608b007..49ca250b44c6


Created with:
  gclient setdep -r third_party/spirv-tools/src@49ca250b44c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I57a0d90e59d75d25f006a9b5ebd97c3ae93b8e6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172068Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cd2d62c9

Vulkan: Always query EGL_WIDTH and EGL_HEIGHT · 718ae508

authored Apr 28, 2020

This fixes the failures of the dEQP EGL resize tests on Android.
Those tests don't actually resize the window (which would allow the
tests to pass), but do change internal Android Surface values that
vkGetPhysicalDeviceSurfaceCapabilitiesKHR queries. Therefore, by
freshly querying these values the test passes.

Bug: b/153329980
Change-Id: Ie966f221bfaa14988c1503c7f5503f0b21476bcb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165639Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

718ae508

28 Apr, 2020 11 commits

Vulkan: Apply binding size in updateBuffersDescriptorSet. · 448b14bb

authored Apr 27, 2020

Previously we would bind the full Vulkan buffer size in cases of
unsized arrays in storage buffers. This then would lead to problems
when binding a dynamic buffer that used sub-allocation or larger
internal sizes. Instead use the GL binding size or GL buffer size as
the size limits.

Bug: angleproject:4380
Change-Id: Ia579bfeae3b8d068813336cbd5e1babee9f4f345
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168020Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

448b14bb

Ignore third_party/nasm in .gitignore. · 5f40f2fe

authored Apr 28, 2020

Was missed in the yasm->nasm update.

Bug: None
Change-Id: I6c3471d1aaea36ed129b445bfd3fa206f3437344
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2170909Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f40f2fe

Take into account baseVertex for drawElementsImpl D3D11 · d9268889

authored Apr 22, 2020

Also add test for GL_DYNAMIC_DRAW and GL_STREAM_DRAW with vertex
color data updating before each draw call to make sure index range
is retrieved correctly.

Bug: angleproject:3402, angleproject:3911
Change-Id: I5f209292b6e316e4b50505a98b361eb8761a7d6b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2162132Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>

d9268889

Capture/Replay: Simplify .gni integration. · 1398080c

authored Apr 27, 2020

Moves a lot of the code out of the gni file into tests/BUILD.gn. In
preparation for auto-generating the gni file as a simple array of trace
test names.

Bug: angleproject:4590 
Change-Id: Iaa2b7872dc6e705d59108fa7532594bdc65d365a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168359
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

1398080c

Update .clang-format. · 1f9e2a8f

authored Apr 28, 2020

Will fix the brace alignment issue. clang-format was finally updated to
a newer version in Chromium and the roll of Chromium DEPS picked up the
new version.

Bug: None
Change-Id: I3cb5aa7778fb9bf5a17a5d74dc0b108ba35aafc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2170406Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1f9e2a8f

Roll third_party/vulkan-validation-layers/src 1512acdf047f..72b2a3b275e5 (4 commits) · 80d3e268

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1512acdf047f..72b2a3b275e5

git log 1512acdf047f..72b2a3b275e5 --date=short --first-parent --format='%ad %ae %s'
2020-04-27 mikes@lunarg.com scripts: Object tracker optional handling
2020-04-27 tony@lunarg.com practices: Fix CreateFramebuffer
2020-04-27 petr_kraus@email.cz tests: Test swapchain image props
2020-04-27 petr_kraus@email.cz layers: Initialize image props for a swapchain

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@72b2a3b275e5

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I11f38bb8b52ef36fca49615d57c0b5b2ababaa54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169970Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

80d3e268

Roll third_party/vulkan-headers/src 62becc509a88..4c19ae6b95e4 (1 commits) · 821575a7

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/62becc509a88..4c19ae6b95e4

git log 62becc509a88..4c19ae6b95e4 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 oddhack@sonic.net Update for Vulkan-Docs 1.2.139

Created with:
  gclient setdep -r third_party/vulkan-headers/src@4c19ae6b95e4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=cnorthrop@google.com

Bug: None
Change-Id: If5e052ec795c2a47148494fbe5489a4031c12ad4
Tbr: cnorthrop@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169338Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

821575a7

Roll third_party/vulkan-tools/src 7774c964d3df..30eb0a301c33 (1 commits) · 34822e7a

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7774c964d3df..30eb0a301c33

git log 7774c964d3df..30eb0a301c33 --date=short --first-parent --format='%ad %ae %s'
2020-04-27 charles@lunarg.com vulkaninfo: fix queues not reporting presentation

Created with:
  gclient setdep -r third_party/vulkan-tools/src@30eb0a301c33

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I027e579d885068ef68529677939fe3ea63ec109c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169967Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

34822e7a

Roll third_party/SwiftShader 60aa34a990fa..2717702e9a1f (6 commits) · e5b82697

authored Apr 28, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/60aa34a990fa..2717702e9a1f

git log 60aa34a990fa..2717702e9a1f --date=short --first-parent --format='%ad %ae %s'
2020-04-28 capn@google.com Eliminate the ABORT() macro
2020-04-27 capn@google.com Record vkCmdBindDescriptorSets() as a single command
2020-04-27 capn@google.com Store binding information in the pipeline layout
2020-04-27 capn@google.com Don't expose individual descriptor set layouts to SPIR-V compilation
2020-04-27 capn@google.com Fix ordering of descriptor set bindings
2020-04-27 bclayton@google.com SpirvShader: Document activeLaneMask() and storesAndAtomicsMask()

Created with:
gclient setdep -r third_party/SwiftShader@2717702e9a1f

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I1e6de4a3f586a4f06925138499142efeb91bed58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169968Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e5b82697

Roll third_party/spirv-tools/src 5547553a0c7b..23d68608b007 (7 commits) · 2597459f

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5547553a0c7b..23d68608b007


Created with:
  gclient setdep -r third_party/spirv-tools/src@23d68608b007

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie81ef413c12cd1e8744c6e7f28adb378db79bc07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169966Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2597459f

Roll third_party/glslang/src bcf6a2430e99..f03cb290ac10 (3 commits) · 7c83a445

authored Apr 28, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bcf6a2430e99..f03cb290ac10


Created with:
  gclient setdep -r third_party/glslang/src@f03cb290ac10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4a270118c0d579d2125478dc44512cc98e708338
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2169969Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7c83a445

27 Apr, 2020 11 commits

Roll chromium_revision fa9d5805c4..b0410bba02 (750702:763000) · 4395170e

authored Apr 27, 2020

Includes a change from yasm to nasm.

Change log: https://chromium.googlesource.com/chromium/src/+log/fa9d5805c4..b0410bba02
Full diff: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a1cbf6469a..45ab3c89af
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/4164a30562..204a35a2a6
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3e21eec53c..3993ef1f52
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c96dc32110..217407c478
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/493c9385c9..ec647b85b6
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/ce0e57e8e6..7e3ad79800
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/156be8c52f..ae385786ed
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d60a6a8084..04b99e7bf9
* tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/0bfd826f85..aae45d8d82
DEPS diff: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02/DEPS

Clang version changed 9284abd0040afecfd619dbcf1b244a8b533291c9:4e0d9925d6a3561449bdd8def27fd3f3f1b3fb9f
Details: https://chromium.googlesource.com/chromium/src/+/fa9d5805c4..b0410bba02/tools/clang/scripts/update.py

Tbr: jmadill@chromium.org
Bug: chromium:1070043
Change-Id: I8f2cd61950b1a94b946eace49a7f1da3447522ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168533
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4395170e

Vulkan: Add gles1 conformance support. · 4262ea04

authored Jan 31, 2020

For Khnoros CTS1 support, ANGLE needs to add conformant and
rendererType for OpenGL ES1 version.

Bug: angleproject:4457
Change-Id: I58ac4672352d3d42e4b8403b80f86154b6a76edc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2160515
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4262ea04

Vulkan: Refactor AttachmentOpsArray. · fbc2f063

authored Apr 24, 2020

Will allow for more flexibly setting ops when we defer clears.

Bug: angleproject:4517
Change-Id: I7d9116bc92e90eb41a1030fea242eadf1cc74562
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165629
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

fbc2f063

OpenGL: Implement OES_draw_buffers_indexed · 6193fd69

authored Mar 07, 2020

OpenGL state sync issues as few GL commands as possible to update the
blend state regardless of an application input.

Enhanced ClearTestES3.MaskedIndexedClearMultipleAttachments
regression test.

Disabled OES_draw_buffers_indexed on Windows/AMD/OpenGL.

Bug: angleproject:4394
Change-Id: I244ac2975678bc559634152cf4eb997d9dbe83d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2145874
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

6193fd69

Fix clearing compressed textures with Vulkan backend · 6e7d7296

authored Apr 24, 2020

When making sure a texture's data is initialized in ANGLE, it
is illegal to attempt to clear it when using the Vulkan backend.

The Vulkan spec, regarding vkCmdClearColorImage, mentions that:
"image must not have a compressed or depth/stencil format"

The proper way of initializing the memory of a compressed image
in Vulkan is to do a buffer to image copy instead. This was added
to ImageHelper::stageRobustResourceClear() so that it may now
handle compressed textures properly.

Bug: angleproject:4092
Change-Id: I073ed0603d9e92e787b9be8992751dbc0c8978db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165636Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

6e7d7296

Add BlendStateExt helper structure · d6c7bac9

authored Apr 18, 2020

It provides compact storage and comparison operations for
per-drawbuffer blend states.

Added BitSetT::Zero() static constexpr.

Bug: angleproject:4394
Change-Id: I66d6275facb7b28022fc24ff9cc0d8c3c976c99d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2154669
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d6c7bac9

Add -Wno-pointer-to-int-cast · 226bba3c

authored Apr 24, 2020

This is the last remaining instance of the warning across Chromium. It's
fixed upstream but I can't seem to figure out how to successfully roll
deqp. So suppressing it here for now.

This can be removed once the deqp in Angle has
https://github.com/KhronosGroup/VK-GL-CTS/pull/199.

Change-Id: Ie954bb2a3d86ea0de644e2a78051531b396e88a8
Bug: chromium:1054220
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2165365Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

226bba3c

Roll third_party/vulkan-loader/src 4fb0e0374a39..3336e65e8801 (1 commits) · 821726de

authored Apr 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/4fb0e0374a39..3336e65e8801

git log 4fb0e0374a39..3336e65e8801 --date=short --first-parent --format='%ad %ae %s'
2020-04-24 lenny@lunarg.com loader: Check for null when creating a queue

Created with:
  gclient setdep -r third_party/vulkan-loader/src@3336e65e8801

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: I6ba1a7862b89939aa652ce5c6eeb95376f1dfb5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167771Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

821726de

Roll third_party/glslang/src 7d65f09b8311..bcf6a2430e99 (3 commits) · 2a37fab2

authored Apr 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7d65f09b8311..bcf6a2430e99


Created with:
  gclient setdep -r third_party/glslang/src@bcf6a2430e99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I973b0f74a757339badbc21555940bd04a45365bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167780Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2a37fab2

Roll third_party/vulkan-validation-layers/src bb0380e3932a..1512acdf047f (2 commits) · 55b639e6

authored Apr 27, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bb0380e3932a..1512acdf047f

git log bb0380e3932a..1512acdf047f --date=short --first-parent --format='%ad %ae %s'
2020-04-24 karen@lunarg.com docs: update khronos_validation_layer.md
2020-04-24 lionel.g.landwerlin@intel.com Fix validation of blended attachments on imageless framebuffers

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@1512acdf047f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ib8cd5bbc69271183bf3dc2b9f391dab045db9d81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167774Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

55b639e6

Roll third_party/SwiftShader f42c698d784a..60aa34a990fa (1 commits) · a67630cd

authored Apr 27, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/f42c698d784a..60aa34a990fa

git log f42c698d784a..60aa34a990fa --date=short --first-parent --format='%ad %ae %s'
2020-04-24 capn@google.com Omit ASSERT() expression evaluation in Release builds

Created with:
  gclient setdep -r third_party/SwiftShader@60aa34a990fa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: tobine@google.com
Change-Id: Ia3d9e7ad2459696eff50e5666099c69ef1f5cd58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2167772Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a67630cd