Commits · a7b60f133d104ec945dde007b1f81ab94aebdd27 · Chen Yisong / angle

09 Apr, 2021 4 commits

Translator: Validate multi-declarations are separated · a7b60f13

authored Apr 08, 2021

Many transformations only look at the first variable in a
TIntermDeclaration.  This change validates that once the
SeparateDeclarations transformation has been run, multi-declarations are
not reintroduced.

Bug: angleproject:2733
Change-Id: If5f96689cbdd28817c479dd7c495b91535f87199
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815565Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

a7b60f13

Remove unused translator option bit · 2feb3db5

authored Apr 07, 2021

SH_DONT_PRUNE_UNUSED_FUNCTIONS was only used by tests, and never used by
ANGLE or chromium.

Bug: angleproject:4889
Change-Id: I4926f86125e69b07e9d4d95134b7b70522e0d64f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607491Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2feb3db5

Roll Chromium from 6cad7c765c8b to 920c6c5ffe65 (341 revisions) · 41dbfe9c

authored Apr 09, 2021

https://chromium.googlesource.com/chromium/src.git/+log/6cad7c765c8b..920c6c5ffe65

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8df5f2532b..0006b44d1f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/b134bc315e..75df5ad7e8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..69936de9be
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a387faa2a6..6e92ef6460
* tools/luci-go: git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87..git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b
* tools/luci-go: git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87..git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b
* tools/luci-go: git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87..git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/93c8ae3a54..e509f34db2
No update to Clang.

Bug: angleproject:5417
Tbr: geofflang@google.com
Change-Id: Icaf720255a92c10111226d330fc2a055e1d4950d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815103
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

41dbfe9c

Vulkan: Add command option to run app traces with minimum GPU work · 4340fcfa

authored Apr 02, 2021

This CL interposes the draw call API entries. If enabled by command line
option "--minimize-gpu-work", it will override all draw calls to render
a single GL_POINT instead. It forces view port and scissor size to 1x1.
It forces all data copy to 1 texel or 1 byte. It ignores
glGenerateMipmap call. The goal is to make the frame time reflect the
driver CPU performance as much as possible so that we can use it to
compare ANGLE vs native GLES on the driver overhead, as well as
identifying CPU hot spot.

Bug: b/184766477
Change-Id: Ie8b5b585e0ed55320fed7863da37cce419acc65f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2802858
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4340fcfa

08 Apr, 2021 13 commits

Tests: Add Call Break: Offline Card Game trace · c2075d81

authored Apr 08, 2021

Test: angle_perftests --gtest_filter="*call_break_offline_card_game*"
Tbr: jmadill@google.com,timvp@google.com
Bug: b/184866238
Bug: angleproject:5837
Change-Id: I39035e62559d6a28fd1ae62ee6ffe6323d94931f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815780Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

c2075d81

Revert "Fix multithreaded crash on draw commands on D3D11 backend." · fc189386

authored Apr 08, 2021

This reverts commit 8b9889bf.

Reason for revert: Breaks CI

Original change's description:
> Fix multithreaded crash on draw commands on D3D11 backend.
>
> A crash can occur if thread A is executing eglDestroyContext while
> thread B issues a draw call, if the threads are interleaved in such a
> manner that a makeCurrent occurs without triggering a change to the
> global context and a dirtyAllState call. We handle that case by
> explicitly making current the proper contexts in the eglDestroyContext
> call.
>
> A test has been added that triggers a crash without this fix when
> running on the D3D11 backend. In addition, all of MultithreadingTest
> is enabled for the D3D11 backend.
>
> Test: Ran MultithreadingTest. Test exhibits a crash before this
> change, and does not after this change. Also ran:
>     dEQP-EGL.functional.sharing.gles2.multithread.*
>     dEQP-EGL.functional.multithread.*
>
> Bug: b/183756357
> Change-Id: Ic6f76a062868b2f3b4e60d29dc087ec180bfb7cd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798591
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Doug Horn <doughorn@google.com>

Bug: b/183756357
Change-Id: I2e9d6385576330f84623d7dafbf690642fcb441f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815242
Commit-Queue: Doug Horn <doughorn@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

fc189386

PPO: Fix updating sampler uniforms between draws · 0261b1d3

authored Mar 31, 2021

Updating sampler uniforms when using PPOs is currently broken, since the
Context/State use the currently bound ProgramExecutable which belongs to
the PPO, but the updates only happen to the Program's executable that
the uniform belongs to.

This change updates Program::updateSamplerUniform() to update any PPO
ProgramExecutables with the updated texture information when a Program's
sampler uniforms are updated, so the Context/State use the correct data.

Bug: b/182409935
Test: ProgramPipelineTest31.SampleTextureAThenTextureB
Test: SamplersTest31.SampleTextureAThenTextureB
Change-Id: I3c4e156c6e0c781e706f321f0bd12baf484ff42a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797951
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

0261b1d3

Tests: Add Bubble Shooter trace · 408c1512

authored Apr 08, 2021

Test: angle_perftests --gtest_filter="*bubble_shooter*"
Tbr: timvp@google.com,jmadill@google.com
Bug: b/184844832
Bug: angleproject:5836
Change-Id: I4a729028020d7e668cd7e368a4473f4e37c55b0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815778Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

408c1512

Fix iOS and Android component builds · 0eaaff28

authored Apr 07, 2021

After the changes in http://crrev.com/c/2797833

Bug: angleproject:5811, angleproject:5820
Change-Id: I629978684ba4d002c296d4dcfe434b09782db4b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2812698
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0eaaff28

Roll Chromium from c8a676460af3 to 6cad7c765c8b (151 revisions) · cec90118

authored Apr 08, 2021

https://chromium.googlesource.com/chromium/src.git/+log/c8a676460af3..6cad7c765c8b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/77edba11e2..8df5f2532b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9d80f02d0..b134bc315e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..145b45a227
* tools/luci-go: git_revision:63310fdc83db00f27d0902961627ff98043076e0..git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87
* tools/luci-go: git_revision:63310fdc83db00f27d0902961627ff98043076e0..git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87
* tools/luci-go: git_revision:63310fdc83db00f27d0902961627ff98043076e0..git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87
No update to Clang.

Bug: angleproject:5417
Tbr: geofflang@google.com,jmadill@google.com
Change-Id: I2138d63a5c0fcd4869c87446ca0a59f9ed350d46
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815239
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cec90118

Fix multithreaded crash on draw commands on D3D11 backend. · 8b9889bf

authored Mar 31, 2021

A crash can occur if thread A is executing eglDestroyContext while
thread B issues a draw call, if the threads are interleaved in such a
manner that a makeCurrent occurs without triggering a change to the
global context and a dirtyAllState call. We handle that case by
explicitly making current the proper contexts in the eglDestroyContext
call.

A test has been added that triggers a crash without this fix when
running on the D3D11 backend. In addition, all of MultithreadingTest
is enabled for the D3D11 backend.

Test: Ran MultithreadingTest. Test exhibits a crash before this
change, and does not after this change. Also ran:
    dEQP-EGL.functional.sharing.gles2.multithread.*
    dEQP-EGL.functional.multithread.*

Bug: b/183756357
Change-Id: Ic6f76a062868b2f3b4e60d29dc087ec180bfb7cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798591Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Doug Horn <doughorn@google.com>

8b9889bf

Reset mCurrentGraphicsPipeline in ProgramExecutableVk::reset · d3e1a7ff

authored Mar 29, 2021

ContextVk::mCurrentGraphicsPipeline should be reset during
ProgramExecutableVk::reset() since programInfo.release() frees the
PipelineHelper that it's pointing to. This has resulted in several
use-after-free errors, which this CL will prevent in the future.

Bug: angleproject:5624
Bug: b/182409935
Change-Id: I847bb7eb5b593c89b84f0fbbca23ea5367f5f55c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2792861
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

d3e1a7ff

Make "force context check" an optional GN flag. · 54dfb62c

authored Apr 07, 2021

Previously it was enabled by default in every build that includes
D3D11. This would impact CPU overhead in Chrome and other targets
that don't need this feature.

Bug: angleproject:5828
Change-Id: Ic9d700847c72978540b66fdaf7a62f959779f2e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809855Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Doug Horn <doughorn@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

54dfb62c

Tests: Add Professional Baseball Spirits trace. · b604f843

authored Apr 07, 2021

Skip the test on Vulkan+AMD+Linux, as it produces OpenGL errors on
Mesa/RADV.
Also skip the test on Vulkan+Intel+Linux, as it requires a Mesa version
of 20.3.5 or higher to work.

Test: angle_perftests --gtest_filter="*professional_baseball_spirits*"
Bug: b/181870336
Bug: angleproject:5827
Change-Id: Ic9c5e3767cb6cf7e925cfbcd2ae5dda0d736b87c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810788Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

b604f843

Roll vulkan-deps from 575b36060ded to c18d8cd5016c (3 revisions) · 83c90f24

authored Apr 08, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/575b36060ded..c18d8cd5016c

Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8bb72ad221..f563b367c7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I6175915edc5f9da742b0076e9700190959bf05c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2814338
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

83c90f24

Roll Chromium from 743bf032b75b to c8a676460af3 (490 revisions) · 619cdbd0

authored Apr 08, 2021

https://chromium.googlesource.com/chromium/src.git/+log/743bf032b75b..c8a676460af3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3e210bf13a..77edba11e2
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/a136a3b8e9..d0f33885a2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/05632231e5..a9d80f02d0
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3cd3442b05..5447d00cc9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..44319b56ef
* tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:63310fdc83db00f27d0902961627ff98043076e0
* tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:63310fdc83db00f27d0902961627ff98043076e0
* tools/luci-go: git_revision:d6d24b11ecded4d89f3dfd1b2e5a0072a3d4ab15..git_revision:63310fdc83db00f27d0902961627ff98043076e0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/8311fb760c..93c8ae3a54
* tools/skia_goldctl/linux: -rExHiWOcks_RlkFBMnAOYEVLEGvm3sncdHy7RIQUvUC..hppkAohY9Cc45kW6zZWYXtdLKzo9CQ9XvcqLNIBaqQQC
* tools/skia_goldctl/mac: vJzRxG9eh8Zl9oN4Li63sfRu7kHPvf54fXvv-nMXJZcC..JnqYnN3TwP__L0jvUBgcLpPQsBgz9ZcBk8-bsbiez6QC
* tools/skia_goldctl/win: Uc9sbdhlwsqNbi5Q4fAmKXKL665j5gsdf3Ifpe4qnr0C..0el4SjlMxSJWhUyzmXXYXqGT59IZHXzEaDTufNH8bOwC
No update to Clang.

Bug: None
Tbr: geofflang@google.com
Change-Id: Idc95dd300300cb1d8eb49f95acaa51f017bb9b3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2812961
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

619cdbd0

Tests: Add Disney Tsum Tsum trace · fc28c1db

authored Apr 07, 2021

Test: angle_perftests --gtest_filter="*disney_tsum_tsum*"
Tbr: timvp@google.com,jmadill@google.com
Bug: b/184770989
Bug: angleproject:5835
Change-Id: I2ee74f95391fa30b0d5bfa88be5fc7dd59fd6f70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2811644Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

fc28c1db

07 Apr, 2021 22 commits

Vulkan: Update layer provoking vertex for geometry shaders · 5af6306a

authored Mar 31, 2021

Set the GS layer provoking vertex value to
GL_LAST_VERTEX_CONVENTION if the provoking vertex extension
is enabled. Otherwise, use GL_FIRST_VERTEX_CONVENTION as
vulkan follows this convention for provoking vertex.

Tests: dEQP-GLES31.functional.geometry_shading.layered.layer_provoking_vertex_*
Bug: angleproject:5452
Change-Id: Ie385f3b713486c54114dbfcefd799d180701bb60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2799033
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5af6306a

Capture/Replay: Ignore deletes of buffer 0 · d49f7351

authored Apr 07, 2021

Per the spec for DeleteBuffers:
> Unused names in buffers are silently ignored, as is the value zero.

Haven't seen an app delete unknown buffers yet, but just hit one that
deletes 0 a lot.

Test: MEC for Disney Tsum Tsum
Bug: b/184770989
Bug: angleproject:5835
Change-Id: I2070b753d89fdcf390203072cd7ec2c9f915089c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2811643
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d49f7351

Vulkan: Refactor to descriptor offset array. · efc53d0f

authored Apr 03, 2021

This is in preparation for using dynamic offsets for other sets than
the default descriptors.

Bug: angleproject:5736
Change-Id: I546e688ad57a35b380f8d7f303ffc0c62773ac18
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2804813
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

efc53d0f

restricted_traces: Remove sha1 remains. · 4640dbff

authored Apr 07, 2021

This deletes redundant sha1 files that are not required anymore since
the migration to CIPD.

Bug: angleproject:5811
Change-Id: Ib1131f9cdda0b00b8f605f8b6dff6650d262ce25
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810789Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4640dbff

Expand CL plumbing support to cover all versions · 84a62266

authored Apr 01, 2021

The OpenCL CTS assumes that libOpenCL has symbols for all versions as it
usually expects to link against the Khronos loader. Since we're not
using that, we have to expose all the symbols it wants, whether we
intend to implement all versions or not. All the 2.x stuff will likely
remain stubs forever as it is made optional again in 3.0.

In the generator scripts, work around a small issue where one function
takes an array-typed parameter, which confused just_the_name and
produced invalid code.

Bug: angleproject:5819
Change-Id: I6c3591dc9229c5276f14ff66ee3ee6362e8bf622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807531
Commit-Queue: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: John Plate <jplate@google.com>

84a62266

Perf Tests: Trigger test failure on API errors. · 68f06888

authored Mar 23, 2021

A prior refactor had broken the method we used to cause test steps to
fail on API errors. This CL restores the path. We detected this when
analyzing a particular GLES trace that contained invalid GLES calls.

Bug: angleproject:5788
Change-Id: I26940e49cf73ce6050ea6ee274d5c5748835a167
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782008
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

68f06888

Scripts: Update bootstrap.py to python3 · 8135dccf

authored Apr 07, 2021

Bug: angleproject:5829
Change-Id: I564fadee92b6ff301c055cf95a163ffb3c838685
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810338Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8135dccf

Handle trace prerequisites. · b4cb63a5

authored Apr 06, 2021

real_gangster_crime: external images
avakin_life: external images
hill_climb_racing: skip on Adreno

Bug: angleproject:5822
Bug: angleproject:5823
Change-Id: I7c6a27eab72ba69464748928c93dda57fa8094f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809653
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b4cb63a5

Capture/Replay: Fix upload script · bd82de95

authored Apr 07, 2021

Small fix to info level logging.

Bug: angleproject:5811
Change-Id: I7c6c762e17b652eedcbde0719996532e730e2a39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809889
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bd82de95

Improve Angle Android gtest support · bf0c6ae1

authored Mar 09, 2021

This CL makes angle_test() use an angle-specific gtest launcher -
AngleUnitTestActivity.java. This enables building standalone Android
angle without //base

Chromium-Bug: 1149922
Bug: None
Change-Id: Id84f3e2bd84c5017ed1988ca07534f424ebfa596
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745535Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bf0c6ae1

perf_test_runner: Enable all trace tests. · 2ef1e0fc

authored Apr 06, 2021

Will allow running "null" Mock ICD tests.

Also fixes a crash running the Mock ICD with the overlay.

Bug: angleproject:5736
Change-Id: I42e3943a0de00dbab3ee125f1946afd22b38fec6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809096Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2ef1e0fc

restricted trace tests: Fix script. · 31d48df1

authored Apr 07, 2021

This script was not parsing the trace list properly and was
running no tests.

Bug: angleproject:5811
Change-Id: I925bc16ac476823ca2f850d4a9e208b9bb5deb62
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810805Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

31d48df1

Add Mesa Vendor ID · 6a606231

authored Apr 06, 2021

ANGLE doesn't recognize the Mesa vendor ID, leading to a crash in
GetVendorString(). This is exposed when trying to capture traces of
ANGLE captures with RenderDoc.

Bug: angleproject:5824
Change-Id: I6c45a01dba78fa6057df26b38ca3db89cacf865e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809878Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

6a606231

Refactor roll_aosp.sh · 4bd370dd

authored Apr 02, 2021

roll_aosp.sh can now generate an Android.bp file without having to
perform a roll. This facilitates on demand generation of Android.bp.
Provide an option to enable API traces with "--enableApiTrace" flag.

Usage -
    # Generates Android.bp and perform a roll
    ./scripts/roll_aosp.sh

    # Generates Android.bp
    ./scripts/roll_aosp.sh --genAndroidBp

    # Generates Android.bp with API tracing enabled
    ./scripts/roll_aosp.sh --genAndroidBp --enableApiTrace

Bug: angleproject:5774
Change-Id: I3a2bd505f5d75d6d5fc331d61fa9517d6042db70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774758Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

4bd370dd

capture: Implement capturing GLES1 vertex pointers. · fddbc9c7

authored Mar 04, 2021

Implement capturing glVertexPointer, glTexCoordPointer, glNormalPointer,
glColorPointer and glPointSizePointerOES using a new
CaptureVertexPointerGLES1 helper function.

This is done by using fixed indices for gClientArrays that are retrieved
from the GLES1Renderer.

Bug: angleproject:5751
Change-Id: I6c774ff21942ea3422c4c77a615f88299901c0ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773288Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

fddbc9c7

EGLWindow: Append noError context attribs only if enabled. · df72ea36

authored Mar 31, 2021

Push EGL_CONTEXT_OPENGL_NO_ERROR_KHR only to the context attribute list
if it's enabled in the mConfigParams. Prior to this patch the attribute
was pushed with a EGL_FALSE value if noError was disabled but available.

This resolves issues on EGL implementations which expose the extension
but fail if it's in the attrib list if certain conditions are met.

This is the case for mesa 21.0 when EGL_CONTEXT_MAJOR_VERSION_KHR is set
to 1 / GLES1.

Mesa upstream issue:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/4586

Bug: angleproject:5809
Change-Id: I91dfafe2a89f0488556942813087e54499895088
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2797331Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

df72ea36

Fixed OpenCL headers for Windows · 2489a0c1

authored Apr 06, 2021

Bug: angleproject:5761
Change-Id: I29d1fd3bf862728a3e78418a4f98219828394452
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807717
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2489a0c1

Roll vulkan-deps from fac6f6b00985 to 575b36060ded (3 revisions) · 15b34197

authored Apr 07, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/fac6f6b00985..575b36060ded

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/5878bcb17e..1481399549
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/7ea01c139f..64cc17099c
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/36e147f591..8bb72ad221

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I43ef7e9e9c61fb68ce0c97bd105bbb32dbea91db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809887
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

15b34197

Roll Chromium from 9bacc030553c to 743bf032b75b (182 revisions) · 0c6efe64

authored Apr 07, 2021

https://chromium.googlesource.com/chromium/src.git/+log/9bacc030553c..743bf032b75b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/83694c4d99..3e210bf13a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/41c8c7acfb..05632231e5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41a5e5e465
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/52aea199fe..8311fb760c
No update to Clang.

Bug: None
Tbr: geofflang@google.com
Change-Id: I3c4b79720e47d29353ee72211051b462d49a731f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810336
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c6efe64

Vulkan: Remove initImmutableImage and use initImage instead · 6d905c76

authored Apr 01, 2021

This is follow up of crrev.com/c/2368038. There was concern that
initImmutableImage and initImage are a bit duplicated. This CL gets rid
of initImmutableImage and uses initImage instead.

Bug: b/181800403
Change-Id: I2c73c7ce979792cc762214f1e5ef9978eeab6212
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800422
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

6d905c76

Vulkan: Remove maxLevel and immutable from ImageHelper::initExternal · 92d3912d

authored Apr 01, 2021

Now that we have removed mBaseLevel and mMaxLevel from ImageHelper class
in previous two CLs. The initExternal function can be modified to not
pass in base/max level information. This CL also removes immutable from
argument and let caller directly pass in firstLevel to it.

Bug: b/181800403
Change-Id: I595c1faffabc7582af35a9578b2ecdf00c39207f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800414
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

92d3912d

Roll Chromium from 99ef73b66e73 to 9bacc030553c (0 revision) · 2143ffc2

authored Apr 06, 2021

https://chromium.googlesource.com/chromium/src.git/+log/99ef73b66e73..9bacc030553c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/728a23351d..83694c4d99
* buildtools/linux64: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92
* buildtools/mac: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92
* buildtools/win: git_revision:a95c8a3ccc7de65eb740aa68a0d021cdc8550205..git_revision:dba01723a441c358d843a575cb7720d54ddcdf92
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/9a03e1204d..41c8c7acfb
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..41a5e5e465
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/ada51aa113..a387faa2a6
No update to Clang.

Bug: None
Tbr: geofflang@google.com,ynovikov@google.com
Change-Id: Ic4d83afa511c9cf906c298c23e0fc194e2672500
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808704
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2143ffc2

06 Apr, 2021 1 commit

Vulkan: Suppress draw-time push constant VVL warnings. · f34b40da

authored Apr 06, 2021

    VUID-vkCmdDraw-None-02698
    VUID-vkCmdDrawIndexed-None-02698
    VUID-vkCmdDrawIndirect-None-02698
    VUID-vkCmdDrawIndirectCount-None-02698
    VUID-vkCmdDrawIndexedIndirect-None-02698
    VUID-vkCmdDrawIndexedIndirectCount-None-02698
    VUID-vkCmdDispatch-None-02698

Bug: angleproject:5821
Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f34b40da