Commits · a9f26cc1ec7522ca959df592a35b3219f378aa43 · Chen Yisong / angle

30 May, 2021 1 commit

Roll VK-GL-CTS from ea6189a7a67e to dd333551c971 (11 revisions) · a9f26cc1

authored May 30, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ea6189a7a67e..dd333551c971

2021-05-29 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-05-28 alexander.galazin@arm.com Update OpenGL mustpass
2021-05-28 alexander.galazin@arm.com Add AOSP tests to the GL4.5 mustpass
2021-05-28 rgarcia@igalia.com Check supportedAlpha is never zero
2021-05-28 siglesias@igalia.com Do not clamp ambiguous snorms values on vkCmdCopy*() functions
2021-05-28 juha.heiskanen@siru.fi Add writing to invalid multisample indices tests
2021-05-27 lexa.knyazev@gmail.com Add GL_EXT_texture_sRGB_RG8 support
2021-05-27 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests
2021-05-27 venni.ihanakangas@siru.fi Add permutations of different cases on existing test
2021-05-27 siglesias@igalia.com Add multiple statistics query tests
2021-05-27 rgarcia@igalia.com Use arrays of pointers with non-identity matrices

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC angle-bots+autoroll-info@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: angle-bots+autoroll-info@google.com,jmadill@google.com
Change-Id: Id1c5be98d90c0d6013fb18955dd9c333f93055b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2926637
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a9f26cc1

28 May, 2021 3 commits

Gold Tests: Fix batch result reporting · 1429130b

authored May 28, 2021

Previously artifacts were not reset for a new trace in a batch

Bug: angleproject:5966
Change-Id: Ia6ed8c070eaaeca7e6cea887419666f630648df8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925218Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

1429130b

Roll vulkan-deps from 012f2ef00731 to 8ea5e4dc6455 (2 revisions) · 45e1596c

authored May 28, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/012f2ef00731..8ea5e4dc6455

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/6fe560f74f..6bdcb4be34
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/ff61890722..a6ce49ca24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I49582b8058df2eed78cc73c3fc6a739ad0ad1772
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925140
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

45e1596c

Roll Chromium from 9e607ee51d46 to ed36a7408427 (195 revisions) · c14ffb98

authored May 28, 2021

https://chromium.googlesource.com/chromium/src.git/+log/9e607ee51d46..ed36a7408427

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b5063cfbea..862b91b57a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/b014545e6c..0f50062689
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..dca1c9711a
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6fc394f93d..0694fa65f8
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4dfe812639..0679044e60
No update to Clang.

Bug: None
Tbr: jmadill@google.com
Change-Id: Id6add386fb8c1189bdb6e97cbc508af6dda1c623
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2925139
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c14ffb98

27 May, 2021 12 commits

Gold Tests: Fix batch uploading · ce7d80bd

authored May 27, 2021

Uploading to Gold used to stop after the first failure in the batch

Bug: angleproject:5966
Change-Id: Iff89c106b18a9aab5a43742a6085c5f9a3c9a188
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923784Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

ce7d80bd

Vulkan: Fine-grained depth stencil layout transition barrier · b6bd039c

authored Oct 06, 2020

Gfxbench Manhattan uses depth attachment as texture in the same render
pass, which creates a feedback loop. The layout we are using for this
has kAllShadersPipelineStageFlags even though it only used by fragment
shader. This creates an unnecessary vertex/fragment dependency that
hurts performance on some mobile GPUs. This CL split
DepthStencilReadOnly to DSAttachmentReadAndFragmentShaderRead,
DSAttachmentReadAndAllShadersRead, and DepthStencilAttachmentReadOnly,
so that if it is used by fragment shader, we only barrier against
fragment stage. If not used by any shader, we don't block any shader
stages. To make names consistent, this CL also renames
DepthStencilAttachmentAndFragmentShaderRead to
DSAttachmentWriteAndFragmentShaderRead, renames
DepthStencilAttachmentAndAllShadersRead to
DSAttachmentWriteAndAllShadersRead.

Bug: b/169891513
Change-Id: Iede497e8af028861f9166a32d122f26dc7aa864a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453599
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b6bd039c

Vulkan: Disable shadowBuffers feature · 5e631c5f

authored May 20, 2021

For PixelUnpack, if the feature is enabled, it always create a shadow
CPU mapped memory. Then when mapBuffer is called, it let user write to
the shadow memory. At unmapBuffer time, it memcpy the shadow buffer data
to context's staging buffer and then issue a vkCmdCopyBuffer from
context staging buffer to the PixelUnpack buffer. This involves too
many data copies. The proper way to do it is simply make sure to create
the buffer as CPU map-able and let user directly write to it. If we find
cases that CPU waiting for GPU to finish is causing performance issues,
there are two ways to improve/fix it: 1)Add event at end of each
renderpass or FBO so that we know if GPU access is finished or not
without have to wait for entire frame to finish rendering. 2) Create
multiple buffers and ping-pong between them, at least there will be no
VkCmdCopyBuffer call involved like shadow buffers do. But we will leave
that to future time when we find such need.

Bug: angleproject:5986
Change-Id: Ib8300e46e779d20533c1f7f81624de0ce003788b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2909758
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

5e631c5f

Roll Chromium from b6af002ef64a to 9e607ee51d46 (637 revisions) · 05baaa37

authored May 27, 2021

https://chromium.googlesource.com/chromium/src.git/+log/b6af002ef64a..9e607ee51d46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/74f9de2dfa..b5063cfbea
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/256e043811..b014545e6c
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/4c713c1163..7949d87093
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/46f611a284..c422ce7b84
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e83a92e7b8
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/72bc20ef29..6fc394f93d
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/e4c7c48174..d0e636edaa
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/31bd71668d..4dfe812639
No update to Clang.

Bug: None
Tbr: jmadill@google.com,ynovikov@google.com
Change-Id: I0008f18e7c0a0e2240947db223e3961ae6218a47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923322
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

05baaa37

Mute MSAN false positive · 84c42d1b

authored May 26, 2021

MSAN currently detects false positives on global/static
thread_local variables which are created at library load
time. This CL mutes the false positive in order to unblock
running blink_web_tests with SwANGLE on MSAN bots.

Bug: chromium:1211047
Change-Id: I7cd103d470177d783df7f73ca6ceeedc0774b163
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920486
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

84c42d1b

Suppress new KHR-GLES32 test on Pixel 2 · de7f559e

authored May 27, 2021

Added in crrev.com/c/2921449

Bug: angleproject:6008, chromium:1214047
Change-Id: Icb42e438fc87271d1c5abbe2201d6c2bf597a4e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2923782Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

de7f559e

Vulkan: Improve generateMipmapsWithBlit barrier usage · d151af7b

authored May 20, 2021

ImageHelper::generateMipmapsWithBlit() implements glGenerateMipmap using
vkCmdBlitImage. For each level it changes layout to
VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL and issue a blit. In order to keep
all mipmap levels' layout consistent, it issues a vkCmdPipelineBarrier
call for the the very last mipmap level to change it to
VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL as well. This creates an
unnecessary barrier for the next operation, that now it sees a barrier
against transfer stage. This CL changes all levels to
VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL so that the whole image will
have consistent layout. After glGenerateMipmap call, the next reasonable
usage is use it in fragment shader, so the barrier is not wasted.

Bug: angleproject:5986
Change-Id: I3690ae8417d97bc504fcf036d016f289e6370526
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2909757
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

d151af7b

Roll VK-GL-CTS from 8010f59c7034 to ea6189a7a67e (4 revisions) · 2622c7b0

authored May 26, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/8010f59c7034..ea6189a7a67e

2021-05-26 mikko.tiusanen@siru.fi Remove empty subtest
2021-05-26 mikko.tiusanen@siru.fi Lower vector constructor test shader version
2021-05-26 mikko.tiusanen@siru.fi Test framebuffer completeness when layered rendering
2021-05-26 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC jmadill@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:6008
Change-Id: I580ddda1ac7fa4614fcf00b834f51b9dc725392c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921449Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2622c7b0

Capture/Replay: Skip GLGetActiveUniformsiv · a29a64a6

authored May 26, 2021

Test: Genshin Impact MEC
Bug: b/181794064
Change-Id: Ib0edfa8d1c063d43c34a65be0144bc5efc4cf19b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921067Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

a29a64a6

Capture/Replay: Support GetUniformIndices · 5ee4a0cb

authored May 25, 2021

Test: Genshin Impact MEC
Bug: b/181794064
Change-Id: I69e2c78678b8e279478ae946131b7e1730070cb0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2921066Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

5ee4a0cb

Tests: Update capture_replay_test expectations · fd262fdc

authored May 26, 2021

Bug: angleproject:6006
Change-Id: I56d21a9d9df343fbf805c10307265cab929914c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920087
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fd262fdc

Roll vulkan-deps from 89ab6280369d to 012f2ef00731 (4 revisions) · b184c64f

authored May 27, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/89ab6280369d..012f2ef00731

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/00ce2bb474..ec1bc3e2e5
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5274701761..8a22bcf6bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I5b6edf04e95609beefe3aa8e9b632c307bf00180
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2920090
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b184c64f

26 May, 2021 10 commits

Gold Tests: Add batching. · 163f6ac0

authored May 26, 2021

This should speed up test runs on Android, which are currently much
slower than the other platforms.

Bug: angleproject:5966
Change-Id: I57890522b64d1d195ea0be56b4f68b6d54192d64
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919888Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

163f6ac0

Revert "GL: Skip redundant flushes." · 565bba3d

authored May 26, 2021

This reverts commit 7a38f3f5.

Reason for revert: caused numerous test failures on FYI waterfall per http://crbug.com/1213507 .

Original change's description:
> GL: Skip redundant flushes.
>
> Skip flushes when there is no work submitted since the last
> flush.
>
> Clone of geofflang's:
> https://chromium-review.googlesource.com/2911879
>
> Bug: chromium:1181068
> Change-Id: Idd8a1c61b814d746bf1e0225cfc4ca375a7bb224
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915675
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: chromium:1181068
Bug: chromium:1213507
No-Try: True
Change-Id: Icd1662e4ea541375b44bddaa839a5241cdad5302
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919503
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

565bba3d

infra: Shard restricted_trace_gold_tests. · 17c45b65

authored May 25, 2021

Reduces shard time from 50+ min to <10 min per shard.

Bug: angleproject:5966
Change-Id: Ia230d71a66ac9a273a10e0389cc04d8c5737bc4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915566
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

17c45b65

Add nullptr check for pfnGetPhysicalDeviceProperties · 814dc299

authored May 25, 2021

This function may be called without checking the pointer.
Speculative fix for a crash in GetSystemInfoVulkan.

Bug: chromium:1211839
Change-Id: Ia7fa55fc328d02bdcd6d48e9b93f552aaea2b284
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2917353Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

814dc299

GL: Implement multisampled_render_to_texture · f410e81a

authored Apr 20, 2021

Bug: angleproject:2894, angleproject:5988
Change-Id: I17b55f0655d32d9f41cb55a0467b93a00fba751b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841084
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f410e81a

Make ANGLE's program hash key deterministic. · f97b8193

authored May 12, 2021

ANGLE's program hash iterates over hash maps which do not guarantee
a determinisitic iteration order. Copy these maps to std::map before
iteration.

It's unclear what must change to make these maps iterate differently,
EGLBlobCacheTest.Functional does cover this path but doesn't trigger
any issues.

Bug: angleproject:5913
Change-Id: Ib5f2c0a0a4e05cbaeeec5d9c889718d53c5fcf1c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892254Reviewed-by: Sunny Sun <sunny.sun@arm.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

f97b8193

infra: Remove Pixel 2 (android_vk) tests from CQ. · cf243705

authored May 25, 2021

These tests are now fully running on the Pixel 4.

Bug: angleproject:5941
Change-Id: Ic0bb094c917226867c3b34ede19986e95ce69b7f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915565Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cf243705

CL: program object creation for front end and pass-through · 1aa88398

authored May 24, 2021

Add program object to back end and implement creation and info query.

Bug: angleproject:6001
Change-Id: If94db8ab8b491e1ac21c767347cabb6f4f3b3cba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912465Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

1aa88398

Roll vulkan-deps from cca33b4d0510 to 89ab6280369d (2 revisions) · a8d98fcf

authored May 26, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/cca33b4d0510..89ab6280369d

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/91931ffcd2..00ce2bb474

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I3fecbbff87b8b7af249bff39f38c8f6d6afffb7f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919169
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a8d98fcf

Roll Chromium from 594a967a8bf8 to b6af002ef64a (448 revisions) · 91885151

authored May 26, 2021

https://chromium.googlesource.com/chromium/src.git/+log/594a967a8bf8..b6af002ef64a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/195185a687..74f9de2dfa
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/8b015a7982..da3e6cbc62
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/0519f53328..256e043811
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6d73014a65
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7fc02e848a..72bc20ef29
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2865d44621..e4c7c48174
* tools/luci-go: git_revision:03ef3f6285cef3766c18a5c7b8cc8c0069eaa2ed..git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab
* tools/luci-go: git_revision:03ef3f6285cef3766c18a5c7b8cc8c0069eaa2ed..git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab
* tools/luci-go: git_revision:03ef3f6285cef3766c18a5c7b8cc8c0069eaa2ed..git_revision:03ab00ce4982877f2d4a0b0db48cd355e5ca65ab
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fd0742eeef..31bd71668d
No update to Clang.

Bug: None
Tbr: jmadill@google.com
Change-Id: I99660d59703eb5917ebc5a8288c2274d7c6de3b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2919168
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

91885151

25 May, 2021 12 commits

Vulkan: Move framebuffer dirty bits handling after texture · a280c671

authored May 24, 2021

When texture changes, it notify the observer. Framebuffer object is one
of the observer and is able to respond to the changes in texture object.
In this specific case, when texture called TextureVk::releaseImage and
requires framebuffer object to syncState and call
TextureVk::initRenderTargets. The problem right now is that framebuffer
object's dirty bits are processed before texture, which means if the
texture is being used by currently bound framebuffer object, it will not
trigger the FBO's dirty bit handling. This CL moves container object
dirty bit (DIRTY_OBJECT_DRAW_FRAMEBUFFER and
DIRTY_OBJECT_READ_FRAMEBUFFER)  after texture/image object's dirty bits.

Bug: chromium:1212206
Bug: chromium:1197431
Change-Id: I95723da1ce5b8936d66692242f2e25e7a73bafe6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915764
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a280c671

Vulkan: Convert web_gl.fuzz545ImmutableTexRenderFeedback to gl_test · ecf2956d

authored May 24, 2021

Bug: chromium:1212206
Change-Id: I4b87906a9e877da12d64e39bfe54b9b7cec409a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912928Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

ecf2956d

CL: sampler object creation for front end and pass-through · e3dd7161

authored May 24, 2021

Add sampler object to back end and implement creation and info query.

Bug: angleproject:6001
Change-Id: If5b7d09564d773d6aeda7612728e19bfec7f6155
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912806
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e3dd7161

Add test for Vulkan crash with texture MAX_LEVEL change · 7761ed1d

authored May 11, 2021

Bug: chromium:1197431
Change-Id: I05fba78b32a7c5d5f1da0435084f96c510b15ed5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889600
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7761ed1d

Vulkan: Clean up GS deqp expectations · 2a0ca0fe

authored May 25, 2021

Bug: angleproject:5579
Test: KHR-GLES32.core.geometry_shader.layered_rendering.layered_rendering
Change-Id: I84a2487a80334b51e7200833ec05fe7d3b773c90
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2917815
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2a0ca0fe

CL: image object creation for front end and pass-through · a6210a8f

authored May 23, 2021

Add image object to front end and implement creation and info query.
Cache more Device info for Image validation.

Bug: angleproject:5956
Change-Id: I38374f4c2c85287109c464ac90eb1bf49b07fa0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912805
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a6210a8f

Reduce ANGLE APK size · 4df2e8ce

authored May 24, 2021

Add some flags to generate_android_bp.py to make the AOSP match the
ANGLE build flags, which makes the CQ testing more relevant and reduces
the ANGLE APK size.   Additionally, disable various GN args that are no
longer required (GL, ESSL, HSSL).   Together, this reduces the ANGLE APK
size in AOSP from 22.2MB to 16.7MB.

This CL also makes some fixes to roll_aosp.sh that are suggested by
"Shell Scipt".

Bug: b/189125396
Test: manual verification
Change-Id: Iea33de799a00ffff182cf028a6998e1ef01a00e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912933Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

4df2e8ce

Add LOCAL_LICENSE_KINDS to generate_android_bp.py · 51feebb4

authored May 21, 2021

Upstread the AOSP license changes that keep getting reverted:
https://android-review.googlesource.com/c/platform/external/angle/+/1704346

Added SPDX-license-identifier-Apache-2.0 SPDX-license-identifier-BSD to:
  third_party/android_ndk/sources/android/cpufeatures/Android.mk

Added SPDX-license-identifier-Apache-2.0 SPDX-license-identifier-BSD
    SPDX-license-identifier-GPL SPDX-license-identifier-GPL-2.0
    SPDX-license-identifier-GPL-3.0 SPDX-license-identifier-LGPL
    SPDX-license-identifier-MIT SPDX-license-identifier-Zlib
    legacy_unencumbered
to:
  Android.bp via generate_android_bp.py

Bug: b/186906888
Change-Id: I86081cfe2858702ed350ce8c72afaaa8eb5566b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912918Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

51feebb4

GL: Skip redundant flushes. · 7a38f3f5

authored May 21, 2021

Skip flushes when there is no work submitted since the last
flush.

Clone of geofflang's:
https://chromium-review.googlesource.com/2911879

Bug: chromium:1181068
Change-Id: Idd8a1c61b814d746bf1e0225cfc4ca375a7bb224
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2915675
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

7a38f3f5

CL: buffer object creation for front end and pass-through · efd8da4d

authored May 21, 2021

Add Buffer object to front end and Memory object to back end.
Implement creation of buffer and sub-buffer objects.
Make cl::Object destructor virtual to support destruction of Buffer.
Cache more Device info for Buffer validation. Add missing and move
existing version checks into validation.

Bug: angleproject:5956
Change-Id: Iea7665be5f6bdd8469e81f5fe4935a9fb0e03436
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912677Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

efd8da4d

Roll vulkan-deps from 1e60587ea42c to cca33b4d0510 (6 revisions) · 63f062e4

authored May 25, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/1e60587ea42c..cca33b4d0510

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0afe1f2b3f..91931ffcd2
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/a132dee142..3bdb32d29f
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/72c2d5f0b0..4e4619ae69
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/00cc43d564..5274701761

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jmadill@google.com
Change-Id: I71a5deb44fdce08c157fa2041fea2311d08f713f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2916573
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

63f062e4

Roll Chromium from 8023f14612cf to 594a967a8bf8 (310 revisions) · 75b9ac30

authored May 25, 2021

https://chromium.googlesource.com/chromium/src.git/+log/8023f14612cf..594a967a8bf8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/3a2af0ac45..195185a687
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/882b1ad904..0519f53328
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..53102de187
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6097a92db0..7fc02e848a
* third_party/jinja2: https://chromium.googlesource.com/chromium/src/third_party/jinja2/+log/11b6b3e597..6906af9d94
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5b8d433953..2865d44621
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/b02b99e45d..d663c27435
* tools/luci-go: git_revision:ff0c02e960b17be5a8d02c13afc28373f236a860..git_revision:03ef3f6285cef3766c18a5c7b8cc8c0069eaa2ed
* tools/luci-go: git_revision:ff0c02e960b17be5a8d02c13afc28373f236a860..git_revision:03ef3f6285cef3766c18a5c7b8cc8c0069eaa2ed
* tools/luci-go: git_revision:ff0c02e960b17be5a8d02c13afc28373f236a860..git_revision:03ef3f6285cef3766c18a5c7b8cc8c0069eaa2ed
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/67fb767044..fd0742eeef
* tools/skia_goldctl/linux: TV3JKpzwWXfG-NTkaeTjpVEsf8EtzcmW29vd8Rjhy8cC..8A8GVNDvQNly-61PpEBfFpqpG9cscGA9DrHNNoc8tSQC
* tools/skia_goldctl/mac: pc3O9jtat8gz4ljL5-dxH01Ocnr0jrR5TgAicVO43_oC..iqXjvpHQMsiYHTsmCxuGGRSb6zp776WuTrwp1k9p_A4C
* tools/skia_goldctl/win: 0hsVmGWo4dqGIAWMqMjUS_uehrpjItSxcoAW_DYPdycC..SufM9WryJm4lk56xFxO5xa0VKBqk-rQ7kcVCJl111ecC
No update to Clang.

Bug: None
Tbr: jmadill@google.com
Change-Id: I4156196e4c2c28a575f7f38fed903a55a8b615fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2914202
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

75b9ac30

24 May, 2021 2 commits

Roll SwiftShader from 024bf32587e5 to b46b97c10c10 (3 revisions) · 91e693af

authored May 24, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/024bf32587e5..b46b97c10c10

2021-05-22 swiftshader.regress@gmail.com Regres: Update test lists @ cbfa971a
2021-05-21 johnstiles@google.com Revert "Fix error in mat4x2(scalar) construction."
2021-05-21 capn@google.com Update llvm::ConstantVector::getSplat() usage to take ElementCount

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I527202ebc7dfd02bd129e85d5bdb50b6e24a3499
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2914993
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

91e693af

Roll vulkan-deps from 15fd0774bd48 to 1e60587ea42c (13 revisions) · e611c292

authored May 24, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/15fd0774bd48..1e60587ea42c

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/e71278cc92..6fe560f74f
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/418542eaef..ff61890722
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f0d110e305..0afe1f2b3f
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/9af411e83f..7fe877c90a
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9c5f59d177..00cc43d564

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I3c85ede6be21757e64cb9d5189fae9c4b54eb7cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2912923
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e611c292