Commits · ac05066a00a9c7fecbe3c0fe4bf71c3994c8c200 · Chen Yisong / angle

11 Jan, 2021 1 commit

Roll Chromium from 28ecef438c2c to 29d2d6a2d436 (82 revisions) · ac05066a

authored Jan 11, 2021

https://chromium.googlesource.com/chromium/src.git/+log/28ecef438c2c..29d2d6a2d436

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/06eb186470..d1a74631f6
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/fdaafe276e..b6a5362054
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ic0ae8442611bc2c32241cf0f8496f118e6e32dca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2620868Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ac05066a

09 Jan, 2021 5 commits

Roll chromium_revision 1e679b773d..28ecef438c (841389:841845) · 0b90eef0

authored Jan 09, 2021

Change log: https://chromium.googlesource.com/chromium/src/+log/1e679b773d..28ecef438c
Full diff: https://chromium.googlesource.com/chromium/src/+/1e679b773d..28ecef438c

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/762c7888b9..06eb186470
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce1689b82d..fdaafe276e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c000d6e459..28924eafb2
DEPS diff: https://chromium.googlesource.com/chromium/src/+/1e679b773d..28ecef438c/DEPS

No update to Clang.

TBR=ynovikov@chromium.org,
BUG=angleproject:5417

Change-Id: I247873fe591c915cf1280739eeff98292984a6bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2619938
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

0b90eef0

Revert "Use is_apple instead of is_mac and is_ios everywhere" · 51603c63

authored Jan 08, 2021

This reverts commit 2762641a.

Reason for revert: is_apple is not universally defined. Breaks ANGLE roll into Skia.

Original change's description:
> Use is_apple instead of is_mac and is_ios everywhere
>
> Bug: chromium:1161513
> Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312
> Reviewed-by: James Darpinian <jdarpinian@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=jdarpinian@chromium.org,syoussefi@chromium.org

Bug: chromium:1161513
Change-Id: I831e60149f410044a79d9f66aa9ddd9902410fd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618039Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

51603c63

Tests: Add Saint Seiya Awakening: Knights of the Zodiac trace · 6e909d94

authored Dec 30, 2020

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*saint_seiya_awakening*
Bug: angleproject:4048
Change-Id: Idf187b9c9298d184f1e0dd13f8a9aa0de7c2beb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2612523
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6e909d94

Vulkan: Add a perf test for pre-rotation code injection · 7cdda2dc

authored Jan 07, 2021

A test is added that dispatches a large number of vertex shaders,
generating primitives that are all culled.  The vertex shaders are
simple so that code injected for pre-rotation would make up the majority
of the shader code.

Bug: angleproject:5478
Change-Id: I75092cb25e6427449251985f56e54f89813dec32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615821Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7cdda2dc

Fix translator fuzzer · 2aa4f7e5

authored Jan 08, 2021

Since some ASTs are now disabled on certain conditions, this change lets
the fuzzer know when it has generated invalid translator options.

Bug: chromium:1164448
Change-Id: I1f1b120c33fb70f9776df858db033ec914d7ad89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618203Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2aa4f7e5

08 Jan, 2021 11 commits

Tests: Add World War Doh trace · 767af74e

authored Jan 06, 2021

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*world_war_doh*
Bug: angleproject:4048
Change-Id: I047ed1ccd06cd3707065fe8afed3ad7af5cd7dcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606645
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

767af74e

Add OWNERS info for Vulkan test utils. · 43366979

authored Jan 08, 2021

Bug: chromium:1164084
Change-Id: I83cb75f2a0b4ad3f616d1b64beb34310cc23dd12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618202Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

43366979

Reland "Changes to build inside a Dawn checkout." · f4cd1747

authored Dec 21, 2020

This is a reland of 11c31e0a

I've landed upstream Skia change https://skia-review.googlesource.com/c/skia/+/351496
which should make this safe to reland.

Original change's description:
> Changes to build inside a Dawn checkout.
>
> Add an "angle_standalone" flag that can be disabled by Dawn.
> Put test definitions behind angle_standalone || build_with_chromium.
>
> Bug: angleproject:5462
> Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Stephen White <senorblanco@chromium.org>

Bug: angleproject:5462
Change-Id: I4ff92d45b3692312a004f03b425234b78c5a6219
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2618040
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f4cd1747

Vulkan: Fix up varying component limits. · 038ae144

authored Dec 31, 2020

We weren't subtracting reserved varying vectors from component limits.
We also were using an incorrect value for fragment input components.

Bug: angleproject:5496
Change-Id: I44fc3b2f15687f4dee7a1498d50378e69d74afe3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606536
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

038ae144

Program: Move more common code to ProgramLinkedResources. · e4497d60

authored Dec 31, 2020

Refactoring change only.

Bug: angleproject:5496
Change-Id: Ic1c8301a070e91ad28791c23831b8236058ab9ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606535
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

e4497d60

Vulkan: Add GL_EXT_clip_control entry points · 68f35f24

authored Jan 07, 2021

Addition of the entry points for GL_EXT_clip_control extension.

Bug: angleproject:5471
Change-Id: If17ba0120bdb226cc5728bfea83e9085260eba19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2615862Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

68f35f24

Fix separable Geometry Shaders. · fa449cf3

authored Jan 06, 2021

Was a needed fix for a new varying test.

Bug: angleproject:3571
Bug: angleproject:5496
Change-Id: I49ae69967510b7a6330ea217a0e0e19e3bebe865
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613198Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fa449cf3

Merge Program/ProgramPipeline::getMergedVaryings(). · 3e33db95

authored Dec 30, 2020

This merges two very similar pieces of code into one simpler function.
The function doesn't use any maps or indirection to build the merged
varyings list. It also fixes a potential bug with IO blocks and name
matching due to the code bifurcation.

Bug: angleproject:5496
Change-Id: Ibf54faeeb01d1940570b366ed153fff7c9135c52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606533
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

3e33db95

Roll SwiftShader from 7b2f93895418 to 937395c1ed5d (2 revisions) · d8ca7d62

authored Jan 08, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/7b2f93895418..937395c1ed5d

2021-01-07 caramelli.devel@gmail.com Add Direct-to-Display support using KMS/DRM
2021-01-07 srisser@google.com Add structs for VK_KHR_vulkan_memory_model

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Iaa11e1b25da9d180081b5b4b0b31c5f655aeb263
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617316Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d8ca7d62

Roll vulkan-deps from c493c6112021 to e395b66ed41c (7 revisions) · 7373f631

authored Jan 08, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/c493c6112021..e395b66ed41c

2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 0e5078dc0cfb to ce18d1b8a563 (1 revision)
2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 134a52003407 to 0e5078dc0cfb (1 revision)
2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 234c65c0f32c to 134a52003407 (1 revision)
2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from ad77ed7a8d52 to f3ccb633dfd7 (1 revision)
2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 9f10caf9c4f3 to ebd3ea2ecbac (2 revisions)
2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from cc435b55410a to 9f10caf9c4f3 (2 revisions)
2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from aa005e8bd435 to ad77ed7a8d52 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ic5ca5fd78243ad6d37e1b8e046e92ee74f88490b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2616969Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7373f631

Roll Chromium from 730c6584bcc6 to 1e679b773de8 (438 revisions) · b7d9a02c

authored Jan 08, 2021

https://chromium.googlesource.com/chromium/src.git/+log/730c6584bcc6..1e679b773de8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e4c5e3e1a0..762c7888b9
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/d17dcf3607..ce1689b82d
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/78f99e18e9..cadb7225e4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..e174329bab
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e8d041d679..01d7e1f0a1
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f8570240b7..c000d6e459
* tools/skia_goldctl/linux: C_u9-R-I-yQyomb3Y-XIH8Ad3Ya4ZWi2MpPiFTtfHz4C..SydJmfq0VW7jq5fTDGtIQ-7WoB0vNc-LJAi3Xd4fKvQC
* tools/skia_goldctl/mac: H_4GgcW8CtnxDnWd7RX17C39CAYzfHUaFR6drL3wWAcC..oxKWG6EzN6FHwQ-4J6gUYMHuNuHyARpVl4EvirOsXSgC
* tools/skia_goldctl/win: FzQDQOcAASIc0LaD9YBjqH2JPm0HbYCE2x0WXw2xpz0C..mvme2We4n3wONUhzQu6ATl9Ow4Fb4li6ET-Yhv7Ph3EC
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Icd5f9ab05c0784d31b353554e003290cda9fada0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617241Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b7d9a02c

07 Jan, 2021 13 commits

Vulkan: Add a perf warning when dropping superseded updates · f99ccb08

authored Jan 06, 2021

If an update to an image subresource is entirely superseded by a
following update, the former update is dropped.  This change adds a perf
warning for this.

Bug: angleproject:3461
Change-Id: Iaf4984ba52f3dfc86d5cc87f8be82123badebd04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613203Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

f99ccb08

GLX: Avoid creating child window when X visual ID is specified. · a392a81d

authored Jan 06, 2021

ANGLE's GLX backend creates a child ID because the visual of the X
window must match that of the GLX window, and we can't always be
certain.
EGL_ANGLE_x11_visual allows applications to specify the visual ID
of the window passed to ANGLE via EGL_X11_VISUAL_ID_ANGLE. When this
is the case, we don't need to make a child window.
Since Chrome always passes this information, this may help optimize
ANGLE's GLX usage in Chrome, because we don't have to poll the parent
window to manage the child window's properties.

Bug: chromium:1132827
Change-Id: If8082d2d07469905afffab01dde2ec9fca8d4eb9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611556
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

a392a81d

Capture/Replay: Capture glBindBufferBase during MEC setup · 2d1406a8

authored Dec 29, 2020

"World War Doh" binds uniform buffers via glBindBufferBase() calls
before any frames have rendered and then uses those bound buffers for
all subsequent frames. ANGLE's frame capture was failing to perform
these calls during the mid-execution capture setup phase, leading to
the replay generating VVL errors:
  VUID-vkCmdDispatch-None-02699
  Descriptor in binding #0 index 0 is being used in draw but has never
  been updated via vkUpdateDescriptorSets() or a similar call.

This CL adds those calls to the MEC setup phase, allowing the replay to
execute without any errors.

Bug: angleproject:5495
Test: angle_perftests --gtest_filter="*world_war_doh*"
Change-Id: I751c9c6f60bf78c13428a9d1d6a06dbfe600c24b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606806Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

2d1406a8

Vulkan: Fix image leak in staged updates in ImageHelper · a7158eb5

authored Jan 06, 2021

When removing superseding updates, the superseded update was not
released, causing a memory leak.  This change also makes
SubresourceUpdate non-copyable and correctly implements the move
assignment operator such that swap between different update types are
correct.  As a result, the destructor can now ASSERT that the image is
not leaked.

Bug: chromium:1146516
Bug: chromium:1163354
Change-Id: I7531c91d8559c23b2e09159118fe645d12fc601f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613201Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

a7158eb5

Build compiler_tests only if GLSL or ESSL build is enabled · 157ddfdc

authored Jan 06, 2021

Most of these tests use TranslatorGLSL or TranslatorESSL (often through
ShaderCompileTreeTest). In specialized builds that disable GLSL and
ESSL shader generation, disable these unit tests.

Bug: chromium:1161513
Change-Id: Ib87e651706f141a41ffdaebfb0cbe5168582e341
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613202Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

157ddfdc

Remove the checking before accessing to function pointers · acdb63b8

authored Dec 23, 2020

Bug: angleproject:5490
Bug: chromium:1161513
Change-Id: I96c5c463a9fd5a337d09f6cefe7836ff52bea90f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601071Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

acdb63b8

Roll vulkan-deps from cbab637962d0 to c493c6112021 (10 revisions) · d0a38010

authored Jan 07, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/cbab637962d0..c493c6112021

2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from 7b7a21c4058c to 234c65c0f32c (3 revisions)
2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 480f6039e072 to 3de5cfe50ede (1 revision)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 4cc0932495ec to a7825740f316 (3 revisions)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 4ed1f4fce9e7 to aa005e8bd435 (1 revision)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from af3a3d481f6e to 4ed1f4fce9e7 (1 revision)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 94d1a80159e3 to af3a3d481f6e (1 revision)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 98382948dfea to cc435b55410a (2 revisions)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f77085c307fc to 480f6039e072 (1 revision)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6d05ed8410b4 to 94d1a80159e3 (1 revision)
2021-01-06 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 37c03859de9e to 6d05ed8410b4 (1 revision)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ibff53e4a69b1a9291679f352a5fe6e7e8b70de50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613796Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d0a38010

Roll SwiftShader from b9e179f1f239 to 7b2f93895418 (1 revision) · aa5457dd

authored Jan 07, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/b9e179f1f239..7b2f93895418

2021-01-07 capn@google.com Fix implicit inexact conversion

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I77ee81cc4f9a8828ef46bf77113fcd6da008dd39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613890Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

aa5457dd

Roll Chromium from 38610c881952 to 730c6584bcc6 (444 revisions) · 35b6156b

authored Jan 07, 2021

https://chromium.googlesource.com/chromium/src.git/+log/38610c881952..730c6584bcc6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/65cd1b9efa..e4c5e3e1a0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3c84fe5c3f..d17dcf3607
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ae206b8b8d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/77a111142a..f8570240b7
* tools/skia_goldctl/linux: CQ5a33Wu9Sm6bRTrd26RFsJVr42IoKD4Ediyp7eyuwwC..C_u9-R-I-yQyomb3Y-XIH8Ad3Ya4ZWi2MpPiFTtfHz4C
* tools/skia_goldctl/mac: AXBg8ZzAzlIdv0U_KR8dr92w1szmAp-MB0Z9ZYBmFy4C..H_4GgcW8CtnxDnWd7RX17C39CAYzfHUaFR6drL3wWAcC
* tools/skia_goldctl/win: slJNuZyzBI9lNI9Uje1a2fiVtubv8LEBgUZLFdHZjssC..FzQDQOcAASIc0LaD9YBjqH2JPm0HbYCE2x0WXw2xpz0C
No update to Clang.

Bug: angleproject:2926,angleproject:2939,angleproject:3481,angleproject:3741,angleproject:4286,angleproject:4539,angleproject:4569,angleproject:4846
Tbr: ianelliott@google.com
Change-Id: Id567e30b16d04e96c869ad3058b03829a9035458
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2614267Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

35b6156b

Vulkan: Move xfb emulation offset calculation to translator · e2a8a69a

authored Jan 04, 2021

A new function is added by the translator to calculate the transform
feedback offsets in the emulation path.  This function makes the
generated code for transform feedback smaller.

Bug: angleproject:3606
Change-Id: I01460f907e20e2887cb720bddad96697fdcb0cf3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607492
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e2a8a69a

Vulkan: Fix missing xfb buffer rebind on new command buffer · 07d619cb

authored Jan 06, 2021

When a command buffer is ended, bindings are lost.  This adds a dirty
bit to `mNewGraphicsCommandBufferDirtyBits` to make sure transform
feedback buffers are bound again on the new command buffer.

Bug: angleproject:5428
Change-Id: I7733c93b1eb5d33a77cbee231a83199be950e19f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611552
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

07d619cb

Move RegenerateStructNames AST transformation to gl/ · 5e280545

authored Jan 06, 2021

This AST transformation is used by the chromium validating command
decoder on Linux/AMD/GL as well as MacOS.

Bug: chromium:1161513
Change-Id: I67e40215ae5576819ba5a58987ceb1776c86c731
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613195
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

5e280545

Vulkan: Refactor generated code in xfb emulation path · ca94d1da

authored Jan 04, 2021

The index expression was regenerated for every component written to the
output.  This change refactors the generated code such that common
values are calculated once.

This is in preparation for moving some of this code to the translator
and reducing the amount of code generated at link time.

Bug: angleproject:3606
Change-Id: Ib180d245218f8f6f18c57c0ea092e8c45cbffd1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607490
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ca94d1da

06 Jan, 2021 10 commits

Suppress dEQP.KHR_GLES31/core_vertex_attrib_binding_basicinputcase5 · 46d3f02a

authored Jan 05, 2021

on Vulkan Pixel2 and SwiftShader.

Ignore device and vendor in test config
if we are running on SwiftShader.

Bug: angleproject:5500
Change-Id: Ib07240dfe1c2ae1d6d081ffa389d041d97b22b36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611309Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

46d3f02a

angle_end2end_tests passes on iOS! · ebf00703

authored Dec 29, 2020

Miscellaneous test skips and fixes for iOS.

Bug: angleproject:5417
Bug: angleproject:5491
Change-Id: Id0785e6243949fc756e4d7923dbbe77a411052f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606656Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

ebf00703

Use is_apple instead of is_mac and is_ios everywhere · 2762641a

authored Jan 05, 2021

Bug: chromium:1161513
Change-Id: Id7d582f127f4b79ea6fc5b8ad39fff768c45f477
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2611312Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2762641a

Update auto-roller docs with vulkan-deps repo. · 1d6329b3

authored Jan 06, 2021

Bug: angleproject:5390
Change-Id: If5edba51b0fdbaee36e0ab31a176f809b1ace38a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2613196Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1d6329b3

Tests: Add FIFA Mobile trace · 56479b06

authored Dec 21, 2020

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*fifa_mobile*
Bug: angleproject:4048
Change-Id: I5cc731ada3ddd9adcb247d7c6f8cf5d823bdc2a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600098Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

56479b06

GL: Add function pointers for EXT/NV_framebuffer_blit · 956a358d

authored Dec 23, 2020

Allow the GL backend to call BlitFramebuffer through these
extensions.

Bug: angleproject:5474
Change-Id: Ic19b0535056c3e2b098dedc60e2eb8da5f862433
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602702
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

956a358d

Roll third_party/vulkan-deps/ b08eace32..cbab63796 (17 commits; 1 trivial rolls) · dc2cf6fc

authored Jan 06, 2021

https://chromium.googlesource.com/vulkan-deps/+log/b08eace32e9c..cbab637962d0

$ git log b08eace32..cbab63796 --date=short --no-merges --format='%ad %ae %s'
2021-01-06 chromium-autoroll Roll SPIRV-Tools from d630e5f8c10c to 37c03859de9e (1 revision)
2021-01-06 chromium-autoroll Roll Vulkan-ValidationLayers from 2468aa9630c2 to 98382948dfea (1 revision)
2021-01-06 chromium-autoroll Roll SPIRV-Tools from 1bb80d2778a3 to d630e5f8c10c (1 revision)
2021-01-06 chromium-autoroll Roll glslang from 9325cc013e3d to f77085c307fc (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 57255a663ed9 to 2468aa9630c2 (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-Loader from 1f0c7868a438 to 9ba835885ffe (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from 56a96658b750 to 57255a663ed9 (3 revisions)
2021-01-05 chromium-autoroll Roll Vulkan-Loader from 294480cb7f3e to 1f0c7868a438 (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-Tools from 7554321b88ae to 4cc0932495ec (2 revisions)
2021-01-05 chromium-autoroll Roll Vulkan-Loader from 66a23ac8c566 to 294480cb7f3e (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-Headers from 85470b32ad5d to 9efc4a631161 (1 revision)
2021-01-05 chromium-autoroll Roll Vulkan-ValidationLayers from aa076dae88e2 to 56a96658b750 (25 revisions)
2021-01-05 chromium-autoroll Roll glslang from f426f652299d to 9325cc013e3d (1 revision)
2021-01-05 chromium-autoroll Roll SPIRV-Cross from e50f7d1ce8e1 to 7b7a21c4058c (3 revisions)
2021-01-05 chromium-autoroll Roll SPIRV-Tools from 17ffa89097b2 to 1bb80d2778a3 (1 revision)
2020-12-21 jmadill Rolling 8 dependencies

Created with:
roll-dep third_party/vulkan-deps

Bug: angleproject:5390
Change-Id: I6f4a499099211e8990ed038984f41bc5f881c71f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601340
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dc2cf6fc

Remove "init" from VaryingPacking. · d9669322

authored Dec 30, 2020

Instead we can pass the pack mode and size to the collectAndPack
method. This cleans up the interface and also allows us to merge
two separate code blocks in Program and ProgramPipeline.

Bug: angleproject:5496
Change-Id: I390b5d2e8a3b033374ccc5a250597be1f03dec96
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606531
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

d9669322

Organize VaryingPacking methods. · d33ffb22

authored Dec 30, 2020

This clarifies the difference between "collect" and "pack" methods.
Previously the naming was overlapping between the two. Also makes
the "packUserVaryings" method private.

Refactoring change only. Will enable further improvements for
capturing varyings with multiple shader stages.

Bug: angleproject:5496
Change-Id: I854590ceab39f3a0e7a785516e0d1fd44e4ccc98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606529
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

d33ffb22

Remove ProgramLinkedResources from ProgramExecutable. · 92e7bc89

authored Dec 23, 2020

Instead of storing the entire LinkedResources struct, we can keep it
only for the duration of the linking calls. Refactoring change only.
It sets the stage for more refactoring. This change also switches the
link call to use LinkingState's ProgramLinkedResources directly to
avoid the need to copy the varying packing or use a pointer.

Bug: angleproject:4514
Bug: angleproject:5496
Change-Id: Iefea3c16a33213dc338cc54efaa7c3064ea6ae08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601403Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

92e7bc89