This is a fix for a graphics problem we've been seeing for a while with WebRender+Angle on Nvidia/Windows. The sampler metadata doesn't get updated properly for some of the draw calls, since it's not invalidated on program change (this is what the CL is fixing). Extra entries get filled with garbage data because the constant buffer is updated with `MAP_WRITE_DISCARD`, and only those samplers are updated that the current program has. This may generally occur undetected, if not for our `textureSize` calls that appear to go the NV-specific Angle workaround path that ignores our `baseLevel = 0` and instead picks the one from the driver constants (which contains garbage), leading to either zeroes returned or even crashing the driver sometimes...

BUG=angleproject:2399

Change-Id: Ie2bef32184e2305c7255299933b899eb3fffb7ab
Reviewed-on: https://chromium-review.googlesource.com/949412Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

gen_builtin_symbols.py now generates code for initializing built-in
variable symbols as well. Some of the variable symbols are static, but
some of them also get initialized dynamically based on values in
ShBuiltInResources.

The static symbols have get functions in a header file so they can be
referenced from AST traversers as well without doing a lookup.

BUG=angleproject:2267
TEST=angle_unittests, angle_end2end_tests

Change-Id: Ida7f3aeb06d2bce0f737f1483b1bd5833aeddd2e
Reviewed-on: https://chromium-review.googlesource.com/911768Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This also fixes a missed VkResult error. In order to do this
we also return an error from ProgramImpl::destroy.

Bug: angleproject:2396
Change-Id: I649b19e64732785bb33eebadea7f361245137d0f
Reviewed-on: https://chromium-review.googlesource.com/958406Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We were missing the data definition for the standard validation layer.
This file was missing from the isolate, and the entire layer system
was not working.

Found this as a side-effect of working on depth stencil support.

Also fixes a missing definition in the white_box_tests BUILD.gn.

Also temporarily disables the ClearTest support for Vulkan because of
an implementation bug on AMD. Unfortunately because of the failure
mode it didn't work to just skip the test in the preamble.

Bug: angleproject:2357
Change-Id: I4d06c54191b09e09a4ba68c24613db6f148b17e3
Reviewed-on: https://chromium-review.googlesource.com/956759
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2107

Change-Id: I7a5e4be124ec4381799fea51de3715e09c2f7400
Reviewed-on: https://chromium-review.googlesource.com/957272
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2107

Change-Id: I45b914a6edf721c6ec53ca2bc6e139685b059d20
Reviewed-on: https://chromium-review.googlesource.com/957271
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=chromium:815092

Change-Id: I5eece73be718eaaf2797c361e3d8671404f718d1
Reviewed-on: https://chromium-review.googlesource.com/957469Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Due to wrong driver version on the bots.

BUG=angleproject:2398

Change-Id: Ia6b69a24bfb0ded8848a791db6b540576ef2f57c
Reviewed-on: https://chromium-review.googlesource.com/957207Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This generalizes the overriding mechanism in gen_Vk_format_table.py.
Instead of defining overrides inline, we keep the vk_format_map as a
1:1 mapping from angle format to vk format, and use the overrides map
to specify any additional emulation or features we need to support
OpenGL textures on Vulkan.

This will simplify the implementation for Depth/Stencil formats by
making the generator script a bit easier to work with.

No code changes, generator script refactor only.

Bug: angleproject:2357
Change-Id: I7132d991795eb91d6ad838481c52545c891215bc
Reviewed-on: https://chromium-review.googlesource.com/957433Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

This forces us to free descriptor sets when we're done with them,
but saves us from needing to track when a descriptor set pool is no
longer in use. We may need to revisit this in the future if we want
to support pool allocation for performance.

Bug: angleproject:2396
Change-Id: I3f3184f3dd9e4c2911e1aade4dcb95962a26c3a7
Reviewed-on: https://chromium-review.googlesource.com/956574Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The blend factor were not converted correctly from GL enum types to
their VK equivalents. I found this by running many dEQP tests related
to blending.

Bug:angleproject:2346

Change-Id: I3c332bb5e5c44d2bec4ff9d62e0df2421507e136
Reviewed-on: https://chromium-review.googlesource.com/956241
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This pattern never really took off. It was intended to be used to
unit-test our Validation logic, but it become so complex because
of interactions with Framebuffer::syncState that we could never
really make use of it.

Nuke it entirely and simplify the Context class.

Bug: angleproject:2372
Change-Id: I40b9d46ce7706511a210da496ee19192cf609366
Reviewed-on: https://chromium-review.googlesource.com/954291Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Some backends may change state while initializing resources.  Make sure
that all resources are initialized before synchronizing the backend
state for the given operation.

BUG=angleproject:2107

Change-Id: Ie75ac3eee986e41dfe3dd11a94a706e19df7497e
Reviewed-on: https://chromium-review.googlesource.com/678481
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Also, do not return InvalidOperation from flush in order to be able to support
running dEQP tests  for Vulkan.

Bug:angleproject:2346

Change-Id: I12f3bd115034e044fb0fa2d94687321ede4a1e9d
Reviewed-on: https://chromium-review.googlesource.com/955889
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Detects undefined behavior when a buffer is bound to a transform feedback
binding point and a non transform feedback binding point at the same time.

Also moves the transform feedback buffer generic binding point out of the
transform feedback object and into the context's global state, to match
driver behavior. This way binding a new transform feedback object does not
affect GL_TRANSFORM_FEEDBACK_BUFFER_BINDING which is similar to how VAOs
work with GL_ARRAY_BUFFER_BINDING.

Bug: 696345
Change-Id: If3b9306cde7cd2197a8ce35e10c3af9ee58da0b8
Reviewed-on: https://chromium-review.googlesource.com/853130
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug:angleproject:1683

Change-Id: I8c79cc92406b210c9d143761ffe4ef74e14c6bed
Reviewed-on: https://chromium-review.googlesource.com/956090
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

copyTextureCHROMIUM should generate INVALID_VALUE when using a NPOT
texture and level not equal to zero, so we should add
validation to catch this case.

BUG=angleproject:2380

Change-Id: I7ca2e657287c11d560db0ad296f8e87ed0c19798
Reviewed-on: https://chromium-review.googlesource.com/956018
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This pipes errors up from the Impl to the top level. There are
still a few places were error swallowing is needed, because the
Framebuffer API doesn't support returning an error.

Bug: angleproject:2372
Change-Id: Idc06bda1817fd28075940f69874d8b6ba69194f9
Reviewed-on: https://chromium-review.googlesource.com/954290
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>

The RenderTargetCache avoids many multiple calls to getRenderTarget,
and should speed up the code somewhat on state changes. Also as a
side benefit removes a bunch of swallowed ANGLE errors.

Bug: angleproject:2372
Change-Id: I072481856aae8607f17a116e25c71acf04b4cc68
Reviewed-on: https://chromium-review.googlesource.com/948785Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2356

Change-Id: I33888f9b4ebaf4b0b5af4ad59b12ad963325a790
Reviewed-on: https://chromium-review.googlesource.com/921882
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This plumbs the front-end code, but doesn't implement Error handling
for any objects yet. Framebuffers and VertexArrays will get error
handling from their syncState methods.

Bug: angleproject:2372
Change-Id: I226049e25ac7af2bdd3c4787b67a5d297c0b9c4b
Reviewed-on: https://chromium-review.googlesource.com/954289
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The dEQP tests cannot be turned on before immediate data for drawElements
is supported.

Bug:angleproject:2364

Change-Id: Id5fd6fbc0c74f2dba08341f36ca0091d540f4ed8
Reviewed-on: https://chromium-review.googlesource.com/951402Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Luc Ferron <lucferron@chromium.org>

This regressed in http://crrev.com/c/948782. It may have also
exposed a problem where our bots are not correctly using the
layers.

Bug: angleproject:2361
Change-Id: I764bb821b5bfd2571a4c43f9444dcef67ea65bc4
Reviewed-on: https://chromium-review.googlesource.com/954412Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This class encapsulates the Framebuffer::syncState update pattern that
caches the RenderTargets for the back-end. RenderTargets abstract away
the differences between Textures/Renderbuffers/Surfaces for the
back-end and allows the back-end to treat the various types the same.
This helper class allows sharing code to cache the RenderTargets.

Bug:angleproject:2372
Change-Id: Ib2beb28a616dee1d34c485cd1a19b7202ef70a60
Reviewed-on: https://chromium-review.googlesource.com/948783Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit 2202680c.

Reason for revert: ASAN found error https://ci.chromium.org/buildbot/chromium.gpu.fyi/Mac%20FYI%20GPU%20ASAN%20Release/210

Original change's description:
> Add NPOT validation to copyTextureCHROMIUM
> 
> copyTextureCHROMIUM should generate INVALID_VALUE when using a NPOT
> texture and level not equal to zero, so we should add
> validation to catch this case.
> 
> BUG=angleproject:2380
> 
> Change-Id: I0ea50a981e4d8f10f5913969f6b629617b57aa15
> Reviewed-on: https://chromium-review.googlesource.com/951713
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,brandon1.jones@intel.com

Change-Id: I04dcbd5e1d97b1bd968b26a06e4d3e4d175be0d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2380
Reviewed-on: https://chromium-review.googlesource.com/953343Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:2393

Moving to HEAD of LVL master on afternoon of 3/6/18.
Made some updates to BUILD.gn to add args to spirv tools
external_revision_generator.py script.
Re-enable ANGLE Vulkan build.

Change-Id: I1705d7a2acae578bab9bbd8bb93176107e0e21dc
Reviewed-on: https://chromium-review.googlesource.com/952547Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

See https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#file-headers

Bug: angleproject:1944
Change-Id: Ic2e284ac75ecab19e8d6c5b97e1a9d9376984f3b
Reviewed-on: https://chromium-review.googlesource.com/953133Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

copyTextureCHROMIUM should generate INVALID_VALUE when using a NPOT
texture and level not equal to zero, so we should add
validation to catch this case.

BUG=angleproject:2380

Change-Id: I0ea50a981e4d8f10f5913969f6b629617b57aa15
Reviewed-on: https://chromium-review.googlesource.com/951713
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The RenderPass load/store ops allow us to specify how we want to use
the data from the attachments. Previously we had the load op set to
CLEAR always, which would prevent us from doing multiple kinds of
operation. Using LOAD should conversatively work in any situation
as long as we can ensure each Image is cleared before we use it.

To this effect this patch also inserts a preliminary clear into each
Texture or Renderbuffer Image's initialization. We already had this
for Surfaces.

In the future we'll improve this by inserting proper load/store ops,
but this unblocks a lot more functionality in the interim.

Bug: angleproject:2361
Change-Id: I7610eaa39d81b23dd74b4a24b7f28a66a6dfffc6
Reviewed-on: https://chromium-review.googlesource.com/948782
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:2393

Rolling Vulkan validation code forward to HEAD of master as of 3/6/18
afternoon. Disable Vulkan from the ANGLE build until ANGLE lands in
Chromium. After that second part of roll will be submitted.

Change-Id: I3c98b42a0b8999e8aa26f538959d888060c2026a
Reviewed-on: https://chromium-review.googlesource.com/952525Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This makes them consistent with the other texture types. Also adds a
test for using texture(sampler2DRect, ...).

BUG=chromium:757974
BUG=angleproject:1650

Change-Id: Ie966da928ae0c83850da1e530e72c0d501909394
Reviewed-on: https://chromium-review.googlesource.com/946675
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>

Adding missing "src".

BUG=angleproject:2267
TEST=python scripts/run_code_generation.py

Change-Id: I89d981c8f09e6d0839d0b796a2ea14a8466f98a7
Reviewed-on: https://chromium-review.googlesource.com/952925Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Instead of using an std::map at each symbol table level, use the
gen_builtin_symbols.py script to build a function to query unmangled
names.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I4f1cf1df1f50fe9d909f3249150ee002ee6efb61
Reviewed-on: https://chromium-review.googlesource.com/931885
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Timeout is not enough to suppress
functional.native_color_mapping.native_window.*
since it's retried 3 times and always times out.
Need to skip.

BUG=angleproject:2382

Change-Id: Ib87f25cc6c17be2b5c4c592374b28386685115d2
Reviewed-on: https://chromium-review.googlesource.com/951973Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This completes the work for the simple texture sample.

Bug: angleproject:2167
Change-Id: I47c6794fa7cd59e295a98623d9ce8879ea1d3298
Reviewed-on: https://chromium-review.googlesource.com/952566Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

glDrawElements will now work with indices and/or vertex data in client memory,
as well as in a buffer object.
Enable corresponding tests.

BUG=angleproject:1683

Change-Id: Iefb9796a48b21ed6f9a837b08b0ad3218ff6dd6b
Reviewed-on: https://chromium-review.googlesource.com/915721
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

To support indexed draws it's useful to have a cheap query for the
presence of vertex attribute data in client memory.
This patch adds a bit mask to keep track of such attributes.
It also lets us simplify VertexArrayVk::streamVertexData() slightly.

BUG=angleproject:1683

Change-Id: I871bfb885112650b025e110c383db3c391eafb90
Reviewed-on: https://chromium-review.googlesource.com/947927
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This completes the refactor by using the packed enums in the gl:: layer
and in the backends.

The packed enum code generation is modified to support explicitly
assigning values to the packed enums so that the TextureTarget cube map
faces are in the correct order and easy to iterate over.

BUG=angleproject:2169

Change-Id: I5903235e684ccf382e92a8a1e10c5c85b4b16a04
Reviewed-on: https://chromium-review.googlesource.com/939994
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=803034

Change-Id: I69ca7a86e1841e86c6a8cf6a0b7279a8e42b0012
Reviewed-on: https://chromium-review.googlesource.com/937964
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Use the Observer pattern to get notified when the BufferVk we've copied our data
from is changing. We will only recopy the data if anything has changed, but otherwise
we'll keep drawing with the same index buffer we've created previously.

Bug: angleproject:2335

Change-Id: Ib65677b4d5ec90c46a5e3b975fffd1fddeed59e7
Reviewed-on: https://chromium-review.googlesource.com/948622
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>