Commits · b77a6c25d92c3364dc78a0c7301472f03decac9d · Chen Yisong / angle

16 Jun, 2021 17 commits

Vulkan: Avoid using VK_WHOLE_SIZE when using dynamic offsets · b77a6c25

authored Jun 16, 2021

Binding descriptor sets that use VK_WHOLE_SIZE with a dynamic offset
results in the VUID-vkCmdBindDescriptorSets-pDescriptorSets-01979
validation error.
Updated the updateDefaultUniformsDescriptorSet function to use the
uniform's size instead of using VK_WHOLE_SIZE.

Bug: angleproject:5924
Tests: dEQP-GLES31.functional.shaders.multisample_interpolation.*
       SimpleStateChangeTest.UniformUpdateTest*Vulkan
       UniformTestES3.MatrixUniformUpload*Vulkan
Change-Id: Ie4633af61d59a9401f599d336a5b9040cdf18004
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950309Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

b77a6c25

Roll Chromium from 2d9121fa2280 to b136d87fc6ad (70 revisions) · 33b5ff4c

authored Jun 16, 2021

https://chromium.googlesource.com/chromium/src.git/+log/2d9121fa2280..b136d87fc6ad

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/1c1a1626e9..cbc508d9f5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70bf08ecdb
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e319aba2ba..592d5ec077
* third_party/r8: o1uegxayAMktc600LZ1gX5ZzkC_qhU-frNcWJfmBg98C..gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/4d45e0aeb2..66b4484319
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/b6e0ed244f..71b29b465c
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/1337efa12c..73cc951f87
Clang version changed llvmorg-13-init-12576-g643b6407:llvmorg-13-init-12881-g4017d033
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/4d45e0aeb2eb02a24c60048b11de5d65b87d0c73..66b4484319f05867883d6f59f86fbf5cb07b0099/scripts/update.py

Bug: None
Tbr: ianelliott@google.com
Change-Id: I1dc772e81192999b7c3776d20cf080a3aa722c3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965334
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

33b5ff4c

Be more specific when deleting unused third_party/ dirs · 3707b01f

authored Jun 16, 2021

The command to delete unused third_party/ directories needs to be more
specific to delete unused third_party/vulkan-deps/ directories.

Additionally, use the flag '-path', since that's more portable than
'-wholename' which is GNU-specific.

Bug: b/187342779
Change-Id: Ie8b02360d0d86f9b42141212aaa6c2aa27a063c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965605Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

3707b01f

Vulkan: SPIR-V Gen: Support discard · 99a98963

authored Jun 10, 2021

This is simply done with OpKill.  If-else blocks now check if the block
is already terminated (through return, discard, continue or break)
before adding the branch to merge block.

Bug: angleproject:4889
Change-Id: I713286cf38e40f9048486d2914a4355ddbc686ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953369
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

99a98963

Roll VK-GL-CTS from 7f2ec8531b64 to 7329723d8103 (10 revisions) · 1529a30c

authored Jun 16, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/7f2ec8531b64..7329723d8103

2021-06-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-06-16 antto.makinen@siru.fi Add a GraphicsFuzz test
2021-06-16 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests
2021-06-16 rgarcia@igalia.com Skip unsupported allocations in invariance test
2021-06-15 jbolz@nvidia.com Subgroup and workgroup reconvergence tests.
2021-06-15 alanbaker@google.com Tests for VK_KHR_shader_subgroup_uniform_control_flow
2021-06-15 alexander.galazin@arm.com Update glslang, SPIR-V Tools and headers
2021-06-14 antto.makinen@siru.fi Shared memory layout tests
2021-06-11 siglesias@igalia.com Add VK_FORMAT_B10G11R11_UFLOAT_PACK32 vertex input tests
2021-06-11 rgarcia@igalia.com Test null fragment shading rate attachment pointers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com
Change-Id: I3bc22f404b4822410248fa9c9a63e35d1a8ff900
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2966861
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1529a30c

Roll Chromium from a47f97f33178 to 2d9121fa2280 (292 revisions) · 350ca026

authored Jun 16, 2021

https://chromium.googlesource.com/chromium/src.git/+log/a47f97f33178..2d9121fa2280

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/bc2162111e..94441aacf6
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/6c2969375e..f4328ad7c0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2dac35d518..1c1a1626e9
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/bd17c406ba..8f8817d6f6
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..6434229377
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ecdc362593..e319aba2ba
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/c6949cb1f9..4d45e0aeb2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f463e5ab39..b6e0ed244f
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/f059cd2376..1337efa12c
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: Ibb6ea3b03d3459b67468a21a304a1504508df0e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2964191
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

350ca026

Vulkan: SPIR-V Gen: Fix user-defined blocks · 9c500951

authored Jun 10, 2021

The _u prefix was missing from blocks and their fields.

Bug: angleproject:4889
Change-Id: I31f3b393bc81352c8cf7a433dd652692833fc3f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953368
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

9c500951

Vulkan: SPIR-V Gen: Fix row-major matrices · 5a737833

authored Jun 10, 2021

Prior to this change, row-major and column-major matrices generated
different types.  That is not correct.  With this change, the same type
is generated for both.  Row-major only comes into account when
calculating the alignment and offset of fields in a block.

Bug: angleproject:4889
Change-Id: Ifa03e1799a2510b90323d9d4fc2f681a3184069b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953367
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

5a737833

Roll SwiftShader from 9559e5836cc1 to 72e6254a135d (1 revision) · 74c6c144

authored Jun 16, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/9559e5836cc1..72e6254a135d

2021-06-15 capn@google.com Regres: Fix testing external contributions if reviewed by Googler

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: Idfa3c5889ed8df3f1fb98d54f4839e8f9280f5f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2963848
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

74c6c144

Roll vulkan-deps from f43437ab3f52 to 734228fd0093 (5 revisions) · b27c596b

authored Jun 16, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/f43437ab3f52..734228fd0093

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b848fd6a94..a23e143636
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ecdd9a3e6b..4d22f58a81
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/7501ad708e..f1f5bdbd1b
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/dafb955601..adb3eb0e78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I859d7377d0e5ed650e315b9f9963555ba4d19b94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965287
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b27c596b

Vulkan: SPIR-V Gen: Support short-circuiting && and || · e48f2210

authored Jun 10, 2021

When short-circuiting is necessary (because the right-hand side has side
effects), the following code is generated in SPIR-V:

    // For left && right:
    result = left
    if (left)
        result = right

    // For left || right:
    result = left
    if (!left)
        result = right

Bug: angleproject:4889
Change-Id: Id87b56dc4a1463ed781852a23d2ba6eb2015d700
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953366
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

e48f2210

Fix build · a76f224f

authored Jun 16, 2021

Two CLs went in at the same time, causing a build breakage.

Bug: angleproject:4889
Change-Id: I0dacda7263959014fb4ad9bd83733f58a5e98fe6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965319Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

a76f224f

Roll Chromium from a4467e2bcd67 to a47f97f33178 (736 revisions) · 9b92aa56

authored Jun 16, 2021

https://chromium.googlesource.com/chromium/src.git/+log/a4467e2bcd67..a47f97f33178

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b59724c60a..bc2162111e
* buildtools/linux64: git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c..git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40
* buildtools/mac: git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c..git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e5f25a39b9..6c2969375e
* buildtools/win: git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c..git_revision:72d5a6e15d868abc8451fe0a3b6596e86a2ffc40
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3c85e0a05c..2dac35d518
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/fa47598982..9f92effa4e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1f843f3975
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ef579a1192..ecdc362593
* third_party/ijar: https://chromium.googlesource.com/chromium/src/third_party/ijar/+log/174c500478..cb29a121b4
* third_party/r8: gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC..o1uegxayAMktc600LZ1gX5ZzkC_qhU-frNcWJfmBg98C
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/aee8160f9a..c6949cb1f9
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/4c1cd5039e..f463e5ab39
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/3205ddf75e..f059cd2376
No update to Clang.

Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: If34b372383f4415cfbf635cf05c5cfddb089d4c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965789
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9b92aa56

Translator: Generate Ops for all built-in functions · 8b869a95

authored Jun 13, 2021

EOpCallBuiltInFunction is removed in this change, as well as the
"op": "auto" property in builtin_function_declarations.txt.  Instead,
gen_builtin_symbols.py automatically generates Ops for every built-in
function and generates the TOperator enum accordingly.

This simplifies SPIR-V code generation by allowing switches to be used
on operators instead of string comparisons.

Bug: angleproject:4589
Bug: angleproject:4889
Change-Id: Ia351524400b0e12a10a5572e27e9b88c6ec2e61c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2958869
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

8b869a95

Vulkan: SPIR-V Gen: Unary operators · 64ca25f1

authored Jun 08, 2021

The line raster emulation coded uses round() which was previously not
translated.  This change implements all operations supported by
TIntermUnary nodes.  Bresenham line emulation is now allowed.

Bug: angleproject:4889
Change-Id: I1ffbe3f9bf0299f7efa2c6d1e8f011fefdbb2ddb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2951624
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

64ca25f1

Vulkan: SPIR-V Gen: Handle invariant variables · 0297779c

authored Jun 08, 2021

The Invariant decoration is applied to variable declarations and block
members as necessary.  When invariant is applied to a gl_PerVertex
built-in, it's applied to the appropriate member in
DeclarePerVertexBlocks.

Bug: angleproject:4889
Change-Id: Idaa8d4ab92f975381a0237d372f0a4044ff983e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946116
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

0297779c

Another fix for -Wc++11-narrowing. · f33a41be

authored Jun 15, 2021

Bug: chromium:1216696
Change-Id: I65955fe818917a1909c3d1af391718aaa82652bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965535Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

f33a41be

15 Jun, 2021 9 commits

Translator: Prune trivial dead code · 3f9dcb00

authored Jun 12, 2021

Code after discard, return, break and continue is discarded with this
change.  This simplifies SPIR-V generation as no code is allowed after a
branch instruction and no special handling is necessary after this
change.

Bug: angleproject:4889
Change-Id: Ife9c8de8a6d0db9d682561daf44366aad9b1cf61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2957811Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

3f9dcb00

Set gclient arg to not generate location tags. · 3824f2ad

authored Jun 15, 2021

This updates ANGLE to handle a Chromium //DEPS change
from https://crrev.com/c/2957335; there is a way
to generate component and file location metadata using
`dirmd` in chromium test isolates, but we don't currently
want to use this in ANGLE. This change updates the ANGLE
DEPS file to propagate the right gclient variable into
the gclient_gn_args_file so that the build continues to
work.

Bug: chromium:1218056
Change-Id: I0b27e08d3b7b35a17ba7dca6b6e032175637e8ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2963837Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

3824f2ad

Fix another -Wc++11-narrowing issue. · e62195c9

authored Jun 15, 2021

Bug: chromium:1216696
Change-Id: I18ceae2d6bdd689830fafbfd12b1185c680f2e33
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2965192Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e62195c9

Translator: Pack TSymbol and TFunction fields · a1d43971

authored Jun 12, 2021

Shaves ~45KB off of binary size in an ANGLE build on Linux, coming from
the built-in TVariable and TFunction variables.

Bug: angleproject:4889
Change-Id: I5466c9e26b069a07bf52d00fc2a9c5d49f3c0feb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2958868Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

a1d43971

Vulkan: SPIR-V Gen: Support mediump/lowp · 18ddd131

authored Jun 07, 2021

The mediump and lowp precisions translate to a RelaxedPrecision
decoration in SPIR-V.  This change implements this decoration and
enables SPIR-V generation when emulating Bresenham lines.  Prior to this
change, Bresenham line emulation resulted in a validation error due to
the vertex shader output being without RelaxedPrecision but the fragment
shader input (translated by glslang) with it.

The function that produces a new id is given a list of decorations to
apply, which itself is automatically deriven from the TType where
applicable, to minimize the risk of any id missing this decoration.

Bug: angleproject:4889
Change-Id: I30cc5a278634c5d83d63cd65b057336f9f573baa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2946113
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

18ddd131

Roll vulkan-deps from 0edfab1c0897 to f43437ab3f52 (7 revisions) · 33aa7ef0

authored Jun 15, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/0edfab1c0897..f43437ab3f52

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/fe15158676..b848fd6a94
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/53231a96c0..7501ad708e
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b82d4bc692..dafb955601

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I2101dc30e15183595ad879029509a3173557d1ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2962280
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

33aa7ef0

Vulkan: Generate gl_FragColor/Data declarations in AST · af1eed2e

authored Jun 10, 2021

gl_FragColor and gl_FragData are not available in Vulkan. Prior to this
change, their declaration as webgl_FragColor and webgl_FragData was done
in text. This change implements an AST transformation that declares a
normal fragment output variable and replaces all references to these
built-ins with those variables.

Bug: angleproject:4889
Change-Id: If224e089dec25e4aa580beb135e1be2890de7887
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953042Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

af1eed2e

Vulkan: Fix accessing index buffer with uninitialized memory · 4fbb6f43

authored Jun 14, 2021

This was discovered by Clusterfuzz on MacOS. The issue was
that is index buffer of a draw indexed call was missing,
causing SwiftShader to access uninitialized memory, leading
to the ASAN crash. The missing index buffer was caused by
DIRTY_BIT_INDEX_BUFFER not being set. This was in turn
caused by ContextVk::flushDirtyGraphicsRenderPass() not
setting dirty bits not included in the dirtyBitMask,
despite needing to be set for future processing.

Bug: chromium:1183068
Bug: chromium:1190493
Change-Id: I65b398d8737b3df5fd51a03a2c8074a774a94a81
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2961690Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4fbb6f43

GL: Respect TexSubImage upload limits for robust init · 8333d061

authored Jun 14, 2021

The chunked_texture_upload splits texture uploads for glTexSubImage
calls but ANGLE uses glTexSubImage internally for robust resource
initialization. Also chunk those uploads.

Bug: chromium:1181068
Change-Id: Ia6eaac8117173946630f420b396cbc54c163b7ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2961230Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

8333d061

14 Jun, 2021 5 commits

Remove unused third_party/ deps from Android checkin · c40262dc

authored Jun 10, 2021

Remove unused third_party/ deps from the Android checkins to reduce
the license burden from unused libraries.

Bug: b/187342779
Change-Id: I87358377d0dbbc644cb85555464f4afad9d5c333
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954924Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

c40262dc

Rename ANGLE APK label to: com.android.angle · 7b14e506

authored Jun 10, 2021

Rename the ANGLE APK to com.android.angle, since ANGLE is a headless
APK.

Bug: b/184757175
Change-Id: I8aae318a1882ee1b55e495b053374c9ebdecb94b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2953509Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

7b14e506

CL: Remaining functions for OpenCL 1.2 · 2c8d9a9a

authored Jun 09, 2021

Add support for the remaining functions for OpenCL 1.2 for the
front end and pass-through back end.
Also fix several bugs discovered by the conformance tests.

Bug: angleproject:6015
Change-Id: I1dca1c3f4c1d9aea7f0501094c171116ea01381f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954259Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

2c8d9a9a

Roll vulkan-deps from 7e098c965711 to 0edfab1c0897 (3 revisions) · 88631e50

authored Jun 14, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/7e098c965711..0edfab1c0897

Changed dependencies:
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/07c4a37bcf..9d10a96f2d
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1021540dc2..53231a96c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I654e9265e8050316c8565fe27993e8c5966d6bf9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2959019
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

88631e50

Roll Chromium from 5aaab2e1ec76 to a4467e2bcd67 (434 revisions) · 3aea00c8

authored Jun 14, 2021

https://chromium.googlesource.com/chromium/src.git/+log/5aaab2e1ec76..a4467e2bcd67

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/eb4ebdf32c..b59724c60a
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c1cef4e23c..be7dcbc361
* buildtools/linux64: git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c
* buildtools/mac: git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c
* buildtools/win: git_revision:393dab000d704a4364d085fa4c01ec7af176c8fa..git_revision:e0c476ffc83dc10897cb90b45c03ae2539352c5c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2438adcd35..3c85e0a05c
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2f46970950
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5d455cca7..ef579a1192
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fd14318cc9..aee8160f9a
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/de888be9c5..4c1cd5039e
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/cd44a3b1ea..3205ddf75e
Clang version changed llvmorg-13-init-12491-g055770d5:llvmorg-13-init-12576-g643b6407
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/fd14318cc948b67e5ec8a0f2f7563142ccd6dac2..aee8160f9ac4d833283a35f1088f94c17d523a16/scripts/update.py

Bug: angleproject:4841
Tbr: syoussefi@google.com
Change-Id: If2031c2773a3bc6a0c5d52f0177329397b18191e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2959016
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3aea00c8

11 Jun, 2021 9 commits

Reland: GL: Skip redundant flushes. · 222a81cf

authored Jun 11, 2021

Skip flushes when there is no work submitted since the last
flush.

Bug: chromium:1181068
Change-Id: Iab31f8949f7eb07dffb7b0930069cbb3ca69ef57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2956453Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

222a81cf

Vulkan: Fix AGI clear hierarchy bug for clear commands · ebf75698

authored Jun 10, 2021

This approach properly handles outside-render-pass clears.

Bug: b/190622922
Change-Id: Ia4a9d6ec13d7da8c4a445af1127e82c03f37e8b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2951960Reviewed-by: Mark Lobodzinski <mark@lunarg.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

ebf75698

Roll vulkan-deps from d19e20ee6d7d to 7e098c965711 (1 revision) · bc913c70

authored Jun 11, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/d19e20ee6d7d..7e098c965711

Changed dependencies:
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bbc660edab..ecdd9a3e6b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I6fe973a3d143e05ddfece8d845627ed7c1c4c7bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2954709
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bc913c70

Roll SwiftShader from 81ba5f47b66c to 9559e5836cc1 (1 revision) · a4fa7a66

authored Jun 11, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/81ba5f47b66c..9559e5836cc1

2021-06-10 nicolascapens@google.com Revert "Remove git submodules before rolling into Android"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I0752c72acb33ef73bbd4162dff753f35d23fbd12
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2955222
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a4fa7a66

CL: Add remaining enqueue commands · 55df3ec1

authored Jun 08, 2021

Add support for remaining OpenCL 1.2 enqueue commands to front end
and pass-through back end.

Bug: angleproject:6015
Change-Id: Iab650e42d51e2105dc826088d3606c56d5cd0fd5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2944966Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

55df3ec1

Roll Chromium from 399855f4bba6 to 5aaab2e1ec76 (226 revisions) · 5e5d17cd

authored Jun 11, 2021

https://chromium.googlesource.com/chromium/src.git/+log/399855f4bba6..5aaab2e1ec76

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2192a63c23..eb4ebdf32c
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/9d8449e380..c1cef4e23c
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/2c53623d59..e5f25a39b9
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ab567bcc84..2438adcd35
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2f46970950
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d099d543d..e5d455cca7
* tools/luci-go: git_revision:725192cc79f07ea946e10a64baac06625c206968..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9
* tools/luci-go: git_revision:725192cc79f07ea946e10a64baac06625c206968..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9
* tools/luci-go: git_revision:725192cc79f07ea946e10a64baac06625c206968..git_revision:2adc53281f4a72ecb71e84a8af5acc0fced04cc9
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/12c8fa872b..de888be9c5
* tools/perf: https://chromium.googlesource.com/chromium/src/tools/perf/+log/2e6477d751..cd44a3b1ea
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I692a13429e5eda59471aa2197beb185cdf1f9113
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2955399
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5e5d17cd

Add Android chromium.angle bots to CQ · c7c3cac0

authored Jun 09, 2021

Bug: angleproject:4483
Change-Id: I5a2d76bb9f5183752cbcd6f9381c4aef83edecd7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950267Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

c7c3cac0

Vulkan: Fix AGI hierarchy for query commands · 1fcbf77c

authored Jun 10, 2021

Treat glBeginQuery* and glEndQuery* commands the same as glDraw*
commands, generating a hierarchy.  This results in vkCmdBeginQuery and
vkCmdEndQuery commands being nested under gl*Query*, instead of being
a peer of glDraw* commands.

This change necessitated plumbing some of the existing "end" path to
return angle::Result.

Bug: b/190512191
Change-Id: I898d3fdd9b4b7d86e76dfae2ffc5d6f7316a55ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2950926Reviewed-by: Mark Lobodzinski <mark@lunarg.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

1fcbf77c

Vulkan: SPIR-V Gen: Specialization constants · 29227eef

authored Jun 05, 2021

With specialization constant qualifier and ids set in the node types,
the SPIR-V generation for these variables are trivially handled.

This is in preparation for enabling line raster emulation as well as
fragment shaders in general.

Bug: angleproject:4889
Change-Id: Ie4d4e47b222ac66d1e0eee29f55ac09990313580
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2939337
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

29227eef