Commits · bb35bb4e53795964f32eee820ed823bc11ddbd9b · Chen Yisong / angle

29 Oct, 2019 11 commits

Vulkan: Implement simple case ANGLE_get_image. · bb35bb4e

authored Oct 29, 2019

A couple cases are left unimplemented:

Incomplete/unused Textures. This leads to a slightly more tricky
implementation. Since we need to read back from the staging buffer
we will need to flush the Image contents to a temporary buffer.

Depth/stencil readback. Requires a more complex pixel packing
step.

3D/Cube/2D Array readback. Also requires a more complex packing
step.

Bug: angleproject:3944
Change-Id: Ic5d9a606177ba7e3e5ab945feb5f555afa11741f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879964
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

bb35bb4e

Fix Renderbuffer support for unsized DS formats · ec5c3d5f

authored Oct 28, 2019

This extends a previous fix for TextureAttachment support to also apply
to Renderbuffer. Unsized DS formats should not pick up support from ES3
automatically.
Also unsized DEPTH COMPONENT textures should not be allowed as renderbuffer
without also having support for GL_ANGLE_depth_texture or
GL_OES_depth_texture extensions.

The DS sections of format tables were also refactored so that the columns
align again.

Bug: angleproject:3952
Change-Id: I034b6bc95091f345b7e543d7454e04554ad8eb79
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884421Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

ec5c3d5f

Update docs for recent dEQP / VK-GL-CTS update · f8a8ac0c

authored Oct 29, 2019

Location of dEQP / VK-GL-CTS has moved, update doc/dEQP.md.

Bug: angleproject:3914
Change-Id: I705922b7292ffb60954042edae2514d515e68b44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1887678Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

f8a8ac0c

Print the testConfig in dEQP tests. · 2c703b1a

authored Oct 24, 2019

This will help debug failures on the bots that could be caused by the
wrong test config being used. As a side effect this changes the
condition array of GPUTestConfig to use an angle::BitSetT

BUG=chromium:997351

Change-Id: If742cd3d416694d5df6c3e6c1d722a24f487a960
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879585
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

2c703b1a

Vulkan Android: Remove support for EGLConfig's with GL_RGB10_A2 & GL_RGBA16F · 88a74e59

authored Oct 29, 2019

These were recently reverted from the Android Vulkan loader, and must
also be reverted from ANGLE.  When the Android Vulkan loader adds
back support, it will be conditional based on whether the device
supports those formats.  Therefore, at that time, ANGLE will need to
do the same.

Bug: http://anglebug.com/4019
Bug: http://anglebug.com/4061
Bug: http://anglebug.com/4062
Change-Id: I0b749dc8be0439e6f3b8eeeb51716d4185e9b021
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1887393Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

88a74e59

Roll dEQP to VK-GL-CTS · febdcf51

authored Oct 28, 2019

Switch from Android dEQP to Khronos GL CTS.
We now mirror from the public Khronos Github
github.com/KhronosGroup/VK-GL-CTS
This includes a number of text fixes for GLES 2.0 conformance.

Bug: angleproject:3914
Bug: angleproject:1656
Change-Id: I4cccd33e47752742cb989127c5883c0afd075b9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879579Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

febdcf51

Vulkan: Enable forceOldRewriteStructSamplers for all Android ICDs · 287b0a67

authored Oct 24, 2019

Both Qualcomm and SwS require forceOldRewriteStructSamplers to be
enabled, so this change will enable that feature for all of Android.

We aren't sure yet why this is required for SwS also, but that will be
chased as part of issue 2703.

Bug: angleproject:4045
Change-Id: I83b2ac18e0111ed35438ffd457bfe120911a7767
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879711
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

287b0a67

Roll third_party/spirv-tools/src ec12de913124..42f885238114 (3 commits) · dc883a94

authored Oct 29, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec12de913124..42f885238114


Created with:
  gclient setdep -r third_party/spirv-tools/src@42f885238114

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=ynovikov@google.com
Change-Id: I4d367272caee2c40d00237049e7af1b0b5db7bc2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1885999Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dc883a94

Roll third_party/SwiftShader 1737a30e3e34..f8f6103eb89f (2 commits) · dca568a3

authored Oct 29, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/1737a30e3e34..f8f6103eb89f

git log 1737a30e3e34..f8f6103eb89f --date=short --no-merges --format='%ad %ae %s'
2019-10-28 sugoi@google.com VK_EXT_provoking_vertex support
2019-10-28 jonahr@google.com Fix vulkan builds in ANGLE on MacOS

Created with:
  gclient setdep -r third_party/SwiftShader@f8f6103eb89f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:3677,angleproject:3430
TBR=ynovikov@google.com
Change-Id: Ib298b4e4a21eeadaa876f442fc2c4408b44f3b23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1886000Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dca568a3

Vulkan: Clean up redundant vk:: prefixes. · e7852798

authored Oct 28, 2019

Were in a lot of places in vk_helpers.

Bug: angleproject:3944
Change-Id: I8635400d6debb7ed92e3cf84993773ca9ed74285
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879963
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

e7852798

Vulkan: Move readPixels logic to ImageHelper. · 96ba0f12

authored Oct 28, 2019

This logic will be shared with ANGLE_get_image. Cleans up some of the
graph access logic so it can work easily with TextureVk/RenderbufferVk.

Bug: angleproject:3944
Change-Id: If069528f27b2c291d52de892c707562875b95227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879962
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

96ba0f12

28 Oct, 2019 7 commits

Fix MinGW include: s/VersionHelpers.h/versionhelpers.h/ · 6f23b4b7

authored Sep 03, 2019

Bug: angleproject:4050
Change-Id: I7d6ac948479b499df4fb4f734fc0d9abd40bb455
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880451Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6f23b4b7

Plumb more logic for ANGLE_get_image. · dfc20daf

authored Oct 28, 2019

Also implements and tests validation / negative API.

Bug: angleproject:3944
Change-Id: I3385a4255f4fab6a12eee2abfa5ffcce2107359a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879961
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

dfc20daf

GN: Don't expose glslang when unused. · 2f71802b

authored Oct 28, 2019

The ninja generation step could get confused if we try to build the
glslang wrapper project on platforms that don't support glslang. Turn
it off if the Metal / Vulkan back-ends are not enabled.

Bug: angleproject:4053
Change-Id: If4dd2856681f18f4f45e952bf88e33371b9a1e3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884010Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2f71802b

Don't cc angle-team on Chromium DEPS rolls. · a12b3032

authored Oct 28, 2019

Leave a TODO to use the wrangler email alias when Chrome's rota-ng
tool is updated.

Bug: angleproject:4059
Change-Id: Ide7538b4762ea3ec0f21237e1f2af7dba5023301
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1884012Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a12b3032

Fixups to ANGLE_get_image boilerplate. · 0964988b

authored Oct 26, 2019

- Remove level parameter from GetRenderbufferImage.
- Add packed enum handling to GetTexImage.
- Fix ext spec reference to table 8.4.

Bug: angleproject:3944
Change-Id: I8f67608396217aaddb789dd95d0f3e2378ce918d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879960Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

0964988b

Roll third_party/SwiftShader f44f7c066a67..1737a30e3e34 (1 commits) · 225301d6

authored Oct 28, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/f44f7c066a67..1737a30e3e34

git log f44f7c066a67..1737a30e3e34 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 sugoi@google.com Removed stencil reference from PixelProcessor::States

Created with:
  gclient setdep -r third_party/SwiftShader@1737a30e3e34

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: I74de5492bf7d771d4d70f2ee91e8579b22b4cddd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1883390Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

225301d6

Roll third_party/spirv-tools/src b34fa731931b..ec12de913124 (2 commits) · 076f869c

authored Oct 28, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b34fa731931b..ec12de913124


Created with:
  gclient setdep -r third_party/spirv-tools/src@ec12de913124

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: I26ac305c6099059c7f1d5671fdd2b0aa419e8881
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1883391Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

076f869c

26 Oct, 2019 2 commits

Reland "Add more test_utils functions." · 95a736bd

authored Oct 09, 2019

This is a reland of 5fcfcea4

Re-land uses static linking with angle_util. The root cause
of the CFI error wasn't solved. Static linking works around
the problem by not using any export rules.

Second re-land fixes missing imports for libEGL and libGLESv2
static varieties.

Original change's description:
> Add more test_utils functions.
>
> Includes methods for creating temporary files, deleting files, and
> reading files into a string. Also renames GetPathSeparator to mention
> it's only used for environment variables. Includes a new virtual type
> angle::Process that will be used to implement cross-platform async
> Process launching for tests. Also includes a way to specify a custom
> crash handler callback.
>
> Also adds a few unit tests for the new functionality. They are disabled
> on Android because the functions are not needed by the new test runner.
>
> Bug: angleproject:3162
> Change-Id: I3e2c2e9837608884c98379fa0f78c9ffbe158d73
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1821940
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Bug: chromium:1015810
Bug: angleproject:3162
Change-Id: I2a18b819b0f91df610ad12ffedea2b38349fe7cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879859
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

95a736bd

Roll chromium_revision 60074bf9e0..5fe256ab5e (709436:709762) · e7c8e80d

authored Oct 26, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/60074bf9e0..5fe256ab5e
Full diff: https://chromium.googlesource.com/chromium/src/+/60074bf9e0..5fe256ab5e

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a193dcc697..258e22bc61
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f712af4fd9..85152663b9
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/571788934b..1cfec065ed
* third_party/yasm: https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/cc10bc0f1d..02a8d2167f
DEPS diff: https://chromium.googlesource.com/chromium/src/+/60074bf9e0..5fe256ab5e/DEPS

No update to Clang.

Also includes new DEPS for jsoncpp and yasm.

TBR=jmadill@chromium.org,
BUG=1017514

Change-Id: I0f1998407f74521251d920d269ad2787e79fb57d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1882273Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e7c8e80d

25 Oct, 2019 20 commits

SwiftShader: Update the expectations file according to latest testing · 76763cb9

authored Oct 25, 2019

Some tests fixed.  Others only fail on Android.

Bug: angleproject:4016
Bug: angleproject:4019
Bug: angleproject:4045
Change-Id: If3b915fdd1c54cefa17589f025ea8a93935377c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880165Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

76763cb9

Capture/Replay: Add ANGLE_get_image extension. · 04ee27ef

authored Oct 24, 2019

Will be used for mid-execution capture. Only has a
stubbed-out implementation right now.

Bug: angleproject:3944
Change-Id: I6ddae07907ecbdbd3be9a5d2d3fcafeb425445e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1878888
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

04ee27ef

Roll third_party/SwiftShader 883e817b14bf..f44f7c066a67 (4 commits) · 003629a5

authored Oct 25, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/883e817b14bf..f44f7c066a67

git log 883e817b14bf..f44f7c066a67 --date=short --no-merges --format='%ad %ae %s'
2019-10-25 amaiorano@google.com Fix LLVM7 partially initialized ManagedStatic
2019-10-24 sugoi@google.com Fixed using an offset in Blitter::blitFromBuffer()
2019-10-24 sugoi@google.com Fix stencil+MSAA
2019-10-24 paulthomson@google.com Add LESS_DEBUG_INFO CMake option

Created with:
  gclient setdep -r third_party/SwiftShader@f44f7c066a67

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4037,angleproject:4013,angleproject:4044
TBR=jonahr@google.com,jmadill@google.com
Change-Id: If8150d05ff1e222c24c1f8dc09b99cbb42bffa10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880455
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

003629a5

Capture/Replay: Fix capture build on Android. · 02c89327

authored Oct 25, 2019

A compile error slipped in due to lack of test coverage.

Bug: angleproject:3611
Change-Id: Id34ce239f3913efb0ed1abab77321981419cab44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880160Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

02c89327

Update wrangling docs to link to SwiftShader roller. · adcda20c

authored Oct 25, 2019

Bug: angleproject:1944
Change-Id: I8eabf5e8ec5cd7bfeab4db9b7bd5422f5168744e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880159Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

adcda20c

GN: Explicitly add several Windows libs. · e55374f7

authored Oct 24, 2019

These were not implicitly added in the Skia build.

Bug: angleproject:4046
Change-Id: I0acdb4056e4598ea372b650dbd8044fe680187b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877483Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e55374f7

Fix warnings in xxhash. · 8ab0bf1f

authored Oct 24, 2019

Again these were showing up in Skia.

Bug: angleproject:4046
Change-Id: Ia295ac02b1e1d7bd4186243fc2bf38dffce43c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877482Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8ab0bf1f

Roll third_party/spirv-tools/src feb154921397..b34fa731931b (23 commits) · 4bad5355

authored Oct 25, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/feb154921397..b34fa731931b


Also rolling transitive DEPS:
  third_party/spirv-headers/src 842ec9067462..af64a9e826bf

Created with:
  gclient setdep -r third_party/spirv-tools/src@b34fa731931b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: I19a2870cef1000757fa7767ef45b5fbac8a3a4a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880801Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4bad5355

Capture/Replay: Fix docs link. · 664be3f8

authored Oct 25, 2019

Should be samples/capture_replay not samples/capture_and_replay.

Bug: angleproject:3611
Change-Id: I5de4849c875add39df36f7875482e4dc91ca0ca6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880158Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

664be3f8

Use googletest nested DEPS file. · 07035681

authored Oct 25, 2019

This will fix the issue where gclient didn't support checking
out DEPS-inside-DEPS. We pass a 'googletest_revision' variable
to third_party/googletest via recursedeps.

Bug: chromium:1017514
Change-Id: I4ef3785e385775910f24e13e60e284b8ab2996d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881023Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

07035681

Roll chromium_revision 9325340209..60074bf9e0 (704874:709436) · 7d51cc98

authored Oct 25, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/9325340209..60074bf9e0
Full diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/592281c03c..a193dcc697
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/6752fa027a..f712af4fd9
* third_party/googletest: https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/c721b68dde..60616473f7
* third_party/jsoncpp: https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/48246a0995..571788934b
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9d3bf3e968..bc13578529
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/ddebad26cf..403ca5ad3a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6bc727d9d8..662cbb8d60
DEPS diff: https://chromium.googlesource.com/chromium/src/+/9325340209..60074bf9e0/DEPS

No update to Clang.

TBR=jmadill@chromium.org,
BUG=None

Change-Id: I429a0179f2941ebe04a41a1e25068c2bc41e66c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1881022Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

7d51cc98

Enable "-Wconditional-uninitialized". · 155947fc

authored Oct 24, 2019

This is a final warning used by Skia.

Bug: angleproject:4046
Change-Id: I3970e30e4bd2aef07cddadd7322ef120ac857493
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877481Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

155947fc

Enable "-Winconsistent-missing-destructor-override". · 16370a65

authored Oct 24, 2019

This is purely a code style and consistency warning. Enabled to
support building in Skia.

Bug: angleproject:4046
Change-Id: Ibdcd06ded0195123e52c693851c43d0864e54ad1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877480Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

16370a65

Roll third_party/glslang/src 7662586844f4..b131630e7c74 (1 commits) · ec14fd5a

authored Oct 25, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7662586844f4..b131630e7c74


Created with:
  gclient setdep -r third_party/glslang/src@b131630e7c74

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=jonahr@google.com
Change-Id: Ia4ef9eeef7404245de43d5adf1636e395c4e61f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880657Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ec14fd5a

Enable "-Wundefined-reinterpret-cast". · c017cee9

authored Oct 24, 2019

A couple cases popped up where we were using an undefined cast.
Fix them by rearranging assignment macros to use decltype.

Another warning that is enabled in Skia.

Bug: angleproject:4046
Change-Id: Ibdbae0b2a96909b101a259ff805b8b2d43a5174b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877479
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c017cee9

Fix improper vertex array assignment in ANGLE test. · 77fba58c

authored Oct 24, 2019

Test: StateChangeTestES3.VertexArrayObjectAndDisabledAttributes
Bug: angleproject:4049
Change-Id: Ibda86585e9117686283081a76df213b2b2db0b6e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879582Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

77fba58c

GL: Temporarily disable emulatePrimitiveRestartFixedIndex. · 4db96149

authored Oct 24, 2019

This workaround appears to cause problems on Mac ASAN builds.
Disabling it while investigating the root cause.

BUG=1017337
BUG=angleproject:3997

Change-Id: I16a2f07f8fc69ec4d5ab40a5bf521c43f6854a49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1879873Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

4db96149

Enable "-Wredundant-parens". · 68945f1c

authored Oct 24, 2019

This one is also required by Skia. It's purely for consistency and
code readability.

Bug: angleproject:4046
Change-Id: I9ed418a0bf6c7661f0970fef6da7088ca6ae6204
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877478Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

68945f1c

Enable "-Wmissing-field-initializers". · a6206854

authored Oct 24, 2019

This is another warning required by Skia. This one didn't find
anything that surprising. Enabling the warning does help enforce
code consistency and avoids a bit of possible undefined behaviour.

Bug: angleproject:4046
Change-Id: Ifec7f4afad49cd820bf3c0a79df3f46559473ee2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877477
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a6206854

Enable "-Wshadow-field". · 859ca039

authored Oct 24, 2019

This warning verifies we don't give variables names that shadow
fields. This is another good warning to enable that Skia requires.
This CL also fixes a small number of points in code that used this
bad pattern. We have to disable the warning for Glslang for now.

Bug: angleproject:4046
Change-Id: I072a686e3023b60cfafa778525fe712ce1fb5a50
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1877476Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

859ca039