Commits · bc2dd313cf94ead827ba01d2e47e10e284047408 · Chen Yisong / angle

13 Oct, 2020 4 commits

Roll glslang from 2067d1a93e6e to f4f1d8a352ca (2 revisions) · bc2dd313

authored Oct 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2067d1a93e6e..f4f1d8a352ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: I35866acde56f6fa340cd5bf68612952c4ef2c678
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2466846Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bc2dd313

Roll Chromium from efbcef254191 to a6b7134c40b1 (408 revisions) · 06b956fe

authored Oct 13, 2020

https://chromium.googlesource.com/chromium/src.git/+log/efbcef254191..a6b7134c40b1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8dae5d8e04..28f65f7116
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/b4cc6eb191..225e4dc4d6
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7e5979b1dd..d4827bfe10
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d3154dd7d9..1b83be28f4
No update to Clang.

Bug: angleproject:5161
Tbr: ynovikov@chromium.org
Change-Id: Ie9a048daf8b35cd6af7a33d0c462c9235618619e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2467656Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

06b956fe

Vulkan: Use StoreOp_None_QCOM for read only depth stencil buffer · df6b7298

authored Oct 12, 2020

For read only depth stencil buffers, there is no need to store depth or
stencil value. But we can not use DontCare for storeOp because vulkan
core spec says DontCare indicates data is undefined after this.
VK_QCOM_render_pass_store_ops extension introduces a new store op that
will leave data defined but skip the store. This CL utilize this if the
extension is available.

Bug: angleproject:5055
Change-Id: I104f3d01eb342a2d0cc900f342430e901bde1bff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462604
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

df6b7298

Vulkan: Expand PackedAttachmentOpsDesc from uint16_t to two uint16_ts · 4c6903a4

authored Oct 12, 2020

This is preparation for crrev.com/c/2462604. We run out of bits in the
struct PackedAttachmentOpsDesc. This expands it from 16 bits to 32 bits
(two uint16_t), gives us a lot more room for current and future needs.

Bug: angleproject:5055
Change-Id: I492cbd18c3b71b76b5b48652094409e76c5721b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2465615Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

4c6903a4

12 Oct, 2020 8 commits

Vulkan: TexSubImage3D using PBO should use correct layerCount · 4c6b4794

authored Oct 12, 2020

The layerCount for 3D texture and 2DArray should be 1 if it does not
have layers.

Bug: b/170657065
Change-Id: I974ddda7c0eaa92da8033f15c682820e3d4eb32a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2466616Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

4c6b4794

Test Runner: Pass batch ID to child processes. · 336202d7

authored Oct 09, 2020

This will let both the ANGLETest and dEQP test runners handle child
processes correctly. The existing ANGLETest runner will reuse displays,
and the dEQP test runner will write to a batch-unique filename.

This solves the problem of the multi-process --bot-mode writing to the
same file from multiple children simultaneously.

Long-term it will be good to include the dEQP QPA files into the test
artifacts.

Also disables flushing after every log write when running as a child
process. This hugely improves performance on machines with no SSD.

Test: https://chromium-swarm.appspot.com/task?id=4f2b87c4f8234910
Bug: angleproject:5157
Change-Id: I226d24adf55e0f8b98e5a8e7947862e6906b4c40
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464424Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

336202d7

FrameCapture: Move compressed texture cache to shared location · 3e8305f5

authored Oct 06, 2020

In support of tracking compressed texture data across multiple
threads and contexts, move our cache to FrameCaptureShared.
Make this accessible only via egl::ShareGroup, which will
ensure unique texture IDs.

Test: Asphalt 8 MEC
Bug: b/150484427
Bug: angleproject:4048
Change-Id: I4e75b323d7aedc0333ceffba305439e54c4d6ac1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2455266
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3e8305f5

Reland "Remove redundant BlendStateArray tracking" · 0f55e3e5

authored Sep 11, 2020

Rebase the original CL and update capture/replay state
serialization

Original CL reviewed-on:
https://chromium-review.googlesource.com/c/angle/angle/+/2169093

Bug: angleproject:4394
Bug: chromium:1085996
Bug: chromium:1086582
Bug: chromium:1086585
Bug: chromium:1086586
Change-Id: If0fba8b6e185540aed57d22eaf0ff79ec142209e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404442
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

0f55e3e5

Roll SwiftShader from 51b03d58fb17 to e72c6099f946 (5 revisions) · 30d067cf

authored Oct 12, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/51b03d58fb17..e72c6099f946

2020-10-11 natsu@google.com Revert "Update virlg_hw path to reflect Minigbm"
2020-10-10 swiftshader.regress@gmail.com Regres: Update test lists @ 139f5c35
2020-10-10 natsu@google.com Update virlg_hw path to reflect Minigbm
2020-10-09 capn@google.com Fix depth bias calculations
2020-10-09 capn@google.com Move interpolant clamping out of interpolate()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: I5ea04e45273dfd26395635c66a10095f0cb410dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2465864Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

30d067cf

Roll Vulkan-ValidationLayers from 0046c31f2f96 to 9d4b40ae645e (10 revisions) · 46d4522b

authored Oct 12, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0046c31f2f96..9d4b40ae645e

2020-10-10 locke@lunarg.com tests: UnnormalizedCoordinates Sampler
2020-10-10 locke@lunarg.com layers: Reduce loop
2020-10-10 locke@lunarg.com layers: VUID-02704
2020-10-10 locke@lunarg.com layers: VUID-02703
2020-10-10 locke@lunarg.com layers: VUID-vkCmdDraw-None-02702
2020-10-10 locke@lunarg.com layers: VUID-vkCmdDraw-None-02699
2020-10-09 tony@lunarg.com layers: Use debug printf create infos
2020-10-09 rgarcia@igalia.com layers: Fix depth/stencil resolve false positives
2020-10-09 mark@lunarg.com dispatch: Add secondary commandbuffer tracking
2020-10-09 mark@lunarg.com dispatch: Move CB APIs to manually generated

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: Iffa368652d3e1a4a85c0bfd148267cd54620384b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2465863Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

46d4522b

Roll Chromium from 77bfcdcde874 to efbcef254191 (569 revisions) · dec35c56

authored Oct 12, 2020

https://chromium.googlesource.com/chromium/src.git/+log/77bfcdcde874..efbcef254191

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/f12b0ac8bf..8dae5d8e04
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/26fd14f32d..b4cc6eb191
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/c89bad5e6d..66b870c3b1
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ed409570c0..d3154dd7d9
* tools/skia_goldctl/linux: ehm_yIO4CdwsvaJZJPQ2xBXAFv3KXEgrDpTY3AaK7EYC..sEWxSos77EKQLWziVoCV6Sa52qijVB0fz9uN1EGoUd0C
* tools/skia_goldctl/mac: wIHfWG-DQOw0ISbpkWZrm2f2GoKa3H1Z4I2w8MxhlVIC..rp50J-ChpY5Dyvjwl71mK28FOzgevSspS8YE1qxgkrAC
* tools/skia_goldctl/win: ixP2POw1dVLvzG-YPiGAJdFrTLwpr--nwyQr_S5FoRkC..6eX8c167sU_avc61blSZpNkSEa5HwWNYfWCk-88QTNsC
No update to Clang.

Bug: None
Tbr: ynovikov@chromium.org
Change-Id: I9bd5f5fbdd62000f87fbb0cde9b54f7a8ff8440b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2465384Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dec35c56

Reland: "4 Vulkan content defined CLs." · 68bd685a

authored Oct 10, 2020

Reland "Vulkan: Avoid content restore by detecting no-op stencil"
This relands commit 243d0f89.

Reland "Vulkan: Restore at the end of RP if write-after-invalidate"
This relands commit e5d52ac3.

Reland "Vulkan: Invalidate/restore depth/stencil separately."
This relands commit 61fa0878.

Reland "Vulkan: Move content-defined tracking to ImageHelper"
This relands commit 2392e6b3.

Reason for revert: Caused crashes in Fuchsia x64 and on ARM.
Reland fixes content defined for external images.

Original CL message:

Content-defined tracking was done in render targets prior to this
change.  This had multiple drawbacks:

- When a framebuffer attachment is changed (including the first time
  it's set), it's unknown whether the contents of the attachment is
  defined.
- Invalidate takes effect at the end of render pass, at which point the
  render target objects may be gone.  Attachment ImageHelpers are
  however correctly tracked.

This change moves content-defined tracking to the ImageHelper itself,
and tracks it per subresource.  ImageHelper::onWrite() now receives the
subresource that is being written, and marks it as having defined
content.

A future optimization can make use of this change to
ImageHelper::onWrite to track "dirty" subresources.  This can lead to
the removal of unnecessary barriers when same-kind writes are done on
different subresources of the image.  See http://anglebug.com/3347#c15

Bug: b/167275320
Bug: angleproject:4836
Bug: angleproject:5159
Change-Id: If5c1ae7152657fd7c94db7d55bea4fb9ddf835ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464825Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

68bd685a

10 Oct, 2020 10 commits

Sync extended dirty bit on texture copies. · 3345e5fd

authored Oct 10, 2020

This works around an issue in the GL back-end where the
extended dirty bit wasn't synced in internal blit draw calls.

This bug is preventing progress with the standalone test runner.
This temporarily solution can be put in place until we have
a more complete solution for internal draw state sync.

Bug: angleproject:5160
Change-Id: Id8ae5efa66b249b008a1535b60493c880f5a06a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464824
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3345e5fd

Revert 4 Vulkan content defined CLs. · d6b1c17b

authored Oct 10, 2020

Revert "Vulkan: Avoid content restore by detecting no-op stencil"
This reverts commit 243d0f89.

Revert "Vulkan: Restore at the end of RP if write-after-invalidate"
This reverts commit e5d52ac3.

Revert "Vulkan: Invalidate/restore depth/stencil separately."
This reverts commit 61fa0878.

Revert "Vulkan: Move content-defined tracking to ImageHelper"
This reverts commit 2392e6b3.

Causes crashes in Fuchsia x64 and on ARM.

Original CL message:

Content-defined tracking was done in render targets prior to this
change.  This had multiple drawbacks:

- When a framebuffer attachment is changed (including the first time
  it's set), it's unknown whether the contents of the attachment is
  defined.
- Invalidate takes effect at the end of render pass, at which point the
  render target objects may be gone.  Attachment ImageHelpers are
  however correctly tracked.

This change moves content-defined tracking to the ImageHelper itself,
and tracks it per subresource.  ImageHelper::onWrite() now receives the
subresource that is being written, and marks it as having defined
content.

A future optimization can make use of this change to
ImageHelper::onWrite to track "dirty" subresources.  This can lead to
the removal of unnecessary barriers when same-kind writes are done on
different subresources of the image.  See http://anglebug.com/3347#c15

Bug: b/167275320
Bug: angleproject:4836
Bug: angleproject:5159
Change-Id: I93d9dfe973caa7ce70aefa46b5b7d04a8637efb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464822Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d6b1c17b

Suppress more tests on Intel/GL/Mac. · f3f80036

authored Oct 10, 2020

These tests crash/fail when reusing EGL Displays.

Bug: angleproject:4992
Change-Id: I72dd61543cb055130836428751167e7528cf55af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2464722Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f3f80036

Vulkan: Avoid content restore by detecting no-op stencil · 243d0f89

authored Oct 08, 2020

Previously, as long as stencil was enabled, it was considered that it is
also being modified. This caused stencil invalidate to be undone in a
number of situations, such as:

- glEnable(GL_STENCIL_TEST); // with func/ops default
- glDrawArrays();
- glInvalidateFramebuffer([GL_STENCIL_ATTACHMENT]);
- glClear(GL_DEPTH_BUFFER_BIT);
- Close render pass

In the above scenario, invalidation of stencil was undone at the end of
render pass.

In this change, the following cases are considered read-only stencil:

- Func = GL_NEVER, stencilFail = GL_KEEP
- Func = GL_ALWAYS, stencilPassDepth* = GL_KEEP
- stencilFail = GL_KEEP, stencilPassDepth* = GL_KEEP

Note that while the above scenario is fixed for no-op stencil, a similar
issue persists if stencil was not no-op.  The reason stencil invalidate
is undone in that case is due to the fact that it's assumed any command
after the invalidate call will be a draw call that outputs to stencil,
but that is not the case with the glClear call in this example.

Bug: angleproject:4836
Change-Id: Ie2ea2d52b7c8ee2394f5456773a7ef434e2b2b16
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461465
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

243d0f89

Vulkan: Clear depth by shader if depthClamp not supported · 6c1c3bd9

authored Oct 09, 2020

This will avoid breaking the render pass when clearing depth through
clearWithDraw if the depthClamp Vulkan feature is not present.

Bug: angleproject:4836
Change-Id: I845fd5074dd95f6896da89f9e119ebc5000a5688
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462719
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

6c1c3bd9

Vulkan: Restore at the end of RP if write-after-invalidate · e5d52ac3

authored Oct 08, 2020

If a depth/stencil attachment is invalidated, but subsequently drawn to
in the same render pass, undo the invalidate when the render pass is
closed.  Adapted from
https://chromium-review.googlesource.com/c/angle/angle/+/2386478.

Bug: b/167275320
Bug: angleproject:4836
Change-Id: I17a35bfd692ddc403ceaa6ec44b5c4f16ff9eed6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461464
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

e5d52ac3

Vulkan: Use depthClamp to clear depth where available · f8070feb

authored Oct 09, 2020

This will avoid breaking render pass if clearing depth in clearWithDraw.

Bug: angleproject:4836
Change-Id: I50242d1115efc91059923143f6ae5fd25fb3d36f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462717
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f8070feb

Vulkan: Boilerplace for vkCmdSetScissor · dd4b6445

authored Oct 09, 2020

Bug: angleproject:4836
Change-Id: I4fa5355fc3e7fcf3ecd091d299c5c0c8d3a74732
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463984
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dd4b6445

Vulkan: Invalidate/restore depth/stencil separately. · 61fa0878

authored Oct 08, 2020

Depth/stencil content defined is already tracked separately in the
ImageHelper.  This change exposes this tracking from RenderTargetVk.

Bug: b/167275320
Bug: angleproject:4836
Change-Id: Ie6520e7a4ab557eb233c60c6ab0d4a8f8f098bf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462039
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

61fa0878

Metal: Disable fence sync extension on Nvidia · 87f3f4b5

authored Oct 09, 2020

The following tests are flaky on Mac FYI Retina Release (NVIDIA), so the
Metal fence sync extension is being disabled for Nvidia.

Bug: chromium:1136673
Change-Id: I7e99f558950c6e867318e27f27bb526b4c209fcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463516
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

87f3f4b5

09 Oct, 2020 16 commits

Vulkan: Support invalidate of MSRTT attachments · 5081f89b

authored Oct 02, 2020

Invalidate was previously affecting only the storeOp of the color and
depth/stencil attachments.  With multisampled-render-to-texture
attachments, the storeOp of the resolve attachments were not being
affected.

This change implements the latter, attempting to remove the attachment
altogether if possible.  With MSRTT depth/stencil buffers, this makes
possible the ability to never write depth/stencil data to memory.

Bug: angleproject:4836
Change-Id: I53599e2f4ed6c390dfd03bf226274f6f53f438bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2437506
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5081f89b

Vulkan: Call onColorDraw in resolveColorWithSubpass · a3d5a6e3

authored Oct 07, 2020

We are currently calling onImageRenderPassWrite() on the read render
target within resolveColorWithSubpass(). We need to instead call
onColorDraw() on the draw render target, since that's what's actually
being written.

Bug: b/159903491
Test: CQ
Change-Id: I577381d91228e132950455d2e872fbb9b066d0c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458850Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

a3d5a6e3

trigger.py: Append user tag. · a1477bef

authored Oct 09, 2020

This puts the output of 'whoami' into the user tag. This is useful for
finding your triggered swarming tasks.

Implemented while working on triggering standalone dEQP test runs.

Bug: angleproject:5157
Change-Id: Ic850726485a96408c8f2ded36195268eabb275f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463370Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a1477bef

Add perf-alert monitoring instruction to docs · 75de9ef2

authored Oct 02, 2020

Bug: angleproject:1944
Change-Id: Idee9a3b749b7f618c221f85be54e1331259a8dce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2446852
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

75de9ef2

Vulkan: DepthStencil layout should use both early and late stages · 848ab12d

authored Oct 08, 2020

Vulkan spec 6.1.2 says "Including a particular pipeline stage in the
first synchronization scope of a command implicitly includes logically
earlier pipeline stages in the synchronization scope. Similarly, the
second synchronization scope includes logically later pipeline stages.
However, note that access scopes are not affected in this way - only the
precise stages specified are considered part of each access scope." For
depth stencil layout, both early and late fragment test stages could
access it, thus we should include both in the src and dst stage mask.

Bug: b/169498230
Change-Id: Ifd2f6f7e9947c95248ae400353ae6570912be560
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461631
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

848ab12d

Declare ozone_platform_gbm when angle doesn't have build · 450209c3

authored Oct 09, 2020

Otherwise, it causes build breakages to other projects that depend on
it, such as Skia project.

Bug: angleproject:5146
Change-Id: I09d8e175fa76fb098a0836c2542986609fae7757
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462721Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

450209c3

Remove gaps in Framebuffer::DirtyBits · efc0aaf4

authored Oct 06, 2020

Bug: angleproject:4836
Change-Id: Ia36563eefaa7f6a84ad70db27e0abc5f9fcba703
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2453465Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

efc0aaf4

Vulkan: Move content-defined tracking to ImageHelper · 2392e6b3

authored Oct 07, 2020

Content-defined tracking was done in render targets prior to this
change.  This had multiple drawbacks:

- When a framebuffer attachment is changed (including the first time
  it's set), it's unknown whether the contents of the attachment is
  defined.
- Invalidate takes effect at the end of render pass, at which point the
  render target objects may be gone.  Attachment ImageHelpers are
  however correctly tracked.

This change moves content-defined tracking to the ImageHelper itself,
and tracks it per subresource.  ImageHelper::onWrite() now receives the
subresource that is being written, and marks it as having defined
content.

A future optimization can make use of this change to
ImageHelper::onWrite to track "dirty" subresources.  This can lead to
the removal of unnecessary barriers when same-kind writes are done on
different subresources of the image.  See http://anglebug.com/3347#c15

Bug: b/167275320
Bug: angleproject:4836
Change-Id: Iabd1dace4eae9eb379453a9eb7ec6eafc9db1aef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462036
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

2392e6b3

Suppress Mac/GL test failures with standalone runner. · b2ff69f8

authored Oct 09, 2020

These tests fail when run in certain orders with display reusei
on the bots. See issues for list of suppressed tests.

Bug: angleproject:5154
Bug: angleproject:5153
Change-Id: I1b4a523ba000785f4f8c26eeb236c518481ed7af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462715
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b2ff69f8

fix an instance of bugprone-unused-return-value · c759206c

authored Oct 07, 2020

This new clang-tidy check fires when the result of a function like
`unique_ptr.release()` is unused. Sometimes this is intentional, other
times, it's not (e.g., the dev intended to `.reset()`).

Bug: chromium:1134714
Change-Id: I9b6bc9e847e5c27d68707a4f33d37b225ded34fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2458188
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

c759206c

Roll SPIRV-Tools from fc8264854c53 to c2553a315f5c (5 revisions) · 5291cbad

authored Oct 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc8264854c53..c2553a315f5c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: If001c4eb01adfdc349719f9aab8bb77722a1d123
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463245Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5291cbad

Roll SwiftShader from 952149303d06 to 51b03d58fb17 (2 revisions) · 1cf632e0

authored Oct 09, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/952149303d06..51b03d58fb17

2020-10-09 bclayton@google.com SpirvShaderDebugger: Fix store() of arrays
2020-10-09 bclayton@google.com SpirvShaderDebugger: Improve ASSERT() messages

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I58214fff9f6b91f592033e07e50aa40a6afe9a83
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463244Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1cf632e0

Roll Vulkan-ValidationLayers from 24184fe81c6f to 0046c31f2f96 (2 revisions) · 500eeff4

authored Oct 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/24184fe81c6f..0046c31f2f96

2020-10-08 nathaniel@lunarg.com layers: Fix ImageView format compatibility error
2020-10-07 shannon@lunarg.com build: Update known-good files for 1.2.156 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ieec1da74d36bd07a4c1eaa114e44986a5e4de10b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463243Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

500eeff4

Roll Vulkan-Loader from dc8a96d60b6b to 14ad927e679a (2 revisions) · f30ae360

authored Oct 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/dc8a96d60b6b..14ad927e679a

2020-10-08 dorian.apanel@gmail.com Handling also zero size override paths.
2020-10-08 dorian.apanel@gmail.com loader: Override layer load when custom allocator used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ib7634589744013e845ae600dffa3fe6f853a3f32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2463242Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f30ae360

Roll Chromium from 090102a7065c to 77bfcdcde874 (466 revisions) · fc8f5e0a

authored Oct 09, 2020

https://chromium.googlesource.com/chromium/src.git/+log/090102a7065c..77bfcdcde874

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d058068a4b..f12b0ac8bf
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/17295a5c35..26fd14f32d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7054864146..ed409570c0
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: Ib54c76f7997a6cac606d68532fd67cd98ad7a59c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462165Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fc8f5e0a

Suppress gl_test failures on Mac ARM64 (Apple DTK) · e0780931

authored Oct 08, 2020

BuiltinVariableFragDepthClampingFloatRBOTest.Below1/ES3_OpenGL
CopyTexImageTest.DeleteAfterCopyingToTextures/ES2_OpenGL
GLSLTest.MaxVaryingVec2Arrays/ES2_Metal
GLSLTest.MaxVaryingVec3ArrayAndOneFloatArray/ES2_Metal
GLSLTest.MoreNestedCompoundStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedCompoundStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedStructsWithSamplersAsFunctionArg/ES2_OpenGL
GLSLTest.NestedStructsWithSamplersAsFunctionArg/ES3_OpenGL
MipmapTestES3.BaseLevelTextureBug/ES3_OpenGL
MipmapTestES3.GenerateMipmapBaseLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapCubeBaseLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapMaxLevel/ES3_OpenGL
MipmapTestES3.GenerateMipmapPreservesOutOfRangeMips/ES3_OpenGL
OcclusionQueriesTest.MultiQueries/ES2_Metal
Texture2DBaseMaxTestES3.GenerateMipmapAfterRedefineAndRebase/ES3_OpenGL
Texture2DFloatTestES2.TextureFloatLinearLegacyTest/ES2_Metal
Texture2DFloatTestES2.TextureFloatLinearLegacyTest/ES2_OpenGL
Texture2DFloatTestES2.TextureFloatLinearTest/ES2_Metal
Texture2DFloatTestES2.TextureFloatLinearTest/ES2_OpenGL
Texture2DFloatTestES3.TextureFloatLinearLegacyTest/ES3_OpenGL
Texture2DFloatTestES3.TextureFloatLinearTest/ES3_OpenGL
TimerQueriesTest.TimeElapsed/ES3_OpenGL
TimerQueriesTest.TimeElapsedMulticontextTest/ES3_OpenGL
WebGLCompatibilityTest.TextureCopyingFeedbackLoops/ES2_OpenGL
WebGLCompatibilityTest.TextureCopyingFeedbackLoops/ES3_OpenGL

Bug: chromium:1132295
Change-Id: If64dc67275063c8046dbc941d92de273fbc226e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461674
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e0780931

08 Oct, 2020 2 commits

GL: Work around Mac glBindBufferRange issue. · cd8eb564

authored Oct 08, 2020

Mac GL drivers generat errors when binding transform feedback buffers
with glBindBufferBase/glBindBufferRange when the buffer has not been
bound to any binding point before. Work around this by simply binding
the buffer first.

Bug: angleproject:5140
Change-Id: I1895f8367412135c100a5072117c929be8a8e90b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461826
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cd8eb564

Target the "absl" component for component builds. · 36f0464a

authored Oct 08, 2020

When performing a component build, we need to make sure our targets are
accessing abseil from the component when is_component_build=true.

Bug: chromium:1134776
Change-Id: Iaf5ee7176b4b8d84b3bafeaa259e476062a1e1dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2461454Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

36f0464a