Commits · bcae4fe18271c1b7a85ec4cc2155546485eccf31 · Chen Yisong / angle

03 May, 2021 5 commits

Roll vulkan-deps from c5559fe406e3 to 4676514cf188 (3 revisions) · bcae4fe1

authored May 03, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/c5559fe406e3..4676514cf188

Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/7ab4afe505..884579ec29

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com,syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com,syoussefi@google.com
Change-Id: If43cecb9faae73c1ce83a9b5b4205fda03efd1bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867786
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

bcae4fe1

[infra] use realms on 5% of Angle builds. · 03a9bf1e

authored May 03, 2021

All swarming tasks triggered from realm-enabled build will be
realm-enabled, too.

This CL is safe to revert in case of problems.
The problems, if any, should not affect CQ badly due to retries,
but on CI they'd probably manifest as purple builds that won't be
retried without human involvement or new Git commit.

Change-Id: I106a587749103bde8d77a1c61438ad0fcb54a7b3
Bug: chromium:1204972
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867083
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

03a9bf1e

infra: init LUCI Realms config for Angle. · 32ed5069

authored May 03, 2021

This doesn't yet have any effect on Angle builds/tasks,
but allows to associate Angle pools with the Realms config in
https://crrev.com/i/3802849

Change-Id: Id756c14e7e181cc1820cee735668949bf9567d0c
Bug: chromium:1204972
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867082
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

32ed5069

infra: validate configs using lucicfg tool in PRESUBMIT.py · de3753d4

authored May 03, 2021

This validates that:
a) checked in generated files correspond to what lucicfg
   actually generates;
b) lucicfg is formatted
c) (same as before) configs are validated against respective
   LUCI services.

Change-Id: I727723beb4172c3dd265c4a4edbc2ecbfb479eb9
Bug: chromium:1204972
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867081
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

de3753d4

infra: remove redundant ACL. · 471e62c8

authored May 03, 2021

Bug: chromium:1204972
Change-Id: If3ab89699adfc47d0a163f8b999da17b10d86ebd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2867079
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

471e62c8

30 Apr, 2021 8 commits

infra: Always checkout swarming_client in standalone. · 4ab224f7

authored Apr 30, 2021

This repo is needed to trigger and wait for swarming tests.

Bug: angleproject:5114
Change-Id: I02b5da49cb0f12e1189ddf56c8f1b7348bb9bd45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862927Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4ab224f7

Roll vulkan-deps from 42d8716d0294 to c5559fe406e3 (24 revisions) · 23ff18f9

authored Apr 30, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/42d8716d0294..c5559fe406e3

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/18eef33bd7..56b17b2f2d
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/c624d5387c..72a2ec4c1b
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/22b82872b4..8ec9f456e6
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/074fa3055c..3f437c4a94
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/d0f1abe22e..5dcea8a449
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/eb3d67bd17..4ee5f2a8be
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f6b4a3dea4..7ab4afe505

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC jonahr@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:5905
Tbr: jonahr@google.com,ynovikov@google.com
Change-Id: I462413910900b8dc38b3e88b78d9ff2e10b103b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2863562Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

23ff18f9

Vulkan: Disable logMemoryReportStats if driver extension not exist · a4588e33

authored Apr 29, 2021

logMemoryReportCallbacks and logMemoryReportCallbacks features are
useful for memory debugging. But they rely on
VK_EXT_device_memory_report extension. Right now if this extension is
not there and you enable the log, you still see the logs but everything
is all zero. This CL will disable the feature and print out warning
message if the extension is not supported.

Bug: None
Change-Id: I478ae0ac7ba1ee43245a9fd8a3f1d9907f5d833c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2861310
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

a4588e33

Add tools/perf essential Python files. · e210287b

authored Apr 30, 2021

While waiting for the full mirror we can simply duplicate the
minimal necessary files for angle_perftests to run.

Test: mb.py zip
Bug: angleproject:5114
Change-Id: I1847909cb78b32efed26a284fdfcd40ed31d7b4b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862922Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e210287b

formatutils: Add 8 unused bits to 24 bit depth formats. · a7d53cb1

authored Mar 30, 2021

Add 8 unused bits to unsized GL_DEPTH_COMPONENT and sized
GL_DEPTH_COMPONENT24.

This results in the corresponding gl::InternalFormat exposing 4 bytes
per pixel and fixes a crash when serializing frame buffer depth
attachements in FrameCapture for GLES1 on Vulkan.

This patch fixes all comparisions crashing in the capture/replay GLES1
tests on SwiftShader.

Bug: angleproject:5799
Change-Id: I39c4309d5c7a1740dfd21c53f116b7e175b64847
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2794381Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

a7d53cb1

Angle: drop ANGLE_serialized_context_string from requestable · 19b7815d

authored Apr 27, 2021

This extension is always needed for replay, and it should always
be enabled. By adding the extension using esOnlyExtension it is
no longer marked as requestable and WebGL compatibility will no
longer disable the extension.

Bug: angleproject:5851
Change-Id: I11c8f684b3bfe76c219a9210df0a2c5cccb706f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853583
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

19b7815d

Roll Chromium from 5feb27ec9892 to ae499a6ea7cf (462 revisions) · 06567870

authored Apr 30, 2021

https://chromium.googlesource.com/chromium/src.git/+log/5feb27ec9892..ae499a6ea7cf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/32281a3e42..f105bbfeaa
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/5dbd89c9d9..5da6005cc9
* buildtools/linux64: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e
* buildtools/mac: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e
* buildtools/win: git_revision:dba01723a441c358d843a575cb7720d54ddcdf92..git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a660a95e6f..791177086b
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/09a1a83d2f..adc89c7364
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/db2bba848d..a81066b46b
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ed0183e21a
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3a56ba9d9c..0d1afc9729
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/09490503d0..e8da4daa81
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/7247aa6f40..4dbf0676ae
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I444c9cbda115fee32715c430af6a0338832109c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862550
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

06567870

Add instruction on how to debug angle on android · 257b29ef

authored Apr 29, 2021

This explains how I am using lldbclient.py to debug angle on android.

Bug: None
Change-Id: I9c0a55ab3e2272fbd74905a7ac390d987c78d550
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860396Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

257b29ef

29 Apr, 2021 10 commits

Vulkan: Cleanup garbage when destroying EGL images · 54e99d36

authored Apr 23, 2021

SurfaceFlinger will optimistically create EGL images just in case it
does need them in the future, since creating them can be slow and
waiting until they're necessary can cause jank on 90hz+ devices.
However, since the images are never actually used, ANGLE's garbage is
never cleaned up so vkDestroyImage() and the memory is never freed. This
can lead to exhausting the device's memory when many EGL images are
allocated. For example, when running the CTS test
CtsBiometricsTestCases.

This CL adds a call to always cleanup the renderer's garbage when an EGL
image is destroyed via eglDestroyImageKHR(), since we can't know if a
draw will ever be performed in the future (which would normally cleanup
the garbage).

Bug: b/184388756
Test: atest CtsBiometricsTestCases
Change-Id: I104c05c7be44f1e57123ac7eed23effaa982837a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848131Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jason Macnak <natsu@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

54e99d36

GL: Flush after framebuffer change on Mac 9th gen Intel GPUs · ce89d99f

authored Apr 29, 2021

Speculative fix for crashes during flush on Mac. Mirrors the
flush_on_framebuffer_change workaround in Chrome from
http://crbug.com/783979

Bug: chromium:1181068
Change-Id: Ic84b1bfc44babf27016b306393da308d504d7fd9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859984Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

ce89d99f

Suppress VUID-VkImageViewCreateInfo-pNext-01585 temporarily · 9c66461c

authored Apr 29, 2021

Vulkan validation failures are happening on ComputeShaderTest on
Linux and Windows with AMD. Suppress for now while the issue is
investigated

Bug: angleproject:5912
Change-Id: If89f7c85bb311a68d6cab85e397112b4178e34d7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2860044Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9c66461c

Disable OpenCL support for Windows UWP CI builds · df657c96

authored Apr 29, 2021

Bug: angleproject:5908
Change-Id: I451e232e545248ff9755cc3f2a4907b8af2fdc2c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859742Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

df657c96

infra: Add isolate server properties. · a29ab50f

authored Apr 29, 2021

These are necessary to work correctly with swarming.

Bug: angleproject:5114
Change-Id: I634e408e523284a935b77f62b95c9bc85e9e997f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859982
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

a29ab50f

infra: Update mixins. · a8d98f7a

authored Apr 29, 2021

The Mac mixins were updated. Ideally we could do this automatically on
Chromium rolls.

Bug: angleproject:5114
Change-Id: I412e227193e7a6503c04dee5df6bb2a4cf1cc1f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2857597Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a8d98f7a

tests: Move DrawAfterFlushWithNoStateChange to ES3 · 422ec18a

authored Apr 26, 2021

The test uses Vertex Array Objects, and these are only
supported from GLES 3.0 on, or by using the extension
OES_vertex_array_object, so make it part of the
StateChangeTestES3 set.

With that we also enable the test.

Bug: angleproject:5855
Change-Id: I0cfb5d23d19e3db8eefffd9d52b744d068666606
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850642
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

422ec18a

Capture/Replay: Print capture and replay exe in verbose mode · 078a2ba6

authored Apr 19, 2021

When running the test script to capture and replay it is helpful to
know the locations of the executables that are run to make it simpler
to locate them for debugging.

Bug: None
Change-Id: Ia43bd9863e94058515d9023981863ad6c711285e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850640
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

078a2ba6

Roll SwiftShader from 112faf441539 to 484a3e15893c (1 revision) · 1da30524

authored Apr 29, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/112faf441539..484a3e15893c

2021-04-28 sugoi@google.com Silence warning for MacOS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: jonahr@google.com
Change-Id: Ic9f3324373ebb26930fce0a70eab176aae09adbb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859305
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1da30524

Roll Chromium from 06f7f05a5f4a to 5feb27ec9892 (428 revisions) · 201f161b

authored Apr 29, 2021

https://chromium.googlesource.com/chromium/src.git/+log/06f7f05a5f4a..5feb27ec9892

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/94367a1d14..32281a3e42
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f6a8e55d6e..5f51521620
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5f9242e282..a660a95e6f
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a26b882fc4..09a1a83d2f
* third_party/android_build_tools: https://chromium.googlesource.com/chromium/src/third_party/android_build_tools/+log/a27b4d3b82..c3565d6e1f
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/d738a9c39a..db2bba848d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..70ce64f463
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3c9edb4af..3a56ba9d9c
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7b4981b650..24e310554f
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/91e097a7c7..7247aa6f40
* tools/skia_goldctl/linux: E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC..tB-aCGPgfoZoJkUY-FwC5e0McBlS1VYtKsDpf5G42GUC
* tools/skia_goldctl/mac: RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC..010YBDimThQHTBULjf4bYMXghL37h6xogw08_Ij5RrMC
* tools/skia_goldctl/win: XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC..PtSSNrSR0okAf8Q4RMYxK1dSmKxaw9jqoyxdNvNzOqwC
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: Ic6f6d13e33d9d70ba856b8444a3107a1d00ebdfb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2858285
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

201f161b

28 Apr, 2021 9 commits

Vulkan: minimize-gpu-work: Use 1x1 offscreen · a766ab14

authored Apr 20, 2021

When minimize-gpu-work is requested, the idea is to have GPU work
reduced to minimum. Without shrink the offscreen window to 1x1, the
driver load/store op may still have to load entire surface which could
be costly. This CL reduces the offscreen surface size to 1x1 when
--minimize-gpu-work is specified.

Bug: b/184766477
Change-Id: Ic8d9d4c2fe8295a0a5808dcee35120fdd20e0f56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840963
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a766ab14

authored Mar 24, 2021

Includes some stats counter gathering and a few related refactors and
cleanups. Also includes a new overlay widget.

Bug: angleproject:5736
Change-Id: Ida8d2cd815c5b598c6a442dd9bbfdf51e9c05180
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785431
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

ccc0fbaa

Remove -raw-cmd from scripts/trigger.py swarming call · d7859d98

authored Apr 28, 2021

It looks like this argument doesn't exist anymore. Removing it from
the swarming call works fine.

Bug: angleproject:5915
Change-Id: I510ef79ae5a540742c3f08c8daa0a14d59d2e60d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855040Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

d7859d98

Metal: Add ASTC HDR support · 53b89b83

authored Apr 24, 2021

ASTC HDR is a superset of ASTC LDR, so always use HDR enums
on supported platforms because there is no such difference in OpenGL ES.

Bug: angleproject:2634, angleproject:5672
Change-Id: I19a3212bcb949aa9cdeb682ab000aa03125f04a9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848509Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Le Hoang Quyen <le.hoang.q@gmail.com>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>

53b89b83

Change perf_test_runner to accept extra args. · 3b2ef1cd

authored Apr 07, 2021

Bug: angleproject:5736
Change-Id: Ic6046c0b8c5ba9bc2f3bffda2c36eaceb24491ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855601Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

3b2ef1cd

Vulkan: Turn on cubemap arrays for Qualcomm · 61288549

authored Apr 27, 2021

The feature works on Pixel 3 and later, so only disable it on Pixel 2.

Bug: angleproject:5143
Change-Id: I824fc9ea71cb612fd99e23b7f37a1a3c278d92aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855218Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

61288549

Vulkan: minimize-gpu-work: Skip synchronization for glMapBufferRange · 939dc8d9

authored Apr 21, 2021

glMapBufferRange call requires CPU and GPU synchronization. Different
drivers implement this differently. Some may choose to keep multiple
copies of data to reduce the synchronization overhead while others may
choose to wait for GPU access to finish to save memory. While this
behavior is important, it should be looked under the scope of overall
game performance and we can write a standalone test for this. When
--minimize-gpu-work is specified, we mainly care about CPU overhead of
driver logic of state tracking. For this purpose, we should get this out
of picture in order to expose the true picture of what we intended to
see. This CL always adds GL_MAP_UNSYNCHRONIZED_BIT to the access bit to
avoid driver to do synchronization or make COW.

Bug: b/184766477
Change-Id: I36228a4ed9913e26aa9ad4e8446fb42ee0182c18
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847101Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

939dc8d9

Reland "Capture/Replay: Reset GL Fence Sync objects" · 7444466c

authored Apr 19, 2021

This is a reland of 9b4fd545

This fixes the original CL by moving where setCaptureActive() is called
to allow the first replay source file to be written.

Original change's description:
> Capture/Replay: Reset GL Fence Sync objects
>
> Asphalt 9 uses GL Fence Sync objects during rendering, which results in
> Fence Sync objects being created during setup and deleted while
> replaying frames. When the replay is restarted, the Fence Sync objects
> that were created during setup and deleted during the replay need to be
> recreated during the reset phase.
>
> Bug: angleproject:5883
> Bug: angleproject:4599
> Change-Id: I118f2b7208c4d512ab646b10f52b3a0936895089
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838237
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Cody Northrop <cnorthrop@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5883
Bug: angleproject:4599
Bug: angleproject:5900
Change-Id: I5e1d901d8875007691699b7b973f3fb7db027337
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2850758Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

7444466c

Roll Chromium from 398f0c392ac5 to 06f7f05a5f4a (465 revisions) · dcfd5526

authored Apr 28, 2021

https://chromium.googlesource.com/chromium/src.git/+log/398f0c392ac5..06f7f05a5f4a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/6273d81b0c..94367a1d14
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f71816594a..5f9242e282
* third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/79b2765902..d738a9c39a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c5554ea0ab
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c91f5f62e2..b3c9edb4af
* tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155
* tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155
* tools/luci-go: git_revision:173195137e006c3bbbd2394409e3d752f8b3c62f..git_revision:7c21dae4ffe132b3bf611dce050d268f1ef4c155
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/3e7b3b8ccc..91e097a7c7
* tools/skia_goldctl/linux: bNvl5eveNZJzFEWnXEt_ohXLbBA8BSt78S5aHS7rNYMC..E6CrCAKZ_DKxclAqgBcEt4adU3HaviUwN42S1t3rW5QC
* tools/skia_goldctl/mac: jWn1_ogilSNdcmHMkXsZTdw5bQ-IDoQ3IifWt1TDv6sC..RTGs3s-N45d3AzDXnEKw3kbI0qf8xyS_JYMHo4iRCMIC
* tools/skia_goldctl/win: dP2sgrA7eRtFoLWGRjvQQ4YXhGlwKqsCiqPqPQuY1OgC..XXJR8g1yaihqXsw7WodVpgLtZsimS7Cc3yLJI9sJssgC
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I315893b34682bf861573d2d3e6378004b29342af
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2856314
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dcfd5526

27 Apr, 2021 8 commits

Revert "infra: Add different builder group from ci/try." · ed8755df

authored Apr 27, 2021

This reverts commit 281b12d2.

Reason for revert: Broke bots.

Original change's description:
> infra: Add different builder group from ci/try.
>
> Uses the 'client.angle' and 'tryserver.angle' naming scheme that
> both V8 and WebRTC use. Necessary for the scripts to work with
> swarming tests.
>
> Bug: angleproject:5114
> Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5114
Change-Id: I2501f3ad89bc21d80ccdeabd52234a1fc5b39a49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2855594Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

ed8755df

infra: Add different builder group from ci/try. · 281b12d2

authored Apr 27, 2021

Uses the 'client.angle' and 'tryserver.angle' naming scheme that
both V8 and WebRTC use. Necessary for the scripts to work with
swarming tests.

Bug: angleproject:5114
Change-Id: I107cf0018e2173117e1d90e840b8e1419e69ef55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854277Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

281b12d2

Fix using VK_EXT_provoking_vertex with VVL · c02d5f12

authored Apr 27, 2021

Vulkan Validation Layers (VVL) automatically rejects and
removes any unknown pNext pointer in an pNext chain
submitted to the driver. For this purpose, a mechanism was
introduced by VVL in order to allow ANGLE to allow some of
our custom pNext entries to go through VVL without being
removed. This had been used for only 1 of the 3 entries in
the VK_EXT_provoking_vertex extension, causing it to be
properly exposed, but impossible to use. This CL corrects
this by adding the missing entries.

Bug: angleproject:5902
Change-Id: If6478b3aa776513b92420736fa1216b014320b02
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854815Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

c02d5f12

infra: Switch Android builders to compile-only. · 6505a768

authored Apr 27, 2021

Initially testing will only be on desktop.

Bug: angleproject:5114
Change-Id: I384e4f81cee3a810fad42e73711862725e786ef2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2854276Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6505a768

Vulkan: minimize-gpu-work: Skip data copy when possible · 7b77dc5b

authored Apr 22, 2021

When --minimize-gpu-work is specified while replaying app traces, the
goal is to avoid any GPU work when possible and focus on driver cpu
logic overhead. Data copy can be lengthy and each driver optimize it
differently for some real world usage scenario. This should be looked
along with normal app trace playback performance. When
--minimize-gpu-work is specified, we want to leave this out of picture.
Previously I have fixed TexImage2D by overwriting pixel pointer with
null.  But there is a hole here when PBO is used. This CL fix the case
that when data is sourced from PBO, we ensure to skip data copy as well.

This CL also noops TexSubImage call instead of doing 1x1 copy. Again
depends on driver implementation, some may use CPU others use GPU which
will have different overhead. We can easily write a test to cover these
performance optimizations. By skipping the subImage call here we will
have less noise to deal with for CPU overhead investigation.

Bug: b/184766477
Change-Id: I84a5d26d2f25f8f0a6c5c9da72737906d6356a53
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2847100
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7b77dc5b

Add stubs for CL platform layer back ends · 16a919b1

authored Apr 27, 2021

Bug: angleproject:5904
Change-Id: If23c7f76013a17c3c67c13194566438035beb3d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2853582
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

16a919b1

Vulkan: Redesign buffer descriptor set cache key. · be7049d7

authored Apr 20, 2021

Instead of writing the bitset masks, iterate up until the last active
buffer. Write zeros instead of skipping spaces. This is a bit simpler
to implement and also fixes a bug where empty buffers could cause us
to write invalid handles.

Bug: angleproject:5736
Change-Id: I785ef18ef5ae45109ec7d6e0b079b79a9984a1f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837848
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

be7049d7

Stubs for CL validation entry points · cddb2003

authored Apr 23, 2021

Bug: angleproject:5775
Change-Id: Ic3b15efdf602bad8f5f170f03ba24b421a398ca8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2848504Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

cddb2003