Imagination GL drivers are buggy with context switching.
We need to ubind fbo to workaround a crash in the driver.

Bug: chromium:1187513
Change-Id: Ie5142b5f43a3f23a9743ba7af0d90567fedd00d3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2841083Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/cb5ad5e674fa..141612cc6143

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/5658f225b4..bdd4e9dcbc
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/db4fc48f37..d364fd2e43
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..09248fe432
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efd29f6f5c..93d80d8686
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f4ded123d0..b0eccdd309
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Id5942b5905f168e90198ec3b63ab77637f02c517
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838870
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

on Linix Vulkan NVIDIA

Bug: angleproject:5884
Change-Id: I46c330b2dc78b2271999315aa2b28930aee490f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842305Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/ededa67cb12a..476acb91ebc2

2021-04-16 alexander.galazin@arm.com Update Vulkan beta Headers
2021-04-16 piotr.byszewski@mobica.com Create chunked mustpass
2021-04-16 rgarcia@igalia.com Test non-uniform args in ray tracing operations
2021-04-16 alexander.galazin@arm.com Support GL 4.5 in the Program State Query tests
2021-04-16 tarceri@itsqueeze.com Add some simple shader tests for compatibility context
2021-04-16 tony.wasserka@gmx.de Add new tests for (u)int->float conversion
2021-04-16 rgarcia@igalia.com Test buffer copies with varying offsets and sizes
2021-04-16 pdaniell@nvidia.com Vulkan CTS coverage for VK_EXT_ycbcr_2plane_444_formats
2021-04-16 slawomir.cygan@intel.com Fix 'implicit-fallthrough' build error on GCC 9.3.0
2021-04-16 alexander.galazin@arm.com Support GL 4.5 in the tessellation and geometry shader interaction tests
2021-04-16 marcin.zajac@mobica.com Fix RT misc tests (querying shaderfloat64)
2021-04-16 lionel.g.landwerlin@intel.com Add missing rasterizationStream in pipeline creation
2021-04-16 sagar.ghuge@intel.com Drop unnecessary barrier
2021-04-16 piotr.byszewski@mobica.com Portability: fix ycbcr query tests
2021-04-16 rgarcia@igalia.com Make tcu::Exception noexcept copy-constructible
2021-04-14 toni.salmivalli@siru.fi dEQP-VK.graphicsfuzz.stable-colorgrid-modulo-true-conditional-divided-1
2021-04-14 toni.salmivalli@siru.fi Add a batch of GraphicsFuzz tests
2021-04-14 selcott@google.com Tests for VK_EXT_color_write_enable
2021-04-14 pdaniell@nvidia.com Tests for VK_EXT_vertex_input_dynamic_state
2021-04-14 dakeley@nvidia.com Add VK_NV_inherited_viewport_scissor tests
2021-04-14 alexander.galazin@arm.com Update Vulkan Headers
2021-04-14 jajones@nvidia.com Support alternate file path lists for loading libs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: I91da42609c1b9a065911762f966e163dbd02c90e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2840964
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: angleproject:5830
Tests: TracePerfTest.Run/*command_and_conquer_rivals
Change-Id: I0b5fedfdeab3c0729bac706ceb7ce98f66b41986
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2838231Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

https://chromium.googlesource.com/vulkan-deps/+log/c18d8cd5016c..494bfcf95bd6

$ git log c18d8cd50..494bfcf95 --date=short --no-merges --format='%ad %ae %s'
2021-04-20 chromium-autoroll Roll SPIRV-Cross from 3cb8e7c223a3 to d137abeef57b (5 revisions)
2021-04-20 chromium-autoroll Roll Vulkan-Loader from 64cc17099c41 to 4b868e5e13dc (2 revisions)
2021-04-19 chromium-autoroll Roll Vulkan-ValidationLayers from 61c2339d1547 to f39a8dc664c6 (2 revisions)
2021-04-19 chromium-autoroll Roll glslang from 842743722152 to 60ce877de03f (1 revision)
2021-04-19 chromium-autoroll Roll Vulkan-ValidationLayers from 33440cbab76c to 61c2339d1547 (2 revisions)
2021-04-19 chromium-autoroll Roll glslang from ed948c8e1226 to 842743722152 (1 revision)
2021-04-19 chromium-autoroll Roll SPIRV-Tools from 693d564db4e9 to dc72924cb31c (1 revision)
2021-04-19 chromium-autoroll Roll SPIRV-Cross from b4aa6dacfa8c to 3cb8e7c223a3 (1 revision)
2021-04-19 chromium-autoroll Roll SPIRV-Cross from 45818c14e49a to b4aa6dacfa8c (1 revision)
2021-04-19 chromium-autoroll Roll SPIRV-Cross from 582749ac68a9 to 45818c14e49a (1 revision)
2021-04-19 chromium-autoroll Roll Vulkan-Headers from f5ac258209dc to 074fa3055cfe (1 revision)
2021-04-16 chromium-autoroll Roll glslang from b3859343a2ca to ed948c8e1226 (1 revision)
2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from 65576d6dc06a to 33440cbab76c (4 revisions)
2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from 8035832536d2 to 65576d6dc06a (1 revision)
2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from e7eb5ca5e6ec to 8035832536d2 (1 revision)
2021-04-16 chromium-autoroll Roll Vulkan-ValidationLayers from ee42bab38c3b to e7eb5ca5e6ec (2 revisions)
2021-04-16 chromium-autoroll Roll SPIRV-Tools from a02a9205ff49 to 693d564db4e9 (1 revision)
2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from c8596531b3f7 to ee42bab38c3b (1 revision)
2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from 675fbfaee4e7 to c8596531b3f7 (1 revision)
2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from fc6291e5eded to 675fbfaee4e7 (2 revisions)
2021-04-15 chromium-autoroll Roll Vulkan-ValidationLayers from 962cad9d3a78 to fc6291e5eded (1 revision)
2021-04-14 chromium-autoroll Roll glslang from e7e4a8eecba5 to b3859343a2ca (1 revision)
2021-04-14 chromium-autoroll Roll glslang from e6a0e7fc7664 to e7e4a8eecba5 (1 revision)
2021-04-14 chromium-autoroll Roll Vulkan-ValidationLayers from 13c4877ea280 to 962cad9d3a78 (1 revision)
2021-04-14 chromium-autoroll Roll SPIRV-Cross from d2e1e7ba9891 to 582749ac68a9 (1 revision)
2021-04-13 chromium-autoroll Roll Vulkan-Headers from cd913e84a81d to f5ac258209dc (1 revision)
2021-04-13 chromium-autoroll Roll Vulkan-Headers from e01b00657664 to cd913e84a81d (1 revision)
2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 7699b91798eb to 13c4877ea280 (2 revisions)
2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 14f4f766ff89 to 7699b91798eb (1 revision)
2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 1e4ea30a1df3 to 14f4f766ff89 (1 revision)
2021-04-13 chromium-autoroll Roll glslang from a7f846a86cb2 to e6a0e7fc7664 (1 revision)
2021-04-13 chromium-autoroll Roll Vulkan-ValidationLayers from 884a3ecf0e11 to 1e4ea30a1df3 (1 revision)
2021-04-13 chromium-autoroll Roll Vulkan-Headers from e1d8c4931d8e to e01b00657664 (1 revision)
2021-04-13 chromium-autoroll Roll SPIRV-Tools from ae6a1e1d2f3e to a02a9205ff49 (1 revision)
2021-04-12 chromium-autoroll Roll Vulkan-ValidationLayers from d78df3497e17 to 884a3ecf0e11 (1 revision)
2021-04-12 chromium-autoroll Roll glslang from 5602195eed90 to a7f846a86cb2 (1 revision)
2021-04-12 chromium-autoroll Roll glslang from 9f76fd133063 to 5602195eed90 (1 revision)
2021-04-12 chromium-autoroll Roll SPIRV-Tools from 6210375e1399 to ae6a1e1d2f3e (1 revision)
2021-04-09 chromium-autoroll Roll SPIRV-Tools from 8da800c4cbc7 to 6210375e1399 (1 revision)
2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from abf8d903e390 to d78df3497e17 (1 revision)
2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from 317a46523468 to abf8d903e390 (3 revisions)
2021-04-09 chromium-autoroll Roll Vulkan-ValidationLayers from 9b36350504c7 to 317a46523468 (2 revisions)
2021-04-09 chromium-autoroll Roll SPIRV-Tools from 212895d4c2cd to 8da800c4cbc7 (1 revision)
2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from 3986d4ffc6b1 to 9b36350504c7 (2 revisions)
2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from eb791f3842c3 to 3986d4ffc6b1 (1 revision)
2021-04-08 chromium-autoroll Roll glslang from 4099f444484b to 9f76fd133063 (1 revision)
2021-04-08 chromium-autoroll Roll Vulkan-ValidationLayers from f563b367c72a to eb791f3842c3 (1 revision)
2021-04-08 chromium-autoroll Roll glslang from 1481399549c5 to 4099f444484b (1 revision)

Created with:
  roll-dep third_party/vulkan-deps

Bug: angleproject:5879
Change-Id: Ic36d6ded7116f8a59c9c4bcfb995dd4b870e3ecb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2837548Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:5880
Change-Id: I18698e0603938c43878ad4d28379d6976952c561
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836787Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Addition of the entry points for GL_KHR_blend_equation_advanced
extension.

Bug: angleproject:3586
Change-Id: I7a651c19a4b3d0a7cfe4af7813f1530d27704bc1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830140
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Big pipeline cache will cost much time to compress. Regarding the
perfomance, handle the compression of big pipeline cache in this way:
1)Return when the pipeline cache data is larger than 10M.
2)Use worker thread to complete compression.

Bug: angleproject:4722
Change-Id: I62eb69d8c46729261f0502af01450ec301c258f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2788169
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Includes necessary DEPS and GN build changes.
Some folders are copied directly from Chromium because they don't
exist as source mirrors or aren't available for other reasons.

Bug: angleproject:2344
Change-Id: Ibb7f8a3e2288048b7aed2b0e277ca63b5a932c57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826480
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Addition of the entry points for EXT_texture_border_clamp extension.

Bug: angleproject:3586
Change-Id: I366c2748213d7fdde815543129320278937000e0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830146
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Blit11 would clip the destination rectangle with the destination size
but ignore the result. gl::ClipRectangle returns false when the
rectangles do not intersect at all, indicating the blit can be skipped.

This could lead to an out-of-bounds write to the GPU memory for the
destination texture.

Mark ClipRectangle as nodiscard to prevent future issues.

Bug: chromium:1199402
Change-Id: I260e82d0917b8aa7e7887f2c9f7ed4b1a03ba785
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836786Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This reverts commit 5166a25b.

Reason for revert: Breaks presubmit tester (again).

Original change's description:
> infra: Switch to "angle_2" presubmit config.
>
> We will revert this once we remove the depot_tools config.
>
> Bug: angleproject:5114
> Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5114
Change-Id: I7a540c728f6851151c2f708480de21ce41938111
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836785
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

OpControlBarrier implicitly synchronizes 'Output' storage class.
If TCS has an out varying it should be considered active because
TCS invocations themselves can read each others' outputs.

Bug: angleproject:5557
Tests: KHR-GLES32.core.tessellation_shader.tessellation_shader_tc_barriers.barrier_guarded_*_calls
Change-Id: Ic252c0afff43a68828ee4cf5f4ba890b1b67731e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770679Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

This reverts commit b027dfeb.

Reason for revert: Breaking win-trace-rel b/c of missing VVL roll.

Original change's description:
> Revert "Vulkan: Suppress draw-time push constant VVL warnings.
> "
>
> This reverts commit f34b40da.
>
> Reason for revert: VVL bug is fixed.
>
> Original change's description:
> > Vulkan: Suppress draw-time push constant VVL warnings.
> >
> >
> >
> >     VUID-vkCmdDraw-None-02698
> >
> >     VUID-vkCmdDrawIndexed-None-02698
> >
> >     VUID-vkCmdDrawIndirect-None-02698
> >
> >     VUID-vkCmdDrawIndirectCount-None-02698
> >
> >     VUID-vkCmdDrawIndexedIndirect-None-02698
> >
> >     VUID-vkCmdDrawIndexedIndirectCount-None-02698
> >
> >     VUID-vkCmdDispatch-None-02698
> >
> >
> >
> > Bug: angleproject:5821
> > Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Jamie Madill <jmadill@chromium.org>
>
> Bug: angleproject:5821
> Change-Id: I771e81a46893f2875605e472273f1388587e042e
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:5821
Change-Id: If9f80d052736e40c4c6d3e9a1cd629205901ba49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2836285Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We will revert this once we remove the depot_tools config.

Bug: angleproject:5114
Change-Id: If922a24c9955ba5d5d30ec634fa6c3d6db177f65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831999Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://swiftshader.googlesource.com/SwiftShader.git/+log/f32791f5d53b..dac99e8221a8

2021-04-16 capn@google.com Update Kokoro's clang-format to version 11.0.1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: I07e7a243f65968e94b942b18d52f11ae6fcc3af3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2833601
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/11d568cbfed1..cb5ad5e674fa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e00ea2a33f..5658f225b4
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5d440f33b4..db4fc48f37
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..d6284252dc
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f959d17028..efd29f6f5c
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/eefe475693..d7dd881ddc
* tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67
* tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67
* tools/luci-go: git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0..git_revision:0f913477afc80d5c4b6609834d3bef6b44910e67
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/5e7cca9ca0..f4ded123d0
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: I61264c3b92501cd9b1816dee7c26cf2d32efdc31
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2834733
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

"

This reverts commit f34b40da.

Reason for revert: VVL bug is fixed.

Original change's description:
> Vulkan: Suppress draw-time push constant VVL warnings.
>
>
>
>     VUID-vkCmdDraw-None-02698
>
>     VUID-vkCmdDrawIndexed-None-02698
>
>     VUID-vkCmdDrawIndirect-None-02698
>
>     VUID-vkCmdDrawIndirectCount-None-02698
>
>     VUID-vkCmdDrawIndexedIndirect-None-02698
>
>     VUID-vkCmdDrawIndexedIndirectCount-None-02698
>
>     VUID-vkCmdDispatch-None-02698
>
>
>
> Bug: angleproject:5821
> Change-Id: Ic8ca6178ce50b409ac8d256848654f43f91fae8e
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808854
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5821
Change-Id: I771e81a46893f2875605e472273f1388587e042e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831997
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Flakily renders black.

Bug: angleproject:5875
Change-Id: I16805278e00d431bf81e531d5b0b17868ee8f476
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2833011Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This trace is ES 3.0 based and shader heavy.

Test: angle_perftests --gtest_filter="*slingshot_test2*"
Tbr: jmadill@google.com,timvp@google.com
Bug: b/185595371
Bug: angleproject:5877
Change-Id: I3d66a5f818b33581b4237e8a9efc56af5666d98b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2832657Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

This trace is ES 3.0 based and geometry heavy.

Test: angle_perftests --gtest_filter="*slingshot_test1*"
Tbr: jmadill@google.com,timvp@google.com
Bug: b/185595371
Bug: angleproject:5877
Change-Id: I8528d399fedbe6ea3a07297a869f33de4605c946
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2832672Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

A change in Vulkan-Headers changes the value of VK_NULL_HANDLE, exposing
an invalid usage in ANGLE, which is fixed in this change.

Bug: angleproject:5879
Change-Id: I136fdc9e707650a060eaee062c7cf8cf24d9e8b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831998Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

OpenGLES 3.0 allows FBO with unequal sized attachments. This CL removes
assertion that all attachment must have equal size from vulkan backend,
and uses common intersect area to create VkFramebuffer object.

Bug: b/181800403
Change-Id: Icbb12a26784b184ebd91740855672013f64b889d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824760
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Before OpenGLES3.0, framebuffer object with unequal sized attachment is
considered incomplete. That restriction has been removed in ARB version
of spec and is legit use in OpenGLES 3.0. This adds a test for this
specific usage.

Bug: b/181800403
Test: FramebufferTest_ES3.AttachmentWithUnequalDimensions
Change-Id: I79608bfd8f10855c6fc47511e080ba3ca4e46c59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824366Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

This test was suppressed on AMD/Windows already.

Bug: angleproject:5687
Bug: angleproject:5874
Change-Id: I9b6bac81adc017f80634271063d53f3d4eebba0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831993Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This is a reland of 9a839732

Chrome Linux crash issue could be fixed in
0615bbde, let's reland this now.

Original change's description:
> Reland "Add support for Linux GPU info with Vulkan backend"
>
> This is a reland of 5c09c1f8
>
> Extra change: Add new ANGLE_HAS_VULKAN_SYSTEM_INFO compile
> variable for GetSystemInfoVulkan() in linux platform.
>
> Original change's description:
> > Add support for Linux GPU info with Vulkan backend
> >
> > 1. Add support for Linux GPU info with vulkan backend: for
> > dev board without PCI support, try vulkan backend to get
> > GPU info.
> > 2. Fix getVulkanInstance() issue when loading non-exist lib:
> > return NULL instance if open lib failed.
> >
> > Bug: angleproject:5717
> > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Jamie Madill <jmadill@chromium.org>
>
> Bug: angleproject:5717
> Change-Id: Iaaab8f512b6ec1d524d7ebb3b4252fec3cfe7dc3
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739097
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5717
Change-Id: Iad6736f9137b7e9640c97fa2b9eded3fd37ac88f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821410Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Test: python3 scripts/run_code_generation.py
Bug: angleproject:5707
Change-Id: I5abae69c1c6bf03cc418f10beaabc80288fa1c94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2828979Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

These files should not be duplicated from Chrome, they are used
as part of Chrome's rolling process for these deps.

Bug: angleproject:5839
Change-Id: If95b11585e5aa7d8f834412d41dca377c495b1fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829330Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Tessellation control, tessellation evaluation and geometry shader
per-vertex input variables and blocks are required to be declared
as arrays. Ensure these variables meet the requirements and error
out if they don't.

Bug: angleproject:5557
Test: KHR-GLES32.core.tessellation_shader.compilation_and_linking_errors.te_non_arrayed_per_vertex_input_blocks
Change-Id: I0213fcc6fab90dea7597462a65cbbb7777e67108
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774759
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/cac0b331e3fc..11d568cbfed1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e966858a7e..e00ea2a33f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ef8239f68..5d440f33b4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c30133fce5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1cc5ed9e8..f959d17028
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fae4e7d723..5e7cca9ca0
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I88c789cd45eb5dbdc4d002029d4fddade79aa06c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830144
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This relands I4d4a88cfbb77d8b7508b787c7fec44073d3b11b0.

Fixes:
- uninstantiated ImageTestMetal error
- failed ImageTest.ANGLEExtensionAvailability on ARM mac.

Bug: angleproject:5763
Bug: angleproject:5814
Change-Id: I906fe52baefd6be3c6e00f594795bd527df01616
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2820178Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>

These auto-generated deps are necessary for the standalone build.
Updates the roll script to start including these automatically.

Bug: angleproject:2344
Change-Id: I389c203a2ddb971e3aeccb728cf37e232f32031e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826479
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Implements a descriptor set cache for UBOs, SSBOs, and atomic counter
buffers. Storage Images and framebuffer fetch input attachments are
not yet included. Requires moving the buffer barrier handling into
ContextVk, similarly to how we handle the barriers for Textures.

The packed description key for the descriptors uses a "fast" vector
with a basic minimum size. For most cases of a few buffers this will
fit easily in stack memory, but for larger programs with many buffers
we fit this into heap memory. The key has a large upper bound due to
the high ES 3.2 requirements and the need to index several values such
as the offset and binding size.

We use dynamic offsets for uniform buffers when possible. This ensures
applications like Manhattan 3.1 that use sets of common buffers with
changing offsets hit the cache most of the time.

Because of resource limits we pick at compilation time whether to use
dynamic or static descriptor sets. Mostly this applies to tests that
use a large number of uniform buffers. A future implementation could
be smart and would recompile the program with heuristics to use a
minimal number of dynamic indices.

Reduces the number of descriptor set updates from ~300 -> ~30 per frame
in Manhattan 3.1 and in Asphalt 9 from 900+ to as low as 0 per frame.

Bug: angleproject:5736
Change-Id: I5c2a3881bec90d301dab15cc86c8a70e60674ad7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757515
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:5869
Change-Id: Ie547d415bed37accef6cb62d28bc6b088a1eb810
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829370Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

Command and Conquer: Rivals requires additional frame capture API
support:
- Program Pipeline Objects
- glProgramUniform*

Bug: angleproject:5830
Change-Id: I159086f92d2dfead0a513cd17fadeda7df92f408
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809891
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

CTS bugs are fixed in [1] and [2].

[1]: https://gerrit.khronos.org/c/vk-gl-cts/+/7062
[2]: https://gerrit.khronos.org/c/vk-gl-cts/+/7049

Bug: angleproject:5673
Change-Id: I2d86f53a6a83bab143f89896d4d5dab3cc7b2334
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808053Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Since now ImageHelper object has a mRenderPassUsageFlags tracking how it
is been used by current RenderPassCommands, we can consolidate
mReadOnlyDepthStencilMode into a bit in the mRenderPassUsageFlags. The
read only mode is just a special attachment mode, so this makes code
more consistent and able to get rid of the extra dword for
mReadOnlyDepthStencilMode.

Bug: b/181797383
Change-Id: Ie9b7be1c18c392e5b2712bdae6ab6506de8d6d34
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821942
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Previously we supported read only depth attachment that attachment and
sample are using the same texture. It was always assuming it will be
read only if the same texture is attached to FBO and same time bound to
texture unit. But we never supported if it actually writing to depth
texture, but at the different level with sampling. This is supported
OpenGL operation as long as the levels render to is outside [base_level,
max_level]. Later on, we added support of the above operation, but
limited to color buffers. This CL extends the same support of render and
sample to the same depth texture with non-overlapping levels. Android
game black desert mobile is running into this usage case.

Bug: b/181797383
Change-Id: I7ee1d52f27603f933102ad1b098684309449c406
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819487
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

Render and sample from the same texture and then bind to another FBO
without trigger texture bind should still detect the condition that it
is render and sample same texture.

Render to depth texture and sample form the same depth texture but with
non-overlapping levels should work.

Bug: b/181797383
Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLODAndFBOSwitch
Test: FramebufferTest_ES3.RenderSampleImmutableDepthTextureWithExcludedLevel
Change-Id: I0d330d6f9530eb4fea417019a627890c4a5c1154
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819486
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>