Commits · bea35130d585caae7446a1ddc71025d723677610 · Chen Yisong / angle

24 Feb, 2015 1 commit

Clean up the style in Buffer11.cpp. · bea35130

authored Feb 11, 2015

Fix indentation, and simplify the naming scheme for the storage.
Also add some missing DISALLOW_COPY_AND_ASSIGN macros.

BUG=angle:912

Change-Id: I7ac36d8185ce926999501358cec222154d9a3492
Reviewed-on: https://chromium-review.googlesource.com/252960Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

bea35130

19 Jan, 2015 1 commit

Fix "start" vertex being applied for instanced buffers. · 459f2e5e

authored Jan 09, 2015

In GLES, the start vertex only applies to non-instanced vertex
attributes.

BUG=angle:864
BUG=447140

Change-Id: Idd2afbfbd4c2e76e06b2704cc002fae26b353109
Reviewed-on: https://chromium-review.googlesource.com/239843Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/241870

459f2e5e

09 Jan, 2015 5 commits

Revert "Fix Linux build, and update BUILD.gn." · 04184fb0

authored Jan 09, 2015

This reverts commit ed409f93.

Change-Id: I208a2c43c73e99ae95988c6d81ed64691bd8a99f
Reviewed-on: https://chromium-review.googlesource.com/239900Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

04184fb0

Fix signed/unsigned missmatch on 32-bit builds. · 8fed1f71

authored Jan 09, 2015

BUG=angle:681

Change-Id: I6144359acd1611a13b0a582d3a31019138bb941c
Reviewed-on: https://chromium-review.googlesource.com/239844Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8fed1f71

Fix Linux build, and update BUILD.gn. · ed409f93

authored Jan 07, 2015

We were getting multiply defined symbol errors on Linux for some
stuff in the common sources. Switch to using a static lib target
for the common sources, and also sync BUILD.gn with the latest gyp.

BUG=angle:773

Change-Id: I212284cfa90cd117a784a5f17057f47dd08900d1
Reviewed-on: https://chromium-review.googlesource.com/239193Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ed409f93

Merge the Texture set*Image methods and use objects for sizes and offsets. · 0a4f1e27

authored Dec 17, 2014

BUG=angle:681

Change-Id: If2e981c522ca5ba3eab4484594cb41aa23800ec4
Reviewed-on: https://chromium-review.googlesource.com/236261Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0a4f1e27

Use typed tests for the gles conformance tests. · ea878cb9

authored Jan 08, 2015

BUG=angle:497

Change-Id: I396411cc7c07047ef2fab70605de39287aaea879
Reviewed-on: https://chromium-review.googlesource.com/239515Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ea878cb9

08 Jan, 2015 9 commits

Fixed WinRT compilation to use non static C runtime because of Windows Store requirements. · cf5d48fa

authored Jan 06, 2015

Change-Id: I310e4909aaa94c90eecd610e6c7cbbde3c19b777
Reviewed-on: https://chromium-review.googlesource.com/238532Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cf5d48fa

Fixed failed compilation for WinRT to use OutputDebugStringA for non wide strings. · 7318b7cb

authored Jan 08, 2015

Change-Id: If012660d4b895399fe5e3226dea25a8c7f78c8ac
Reviewed-on: https://chromium-review.googlesource.com/239504Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7318b7cb

Add EGL extensions structs. · 40856813

authored Dec 11, 2014

BUG=angle:658

Change-Id: Iffb26caf16416313abc114ba779e6311f2c00848
Reviewed-on: https://chromium-review.googlesource.com/234760Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

40856813

Implement float-integer conversions for ESSL 3.00 · e8d2c072

authored Jan 08, 2015

The implementation uses asint, asuint and asfloat in the HLSL output.

BUG=angle:865

Change-Id: I6b48298e18c7b3b0bdeac522b375ebc4eab7cf4e
Reviewed-on: https://chromium-review.googlesource.com/239520Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

e8d2c072

Fix multisample framebuffer validation ASSERT · d2cf3ad3

authored Jan 07, 2015

Change-Id: I1b02ed7209f30549c17f46aeb3726ba1254df3ea
Reviewed-on: https://chromium-review.googlesource.com/239270Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d2cf3ad3

Disable some extensions on D3D11 Feature Level 9_3 which aren't supported · cf4432c3

authored Jan 07, 2015

BUG=angle:858

Change-Id: Ib2b2b2b54ba25654ea80b5cb1c59b74ed0379b68
Reviewed-on: https://chromium-review.googlesource.com/239271Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

cf4432c3

Disable shared texture support on D3D11 FL9_3 · ab989891

authored Jan 07, 2015

BUG=angle:858

Change-Id: I0fe3baf811d561584f7d24f6da665c6934e32b2a
Reviewed-on: https://chromium-review.googlesource.com/239272Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ab989891

Remove an unused mRenderer member from Program and initialize TF members. · ce5d66e8

authored Jan 07, 2015

BUG=angle:731

Change-Id: Ie11c80ce1f3a8c3d08145dfb4a075ac0e022ae38
Reviewed-on: https://chromium-review.googlesource.com/239218Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ce5d66e8

Add a test for rendering to cube map faces. · 5879598b

authored Jan 07, 2015

BUG=angle:849

Change-Id: I9986e45256da6f4cdbd375dad95037464fbcf299
Reviewed-on: https://chromium-review.googlesource.com/239219Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5879598b

07 Jan, 2015 10 commits

Print ERR() errors to the debug output on Windows. · 14aa40f0

authored Jan 07, 2015

We can switch this on for Debug only. This will help developers
catch bugs more easily, and will only show up for internal
errors and major performance caveats. Currently it's far too easy
to miss these messages - it requires manually modifying debug.h,
looking at a text file and potentially also running Chromium with
an special flag.

BUG=angle:663

Change-Id: I75b3bd05fbc75d21607b9957134db8e8990c77b1
Reviewed-on: https://chromium-review.googlesource.com/239191Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

14aa40f0

Allow the special format BGR5_A1 in CopyTexImage. · 054369e3

authored Jan 07, 2015

We use this format as a backbuffer texture for the EGL surface in
some configs. Thus, the app needs to be able to use it, since they
don't know when they are secretly using BGRA instead of RGBA,
similar to our existing logic which allows BGRA in CopyTexImage.

BUG=angle:811

Change-Id: I3748d38b3b085aa4ccaae67ce88711b13eb2c98e
Reviewed-on: https://chromium-review.googlesource.com/239192Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

054369e3

Use gl::Data as a parameter to Texture::isSamplerComplete. · f4134d20

authored Dec 15, 2014

BUG=angle:861

Change-Id: I3fadf954e6d28dd82e361ceac4ba1967dbd7e8bf
Reviewed-on: https://chromium-review.googlesource.com/235612Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f4134d20

Remove all uses of "actual" formats. · d8a2258c

authored Dec 17, 2014

BUG=angle:861

Change-Id: I7cd2d1a56772fdf18bcf926456399322d13e7a4f
Reviewed-on: https://chromium-review.googlesource.com/236305Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d8a2258c

Add missing test files to angle_end2end_tests_sources. · 4f89e3dd

authored Jan 07, 2015

Change-Id: I97217f4b4f42d9b9811185706587e2eb55270888
Reviewed-on: https://chromium-review.googlesource.com/239226Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

4f89e3dd

Fix missing "!" in cube map render target serial check. · 8cb85c44

authored Jan 07, 2015

BUG=angle:849

Change-Id: I9e4cb31bdc82a1c556908571355387a9698c7528
Reviewed-on: https://chromium-review.googlesource.com/239230Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8cb85c44

Fixed invalid IsWindow( ) call for WinRT Windows Store applications. · 2676fac9

authored Jan 06, 2015

Change-Id: Ic5f2aca0100a842be193cec9e89872187742f2c6
Reviewed-on: https://chromium-review.googlesource.com/238821Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2676fac9

Avoid using std::unordered_map on OSX. · cd1db9e6

authored Jan 05, 2015

This c++11 standard library class isn't available on Chromium/OSX.
For now we can replace it with std::map.

BUG=angle:773

Change-Id: I0b8ab0de5192a23408755d03df2b9f738f28d762
Reviewed-on: https://chromium-review.googlesource.com/238445Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

cd1db9e6

Remove "mDeviceLost" member from Renderer9 and Renderer11 · b78b42dd

authored Jan 07, 2015

These classes has base RendererD3D which already have "mDeviceLost".
This can lead to errors because this variable is used in the methods
from RendererD3D and his derived classes

Change-Id: Ie0814bd1fd604a2f26693a705d127345ba8f77b5
Reviewed-on: https://chromium-review.googlesource.com/239171Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b78b42dd

Unwritten shader output variables should not crash. · e1728549

authored Jan 07, 2015

BUG=angle:862

Change-Id: I8e7fa9b0d00bb1b2a32a8d60d8ceda998cea8e8c
Reviewed-on: https://chromium-review.googlesource.com/239160Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e1728549

06 Jan, 2015 1 commit

Fix assertion in D3D11 Feature Level 9_3 instancing implementation · edd84e41

authored Jan 05, 2015

BUG=angle:858

Change-Id: I6197d0f86536cb4613aa1aeb2d73a8173b4e4631
Reviewed-on: https://chromium-review.googlesource.com/238530Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

edd84e41

05 Jan, 2015 13 commits

Use correct SSE header on OSX. · 01675d80

authored Jan 05, 2015

This fixes the compile errors in loadImageSSE2.cpp.

BUG=angle:773

This reverts commit a93192369eb448e932bcdd1e08ae791aacfbe0c4.

Change-Id: I31bc419cd3930ae129903b935f49a3c9b27fc887
Reviewed-on: https://chromium-review.googlesource.com/238448Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

01675d80

Add a cross-platform rotl implementation. · 3b9bb72b

authored Jan 05, 2015

The _rotl method is unavailable on any platform but Windows,
so we can implement the method ourselves.

BUG=angle:773

Change-Id: I1342f4cf8a996daf11a36553c3bf7a01a2b182b3
Reviewed-on: https://chromium-review.googlesource.com/238500Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3b9bb72b

Ensure all source files end in a newline. · dff56337

authored Jan 05, 2015

This fixes compile errors on OSX.

BUG=angle:773

Change-Id: I11ce9fd470a54b08656a62afc50586e5d2f987d8
Reviewed-on: https://chromium-review.googlesource.com/238446Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

dff56337

Move getData from the D3D to the Impl. · 72468834

authored Jan 05, 2015

We will need this functionality for index validation, so we likely
can assume an implemenation will need to support such a call. We
might redesign this requirement, but for now we can't call though
to BufferD3D on OSX.

BUG=angle:773

Change-Id: I16187c78ff62471fdf7221a11b9956560e617a14
Reviewed-on: https://chromium-review.googlesource.com/238450Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

72468834

Fix standalone OSX build. · c34d53e4

authored Jan 05, 2015

We were missing one warning diable flag, for bison compatiblity,
and were missing the appropriate flag to enable c++11 support.

BUG=angle:773

Change-Id: I717ead6e1726920a6c28559503cb98e94dc29c16
Reviewed-on: https://chromium-review.googlesource.com/238449Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

c34d53e4

Don't call std::is_fundamental on OSX. · 5ffa95da

authored Jan 05, 2015

We can't use this method on OSX due to missing c++11 STL support.
Instead use a helper function to replace it.

BUG=angle:773

Change-Id: Iddcd2705792217e6356f51e4bb9dce248d7c3be2
Reviewed-on: https://chromium-review.googlesource.com/238447Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5ffa95da

Fix iterator comparison in Context.cpp. · 5fd0b2d9

authored Jan 05, 2015

In deleteTransformFeedback, we were using a const iterator, in a
non-const method. Fix the comparison by using auto, which delegates
more work to the compiler's static type checking.

BUG=angle:773

Change-Id: Ibc362fe49629331811a5302df1b68269dfa128a6
Reviewed-on: https://chromium-review.googlesource.com/238444Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5fd0b2d9

Add OSX cases to EGL headers. · 3b141a6c

authored Jan 05, 2015

These changes we'll have to upstream at a later time.

BUG=angle:773

Change-Id: I18feb84ae58cb16e3e555c9ab65b6925ba35048e
Reviewed-on: https://chromium-review.googlesource.com/238443Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3b141a6c

Don't use std::tuple in IndexRangeCache. · 3897cd17

authored Jan 05, 2015

std::tuple currently isn't available on Chromium/OSX.

BUG=angle:773

Change-Id: I9f9efc88dcfe904e98a76df8b04086b88f724424
Reviewed-on: https://chromium-review.googlesource.com/238442Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3897cd17

Use #include <stdint.h> instead of <cstdint>. · 47e156c0

authored Jan 05, 2015

This fixes the compile on OSX.

BUG=angle:773

Change-Id: I68111e178986bb78b73006a1559ba26120275599
Reviewed-on: https://chromium-review.googlesource.com/238441Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

47e156c0

Don't assume c++11 std::map::erase in invalidateRange. · 2bd2a42d

authored Jan 05, 2015

We were using the c++11 iterator return value from std::map::erase.
Instead use the post-increment operator to keep a valid iterator
after the call to erase, even on older stl.

BUG=angle:773

Change-Id: Ieaa21a2b5a3fcd5ca229a31d40bdf9b8f3283a3c
Reviewed-on: https://chromium-review.googlesource.com/238440Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2bd2a42d

Implement KHR_create_context. · 22bcf7cf

authored Dec 30, 2014

We need the functionality of this extension to support dEQP. Likely
we only needed the minor version enum to not generate an error, but
we can take the time to implement the few cases for the other enums
as well.

We don't support any debug context functionality currently, but we
may want to support it in the future.

BUG=angle:501

Change-Id: Ib74cd2e4581e054f8153bb358824d9296b9f8a1c
Reviewed-on: https://chromium-review.googlesource.com/238083Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

22bcf7cf

Advertise EGL_EXT_platform_base. · 2445143a

authored Dec 30, 2014

We were not advertising the extension, though we require it for
ANGLE_platform_angle. This was blocking dEQP functionality.

Change-Id: I8781867e772b4b1af62f1387faa863f8ce21de76
Reviewed-on: https://chromium-review.googlesource.com/238082Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2445143a