Skip to content

A
angle
Switch branch/tag
  1. 25 Aug, 2020 6 commits
  3. 24 Aug, 2020 5 commits
  5. 23 Aug, 2020 5 commits
  7. 22 Aug, 2020 2 commits
  9. 21 Aug, 2020 10 commits
  11. 20 Aug, 2020 10 commits
  13. 19 Aug, 2020 2 commits
    • Revert "Feedback Loop Redesign 2/3: Track bound FBOs in Texture." · f6fb6da8
      Khushal authored 
      This reverts commit 699bcde0.

Reason for revert: Breaking GLES2WebGLDecoderPassthroughTest.DrawArraysInstancedANGLEEnablement. Here is a sample build : https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20Release%20%28NVIDIA%29/4240

Original change's description:
> Feedback Loop Redesign 2/3: Track bound FBOs in Texture.
> 
> Currently we track feedback loops by counting the times a Texture is
> bound as a sampler or image in a particular context. This is a bit
> tricky because Texture bindings change frequently. Relative to the
> number of times we need to check for a feedback loop this causes excess
> overhead.
> 
> Usually Framebuffers have a low number of Textures bound (in many cases
> just 1). And Textures aren't usually bound to many different FBOs. So
> instead of counting the number of times a Texture is bound as a sampler
> or image we will track the Framebuffers that the Texture is bound to.
> 
> This CL adds a small vector class to gl::Texture which tracks all the
> Framebufer Serials of its bound Framebuffers. We can use this set to
> quickly check if there's any potential feedback loop between the a FBO
> and this Texture.
> 
> We also update the feedback loop check to use this new method. We will
> be able to remove the old counting method when we switch the Vulkan
> feedback loop handling to use the new tracking in this CL.
> 
> Bug: angleproject:4500
> Bug: angleproject:4959
> Change-Id: I84a2f0ed8480d1da63d5879e0e56a8be4af4e735
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358850
> Reviewed-by: Tobin Ehlis <tobine@google.com>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=tobine@google.com,courtneygo@google.com,jonahr@google.com,jmadill@chromium.org

Change-Id: Ica795036895652add37ac8ed319031f9d5a321ac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4500
Bug: angleproject:4959
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2365077Reviewed-by: 's avatarKhushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
    • Adjust roll_chromium_deps.py to work with autoroller. · 0f33d01e
      Yuly Novikov authored 
      Add --autoroll option which expects an existing git commit by the
autoroller, which updates chromium_revision.
roll_chromium_deps.py then updates other ANGLE dependencies to the
revision of their Chromium counterparts and amends autoroller's commit.

Bug: skia:10572
Change-Id: Iddb9296bd1470f4a2113563c5ed3a1c27e16f128
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2363212
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>