- 13 May, 2020 1 commit
-
-
Ian Elliott authored
Follow-on CL per request in https://chromium-review.googlesource.com/c/angle/angle/+/2191425/3/src/libANGLE/renderer/renderer_utils.h#48 Bug: angleproject:4436 Change-Id: I2ee8c65a0dbcf2eee4c9c7f4252abf16a578cad3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197614 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 12 May, 2020 12 commits
-
-
Michael Spang authored
This reverts commit 69e46942. Reason for revert: Broke the build due to VulkanExternalHelper API change Original change's description: > Vulkan: Add semaphores test to VulkanExternalImageTest > > Add a more substantial test that uses semaphores to > VulkanExternalImageTest. > > It's still just a clear in GL, which exposed a bug that a staged clear > wasn't be flushed by a call to glSignalSemaphoreEXT. > > Bug: angleproject:3289 > Change-Id: Id938eaf2c8c20cb0ae9fb948fbfcf3448980b577 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195684 > Commit-Queue: Michael Spang <spang@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> TBR=spang@chromium.org,geofflang@chromium.org,jmadill@chromium.org Change-Id: I50b2af80cd0214bd3c317eb5ba211ddc66803d74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3289 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2197193Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org>
-
Jamie Madill authored
This allows us to avoid using draw commands with pipelines for scissored clears. This prevents some tests from generating large numbers of VkPipelines. Bug: angleproject:4517 Bug: angleproject:4617 Change-Id: Id4a44000078098a60aa89233cfef30b75727d108 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2194473 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Michael Spang authored
Add a more substantial test that uses semaphores to VulkanExternalImageTest. It's still just a clear in GL, which exposed a bug that a staged clear wasn't be flushed by a call to glSignalSemaphoreEXT. Bug: angleproject:3289 Change-Id: Id938eaf2c8c20cb0ae9fb948fbfcf3448980b577 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195684 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Michael Spang authored
If validation layers are requested by default, also enabled them in VulkanExternalHelper. Bug: angleproject:3289 Change-Id: Ic75089d38992be3b4745ce0309bf4ce6b8a702b1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195683Reviewed-by:
-
shrekshao authored
WebGL 2 seems to be ES300 context and will fail the ValidateGetBooleani_v at context->getClientVersion() >= ES_3_1. Also for getIndexedParameter pname==GL_COLOR_WRITEMASK, the length shall be 4. Bug: angleproject:4394, chromium:1058744 Change-Id: Ia60506b6b1f120ed06acbcea0cb1f4581c70b32b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2191424Reviewed-by:
-
Geoff Lang authored
The frontend format is not always valid to use for glCopyTexImage. Translate it to a valid format for the current driver. TEST=deqp/functional/gles3/framebufferblit/default_framebuffer_00.html BUG=angleproject:4632 Change-Id: I838a1b27b528f074f440575adb88357a910f596a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2196842Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Ian Elliott authored
Depending on the orientation, the source image may be row-major or column-major; with positive or negative x/y-axis pitches. Regardless of the orientation, the destination remains row-major. Bug: angleproject:4436 Bug: b/150329975 Change-Id: Ia1287f7036f07548d35128f1761feadf721cd78a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2191425Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Alexey Knyazev authored
Fixes ClearTestES3.ClearDisabledNonZeroAttachmentNoAssert Also fixed an assert in RenderTargetCache::updateColorRenderTarget Bug: angleproject:4607 Change-Id: Ic527eabacd424786736876136590b8409c9b49d1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172091 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Xinyi He authored
Some Mali GPUs don't support vertexPipelineStoresAndAtomics feature, so the maxShaderImageUniforms should be set zero. Bug: angleproject:4629 Change-Id: I754506dd27c75b3dfd5ab695e24a680f683ca78a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195424 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/bb279b9f0bda..fe0b6a61d732 git log bb279b9f0bda..fe0b6a61d732 --date=short --first-parent --format='%ad %ae %s' 2020-05-11 s.fricke@samsung.com layers: Add VUID 00829 2020-05-11 s.fricke@samsung.com layers: Label VUID 04006 2020-05-11 jbolz@nvidia.com tests: Add null descriptor validation tests 2020-05-11 jbolz@nvidia.com layers: Validate VK_EXT_robustness2 2020-05-11 mark@lunarg.com practices: Change non-success warnings to infos Created with: gclient setdep -r third_party/vulkan-validation-layers/src@fe0b6a61d732 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@chromium.org Change-Id: I902443c757cd4d1bef935282b9c5775da5cc8bdd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195778Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b5f003d7a3ec..55f9d97f3b1e Created with: gclient setdep -r third_party/glslang/src@55f9d97f3b1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@chromium.org Change-Id: If49d8dbbfd596c810412e849e43e0c6c28d3958d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195777Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7b87548e5a63..d9ba4b7dd30b git log 7b87548e5a63..d9ba4b7dd30b --date=short --first-parent --format='%ad %ae %s' 2020-05-11 amaiorano@google.com Add high precision filtering extension Created with: gclient setdep -r third_party/SwiftShader@d9ba4b7dd30b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@chromium.org Change-Id: I78991067bfe43eaf6a968f5cf54b3786af2f8812 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2195779Reviewed-by:
-
- 11 May, 2020 13 commits
-
-
Michael Spang authored
A VkSurfaceKHR may not have an intrinsic size as is the case on Fuchsia. This is broken since 718ae508 ("Vulkan: Always query EGL_WIDTH and EGL_HEIGHT"); queries for EGL_WIDTH or EGL_HEIGHT now always return -1. Switch back to the old behavior in this case. Bug: angleproject:4624 Change-Id: I7e7bf569db9aec9890b2cb184056be5a6031bd98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2191173Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
-
Michael Spang authored
Currently Swiftshader tests are skipped only if a swiftshader device is requested. We should also skip swiftshader tests if the default GPU on the system is swiftshader, as is the case in certain emulated systems. Bug: angleproject:4626 Change-Id: I3ee83c43d35eb4f94b516e80689b241d53bbfb62 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2192090 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Michael Spang authored
This removes the coverage of non-dedicated allocations, but we've never supported that properly anyway (we require that the offset passed to glTexStorageMem2DEXT be zero). Bug: angleproject:4627 Change-Id: I14b0f39e5e13c3aafc4549dc59b6e3ac4ec6ad8c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2192500Reviewed-by:
-
Jamie Madill authored
This ensures if we re-capture with different parameters that we regenerate traces. It uses the sha1 so that it can be run correctly from an open-source checkout. Bug: angleproject:4590 Change-Id: I01a2eef037924c5acaaf124308315364e6f1d723 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2185157 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Michael Spang authored
Add a VkMemoryDedicatedAllocateInfo to the vkAllocateMemory pNext chain if the client specifies the memory object was a dedicated allocation. We don't yet support suballocation of external memory objects, so all allocations are already effectively dedicated allocations regardless of whether vulkan requires it. The spec requires that memory passed to vkBindImageMemory be created with a VkMemoryDedicatedAllocateInfo if the driver requires dedicated allocations for that VkImage. If the driver does not require a dedicated allocation, there actually seems to be no explicit requirement to use this structure even if it was passed in at allocation time. Bug: angleproject:4627 Change-Id: I8a660e871bdf72815815f0c0b3000f3b0570bd2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2192501Reviewed-by:
-
Jamie Madill authored
This makes the traces consistent no matter which platform they are captured on. Will make it easier to use hashing with our code generator script. Bug: angleproject:4590 Change-Id: I7134b824c5cfefe4f2c21d8f9e21d80c2e8af57b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2188953 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Le Hoang Quyen authored
This includes some bug fixes needed by Metal back-end's later commits. Bug: angleproject:2634 Change-Id: Idaa1461a0929cc998f7f7c11eaea5219ef63f801 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2192568Reviewed-by:
-
Charlie Lao authored
gets introduced This tracks barriers in an array based on dstPipelineStage. Bug: b/155341891 Change-Id: Icba2ef81530edcdb9ae363b00f0e7b9efe93d48f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2188955Reviewed-by:
-
Jamie Madill authored
Makes a lot common between Linux and Windows using git bash. Bug: angleproject:4620 Change-Id: I68cf8ac0fb43bc9c21d07ae3abecf5ca0358261c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2189814 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Antonio Maiorano authored
Chromium enables a custom extension, GL_CHROMIUM_texture_filtering, when using SwiftShaderGL, to enable high precision filtering. This change makes it so ANGLE also handles this same extension when using the SwiftShaderVK backend, by enabling the new VK_GOOGLE_sampler_filtering_precision custom extension. Bug: b/146423360 Bug: b/154620295 Change-Id: I69cafc1ccf5970a3d220ac7e13ec3c8fdd4a9643 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2185822 Commit-Queue: Antonio Maiorano <amaiorano@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Amy Liu authored
In vulkan spec, if srcImage or dstImage parameters are of VkImageType VK_IMAGE_TYPE_3D, the baseArrayLayer and layerCount members of the corresponding subresource must be 0 and 1. Bug: angleproject:4553 Change-Id: Iabdc9708c86606c0d78c095c9d44827951264180 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2166863Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2dd864470e31..7b87548e5a63 git log 2dd864470e31..7b87548e5a63 --date=short --first-parent --format='%ad %ae %s' 2020-05-08 capn@google.com Regres: Limit the Gerrit comment message length Created with: gclient setdep -r third_party/SwiftShader@7b87548e5a63 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I0413207579012743dfdd6fe16eb173c2f3f4d543 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2192826Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/43ea8c0fdf49..bb279b9f0bda git log 43ea8c0fdf49..bb279b9f0bda --date=short --first-parent --format='%ad %ae %s' 2020-05-09 mark@lunarg.com corechecks: Fix unused function assert in clang release builds 2020-05-08 mark@lunarg.com docs: Update BUILD.md for the new SPIRV-headers dependency 2020-05-08 mark@lunarg.com tests: Audit use of locks in ErrorMonitor 2020-05-08 mark@lunarg.com tests: Added CmdBindIndexBuffer TYPE_UINT8_EXT test case 2020-05-08 mark@lunarg.com stateless: Fixed null check for uint8_feature validation 2020-05-08 mark@lunarg.com layers: Avoid state updates if QueueSubmit doesn't succeed 2020-05-08 tony@lunarg.com layers: Move logging into ValidateDescriptorSetBindingData 2020-05-08 tony@lunarg.com tests: Test gpu-av aborts 2020-05-08 tony@lunarg.com gpu: Initialize layout handles 2020-05-08 shannon@lunarg.com build: Modify tests for VUID changes for 1.2.140 2020-05-08 mikes@lunarg.com travis: Remove devsim from validation cloud CI 2020-05-08 shannon@lunarg.com scripts: Modify scripts to output UNIX line ending 2020-05-08 mark@lunarg.com lifetimes: Fixed code generator to ignore new param attribs 2020-05-08 shannon@lunarg.com build: Update known-good files for 1.2.140 header Created with: gclient setdep -r third_party/vulkan-validation-layers/src@bb279b9f0bda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ifa97a5205eeacfd13dcb15dc6a1f22f068b102ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2192825Reviewed-by:
-
- 08 May, 2020 7 commits
-
-
Jamie Madill authored
Bug: chromium:1074162 Change-Id: I6aa545e20f64dda0a1716cf8d0df9ad62fc1a890 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2190624 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This time using a simpler integration and no template. Bug: chromium:1074162 Change-Id: Ia770f2bf724ffb9b8120dbdbc707133fc61e16c6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2182173Reviewed-by:
-
Geoff Lang authored
The other initailization path SamplerDesc::reset updates sets this value. Make sure it's initialized in all paths. BUG= chromium:1079398 Change-Id: Ia39722ec905e75483acde0907e891e68badfa9ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2189913Reviewed-by:
-
Brian Osman authored
These are both fairly common, and rarely actionable. Bug: chromium:765576 Change-Id: Ib067fcbb1d4ffe7fcd47b69dbe5defac81430a70 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2188952Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/08afdde7726c..2dd864470e31 git log 08afdde7726c..2dd864470e31 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 nicolascapens@google.com Revert "Produce MSVC error when virtual class misses virtual destructor" 2020-05-07 capn@google.com Remove typeinfo from Vulkan exported symbols 2020-05-07 capn@google.com Produce MSVC error when virtual class misses virtual destructor Created with: gclient setdep -r third_party/SwiftShader@2dd864470e31 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I206339d7591b22498a7562de07c032be741cab26 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2190373Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/17019fa23604..7bcbfd304f8b git log 17019fa23604..7bcbfd304f8b --date=short --first-parent --format='%ad %ae %s' 2020-05-08 mikes@lunarg.com build: Update known-good files for 1.2.140 header 2020-05-07 tony@lunarg.com cube: Remove dependency on VK_DYNAMIC_STATE_RANGE_SIZE Created with: gclient setdep -r third_party/vulkan-tools/src@7bcbfd304f8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Ica7055285c6229ff8328a76d2aeb9995deddf89b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2190374Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/28b8813b3998..43ea8c0fdf49 git log 28b8813b3998..43ea8c0fdf49 --date=short --first-parent --format='%ad %ae %s' 2020-05-07 mark@lunarg.com tests: Fix an END_RANGE use that slipped through code review 2020-05-07 s.fricke@samsung.com layers: Fix typo of dose to does Created with: gclient setdep -r third_party/vulkan-validation-layers/src@43ea8c0fdf49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I8460f6050688efdc09a0d15eb9eb36cf41814f92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2189972Reviewed-by:
-
- 07 May, 2020 7 commits
-
-
Jamie Madill authored
Now works when run in a sequence. Also saves RGB images to avoid issues with the alpha being inconsistent and also flips images vertically to fix the rendering. Bug: angleproject:4615 Change-Id: I8d3b38c5d914e0ca2227320ac42a0e28acd12c4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2187971 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Charlie Lao authored
This is preparation CL without introducing any functional change. This Cl wraps barrier data into its own class and put necessary data structures in place. It still uses one vkCmdPipelineBarrier call. Bug: b/155341891 Change-Id: If9c70d24873bd9b89e598acfba2eeee364f0b6c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2185149 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
Michael Spang authored
These tests previously encountered errors attempting to transfer images from VK_QUEUE_FAMILY_EXTERNAL back to itself (this is not valid because one of the queues families in a memory barrier must be the family of the queue that executes the barrier). These invalid transfers were made because our ownership tracking started all resources in the "externally owned" state, with the expectation that the first operation on the resource would be a call to glWaitSemaphoreEXT to acquire ownership. It is far from clear that a call to glWaitSemaphoreEXT is always required to gain ownership of a resource. The EXT_external_objects extension inherits Vulkan's semantics, and what the Vulkan spec says is that the first entity to access a resource implicitly assumes ownership (see 11.7.1 "External Resource Sharing"). Binding a resource to memory does not constitute an access to that resource, or affect its ownership. Allocations should not be accesses, either; they happen at a lower level and the entire discussion about determining initial ownership from first access would serve no purpose if the mere allocation of the underlying memory was sufficient to assume ownership. This patch therefore adjusts the initial queue family ownership of resources created in memory objects to be the ANGLE renderer's queue family, just like a locally allocated image would be. Since this ownership state may not be correct (an external API may have already accessed the image, and assumed ownership) we must relax our assertions to allow a call to glWaitSemaphoreEXT while in this state. For images, this is only permitted while the layout is undefined. An alternative would be to set the initial queue family to a sentinel value that indicates that we don't know, but that would require checking for this value before making any accesses, and only then asserting local ownership. There's no real upside to this; the net effect of the first access rule is that we must effectively assume ownership until proven otherwise. Besides appearing to be the spec's intent, this change simplifies some usage scenarios because a queue submission is not required in the source Vulkan instance in order to allocate resources that will be initially accessed from GL. This seems especially important since there's no mechanism to allocate an external memory object from inside GL. The only downside is that the initial ambiguity in ownership prevents us from diagnosing certain errors, but this limitation is temporary; ownership becomes clear as soon as there is at least one access or at least one synchronization operation affecting the resource. Bug: angleproject:4229 Change-Id: Ibca2bfe373810c55352b1d849d07733d5fcfe5f4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2178946 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This adds a "--screenshot-dir" argument to capture screenshots. If we're running with screenshot capture then the test will early exit after the first capture. The screenshots use the same naming pattern as the test name: TracePerfTest.Run/vulkan_trex_200 -> angle_vulkan_trex_200.png Note the screenshot dir is relative to the test binary directory, not the CWD. Also adds a PNG saving utility function. Bug: angleproject:4615 Change-Id: I1de8ae6a6e6892586bb0b743e7b9a842f90f98e5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2184834 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/baa10d7b1dee..08afdde7726c git log baa10d7b1dee..08afdde7726c --date=short --first-parent --format='%ad %ae %s' 2020-05-06 sugoi@google.com Also use out of bound detection for image stores 2020-05-06 bclayton@google.com CMakeLists: Fix building of llvm-with-cov 2020-05-06 jrprice@google.com Insert __msan_unposion for masked/scattered stores 2020-05-06 sugoi@google.com Detect out of bounds image pointers Created with: gclient setdep -r third_party/SwiftShader@08afdde7726c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: Id58702e5370f868903a3e799cfd3f6068b028c91 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2187351Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d2b486219495..c8590c18bd0c Created with: gclient setdep -r third_party/spirv-tools/src@c8590c18bd0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: courtneygo@google.com Change-Id: I66ed2a0daf3ee6755495e025a10fcf06f5aa2978 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2186548Reviewed-by:
-
Jiajie Hu authored
In the D3D renderer, changing the base level may trigger re-allocation of the texture storage, for example if the new base level has a different aspect ratio. During the process, image contents in the texture storage should be backed up properly. The D3D11 backend does this if an image has been associated with the texture storage, but it may happen such an association has never been established, and corruption will be observed then. The proposed patch mitigates the problem by introducing a new method named findRenderTarget(), with which one can tell if a mip level has been used as the render target. This works based on the fact that render targets are cached in the texture storage object. Hence all mip levels of interest can be found, without relying on the association between images and texture storage. Bug: angleproject:2291 Change-Id: Ic73af7b603be25c65760928f276bec16df003baf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2158830 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
