Commits · d41cec67e8cb8cd3211975d31079ba1fdf6c36ec · Chen Yisong / angle

26 Mar, 2021 1 commit

Roll Chromium from 7a30f2f0e630 to e0abc3035c46 (431 revisions) · d41cec67

authored Mar 26, 2021

https://chromium.googlesource.com/chromium/src.git/+log/7a30f2f0e630..e0abc3035c46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7b935ebade..5b847b7f2c
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/f50df92a29..9bb07683fb
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3977fbe3b4..e50b540620
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36e45025a8
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a2d934b248..fc39a84984
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f5499b6afa..fc72712d33
No update to Clang.

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie0442b56785f1b203ce86ad8a78f181206e8c0ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2786167
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d41cec67

25 Mar, 2021 9 commits

capture_gles_1_0: Implement capture functions. · 58502aa5

authored Mar 04, 2021

Implement various capture functions as required by the GLES1 tests
and GLES1 applications like Dr. Driving.

Implements glMultMatrixf,  glTexEnvxv, glLightxv, glLoadMatrixf and
glGetFixedv.

Bug: angleproject:5751
Change-Id: Id22899d755a9126f91b37eeea4619d6a03636f8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756533Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

58502aa5

Remove old Win x86 bots from CQ · 67232387

authored Mar 25, 2021

win-angle-chromium-x86-try + win-angle-x86-try replace
win-angle-rel-32 + win-angle-deqp-rel-32

Bug: angleproject:4483
Change-Id: If2c6d13937d61793f8b1845dc4aec83cae43d3b8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787197
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

67232387

Vulkan: Call glslang at compile time · 776c6015

authored Feb 26, 2021

With this change, the ANGLE translator immediately compiles the
generated GLSL into SPIR-V with glslang and discards the source.  This
is in preparation for generating SPIR-V directly, by making the frontend
and backend already able to digest it.

This change also allows the expensive glslang calls to be parallelized,
improving the following perf test by about 20%:

    LinkProgramBenchmark.Run/vulkan_compile_and_link_multi_thread

Previously, the test was run as such in the Vulkan backend:

    Main           Thread 1          Thread 2
    Compile1 --->
    Compile2 --------------------->
                  Translator        Translator
             <---
             <---------------------
    Link

    glslang
     for
      shader1

    glslang
     for
      shader2

    Done

With this change, it is run as such:

    Main           Thread 1          Thread 2
    Compile1 --->
    Compile2 --------------------->
                  Translator        Translator
                   glslang           glslang
             <---
             <---------------------
    Link
    Done

glslang_wrapper_utils no longer interacts with glslang! A rename will
follow.

Bug: angleproject:4889
Change-Id: If4303e8ba0ba43b1a2f47f8c0a9133d0bee1a19a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2721195
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

776c6015

Trace Tests: Work around autoninja.bat change on Win. · eac2397b

authored Mar 25, 2021

A breaking change to autoninja.bat was causing the script to fail to
find 'python3.bat' in this configuration. Work around the issue by
instead invoking 'ninja.exe' directly with the correct '-j' argument.

Bug: angleproject:5766
Change-Id: Ie01d7e8c4caf80661f420ccfc55a8d951a4e1b4f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2787186Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

eac2397b

Vulkan: Enable glBlitFramebuffer for EXT_sRGB_write_control · f28d63e9

authored Mar 24, 2021

Implements support for the glBlitFramebuffer edge case in the
EXT_sRGB_write_control spec, and fully exposes this extension.

Bug: angleproject:5075
Test: SRGBFramebufferTest*.*Vulkan*
Change-Id: I05f044abbc5cb272825d1fc4b9028217f18e63c2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785641Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

f28d63e9

Roll vulkan-deps from 91a2a0b15f23 to 3f4383f1d450 (26 revisions) · 5dad9d8a

authored Mar 25, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/91a2a0b15f23..3f4383f1d450

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/979319b9b1..2c7c84c8ac
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a732e4c03c..ecc840d30b
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/89d366355e..a8d6ab19d1
* vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/1353e80d87..5180defc01
* vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/27c2124822..1d3ce716df
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/309d9bea09..b1a10a4bc6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I730b4b918d2b2ca94a96caf4df7986be09d2fe8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2786594
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5dad9d8a

Roll SwiftShader from a98fb3f8380a to 8969f861fc24 (2 revisions) · b1896811

authored Mar 25, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/a98fb3f8380a..8969f861fc24

2021-03-25 swiftshader.regress@gmail.com Regres: Update test lists @ 2eed61ff
2021-03-24 capn@google.com Ensure compressed image copy is height compliant

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ie6157852af2cb1cccc412e30fd6d3b64aa8b0104
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785477
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b1896811

Roll Chromium from bda1e3894abc to 7a30f2f0e630 (468 revisions) · 12bdb7f0

authored Mar 25, 2021

https://chromium.googlesource.com/chromium/src.git/+log/bda1e3894abc..7a30f2f0e630

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/cb055e229d..7b935ebade
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/731dd85349..f50df92a29
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ada28b558f..3977fbe3b4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..36e45025a8
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/24cecabb89..a2d934b248
* tools/luci-go: git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b
* tools/luci-go: git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b
* tools/luci-go: git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2..git_revision:e1c81c53ccd0366e8fff438f89030043343d4d6b
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/772ad67f2e..f5499b6afa
No update to Clang.

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I7b8471ce869387cd4d6708717b990238cc303d8a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785254
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

12bdb7f0

Leave Android devices in portrait orientation after test · 3d6cedb1

authored Mar 24, 2021

EGLPreRotationSurfaceTest.ChangeRotationWithDraw
alternates between landscape and portrait orientations.
The last one needs to be portrait, since this is the default state
that other tests expect.
Since changing orientation takes 1 second, it's more efficient to do it
in this one place instead of before every test.

Bug: angleproject:5781
Change-Id: I63c2eeb77663ea7de6679385c9deb089b16e74f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785433Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

3d6cedb1

24 Mar, 2021 10 commits

Vulkan: Add A few other *-None-04584 VVL error to skip list · 9a79ee78

authored Mar 22, 2021

If app uses textureLoad to fetch a texture level and mean time renders
to the same texture but with different level, this will generate vulkan
validation errors. Previously we are only skipping
VUID-vkCmdDraw-None-04584, but it is necessary to skip all other-04584
VVL error that stem from other draw calls as well. Aztec ruins can run
into VUID-vkCmdDrawIndexed-None-04584 on QComm GPU, for example.

Bug: b/175584609
Change-Id: I2da6945415975350e36f533f007ae1e2a5feddfd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780563Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

9a79ee78

SSBO handling rewrite. · ac8e1196

authored Mar 20, 2021

The basic idea is to replace the current SSBO output traversal by build
a new AST for the Load and Store subtrees, then traverse that AST with
the regular OutputHLSL traversal.

This way, all the paren balancing and state management can go away.

BUG: angleproject:5734
Change-Id: I14d2fecd724d7419fbc9315fad4e9202a741b03f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773401
Commit-Queue: Stephen White <senorblanco@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ac8e1196

Fix potential mod by 0 with invalid formats. · 525fde75

authored Mar 22, 2021

If the format passed to MakeValidSize is invalid, there
is potential for a mod by 0 which can result in a crash.

Test: Verify no crash when format is invalid.

Bug: b/182823289
Change-Id: I7f538be5d984070984f5581a5cc7ea47264109f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780557Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Doug Horn <doughorn@google.com>

525fde75

Disable Framebuffer Fetch test. · 010d61f2

authored Mar 24, 2021

See issue for more details.

Bug: angleproject:5792
Change-Id: I7a72dfe75a85f2bf69e3528f35c01ca69c67f8f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2785420Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

010d61f2

Add missing qualifier type handling in translator · dd5705e7

authored Mar 24, 2021

Translator checks tessellation shader unsized array type qualifier.
sample in/sample out were missing in handling qualifier type.

Bug: angleproject:5557
Test: GLSLTest_ES31.VaryingTessellationSampleInAndOut*
Change-Id: I8a2f2c4c4fcc9cc88000d3b2d448ab51fb9e5d38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776263Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

dd5705e7

Scripts: Ignore robin_hood headers in VVL · 775caee1

authored Mar 24, 2021

Needed to unblock vulkan-deps roll.

Example bad roll:
https://chromium-review.googlesource.com/c/angle/angle/+/2784701

Fallout from upstream changes:
https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/2639

TBR: jmadill@google.com
Bug: angleproject:5791
Change-Id: Idf4a0f6b4a7ef04e48d84110cd9d30887ebff9cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2784712Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

775caee1

Roll Chromium from f1617b736428 to bda1e3894abc (469 revisions) · 0c9f22d3

authored Mar 24, 2021

https://chromium.googlesource.com/chromium/src.git/+log/f1617b736428..bda1e3894abc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b43166a3d1..cb055e229d
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/4e078437d0..731dd85349
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/a9cb74b2b5..ada28b558f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..25699ba498
* tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2
* tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2
* tools/luci-go: git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e..git_revision:689d9817823a3bc34ff2b7a3c45c7e6b41a70ca2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c94714a14b..772ad67f2e
* tools/skia_goldctl/linux: PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC..siMs1o8b-ON1wWPwvSA4NKhGMBXPWhkMQ3HHr7-yDqQC
* tools/skia_goldctl/mac: rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC..77UQ9Zx-irz8MxBwN3CtYielGQtPthCIaWzlOONC8_MC
* tools/skia_goldctl/win: bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC..rLRz9NhcZkVWiGMr_kp9C1L_1QOynKyxdh-eu6REt4MC
No update to Clang.

Bug: None
Tbr: cnorthrop@google.com
Change-Id: If48fd51ba96e71909d3be086667bfc73fdd32a0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782377
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0c9f22d3

Compression of the data from vkGetPipelineCacheData. · 1fb7f648

authored Mar 18, 2021

The size of pipelineCacheData sometimes is greater than
64k which cannot be saved because of the Android blob cache
limitation (single cache data size should be < 64k).
Implement the compression to store more cache data.

Re-land this patch before fixing the performance regression
of big pipeline cache.

Bug: angleproject:4722
Change-Id: I4bc05a88334c3e7e9e945d1a0877429db1750422
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2771840
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1fb7f648

Vulkan: Fix gl_SamplePosition XY-flip and rotation. · 9f796506

authored Mar 23, 2021

In multi sample scenario, gl_SamplePosition is not
handled with XY-flip and rotation, add codes for
flip and rotation.

Bug: angleproject:5637
Test: dEQP-GLES31.functional.shaders.multisample_interpolation.
      interpolate_at_offset.at_sample_position.default_framebuffer
      --deqp-gl-config-name=rgba8888d24s8ms4
Test: dEQP-GLES31.functional.shaders.sample_variables.sample_pos.
      correctness.default_framebuffer
      --deqp-gl-config-name=rgba8888d24s8ms4
Change-Id: I7ba2227e85c62d2ca7bf534a841a1c3a5c9beb5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2781124Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9f796506

[Fuchsia] Add ifndefs to vulkan_fuchsia_ext.h · 3fd439c2

authored Mar 23, 2021

This allows chromium to build with upstream headers that
include these extension. The old TEMP enums and structure
types are used until drivers have been updated to support
upstream header values.

Bug: chromium:1191605
Change-Id: I25d2991204ca34956298013138af8f48e0aaefaf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2782765
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

3fd439c2

23 Mar, 2021 11 commits

Vulkan: Use VK_EXT_multisampled_render_to_single_sampled · d1462228

authored Mar 09, 2021

Additionally, makes the emulation path not require
independentResolveNone.  This was only used to select the NONE resolve
mode when the attachment format doesn't have either of depth or stencil
aspects, but it's ok to specify the same resolve mode for both aspects
even if one aspect is missing.

Bug: chromium:1088005
Change-Id: Ifc37cbf5331145179c5927853b996a0d62b871ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743666Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d1462228

Update ANGLEWrangling.md with Hotlist-Wrangler · c4da42e1

authored Mar 22, 2021

Bug: angleproject:5782
Change-Id: I6f808e6ece97dbc0166ba8f60b0cc31e783165a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779393
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c4da42e1

Enable D3D11 debug names in ANGLE release builds · d809147f

authored Mar 22, 2021

Previously, D3D11 debug names were only output in debug builds. This
change enables them in release builds so we can debug GPU memory
consumption given traces or full memory dumps.

Where it made sense, existing names were shortened for brevity.
A future CL can shorten the names further by removing the words
texture, SRV, DSV, etc since D3D already outputs this type
information.

Bug: chromium:1164111
Change-Id: Iadd6222c29dd945115e844ec28ee395ce16c139f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780564
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d809147f

Disable timestamp queries for Mali-G31 and older GPUs · 90e3d86c

authored Mar 22, 2021

Bug: chromium:1178333
Change-Id: I8f21cd1c8f815a5cd7344778d2d1b28710dc6763
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779211Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

90e3d86c

Revert "Save/Load missing members" · 2a43f43a

authored Mar 23, 2021

This reverts commit b2e76cf5.

Reason for revert: Causing MSan failures on Linux. See bug.

Bug: chromium:1191344

Original change's description:
> Save/Load missing members
>
> There are several class/struct members that are missing when a program
> is serialized/deserialized. This leads to errors when attempting to link
> programs that have been deserialized. For example, when drawing with a
> PPO that contains programs which were created with glProgramBinary().
>
> This CL adds saving/loading the missing members.
>
> Bug: b/182409935
> Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Cody Northrop <cnorthrop@google.com>

Bug: b/182409935
Change-Id: I1209257ed6bb55ba2d01d92bd3305d5e3ad6ee28
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780015Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2a43f43a

Vulkan: Rename Uniforms/XFB descriptor desc. · 572fd801

authored Mar 22, 2021

The new name is more consistent with the other names.

Refactoring change only.

Bug: angleproject:5736
Change-Id: Idc47fef29040e3a422267795c4536163a6f8eb4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779953Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

572fd801

Roll Chromium from 3eced2421f5a to f1617b736428 (473 revisions) · e6ca472b

authored Mar 23, 2021

https://chromium.googlesource.com/chromium/src.git/+log/3eced2421f5a..f1617b736428

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/120a8d610c..b43166a3d1
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f13f2e366c..a9cb74b2b5
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de74236cf7
* tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e
* tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e
* tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e
* tools/skia_goldctl/linux: PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC..PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC
* tools/skia_goldctl/mac: Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC..rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC
* tools/skia_goldctl/win: 3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC..bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC
No update to Clang.

Bug: angleproject:5768
Tbr: cnorthrop@google.com
Change-Id: I82f74de7812ba075f6c3cd9fa0b4d724df876669
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779806
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e6ca472b

Tests: Add Real Cricket 20 trace · 48560f67

authored Mar 19, 2021

Test: angle_perftests --gtest_filter="*real_cricket_20*"
Bug: b/183165790
Bug: angleproject:5777
Change-Id: I1f350e3ea458a599396412e2c5ca80d6c7887d73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776554
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

48560f67

Fix copyright dates of new test files per Shabi · c4b1f366

authored Mar 22, 2021

Bug: b/181711029
Change-Id: Ie619ba90f699dd8234cf185198cb6eeac9142758
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780560Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

c4b1f366

Vulkan: Add test for filament gltf usage case · ef17c650

authored Mar 08, 2021

filament gltf sample code is rendering to a level that is excluded from
[base_level, max_level]. This is allowed by OpenGL spec. We are crashing
right not. This CL adds tests for the exact usage pattern for filament.

Bug: b/181800403
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBeyondMaxLevel
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel
Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD
Change-Id: I69bab8bc3961bbc2dcc78ba2db3c8759f277416b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752897
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ef17c650

Save/Load missing members · b2e76cf5

authored Mar 17, 2021

There are several class/struct members that are missing when a program
is serialized/deserialized. This leads to errors when attempting to link
programs that have been deserialized. For example, when drawing with a
PPO that contains programs which were created with glProgramBinary().

This CL adds saving/loading the missing members.

Bug: b/182409935
Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

b2e76cf5

22 Mar, 2021 9 commits

Tests: Add android log library to traces · 4386840c

authored Mar 19, 2021

This is required in order to call __android_log_print, which can
be sprinkled into the trace for debugging.

Bug: b/183165790
Change-Id: I717f2ac7809172f22b7badee6f1096394a02bc14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776553Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

4386840c

Reorder ShaderVariable functions and members · 34e28778

authored Mar 17, 2021

ShaderVariable's functions and members are all mixed up. This CL
reorders things to move the functions before the members, to better
match ANGLE's coding style.

This also adds a note that any new members that are added need to be
added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are
actually implemented in Program.cpp, since ShaderVars.h/cpp can't
include libANGLE/BinaryStream.h. There are currently several members
that are missing, leading to save/load errors, which are fixed in a
follow-on CL in this chain.

Bug: b/182409935
Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

34e28778

Handle inactive structure type varyings correctly · 2be71410

authored Mar 19, 2021

Correctly handle inactive varyings of structure type when collecting
transform feedback varyings. Previously, all varyings of structure type
were marked as active by mistake.

Bug: angleproject:5557
Test: TransformFeedbackTest.InactiveStructureVarying*
Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2be71410

Vulkan: Handle compilation error involving gl_InvocationID · 570970f9

authored Mar 19, 2021

We need to generate a compiler error only when the vertex index
of an output variable as an l-value, in a tessellation control shader,
is not the indentifier gl_InvocationID.

Bug: angleproject:5557
Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier
Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

570970f9

Vulkan: Rename onImageHelperRelease to finalizeImageLayout · 81432c24

authored Mar 19, 2021

Make the API name reflect what it does. With recent changes, this get
called from places that are not releasing ImageHelper object, but is try
to reference the current layout. This new name makes more sense than
onImageHelperRelease (at that time when this API was introduced, it was
only called when ImageHelper is being released).

Bug: b/175584609
Change-Id: Ie5f5fcdbd97436724d7eb016374d8b4178e7ba1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776261
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

81432c24

Vulkan: More cleanups to perf counters. · 02acc5ee

authored Mar 18, 2021

This refactors the pipeline type in the ContextVk class to also use
a packed enum map. It also expands the object perf counters to store
both a specific and cumulative version for use in different cases.

Bug: angleproject:5736
Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

02acc5ee

Tests: Add Avakin Life - 3D Virtual World trace · ecbd870f

authored Mar 21, 2021

Test: angle_perftest --gtest_filter="*avakin_life*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/183344915
Bug: angleproject:5779
Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

ecbd870f

Skip ResizeWindow test on Linux. · 0380f115

authored Mar 18, 2021

ARM Linux doesn't support window surface resize.

Bug: angleproject:4453
Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

0380f115

Vulkan: Don't acquire new BufferHelper for external buffers · 7fe44a53

authored Mar 20, 2021

EXT_external_buffer spec -
    This extension allows the data store for an immutable buffer to be
    sourced from an external EGLClientBuffer, allowing sharing of EGL
    client buffers across APIs, across processes, and across different
    processing cores such as the GPU, CPU, and DSP.

The intent is for a single backing memory to be reused across various
processes and processors. Ensure that a glBuffer backed by external
memory does not orphan the memory when glBuffer APIs like
glBufferSubData or glMapBufferRangeEXT modify the glBuffer.

Bug: angleproject:4380
Bug: angleproject:5073
Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan
Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7fe44a53