Commits · d80d9044857e168bb7945eb726a451c20140b80c · Chen Yisong / angle

09 Jun, 2020 13 commits

Reland "Add trace event to angle Program compilation API" · d80d9044

authored Jun 08, 2020

This reverts commit be04c047.

Reason for revert: The appropriate fix for ASAN is landed here:
  https://chromium-review.googlesource.com/
     c/angle/angle/+/2233410

Original change's description:
> Revert "Add trace event to angle Program compilation API"
>
> This reverts commit 7685a79e.
>
> Reason for revert: Causing TSAN failures, see issue.
>
> Bug: chromium:1091723
>
> Original change's description:
> > Add trace event to angle Program compilation API
> >
> > Bug: chromium:1064662
> > Change-Id: I2ee48718ff3946ab9307ba27177a02858bf436b0
> > Reviewed-on: https://chromium-review.googlesource.com/
c/angle/angle/+/2230789
> > Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
>
> TBR=etienneb@chromium.org,jmadill@chromium.org
>
> Change-Id: I92148677ac53c1ff7a9bc880e0a0834a03fc92ea
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1064662
> Reviewed-on: https://chromium-review.googlesource.com/
c/angle/angle/+/2231870
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=etienneb@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1091723, chromium:1064662
Change-Id: I6e2ccfcb29fcddc5e0bffee43d3a737c8a6a75ea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2235915
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>

d80d9044

Update glslang_validator binary for Windows. · f56e7227

authored Jun 09, 2020

This binary was updated using update_glslang_binary.py.
Please see instructions in tools/glslang/README.md.

Bug: None
Change-Id: I5949749ed704f55ecc8ef65789d665b1e8cf7af6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2238388Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f56e7227

Fix racy GetCategory with trace_event · f8fd9cfb

authored Jun 09, 2020

See racy trace_event:
  http://crbug.com/1091723

The trace event macros were racy because of this code:
  INTERNAL_TRACE_EVENT_GET_CATEGORY_INFO(...)
The macro is using a static variable which is not thread-safe.
The design of tracing was racy (by design) and rely on
the fact that addTraceEvent(...) is threadsafe internally via
TraceLog::lock_

This CL is replacing the static variable with a scope (C++11)
pattern. The static variable is guaranted (C++) to be atomic
and it is implemented efficiently.

see: §6.7 [stmt.dcl] p4
   " If control enters the declaration concurrently while the
     variable is being initialized, the concurrent execution
     shall wait for completion of the initialization. "

Bug to track follow-up migration:
  http://anglebug.com/4702

Bug: chromium:1091259, chromium:1091723
Change-Id: If67b501e6e826ccf603eb2349c3f0aa6272c9a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233410
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f8fd9cfb

Remove missing script from angle.gni test config. · 86a45a1a

authored Jun 09, 2020

Was from a subsequent CL. For some reason this was only picked up
on the ANGLE roll into Chrome.

Bug: angleproject:3162
Change-Id: I6c9d4ab3843bd5a58a6695b79648b57343689c4d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2236759Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

86a45a1a

Capture/Replay: Support buffer map/unmap state during MEC · 22c95964

authored Jun 04, 2020

Angry Birds 2 is the first app we've targeted that maps buffers
across frame boundaries.  This exposed some gaps and assumptions
we had in the code, and required additional support for MEC.

To support this, we track each buffer's starting map/unmap state
and how it changes throughout the trace.  Then during Reset, we emit
calls to return them to the correct state:

void ResetContext3Replay()
{
    ...
    glBindBuffer(GL_ARRAY_BUFFER, gBufferMap[546]);
    glUnmapBuffer(GL_ARRAY_BUFFER);
    glBindBuffer(GL_ARRAY_BUFFER, gBufferMap[550]);
    gMappedBufferData[gBufferMap[550]] =
        glMapBufferRange(GL_ARRAY_BUFFER, 0, 8192, GL_MAP_WRITE_BIT);
    ...
}

Test: MEC of Angry Birds 2
Bug: angleproject:4599
Bug: b/157672184
Change-Id: I5c73ca4d4eba7f1ecea01467ae887bae7f2d27fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231803
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

22c95964

Fix failures that alpha channel is not correct · 5abc0c56

authored Jun 09, 2020

Previously, the alpha channel was not set which resulted the intended
swapchain buffer format is B8G8R8X8_UNORM. It means that the format
supports 8 bits for each color channel and 8 bits unused. However, in
our test case, we expect to compare the alpha channel. So we should
set alpha channel explicitly.

Bug: angleproject:4575
Bug: angleproject:4576
Change-Id: Ic26ee81a6a34dc44d0ae32e3dc463e9afa16e05c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237189
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5abc0c56

Roll glslang from 8111268575a4 to 08328fea5ab9 (1 revision) · 74b33834

authored Jun 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8111268575a4..08328fea5ab9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I82c97aefcfe63d8b09119d8a4c6bd6dec0e48db3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237237Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

74b33834

Roll Vulkan-Headers from db1a98c6cc43 to 9d2dfca53b75 (1 revision) · c4004a93

authored Jun 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/db1a98c6cc43..9d2dfca53b75

2020-06-08 oddhack@sonic.net Update for Vulkan-Docs 1.2.143

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I8255d01829fba9fab643a76693503e5a0242de20
Bug: None
Tbr: cnorthrop@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237188Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c4004a93

Roll Vulkan-ValidationLayers from f1b11cc29c58 to 236f1f090429 (2 revisions) · 4159e75f

authored Jun 09, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f1b11cc29c58..236f1f090429

2020-06-08 marcin.slusarz@intel.com build: detect missing SPIRV_HEADERS_INSTALL_DIR at cmake time
2020-06-08 marcin.slusarz@intel.com build: SPIRV-Tools and glsllang are 2 separate projects

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I12cfe46fcfbb3327f02f2c9f2f9a7f122e6dc424
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2237227Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4159e75f

Update glslang_validator binary for Linux. · 8a7b3d61

authored Jun 08, 2020

This binary was updated using update_glslang_binary.py.
Please see instructions in tools/glslang/README.md.

Bug: None
Change-Id: I1aed97de25baa3cb47ae81b63a70339a962d957d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2235361Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8a7b3d61

Add texture base-level related tests · dbb18b53

authored Jun 05, 2020

Bug: angleproject:4695
Bug: angleproject:4696
Bug: angleproject:4698
Bug: angleproject:4699
Bug: angleproject:4701
Change-Id: Ia49e2100851c029b1ae05bc1398528170d71c3cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233402
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

dbb18b53

Unmap buffers targeted by glBufferData · 5d7014e4

authored Jun 05, 2020

When glBufferData is called on a mapped buffer, per the OpenGL ES 3.0
spec it is implicitly unmapped. Later calls to glMapBufferRange should
not throw an error.

This CL unmaps the buffer in BufferData if it is already mapped.
Also adds a new test that verfies the behavior.

Test: angle_end2end_tests --gtest_filter=BufferDataTestES3.BufferDataUnmap/*
Test: Angry Birds 2 MEC
Bug: angleproject:4599
Bug: b/157672184
Change-Id: I1a1e458aa5f50da4dfde9f6847f71cd5b6f6c08a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233365
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Manh Nguyen <nguyenmh@google.com>

5d7014e4

Capture/Replay: Don't assert when reading combined depth/stencil · 15328f69

authored Jun 04, 2020

We can't actually read them back at the moment, so this needs a proper
fix. In the meantime, the apps we are tracking don't need this value at
the beginning of the trace.

Test: Angry Birds 2 MEC
Bug: angleproject:3662
Bug: angleproject:4688
Bug: b/157672184
Change-Id: I67190092bcce7080edc69714f1ca1194c37d54fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231802Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

15328f69

08 Jun, 2020 11 commits

Perf: Ensure last frame is replayed for traces · 4360c6b9

authored Jun 04, 2020

This is now required for upcoming buffer mapping resets.

Test: Angry Birds 2 MEC
Bug: b/157672184
Change-Id: I6358acf42ca9b92bfff621f12f207be7c3655e52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231801Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

4360c6b9

Fix ExceedMaxVertexAtomicCounters test crash with FrameCapture · 66ec30a7

authored Jun 03, 2020

The AtomicCounterBufferTest31.ExceedMaxVertexAtomicCounters crash is
because when program linking fails, as it should for this test, the
code tries to get the info log by calling glGetProgramInfoLog. The
FrameCapture capturing this call currently tries to make sure that the
program is linked. However, glGetProgramInfoLog does not require the
program to be linked to execute.

Bug: angleproject:4679
Change-Id: Ibbb87d6437152e9eb225e411100b1729e56e4c4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227857Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

66ec30a7

Implement EGL_CreatePlatformWindowSurface() · 97bb5a64

authored Jun 04, 2020

The function EGL_CreatePlatformWindowSurface() was introduced by EGL
1.5 and is required by dEQP starting with 3.2.6. ANGLE has worked
around EGL_CreatePlatformWindowSurface() being unimplemented by
submitting conformance on 3.2.5, but Android's internal master uses
ToT dEQP so we need to implement this to pass CTS and enable SWANGLE
on CuttleFish.

Bug: b/157670307
Test: Android CtsDeqpTestCases, CQ
Change-Id: Ib21929701c7881a7dc3a22196e48139a5c8e2ddf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231247Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

97bb5a64

doc: Update CONTRIBUTORS · df2caf5c

authored Jun 08, 2020

Added a number of names that were missing from CONTRIBUTORS.

Bug: angleproject:1944
Change-Id: I5e8e2d13494b5ded7dec7a094218e4aef90d9da3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2235931Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

df2caf5c

Fix copy texture to sRGB in ANGLE/VK · 111a4d97

authored Jun 05, 2020

Like the GL backend, use the CPU copy path rather than the draw path
when the target is sRGB.

Fixes the following WebGL tests:
conformance2/textures/canvas/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html
conformance2/textures/canvas/tex-2d-srgb8-rgb-unsigned_byte.html
conformance2/textures/image_bitmap_from_canvas/tex-2d-srgb8_alpha8-rgba-unsigned_byte.html
conformance2/textures/image_bitmap_from_canvas/tex-2d-srgb8-rgb-unsigned_byte.html

Re-enable CopyTextureTestES3.ES3UnormFormats for Vulkan as they now pass
with this change.

Bug: b/157934810
Bug: angleproject:4092
Change-Id: I6b76e5f4345d204a084f5483e206c5bb4ff2f139
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233405Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>

111a4d97

Build both standalone and Chromium gTest targets. · 8e2b4fef

authored Jun 03, 2020

This will let us pick the standalone test version when trying out
the new test runner.

GN-only change.

Bug: angleproject:3162
Change-Id: I08c75c7a38aaf63c5a25cc8623eb05615cc29abb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2229068
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

8e2b4fef

Workaround broken copyTexImage2D on iOS · 336e8915

authored May 29, 2020

Use BlitGL to reimplement copyTex[Sub]Image2D on iOS.

Bug: angleproject:4674
Change-Id: Ie3018d6d33da57797162922410f76557124df4b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2222718
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

336e8915

Vulkan: Don't invalidate index buffers on vertex change. · 4038679a

authored Jun 05, 2020

The vertex state should not affect index state changes. Split off
from a larger CL.

Bug: angleproject:4622
Change-Id: Ie7c3148a16b5da89b79d95e1de130a1ff0e6c634
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233404Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

4038679a

Fix assertion when running tests without suffix on Windows · e9a0cb87

authored May 18, 2020

On Windows, we may omit suffix ".exe" when running an executable.
However, this will trigger an assertion failure in current code and this
CL is to fix this issue.

Bug: angleproject:4640
Change-Id: I7edfdc0b4a7c590c874817530b19a812018b9288
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2206425
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

e9a0cb87

Roll SPIRV-Tools from 74130f2d3ab1 to 7c213720bb46 (4 revisions) · 3e1a57b8

authored Jun 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/74130f2d3ab1..7c213720bb46

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I38a79fa12858807ac7b11be687e90d2b294c9a57
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2234959Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3e1a57b8

Roll Vulkan-Tools from 5b40c4aa0dba to 9d7880c7a075 (1 revision) · 38e96a12

authored Jun 08, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/5b40c4aa0dba..9d7880c7a075

2020-06-05 tobine@google.com icd: Cleanup supported VK API version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I66549c03ce27152541b9119305287de74f9d2c17
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2234960Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

38e96a12

06 Jun, 2020 3 commits

Vulkan: Remove non-triggering validation error suppression · d80adf4e

authored Jun 03, 2020

Bug: angleproject:4510
Change-Id: I04f989943ec2abe17cfe90f32a276e20c5a42cea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2227811Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d80adf4e

Vulkan: Add test for RT created from mip-incomplete texture · 6fad384b

authored Jun 04, 2020

The Vulkan backend creates an image with 3 mips, while it should only
create one with a single mip.

Bug: angleproject:4686
Change-Id: Ide7f9612c9440bfb9d9650637f6a1ad42be61208
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230797Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

6fad384b

Roll Vulkan-ValidationLayers from 4685ffce93ad to f1b11cc29c58 (7 revisions) · a8970861

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4685ffce93ad..f1b11cc29c58

2020-06-04 s.fricke@samsung.com tests: Validate VK_KHR_multiview features
2020-06-04 s.fricke@samsung.com layers: Validate VK_KHR_multiview features
2020-06-04 tony@lunarg.com gpu: Record destroy of buffers and devices
2020-06-04 mark@lunarg.com tests: Leave handle wrapping enabled at all times
2020-06-04 s.fricke@samsung.com layers: Label VUID 01386 and fix log messages
2020-06-04 s.fricke@samsung.com tests: Add YCbCr BufferImageCopy VUID
2020-06-04 s.fricke@samsung.com layers: Add YCbCr BufferImageCopy VUID

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I18a190951f7517723b499032f6a9fb904e9e673f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232221Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a8970861

05 Jun, 2020 13 commits

Vulkan: Zero-init ContextVk dirty bit handlers. · 6b946a7b

authored Jun 05, 2020

This allows for a better debugging experience and can solve some
potential invalid ASSERTs due to some dirty bit handlers not being
initialized.

Bug: angleproject:4622
Change-Id: Ib34e35dea6c6c7de250ae6600576f0324c150ae6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233403
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6b946a7b

GL: Work around drivers that generate mipmaps in linear color space · 60803838

authored May 20, 2020

Mac drivers generate mipmaps in linear color space. To work around
this, copy the sRGB texture to a linear texture, generate mipmaps
and then copy back.

TEST=conformance2/textures/misc/tex-srgb-mipmap.html

BUG=angleproject:4646

Change-Id: I8675d0ab004bcd2985f685d64cbb84deff5f1c86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2211083Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

60803838

Make GLES 1 tests use ANGLE EGL headers. · 9fa671d5

authored Jun 05, 2020

This will allow us to more easily support a different test target
topology for the standalone test harness that uses an intermediate
source_set. Also it's better in the long run to only have to worry
about one set of EGL headers.

Bug: angleproject:3162
Change-Id: I738dbb68df1abc0c0569748e18d6826914d90a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233399Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9fa671d5

Skip MultisampledBGRAToRGBA, MultisampledRGBAToBGRA tests on Vulkan · 925d1e7b

authored Jun 05, 2020

VVL report VUID-vkCmdResolveImage-srcImage-01386 in these two.

Bug: angleproject:4694
Change-Id: I4a4af598cfa77af18ccf6e322cde92749cb9ad70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2233401Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

925d1e7b

Vulkan: Pass API version to VMA. · 17b4a877

authored May 26, 2020

This apparently can save on memory usage in the allocator.

Reported by penghuang@chromium.org.

Bug: angleproject:4685
Change-Id: I6f29280e3fe16f3388c4f8412e0acb09d7f16e58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216714Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

17b4a877

Fix FramebufferVk::getScissoredRenderArea() for pre-rotation · a91dcb62

authored Jun 05, 2020

This fixes cases where pre-rotation wasn't occuring for small scissors
used with glClear().  There are around 1000 tests that do this.

Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_fragment_ops_depth_stencil_*
Bug: angleproject:4431
Bug: b/157933235
Bug: b/157933198
Change-Id: I469d51975e3bc3a7bfc9521a3817c919e809f7dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2228211Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

a91dcb62

Reduce dependency on ProgramExecutable::mProgram[Pipeline]State · 77851053

authored May 26, 2020

Remove the dependency on mProgramState/mProgramPipelineState for the
following functions in ProgramExecutable:

hasUniformBuffers()
hasStorageBuffers()
hasAtomicCounterBuffers()
hasTransformFeedbackOutput()
getTransformFeedbackBufferCount()

The data structures those function were querying were recently moved
into the ProgramExecutable, so the call stack was:
ProgramExecutable -> ProgramState -> ProgramExecutable

This change updates the functions to return the results immediately.

Remaining functions to be cleaned up in later CLs:

hasDefaultUniforms()
hasTextures()
hasImages()

Bug: angleproject:4520
Test: Build/CQ
Change-Id: Ieaa041ff128e389f322745d55f688d4b07a5a23d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216764Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

77851053

Fill in missing GL methods for MemorySizeTest · 550bc069

authored Jun 03, 2020

Implements captures of glGetRenderbufferParameteriv,
glGetBufferParameteriv, and glgetAttachedShader. Fix FrameCapture and
CaptureReplay sample so that it has single-frame capture and replay
capabilities.

Bug: angleproject:4681
Bug: angleproject:4682
Change-Id: I12c25a3857a88f2f40b3c3e8624da1379a950339
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2229069Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Manh Nguyen <nguyenmh@google.com>

550bc069

Revert "Add trace event to angle Program compilation API" · be04c047

authored Jun 05, 2020

This reverts commit 7685a79e.

Reason for revert: Causing TSAN failures, see issue.

Bug: chromium:1091723

Original change's description:
> Add trace event to angle Program compilation API
> 
> Bug: chromium:1064662
> Change-Id: I2ee48718ff3946ab9307ba27177a02858bf436b0
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2230789
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=etienneb@chromium.org,jmadill@chromium.org

Change-Id: I92148677ac53c1ff7a9bc880e0a0834a03fc92ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1064662
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231870Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

be04c047

Fix UtilsVk::clearFramebuffer() for pre-rotation · ae9d1227

authored Jun 04, 2020

This fixes cases where pre-rotation wasn't occuring when glClear() was
implemented by a small shader.  A specialized viewport was generated
(thus, not with ContextVk::updateViewport()) for the entire
framebuffer.  However, the framebuffer width and height were not
swapped for 90/270-degree rotation cases, and so the wrong viewport.y
value was calculated.

Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_color_clear*
Bug: b/157933235
Bug: b/157933198
Change-Id: I1ac158c84ef812c8863dee01c6c8bfe9295b900e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2231597Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

ae9d1227

Roll VK-GL-CTS from 80dc8399b063 to a60f89ffcba2 (8 revisions) · eef10995

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/80dc8399b063..a60f89ffcba2

2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master
2020-06-04 ari.suonpaa@siru.fi Test multiple fragment output locations
2020-06-04 rgarcia@igalia.com Try spec constants with more sizes and packing
2020-06-04 pawel.ksiezopolski@mobica.com Add tests for VK_EXT_filter_cubic
2020-06-04 pdaniell@nvidia.com Fix VkPhysicalDeviceMemoryBudgetPropertiesEXT
2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master
2020-06-04 dcastagna@google.com Fix compilation on clang 11
2020-06-04 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/master

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: I882e93a2b23ad3d42e7684f484bf9c30a5585805
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232182Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eef10995

Roll SwiftShader from 0711869b5f20 to e3eb327e8c3c (1 revision) · 6dfa959b

authored Jun 05, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/0711869b5f20..e3eb327e8c3c

2020-06-05 caio.oliveira@intel.com Convert Vulkan headers from CRLF to LF endings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Id6e28b1cfb3a6acc40ce2767ff1d596e81e74856
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232224Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6dfa959b

Roll Vulkan-Tools from 322784a873be to 5b40c4aa0dba (1 revision) · d3552246

authored Jun 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/322784a873be..5b40c4aa0dba

2020-06-04 tobine@google.com icd:Correctly Support Vulkan 1.1

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie781511cd2b3bdf126fe6aa5c9604b92abdeff0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2232223Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d3552246