The validation previously checked that two matrices in compound
multiplication are the exact same size, which isn't correct for
non-square matrices introduced in ESSL 3.00.

Instead, check that the matrix multiplication is valid and that the
resulting value has the same number of columns as the lvalue. The
number of rows in the result is taken from the lvalue so it doesn't
need to be checked.

BUG=angleproject:1431
TEST=angle_unittests

Change-Id: I6f32b7dc037d72c3c5cfdfffcda5d996e8450283
Reviewed-on: https://chromium-review.googlesource.com/356411Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This is more accurate, and doesn't break platforms with no pkgconfig,
e.g. Android.

BUG=angleproject:1297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_rel;tryserver.chromium.android:android_compile_dbg

Change-Id: Iafbd66a5e81467d2a5431c3bb1ddd26a837888e7
Reviewed-on: https://chromium-review.googlesource.com/356481Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Simply using the ReadPixels code paths to unpack the framebuffer into a texture
was insufficient for handling cases like LUMA or RGB textures that are emulated
with RGBA textures in D3D11.  Instead, read the framebuffer's data into a
buffer and then use the loading functions which are aware of the emulated
formats to write the data to the destionation.

Fix LUMA format structure's logic for reading colors.  They aren't supposed
to do any averaging logic.

BUG=angleproject:1095
BUG=483282

Change-Id: Iad91d193d4c824573d9e9cafd28cf456d2de8be5
Reviewed-on: https://chromium-review.googlesource.com/354482Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

TEST=deqp/functional/gles3/negativetextureapi.html

BUG=483282

Change-Id: Ifd9674c2d29dc7e3a5e620b7a043cdb38a923ca0
Reviewed-on: https://chromium-review.googlesource.com/356680Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Blit11 refactorings enable re-using some code for multisample resolve
blits. Also some Renderer11 refactorings to use TextureHelper11 make
the code more flexible for the multisample resolve, to come later.

BUG=angleproject:1246

Change-Id: Id0c168cef75b0f487cb3995a906f6473989edcd5
Reviewed-on: https://chromium-review.googlesource.com/354420Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Transform feedback varyings that were optimized out were still being unpacked
causing HLSL compilation failures.

This was triggering failures in the conformance2/state/gl-object-get-calls.html
test.

BUG=angleproject:1422

Change-Id: I297cccd5b99435dfb69a3c2b0fd3086b6ddf0b3a
Reviewed-on: https://chromium-review.googlesource.com/354590Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

It's acceptable to have the same object attached to muliple framebuffer
attachments if they are not being drawn to.

This was triggering failures in the conformance2/state/gl-object-get-calls.html
test.

BUG=483282

Change-Id: If088ccd9b1189f060dfa33ebbe4d82f1f47559b0
Reviewed-on: https://chromium-review.googlesource.com/354570Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Due to Adreno compilation failure of two arrays in single line declaration.

BUG=angleproject:1428
TEST=GLSLTest_ES3.InitGlobalArrayWithArrayIndexing

Change-Id: I05d7c6b3a0eef8c879edf4d9cf24cdec0a2a403c
Reviewed-on: https://chromium-review.googlesource.com/356217Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Don't assume bucket name to start with 'master.'.

NOTRY=True
BUG=chromium:617627

Change-Id: I4e634fd2f485ac06c8e06af2de0cd86dbf425e9b
Reviewed-on: https://chromium-review.googlesource.com/355990Reviewed-by: Jamie Madill <jmadill@chromium.org>

Pick up ozone source when use_ozone = true.
Don't link X11 unless use_x11 = true.

BUG=angleproject:1297
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_chromeos_rel

Change-Id: I94e6242189646c8a18b00436294bccdd4c5a8785
Reviewed-on: https://chromium-review.googlesource.com/352251Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

BUG=angleproject:1421

Change-Id: I08f0fa5f178c8d25cd2b02e75cf92759254aa918
Reviewed-on: https://chromium-review.googlesource.com/355020Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Due to Adreno bug in GL_HALF_FLOAT support

BUG=angleproject:1420
TEST=Texture2DTestES3.TextureLuminance16ImplicitAlpha1

Change-Id: Id9bc12da21048a557325f076202ec482675320e3
Reviewed-on: https://chromium-review.googlesource.com/354782Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Cast the second parameter of eglGetPlatformDisplayEXT() to the correct
type to stop compiler complaining.

BUG=angleproject:1297

Change-Id: I37260edbd0fb6b92c24b556b15ea8206295e12d4
Reviewed-on: https://chromium-review.googlesource.com/354740Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Check for null pointers so DisplayOzone::terminate() doesn't crash when
DisplayOzone::initialize() wasn't completely successful.

BUG=angleproject:1419

Change-Id: I70e994490a7282083d5289e6c35b077676688b65
Reviewed-on: https://chromium-review.googlesource.com/354700Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Because this builtin uses a structure, certain shaders could trigger
the mangled name to be allocated during normal shader compilation.
Then when the scope is popped, the mangled name for DepthRange is
freed, and we're left with a dangling pointer.

Fix this temporarily by enforcing mangled name construction when
we initialize the builtins, but we should look for a more robust and
future-proof fix.

BUG=620937

Change-Id: If130c8b48a18054502abaec08f10264f282b4925
Reviewed-on: https://chromium-review.googlesource.com/354494Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

mbstowcs needs stdlib.h header on mipsel

BUG=

Change-Id: Ia93d0a877b2e22d5c1c461f0dea9999ede725520
Reviewed-on: https://chromium-review.googlesource.com/354020Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit 13511a9c.

Change-Id: Ic5a91d14b59204c5667940797742bc55a137f177
Reviewed-on: https://chromium-review.googlesource.com/354706Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

Add tryserver.chromium.linux:linux_chromium_gn_chromeos_rel to ANGLE CQ
to build test with use_ozone=1.

BUG=angleproject:1412

Change-Id: Ib4e851b95f7cfbb7099b531affccd14f08418725
Reviewed-on: https://chromium-review.googlesource.com/352318Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

BUG=621932
R=cwallez@chromium.org

Change-Id: I10b0fd5a668d74b7062747002bc48ef0e0a6df9c
Reviewed-on: https://chromium-review.googlesource.com/354302Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1418
BUG=angleproject:1340

Change-Id: I8930845a2d398440a78b2569daaf655b51a30ee9
Reviewed-on: https://chromium-review.googlesource.com/354261Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=None

Change-Id: I3e2e7e845e9ad3814f7d85e56c12023a5e2ef0df
Reviewed-on: https://chromium-review.googlesource.com/354104Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1382

Change-Id: I63925fb7eeff2bdab26c1e541afd9cd1851485e6
Reviewed-on: https://chromium-review.googlesource.com/354083Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

https://android.googlesource.com/platform/external/deqp/+log/cc0ded6c77267b..f4f3d8079e7a37d7

BUG=None

Change-Id: I863f81d2c4c3f48862cb821b23c38266987a82a2
Reviewed-on: https://chromium-review.googlesource.com/340260Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1416
TEST=conformance/extention/ in core profile
R=jmadill@chromium.org,geofflang@chromium.org,cwallez@chromium.org

Change-Id: I89b815929535586a2e90489129a1c6692bb87b3c
Reviewed-on: https://chromium-review.googlesource.com/353820
Tryjob-Request: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>

BUG=angleproject:1382

Change-Id: I9fd6e20b9487f9d7817865bc9129a60fc833d0ca
Reviewed-on: https://chromium-review.googlesource.com/354030Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1382

Change-Id: I586cd4a03d06a6ec87b6a57342b7f8d0ed0d9cd8
Reviewed-on: https://chromium-review.googlesource.com/354031Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1092
BUG=angleproject:1095
BUG=angleproject:1323

Change-Id: I58550f841febbfdf45133707f72e7f3a62b20a1c
Reviewed-on: https://chromium-review.googlesource.com/353343
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1388

Change-Id: I4d346ca3c6914e56055aa6492d9d013634a1b9ad
Reviewed-on: https://chromium-review.googlesource.com/353693Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This is partial support for CHROMIUM_path_rendering
and implements basic path management and non-instanced
rendering.

BUG=angleproject:1382

Change-Id: I9c0e88183e0a915d522889323933439d25b45b5f
Reviewed-on: https://chromium-review.googlesource.com/348630Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Change-Id: I791fd7c4e145c37d0173e23cf57f937f802c26ea
Reviewed-on: https://chromium-review.googlesource.com/353701Reviewed-by: Sami Väisänen <svaisanen@nvidia.com>
Commit-Queue: Sami Väisänen <svaisanen@nvidia.com>

Due to either Adreno bug in glBufferSubData,
or generic Android bug in ANativeWindow_setBuffersGeometry.

BUG=angleproject:1415
TEST=ReadPixelsPBOTest.SubDataOffsetPreservesContents

Change-Id: If55f6ad4eacde98cfdbc46a61cc9fb479b779297
Reviewed-on: https://chromium-review.googlesource.com/353396Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Due to Adreno bug in glReadPixels

BUG=angleproject:1413
TEST=ReadPixelsTest.OutOfBounds

Change-Id: I2fd426bc6d21f5d9604ca32ad34dd8841cbb9a3e
Reviewed-on: https://chromium-review.googlesource.com/353363Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

We were calling the global pool allocator in the builtin function
emulator, which would lead to us freeing TTypes that were still
referenced. Fix this by using the TCache which was designed for
such a purpose, and locking the allocator around the builtin
function emulator to try and prevent similar bugs from creeping
in.

Eventually we would like to get rid of the global allocator and
replace it with different pools in different contexts, which are
managed more safely.

BUG=620937

Change-Id: If501ff6ea4d9bf8a2b8f89f2c94a01386f79ee3a
Reviewed-on: https://chromium-review.googlesource.com/353671Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

ANGLE uses a workflow where we upload stacks of dependent patches to
Gerrit. The Chromium workflow has squashed by default for a long time,
so the infra team is planning to switch to squash by default. This
change will preserve our workflow.

See http://crbug.com/611892

BUG=None

Change-Id: I62ab7a26d5bd899fbb8c48a1aced7d044640a66a
Reviewed-on: https://chromium-review.googlesource.com/353039Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

Improves performance on the render-to-texture microbenchmark
by ~3x on the OpenGL back-end. Wipes out several of the top profling
hotspots on that benchmark.

BUG=angleproject:1388

Change-Id: I6a35a0b435b2ed3c83d32acdb9df090df98214ad
Reviewed-on: https://chromium-review.googlesource.com/348957Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

This reverts commit 230d9561.

This broke GLES2ConformTest.GL2Tests_framebuffer_objects_input_run on the NVIDIA Win8 Chromium bots.

BUG=chromium:620908

Change-Id: Idf6e3eb51483ff0b6bc758b95c5910863ddfc25f
Reviewed-on: https://chromium-review.googlesource.com/353394Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: John Bauman <jbauman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

While in ESSL 3.00 invariant is allowed only for out varyings.
Verify that, and update test expectations.

BUG=angleproject:1293
TEST=GLSLTest*.Invariant*

Change-Id: I5cab6c68f2b94ea2179719119668d905fe7a9b3d
Reviewed-on: https://chromium-review.googlesource.com/352743Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Per GLSL_ES_Specification_3.00.4 paragraph 3.3 Version Declaration:
"Shaders declaring version 3.00 of the shading language
cannot be linked with shaders declaring version 1.00."

BUG=angleproject:1361
TEST=GLSLTest_ES3.VersionMismatch

Change-Id: Icee672b798dcdb41a189e4a6459c4e643daf1fa6
Reviewed-on: https://chromium-review.googlesource.com/353182Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

For some BGRA-backed formats (RGBA4, R5G6B5, RGB5A1), our ReadPixels
implementation wasn't aware the BGRA format didn't exactly match the
RGBA format. For these it would do the 'fast path' memcpy method, when
it should stop and do the slow pixel-by-pixel packing method.

BUG=angleproject:1407
BUG=chromium:616176

Change-Id: Ie24758513af6f9ef87f0aa503135456c96493701
Reviewed-on: https://chromium-review.googlesource.com/352252Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The Clear command in the draw call benchmark was not being properly
no-op'ed. This would cause the driver to get a huge queue of GL
command, which it would only flush when the test was torn down. This
manifested as a 5+ second stall on test teardown.

Looking at the clear command, it does some work with binding
and then calling GL functions, so properly filtering out the driver
commands would be a bit more complicated. For now, we can hack in a
workaround for the draw call test (the only one that uses the GL
NULL renderer at the moment) to not call clear when it would give
us problems.

BUG=620687

Change-Id: I64a2ed1883e8d3bf0d4c423c8bce0902ae9bf8df
Reviewed-on: https://chromium-review.googlesource.com/352828Reviewed-by: Geoff Lang <geofflang@chromium.org>