Commits · de62b251b73b9b582206082c0dc1748f67800bc3 · Chen Yisong / angle

30 Dec, 2020 1 commit

Make sure the queried resources are active · de62b251

authored Dec 29, 2020

In GLES 3.1 spec, sesion 7.3.1 program interfaces, it says that
'Resources referenced in shader code are considered active unless the
compiler and linker can conclusively determine that they have no
observable effect on the results produced by the executable code of the
program.'. Variables might be considered inactive if they are used only
in computations of temporary variables having no effect on any shader
output. So we should use atomicCounterIncrement instead of atomicCounter
in case the resources are marked as inactive on some platforms.

Bug: angleproject:5494
Change-Id: Ic04bd4a2936e97776fc680b5ef8273f0944d7480
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605917Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

de62b251

29 Dec, 2020 4 commits

Add build flags to disable desktop gl backend · 47ee6a7b

authored Dec 23, 2020

This change saves about 100KB on Android

Bug: angleproject:5490
Change-Id: Ieca0e597423f74a917197f381560af5409a9e874
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601341Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>

47ee6a7b

Vulkan: Make shader variable info maps a class. · 093250e0

authored Dec 23, 2020

Instead of using a map type directly we abstract the info maps into an
encapsulated class. We can enforce a specific API set instead of using
the same API as the map class. This also cleans up a few of the APIs
related to these maps.

This change will allow future changes to the way the variables are
stored in the class without drastically changing the interface.

Bug: angleproject:3572
Bug: angleproject:4524
Change-Id: Ic1a63e1776c39f49b895a1274bae8282d7a6b9b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600080
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

093250e0

[GLX] Don't request exposure events for child windows · c2847bbc

authored Dec 23, 2020

After [1], Chrome and ANGLE use separate X11 connections, so in order
for Chrome to receive exposure events, it must select for them its own
connection, which is done in [2].

The events selected by ANGLE's connection are never dispatched, so
they queue up indefinitely and leak until the connection is closed
(when happens when Chrome closes).  This change removes the request
to receive exposure events.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2492177
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2602441

Change-Id: Ie47c3700855aeeecc8efa1b379df60c344b1b70a
Bug: chromium:1158170
R=jonahr
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602705Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

c2847bbc

Roll Chromium from e02e8b371308 to aba6331a18cb (134 revisions) · 095fd1d3

authored Dec 29, 2020

https://chromium.googlesource.com/chromium/src.git/+log/e02e8b371308..aba6331a18cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ffd4756efa..7dcf5f0e82
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/cba08c42d7..767dddd781
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: jonahr@google.com
Change-Id: I1aafc49da55631bc5ade1dc673a5ac50015bc3bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2605988Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

095fd1d3

28 Dec, 2020 2 commits

Allow Drawing with Immutable Persistent Mapped Buffers · 220642a9

authored Dec 16, 2020

From the EXT_buffer_storage overview:

    The GL_EXT_texture_storage extension added immutable storage for
    texture objects (and was subsequently incorporated into OpenGL ES
    3.0). This extension further applies the concept of immutable
    storage to buffer objects.

    [T]his extension introduces the concept of persistent client
    mappings of buffer objects, which allow clients to retain pointers
    to a buffer's data store returned as the result of a mapping, and to
    issue drawing commands while those mappings are in place.

The initial implementation of EXT_buffer_storage didn't enable this
portion of the extension, so ANGLE is generating errors while attempting
to draw with an immutable buffer mapped with the GL_MAP_PERSISTENT_BIT
flag.

This CL enables that functionality, since apps (e.g., FIFA Soccer) rely
on it.

Bug: angleproject:5473
Change-Id: Icf1c0597156044a342aac5e4d2abbc29b34f46b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596957Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

220642a9

Roll Chromium from abaaee149813 to e02e8b371308 (106 revisions) · bc06d145

authored Dec 28, 2020

https://chromium.googlesource.com/chromium/src.git/+log/abaaee149813..e02e8b371308

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ff0b5c1349..ffd4756efa
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/ea9f1f7375..2277272f7a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/38dfc9d41a..cba08c42d7
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Idbdd8032cf051b2f5b8f33af16338be8d36b43e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2604769Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bc06d145

25 Dec, 2020 2 commits

Roll Chromium from 8baa5d6f121f to abaaee149813 (66 revisions) · 5e606e5b

authored Dec 25, 2020

https://chromium.googlesource.com/chromium/src.git/+log/8baa5d6f121f..abaaee149813

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/fffb44c47e..ff0b5c1349
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/f9f9a7c26e..38dfc9d41a
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ie88c73237d45dd53a0572fd4148aacbe1ce174c0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2603551Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5e606e5b

Suppress IOBlocksSeparate xfb test on AMD/Linux/GL · c6e63da8

authored Dec 24, 2020

Bug: angleproject:5487
Bug: angleproject:5493
Change-Id: I6e15c35eacafef0ac4b7c7789619470501e31402
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601345Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c6e63da8

24 Dec, 2020 5 commits

Skip TransformFeedbackTestES31.IOBlocks* on Linux AMD Vulkan · 9f0748ea

authored Dec 24, 2020

Bug: angleproject:5493
Change-Id: I5e0b0ec478807ebfe7a0ec114adaba13ea103ea0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601344Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

9f0748ea

Roll Chromium from 75537d54458b to 8baa5d6f121f (63 revisions) · 26c8aaad

authored Dec 24, 2020

https://chromium.googlesource.com/chromium/src.git/+log/75537d54458b..8baa5d6f121f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/49a440c36a..fffb44c47e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..3f5c581d3b
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ifed577c2fa17724f4629352d68fc555fa7747fb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602788Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

26c8aaad

Don't use optional BGRA_EXT by default · cde0e3ab

authored Dec 22, 2020

It's not currently exposed on iOS.

Bug: angleproject:5417
Change-Id: I2564d3363f8f8bddad4da7d8a9d7dac9bea15897
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600454Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

cde0e3ab

Skip tests using unimplemented features on iOS · 939195a0

authored Dec 23, 2020

Bug: angleproject:5485
Change-Id: I3248126060b9957596f65221c60f42f213e9a9dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601377Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

939195a0

Fix BlitFramebuffer issues with large rects on iOS · 7061af26

authored Dec 22, 2020

Enable adjustSrcDstRegionBlitFramebuffer workaround on iOS and fix
a conflict when it is enabled in combination with
clipSrcRegionBlitFramebuffer.

Bug: angleproject:5417
Change-Id: I1de0f9f392643fbcf6900bad86d83084cb6d4009
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601106Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

7061af26

23 Dec, 2020 11 commits

Code generation for NV_framebuffer_blit · 88fec1e8

authored Dec 23, 2020

Generate the entry points for NV_framebuffer_blit.

Bug: angleproject:5474
Bug: chromium:1157057
Change-Id: Iadffa24ce7368d8ab6c4bf9d5b6c016276e762f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602242Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

88fec1e8

Roll Chromium from a5e4417becc2 to 75537d54458b (114 revisions) · dd1ecbc9

authored Dec 23, 2020

https://chromium.googlesource.com/chromium/src.git/+log/a5e4417becc2..75537d54458b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/d4fcf57b4e..49a440c36a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/36d8b4b883..f9f9a7c26e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..be9a4317e5
No update to Clang.

Bug: angleproject:5390
Tbr: ynovikov@google.com,jmadill@google.com
Change-Id: I7ed34cac8bd0d669fdc05aaa5e6f82d177caa9f8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602626Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

dd1ecbc9

Android: Update adb install to include -r -d --force-queryable · e16ff968

authored Dec 23, 2020

The adb install command is being updated to include the following
options:

  -r: replace existing application
  -d: allow version code downgrade (debuggable packages only)
  --force-queryable: mark the ANGLE APK as visible to all other packages

This will allow AngleLibraries.apk to install without errors and be
loadable for apps targeting SDK >= 30.

Bug: b/175800879
Change-Id: I61bb7218b407e54057adbfb5aa3098a96b903f5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602241Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

e16ff968

iOS testing support · 0dbe7cdd

authored Dec 08, 2020

angle_white_box_tests build and runs and passes on the iOS
simulator with this change. angle_end2end_tests builds and runs but
crashes.

Bug: angleproject:4256
Bug: angleproject:5417
Change-Id: I8817e46415c4598cbfae49804727a2e9b21baff1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600361
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

0dbe7cdd

Vulkan: Support xfb capture of I/O block fields · eeb14308

authored Dec 23, 2020

In the emulation path, it's ensured that the generated code references
the I/O block field correctly (using the instance name if provided, and
without it otherwise).

In the extension path, the info map is augmented with an array of xfb
decorations for its fields.  Then when `OpDecorate %IOBlockId Block` is
encountered, the transform feedback decorations on the fields are
inserted:

    OpMemberDecorate %IOBlockId MemberN XfbBuffer buffer
    OpMemberDecorate %IOBlockId MemberN XfbStride stride
    OpMemberDecorate %IOBlockId MemberN Offset    offset

Future work includes removing the duplicate varying added for
gl_PointSize and use this mechanism to decorate gl_PerVertex directly.

Bug: angleproject:3606
Change-Id: I6fed0b1ee7245fe695337043b40b281fb01a1fb0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599953Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

eeb14308

Front-end support for xfb capture of I/O block members · 8065aa82

authored Dec 22, 2020

Validation and generation of transform feedback varyings that specify an
I/O block member are implemented in this change.  The GL backend is able
to pass the added tests.

Bug: angleproject:3606
Change-Id: I66d02bed8ca9161555d0d1e7a32ae9ef4d9e813f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599952
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

8065aa82

Revert "Changes to build inside a Dawn checkout." · c500ee03

authored Dec 23, 2020

This reverts commit 11c31e0a.

Reason for revert: Broke ANGLE -> Skia roll because of GN error.

Bug: angleproject:5489

Original change's description:
> Changes to build inside a Dawn checkout.
>
> Add an "angle_standalone" flag that can be disabled by Dawn.
> Put test definitions behind angle_standalone || build_with_chromium.
>
> Bug: angleproject:5462
> Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Stephen White <senorblanco@chromium.org>

TBR=senorblanco@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:5462
Change-Id: I4363d1d35b03e00d970e25ddd3d7eac51ad2da2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600078Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c500ee03

Roll Chromium from 78f4bbcd4cb1 to a5e4417becc2 (263 revisions) · d447829c

authored Dec 23, 2020

https://chromium.googlesource.com/chromium/src.git/+log/78f4bbcd4cb1..a5e4417becc2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b4b7adbdc2..d4fcf57b4e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/9d83fdb696..36d8b4b883
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/3b78ceeade..ea63baff14
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2752abe7e2
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/e9a659a09e..09efc26aff
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ic57fe979eda136816aca4bcf9f38eb476e07cb56
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601584Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d447829c

Bump implementation max textures/images limit to 96. · b91afcfd

authored Dec 11, 2020

We need the higher limit for tessellation shaders and ES 3.2.
Unfortunately this means we are no longer using a packed 64-bit bitset
for the active textures and images. We fallback to using std::bitset.

Also keeps the 64 texture limit if tessellation is not available. The
higher limits was causing timeouts in WebGL tests.

Bug: angleproject:3572
Change-Id: I1953955600b56d7c66178bd610de53453151dc8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2586996
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b91afcfd

Fix out of bounds indices in transform feedback test · c2a620b0

authored Dec 22, 2020

Type confusion on the index buffer. It should be unsigned shorts. Fixes
a crash on iOS.

Bug: angleproject:4992
Bug: angleproject:5417
Change-Id: I18179a89dd81fff2582636496ea9684e432f4400
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2601162Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c2a620b0

Roll VK-GL-CTS from 54509765b18d to b29bf0434c16 (15 revisions) · 5c0ba543

authored Dec 22, 2020

Manually update deqp.gni to include new es3cNumberParsingTests files.

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/54509765b18d..b29bf0434c16

2020-12-19 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2020-12-18 alexander.galazin@arm.com Raise min CMake version to 3.10.2
2020-12-18 jeremyg@lunarg.com Fix Renderpass storeOp synchronization hazards
2020-12-18 jeremyg@lunarg.com Fix back-to-back transfer command synchronization hazards
2020-12-18 gleese@broadcom.com Simplify code for subgroup builtin mask tests
2020-12-18 jeremyg@lunarg.com Fix end of Renderpass synchronization hazards
2020-12-18 jeremyg@lunarg.com Fix additional RenderPass loadOp/stencilLoadOp sync hazards.
2020-12-18 jeremyg@lunarg.com Fix RenderPass stencilLoadOp synchronization hazards.
2020-12-18 jeremyg@lunarg.com Fix RenderPass loadOp synchronization hazards.
2020-12-17 mikko.tiusanen@siru.fi Tests for GLES3 number parsing
2020-12-17 mikko.tiusanen@siru.fi Tests for multiple clears within render pass
2020-12-17 rgarcia@igalia.com Enable nullDescriptor for AS ray query tests
2020-12-15 piotr.byszewski@mobica.com Test dynamic indexing of AS
2020-12-15 rgarcia@igalia.com Test dynamic indexing of ray queries
2020-12-13 piotr.byszewski@mobica.com Test procedural geometry with complex BB sets

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ynovikov@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com,angle-bots+autoroll-info@google.com
Change-Id: I59e4aabcfbf496d02e18ba7b7aa06391ba90f434
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600639Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

5c0ba543

22 Dec, 2020 5 commits

Vulkan: Fix assertion in xfb of indirect calls · 74788951

authored Dec 22, 2020

An assertion was fired which was only valid when emulating transform
feedback. The relevant block is conditioned to the respective feature.

Bug: angleproject:3571
Change-Id: I287ef6d94c920ccda742e4032bfc389409a38e1f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599951Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

74788951

Vulkan: GS tests that demonstrate gl_Position bugs · 9d45f527

authored Dec 21, 2020

Bug: angleproject:5478
Bug: angleproject:5479
Change-Id: If7ae7b6e0960c66dde697726381bc68c6809b3c6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599940Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

9d45f527

Use Android API to get storage path. · 00643e7d

authored Jul 22, 2020

This pipes through to a system call via JNI. This will allow
Chromium changes to land that were prevented because ANGLE
hard-coded some parts of this path. This in turn will allow
us to more easily override these paths for changes needed
for Android R support.

Bug: chromium:1094062
Change-Id: I20d75b8ee40d418ba5c057f618640ef896248299
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2315483
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

00643e7d

Vulkan: Pass in SPIR-V transform options in a struct · 85707f7f

authored Dec 21, 2020

Clean up change in preparation for changes that add more options.

Bug: angleproject:5478
Change-Id: Id35825b337dba153a5c28dfcc311b344ce257f78
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599941
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

85707f7f

Roll Chromium from 4545fb53923b to 78f4bbcd4cb1 (198 revisions) · 41d78ae1

authored Dec 22, 2020

https://chromium.googlesource.com/chromium/src.git/+log/4545fb53923b..78f4bbcd4cb1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/34da458aa2..b4b7adbdc2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c28f31863b..9d83fdb696
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d43e58994
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/d324a17c34..1283870fa3
No update to Clang.

Bug: None
Tbr: ynovikov@google.com
Change-Id: I9782920f655b361fcf171cecd29f06f671fe5d8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2600183Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

41d78ae1

21 Dec, 2020 4 commits

Changes to build inside a Dawn checkout. · 11c31e0a

authored Dec 21, 2020

Add an "angle_standalone" flag that can be disabled by Dawn.
Put test definitions behind angle_standalone || build_with_chromium.

Bug: angleproject:5462
Change-Id: I58c9b18723384334156e2a3dd86ed3f89afcaade
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587451Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>

11c31e0a

Vulkan: MapBufferRange should avoid wait if INVALIDATE_BUFFER is set · 0c5a55a5

authored Dec 17, 2020

If glMapBufferRange is called with GL_MAP_INVALIDATE_BUFFER_BIT bit set,
caller indicates that it don't care about the previous content. If the
buffer is busy, instead of wait for GPU to finish and then map the
buffer, we should just allocate a new memory and return it.

brawl_stars is hitting this case. With this CL, the frame time is
cutting to half on the pixel device.

Bug: b/175905404
Change-Id: If1220f07ebf53dd28fe6a4732eaba84e2e57598e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2597784Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

0c5a55a5

Fix PackedVarying's move constructor · 4e2b6d6b

authored Dec 21, 2020

The move constructor was calling the move assignment operator, which
used std::swap on the members. However, `this` was not constructed, so
std::swap was operating on uninitialized values. Caught by UBSAN.

Bug: chromium:1159444
Change-Id: I65f2f0affd1461f880c59780f31a368779411f24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2599936Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4e2b6d6b

Roll Chromium from af73f1e9f8c8 to 4545fb53923b (180 revisions) · 4ebcee3e

authored Dec 21, 2020

https://chromium.googlesource.com/chromium/src.git/+log/af73f1e9f8c8..4545fb53923b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/68fec68de7..34da458aa2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5bbe1bc6f..c28f31863b
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d43e58994
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: Ib5357a8c44f44245b5df8e583e8460b9ac84a70f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2597052Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4ebcee3e

19 Dec, 2020 2 commits

Metal: explicitly convert XFB vertex shader to void function · ed9213bc

authored Dec 18, 2020

Previously, spirv-cross would automatically do this (converting to void
function) if shader writes to XFB buffers, however this behavior is
changed in latest spirv-cross version.
So the rasterization disable must be explicitly specified via
spirv-cross’s options now.

Bug: chromium:1159974
Change-Id: I9f34e1cd9d2f1386e8a8d030a800fbd7341eb68f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2596914
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ed9213bc

Disable syncFramebufferBindingsOnTexImage on Intel/Win/GL · 0322fc1a

authored Dec 16, 2020

The driver fix is available already.

Bug: angleproject:2906
Change-Id: Id607fa5217360afd99e5de0d2e5f35f79615d160
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2594323
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0322fc1a

18 Dec, 2020 4 commits

Promote RGBA4444 and RGB565 to RGB[A]8 on macOS with AMD GPUs. · 011e0ad1

authored Dec 16, 2020

There are bugs in Apple's OpenGL driver when uploading to textures of
these formats via pixel buffer objects.

Because automatic graphics switching might activate the AMD GPU at any
time, use this workaround on dual-GPU MacBook Pros even if the Intel
GPU is active.

Fixes the following WebGL 2.0 conformance tests:

  deqp/functional/gles3/texturespecification/
    teximage2d_pbo_2d_00.html
    teximage2d_pbo_2d_01.html
    texsubimage2d_pbo_2d_00.html
    texsubimage2d_pbo_2d_01.html
    texsubimage2d_pbo_cube_01.html

Bug: angleproject:5469
Change-Id: I7d65dc5f664159b4b59d46400a8d9c492f67040b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2595245
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

011e0ad1

Import Vulkan DEPS from the new vulkan-deps repo. · 653f6196

authored Dec 14, 2020

This will allow the entire set of Vulkan DEPS to be rolled as one.

Bug: angleproject:5390
Change-Id: I10ca4f966f986baf3aab7250935802a3ed1065f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2587671
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

653f6196

Roll SwiftShader from 1ca6504eb7bb to 1cc5b3357d2f (2 revisions) · 0bb22ef2

authored Dec 18, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/1ca6504eb7bb..1cc5b3357d2f

2020-12-17 amaiorano@google.com Optimize reciprocal sqrt operation
2020-12-17 amaiorano@google.com Optimize reciprocal operation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I138802959ca39114cf2d4373171b47b3a1911681
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598359Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0bb22ef2

Roll Chromium from 45e7154d4b07 to af73f1e9f8c8 (218 revisions) · 165c345e

authored Dec 18, 2020

https://chromium.googlesource.com/chromium/src.git/+log/45e7154d4b07..af73f1e9f8c8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/de4c58d749..68fec68de7
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/13342b6ee2..e5bbe1bc6f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..8d43e58994
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/36810de981..d324a17c34
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/f9059111fd..bd7d73d146
No update to Clang.

Bug: angleproject:5390
Tbr: cwallez@google.com
Change-Id: I86fb4663eaf9eed3992dcc2721b489d5bbd6add2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2598280Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

165c345e