Commits · defeda29ddfc944266d15de470ebda65b009c255 · Chen Yisong / angle

19 Aug, 2020 11 commits

Metal: autogen for EXT_draw_buffers & ANGLE_framebuffer_blit · defeda29

authored Aug 04, 2020

Bug: angleproject:2634
Change-Id: I8f8ee91fb673301b8bd97c359ee39c411e2bf8da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336124
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

defeda29

Delete extra initialization in spirv shader. · add9b677

authored Aug 17, 2020

Only webgl requires initialization of local variables,others don't.
Extra initialization in spirv shader may affect performance.

Bug: angleproject:4952
Change-Id: I004761779067748d43c1ea2630794491f1389492
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359608
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

add9b677

Vulkan: Check aggregate barrier feature instead of caching. · 27a24f6d

authored Aug 17, 2020

Bug: b/157508684
Change-Id: I6c98cb017d44c1279439d815e77f6ad1a32133e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360903
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

27a24f6d

Vulkan: Name image layouts. · ea1bda26

authored Aug 17, 2020

Can be useful for debugging logging.

Bug: angleproject:4959
Change-Id: I4bdb72b4c07979fecc2af0ca2a2b2e7cdab36b9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360902
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ea1bda26

Roll Vulkan-Tools from 1590d46aaaeb to eceb318c06a2 (1 revision) · 6133bb4d

authored Aug 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1590d46aaaeb..eceb318c06a2

2020-08-18 shannon@lunarg.com build: Update known-good files for 1.2.151 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I8bb85820739d3f9d881e2559f167f05f7d3ee2ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364248Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6133bb4d

Roll SwiftShader from 6f74415e2f74 to cbfd396756c6 (1 revision) · 330eb73f

authored Aug 19, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/6f74415e2f74..cbfd396756c6

2020-08-18 sugoi@google.com Control Flow Integrity (cfi) fix

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I04196ff58d26afae7c52d4aebc2a962909a9b846
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364247Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

330eb73f

Roll Vulkan-ValidationLayers from 9d431ae2eeb4 to c97acd1d3e07 (1 revision) · e16e2cf4

authored Aug 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9d431ae2eeb4..c97acd1d3e07

2020-08-18 mark@lunarg.com layers: Fix whitespace error in layer settings file

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I82f83a33bffee7ff6f5ffebca1bd59f726e85012
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364249Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e16e2cf4

Roll SPIRV-Tools from e28436f2b8a2 to 3434cb0b006d (2 revisions) · 9e17caba

authored Aug 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e28436f2b8a2..3434cb0b006d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I98c5ba5b5a5ad87051cdadd89ae431412b003405
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364250Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9e17caba

Vulkan: Track RP's read/write access for depth/stencil. · d286daf1

authored Aug 16, 2020

This generalizes the read tracking into read/write. Knowing the write
access can let us determine if we can switch a RenderPass to a read-
only mode. And switching to read-only will let us combine some
RenderPasses in Manhattan.

Bug: angleproject:4959
Change-Id: Ic97547e84fef4a2670437677000d4525006ef69f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358771
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

d286daf1

Feedback Loop Redesign 2/3: Track bound FBOs in Texture. · 699bcde0

authored Aug 14, 2020

Currently we track feedback loops by counting the times a Texture is
bound as a sampler or image in a particular context. This is a bit
tricky because Texture bindings change frequently. Relative to the
number of times we need to check for a feedback loop this causes excess
overhead.

Usually Framebuffers have a low number of Textures bound (in many cases
just 1). And Textures aren't usually bound to many different FBOs. So
instead of counting the number of times a Texture is bound as a sampler
or image we will track the Framebuffers that the Texture is bound to.

This CL adds a small vector class to gl::Texture which tracks all the
Framebufer Serials of its bound Framebuffers. We can use this set to
quickly check if there's any potential feedback loop between the a FBO
and this Texture.

We also update the feedback loop check to use this new method. We will
be able to remove the old counting method when we switch the Vulkan
feedback loop handling to use the new tracking in this CL.

Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: I84a2f0ed8480d1da63d5879e0e56a8be4af4e735
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358850Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

699bcde0

Vulkan: Add overlay widget for RP buffer count. · 5b4f6e31

authored Aug 15, 2020

Can help evaluate when scenes stress out the resource tracking in the
RenderPass command buffer.

Bug: angleproject:4950
Bug: angleproject:4965
Change-Id: I7da2ad0101a840c5441f2112db4bb61f564afcef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358521
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

5b4f6e31

18 Aug, 2020 17 commits

Feedback Loop Redesign 1/3: Framebuffer Serials. · d0b270e6

authored Aug 14, 2020

Currently we track feedback loops by counting the times a Texture is
bound as a sampler or image in a particular context. This is a bit
tricky because Texture bindings change frequently. Relative to the
number of times we need to check for a feedback loop this causes excess
overhead.

Usually Framebuffers have a low number of Textures bound (in many cases
just 1). And Textures aren't usually bound to many different FBOs. So
instead of counting the number of times a Texture is bound as a sampler
or image we will track the Framebuffers that the Texture is bound to.

Because FBOs are unique to a Context, a Texture could be bound to two
different FBOs with the same ID. In this CL we introduce a new Serial
for the FBO which is unique to an EGL Share Group. This way we can
ensure we don't make the wrong call when a Texture is referenced by a
Framebuffer. It also replaces the old FB serial which was again only
unique to a particular Context.

Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: I0a9989d861a4132bd3b7ed85f699a4448ff37a4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358849Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d0b270e6

Metal: autogen format caps from json · 85919ef7

authored Aug 08, 2020

Bug: angleproject:4940
Bug: angleproject:2634
Change-Id: I1e107e856a50a7eaf685296dd7464af9ad5bcec4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342522
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

85919ef7

Vulkan: Add DS ReadOnly mode to Framebuffer/RP caches. · 594e0e14

authored Aug 15, 2020

Allows ANGLE to create Framebuffers and RenderPasses with a read-
only depth/stencil layout. Also allows us to transition our Images
to this new DepthStencilReadOnly layout.

Internal code redesign. No functional change to our command stream.

Bug: angleproject:4959
Change-Id: I9b80063bdaec8f5d6c89037e0618c85e1c11b78d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2354280Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

594e0e14

Metal: Fix missing image view for texture from IOSurface. · a13f1061

authored Aug 14, 2020

Image view is used by glTexSubImage*, glCopySubImage* and
glCopySubTexture*.
This fixed some failed WebGL tests that make use of IOSurface.

Bug: angleproject:4846
Bug: angleproject:2634
Change-Id: Iebcf840fdc1be2794feab766957b5848a361a63c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2356107
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a13f1061

Auto-gen more Overlay code. · 57393152

authored Aug 16, 2020

We add a new header where we auto-generate the Widget ID. We also use
a new X macro to generate per-widget arrays and tables.

Bug: angleproject:4965
Change-Id: Ic53e5d1c47d5712a63c98c481c15f550f1f99692
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358520
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

57393152

Clean up Overlay code duplication. · 4cf01e3e

authored Aug 18, 2020

Adds common helper functions for Running Graphs and Histograms.

Bug: angleproject:4965
Change-Id: I8c7295217c637e377b74b4a336eb151b8a7c9596
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358518
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

4cf01e3e

Vulkan: Clean up ImageLayout enum. · ee0a9a34

authored Aug 13, 2020

Remove the redundant manual numbering. Also rename
AllGraphicsShadersReadWrite to AllGraphicsShadersWrite for consistency.

Refactoring change only.

Bug: angleproject:4959
Change-Id: I2e7ca00993f192897bbf88f4bdc3f1610bcb345f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2354279
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

ee0a9a34

Tests: Add COD:Mobile trace · c4a82aaa

authored Aug 17, 2020

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*cod_mobile*
Bug: b/164426913
Bug: angleproject:4048
Change-Id: I306714632b635c728fa212ed793f076c6b889227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360047
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c4a82aaa

Roll Vulkan-Headers from 99638d8d7fc6 to 834673eaa34a (1 revision) · 0d421b60

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/99638d8d7fc6..834673eaa34a

2020-08-17 mchock@nvidia.com Add VI WSI platform support to vk_icd.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I675172be28aaee839ca2ab0547e59b59e2db17b4
Bug: None
Tbr: cnorthrop@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361863Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0d421b60

Roll glslang from 758b30727efc to f257e0ea6b9a (2 revisions) · a14f1c8a

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/758b30727efc..f257e0ea6b9a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I17cf464de87a81fa085918f68322425b1b95203b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361765Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a14f1c8a

Roll SPIRV-Tools from b8de4f57e983 to e28436f2b8a2 (3 revisions) · 8150670d

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b8de4f57e983..e28436f2b8a2

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: If8a90870cbf6cc3b0a3a910c12e35524db3de232
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361526Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8150670d

Roll Vulkan-Loader from 527e67e9d933 to 30b3f3857835 (13 revisions) · 4bf2e254

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/527e67e9d933..30b3f3857835

2020-08-17 cnorthrop@google.com loader: Fixes for gn build
2020-08-17 shannon@lunarg.com build: Update known-good files for 1.2.151 header
2020-08-17 Neonfxsh@gmail.com docs: Remove COPYRIGHT.txt from the readme
2020-08-14 lenny@lunarg.com repo: Set appveyor build to use Win10 SDK
2020-08-14 lenny@lunarg.com loader: Move tag to avoid linux warning
2020-08-14 piotr.bialecki@intel.com loader: Fix physical device sorting crash
2020-08-14 lenny@lunarg.com loader: Remove illegal asssignment
2020-08-14 lenny@lunarg.com loader: Fix variable name
2020-08-14 lenny@lunarg.com loader: Fixpossible memory corruption
2020-08-14 lenny@lunarg.com loader: Add reporting for physical device sorting
2020-08-14 lenny@lunarg.com docs: Update loader doc with device sorting info
2020-08-14 lenny@lunarg.com loader: Sort physical devices on Windows
2020-08-14 shannon@lunarg.com build: Update known-good files for 1.2.150 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I0e3d7b270fc9e659ecb1862883cc8231021b89da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361766Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4bf2e254

Roll Vulkan-ValidationLayers from c1db3b8e7960 to 9d431ae2eeb4 (1 revision) · 366a7334

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c1db3b8e7960..9d431ae2eeb4

2020-08-17 s.fricke@samsung.com layers: Fix TransformFeedback size check

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I99fb617dfa4e09c29e965b0364ef0f2090567652
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361525Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

366a7334

Roll SwiftShader from abe07b943855 to 6f74415e2f74 (2 revisions) · 95b26583

authored Aug 18, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/abe07b943855..6f74415e2f74

2020-08-17 amaiorano@google.com Update README to add details on Vulkan and less about GLES
2020-08-17 capn@google.com Don't rely on VectorType::get() default parameter

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I7e4f009c36170658f58adee8c944478afea69c69
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361524Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

95b26583

Vulkan: Clean up handleDirtyTexturesImpl. · 26ae42cf

authored Aug 09, 2020

Adds a new bitset helper and changes a check to an ASSERT.
Refactoring change only.

Bug: angleproject:4959
Change-Id: I0de9f1b707c87cfb6fed8a110654783059e55c99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2345025
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

26ae42cf

Vulkan: Clean up ImageHelper barrier functions. · dceaabb1

authored Aug 08, 2020

We don't need to explicitly check if a barrier is required for write
barriers. Write barriers always require a barrier and read barriers
need the layout change check. We introduce a new enum encoding ReadOnly
vs Write layout types and call specialized write/read functions
instead. Also renames the helper APIs to be more consistent.

Refactoring change only.

Bug: angleproject:4959
Change-Id: I0ce39ceaca6be588327c381194a580dc6b11f036
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2344744
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

dceaabb1

Re-enable a dEQP-EGL test on SwANGLE · 863115fb

authored Aug 17, 2020

Hopefully no longer flaky.
dEQP.EGL/functional_sharing_gles2_multithread_random_egl_server_sync_shaders_compile_9

Bug: angleproject:4495
Change-Id: I121ad4ece0be3e0ab7b0390a1a2c54cfd2bed537
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360904Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

863115fb

17 Aug, 2020 10 commits

Vulkan: Minor cleanup to vk_helpers. · 693d0e0b

authored Aug 07, 2020

Moves some checks into helper functions. Refactor only.

Bug: angleproject:4959
Change-Id: I08053a96f99baff75eb3954ecbb77e83483eba0f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2343406Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

693d0e0b

Capture/Replay: Don't capture unused default uniforms in MEC · d488568a

authored Aug 17, 2020

Test: MEC capture of COD:Mobile
Bug: b/164426913
Bug: angleproject:4048
Change-Id: I7f47c8828d57dfcc14bee5994d98c7df5f6a9a71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360046
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d488568a

Vulkan: Add test for RGB texture not break renderpass · d63bca58

authored Aug 06, 2020

This adds a test that will use an empty RGB texture. It should not break
renderpass.

Bug: b/162603208
Change-Id: I90f5aa2fafdbd70c654c9ad0675d6def32b58313
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2338828
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

d63bca58

Update commit ID when the git ref changes. · 5f2ba637

authored Aug 15, 2020

Previously we were only regenerating the commit ID when the .git/HEAD
file changed. When working on a branch the HEAD file doesn't change.
It points to a ref like refs/heads/master that changes. So we can read
back the contents of .git/HEAD using GN's read_file command and then
mark the commit id as dirty when the ref changes.

Should alleviate some of the shader cache problems.

Bug: angleproject:4448
Change-Id: I1c39b12af3455e3620d80bec92a15f9921d9163b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358519Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

5f2ba637

Capture/Replay: Fix 1010102 vertex attrib type name · 65ccbd71

authored Aug 14, 2020

The string for VertexAttribType::Int2101010 was wrong, similar to
the fix in ffb31229.

Test: Capture and replay first 1200 frames of COD.
Bug: b/164426913
Bug: angleproject:4048
Change-Id: I86a9ad844cde211d8273840ef7e8ecb055521316
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2357170Reviewed-by: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

65ccbd71

Roll Vulkan-Headers from 6eaf979e7366 to 99638d8d7fc6 (1 revision) · 064bbf29

authored Aug 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/6eaf979e7366..99638d8d7fc6

2020-08-17 oddhack@sonic.net Update for Vulkan-Docs 1.2.151

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: Ieb7b233ed32ad9a15878a347890c73f92729aa1f
Bug: None
Tbr: ynovikov@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358773Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

064bbf29

Roll Vulkan-ValidationLayers from 1980311465cf to c1db3b8e7960 (1 revision) · 29271d0e

authored Aug 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1980311465cf..c1db3b8e7960

2020-08-14 locke@lunarg.com layers: Fix has_writable_descriptor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I998f5a176a70ac4443c396fb9e039cf36e1f0431
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359759Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

29271d0e

Roll SPIRV-Tools from b4c4da3e7606 to b8de4f57e983 (4 revisions) · db2bf132

authored Aug 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b4c4da3e7606..b8de4f57e983

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: I875cd44f7d1f78df86e3be15cdf35eebc1f7c0ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359760Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

db2bf132

Roll glslang from d253278f9865 to 758b30727efc (2 revisions) · d852ad24

authored Aug 17, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d253278f9865..758b30727efc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ynovikov@google.com
Change-Id: Ia1a4ab99a1056e25837193d20519a14984ca871b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359757Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d852ad24

Capture/Replay: Add ability to override entry points · a9b199b0

authored Aug 13, 2020

We don't support populating a texture from an EGLImage, but
this feature is in use by games. Instead, populate the texture
with null data. In the future, improve this by reading back the
data.

Test: Capture and play back first 1200 frames of COD.
Bug: b/164426913
Bug: angleproject:4048
Change-Id: Ic8c6bdf3c359c89e647c28b8c57b7218bdf05b15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2355705Reviewed-by: Manh Nguyen <nguyenmh@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

a9b199b0

14 Aug, 2020 2 commits

D3D: disable to translate uniform block to StructuredBuffer · 9ae6d7f2

authored Aug 14, 2020

Temporarily disables the feature that translate uniform block to
StructuredBuffer on D3D backend for a bug.

Adapted from a patch by xinghua.cao@intel.com

Bug: chromium:1112112
Change-Id: I3419a0eb8ae619e1fa532ffb29f56a9099f04618
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2357752
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9ae6d7f2

Reduce spam in native perf tests. · e89eb912

authored Aug 12, 2020

The QC driver was repeating HIGH priority messages about map flags.

Bug: angleproject:4943
Change-Id: I927c38249f840544a7c1f5e595fa34e706e401bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2352472Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e89eb912