Refactors code out of generated functions into a common function and
simplifies assertions.

Bug: angleproject:2958
Change-Id: I896c2304c3ac1e043c16f9ecf81fa8b72a6b87c0
Reviewed-on: https://chromium-review.googlesource.com/c/1355501
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This is useful for triggering a dirty state notification for Textures.
It will lead to improvements for program and texture dirty bits.

Bug: angleproject:2966
Change-Id: Iaba625da8a970a558f7d158bfa2f09c964f6761a
Reviewed-on: https://chromium-review.googlesource.com/c/1347669
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This allows us to skip 1/2 of the robust resource init check in
Context::setupDraw. The plan is to remove the other half in a follow-up
CL.

Most of the work of this CL was already handled. We just need to add
the right dirty object mask to the Context's draw dirty objects list.
We can mask out this check when robust resource is not enabled.

Bug: angleproject:2966
Change-Id: I97ec2497c95e5cdf52988e1ce85f7602206935f0
Reviewed-on: https://chromium-review.googlesource.com/c/1343140
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Even though we don't plan to be launchable, we need to include an
icon for plumbing reasons.  For now I'm using a temporary
icon pulled from our Cubey sample.  When we get something official
we can easily swap it in, and enhance it support multiple dpis.

Bug: angleproject:2991
Change-Id: I2873d74586543c617cfc13fe6582b0b4967cbb22
Reviewed-on: https://chromium-review.googlesource.com/c/1355505Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

The packing and unpacking take a few extra instructions. But it
completely obviates the need for any switches in the validation code.
Speed is slightly faster or the similar depending on the back-end.

Also add gl_angle_ext.xml to GL entry point generator inputs. This was
missing and would cause the code generation to miss certain changes.

Bug: angleproject:2985
Change-Id: I1ea41a71db71135000166ead8305ec42d22ff7b3
Reviewed-on: https://chromium-review.googlesource.com/c/1351729
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT was used for barriers, but TOP and
BOTTOM bits can only be used for execution barriers.  These stages don't
access memory, so they don't participate in memory barriers at all.  A
validation error is generated as our current barriers violate this:

https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-vkCmdPipelineBarrier-pMemoryBarriers-01184

A note from the spec (see second paragraph in particular):

> An execution dependency with only VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT
> in the destination stage mask will only prevent that stage from
> executing in subsequently submitted commands. As this stage does not
> perform any actual execution, this is not observable - in effect, it
> does not delay processing of subsequent commands. Similarly an execution
> dependency with only VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT in the source
> stage mask will effectively not wait for any prior commands to complete.

> When defining a memory dependency, using only
> VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT or
> VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT would never make any accesses
> available and/or visible because these stages do not access memory.

> VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT and
> VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT are useful for accomplishing layout
> transitions and queue ownership operations when the required execution
> dependency is satisfied by other means - for example, semaphore
> operations between queues.

Bug: angleproject:2958
Change-Id: Ic616dcad7583db6b386d7d01a774b3ebd71a7081
Reviewed-on: https://chromium-review.googlesource.com/c/1352733
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Create a function table for State::syncDirtyObjects to avoid the
costly switch and inline calls along the Context::syncDirtyObjects
calling hierarchy.

Bug: angleproject:2975

Change-Id: I1ec797452af41bc767578e4017c8eccb7d83628b
Reviewed-on: https://chromium-review.googlesource.com/c/1340222
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

For each internal shader, there is now possibly a companion .json file
that defines shader variations.  The variations consist of a set of
flags and a set of enums.  Each enum defines a variation that takes one
of a few values.  Flags are shorthands for 2-value enums.

In the shader code, #if can be used to change the shader based on
variations derived from flags and enums.  On the C++ side, those
variations are combined into an index and the appropriate shader is
retrieved from a table.

Bug: angleproject:2958
Change-Id: Ic4fc7061adb20c047c26624305285e3005092aab
Reviewed-on: https://chromium-review.googlesource.com/c/1351117
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The internal shaders know exactly what mix of resources they use, so
with this change they can make one allocation of multiple types.

Bug: angleproject:2958
Change-Id: Ia6f03672b95af4be9618a2f5eeb41ef1c027e810
Reviewed-on: https://chromium-review.googlesource.com/c/1351116Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This patch adds GetMultismaplefvANGLE and SampleMaskiANGLE api.

TEST=TextureMultisampleTest.CheckSamplePositions*
TEST=NegativeTextureMultisampleTest.Negtive*

BUG=angleproject:2275

Change-Id: Ib1e8b856059229bbe88328a28cf2a892f4673214
Reviewed-on: https://chromium-review.googlesource.com/c/1319252
Commit-Queue: Yizhou Jiang <yizhou.jiang@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Also optimizes the DrawElements validation to remove redundant tests.
Also make some more validation WebGL-specific.

Bug: angleproject:2979
Change-Id: I2d5c3094ed86ebadbc572e46b8ae105431f7ae68
Reviewed-on: https://chromium-review.googlesource.com/c/1343139Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2958
Change-Id: I7fd50e8b2029aad59a35050f401e1cf70d047444
Reviewed-on: https://chromium-review.googlesource.com/c/1354098
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This is so that the resulting buffers can be written to by the GPU.

Additionally, the class is given the ability to create host-visible or
device-local buffers, making map()-on-init() optional.

This is in preparation for vertex/index transformations in compute.

Bug: angleproject:2958
Change-Id: Ib8f5829e33a1e49fa8f80c70dbde74f313ae49ec
Reviewed-on: https://chromium-review.googlesource.com/c/1351113
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Vulkan backend was missing dependency on NativeWindow.

Bug: angleproject:2314

Change-Id: I66675af6f885b57bdb0524a0626dfec0256a21d3
Reviewed-on: https://chromium-review.googlesource.com/c/1354100Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This reverts commit fdbdb2b2.

Reason for revert:
I didn't mean to land this quite yet, since we are still working on the Android side of things.   It seems doing CQ+2 merges it while I was trying for just a dry run while replying to Jamie's comments with updates (after checking with Boulder folks, I want CQ+1 next time).

Once the Android changes are ready, I'll work on getting this landed again.

Original change's description:
> Enhance ANGLE for Android Developer Options
> 
> Update ANGLE Developer Options
> 
> Update ANGLE developer options to allow selecting the OpenGL driver
> (default, ANGLE, native) for each app as well as forcing ANGLE for all
> apps.
> 
> Bug: angleproject:2962
> Test: Verify the default/ANGLE/native values are saved and applied and
> used by the loader.
> 
> Change-Id: I6041e7e49ca5cc65f90fc8ae6f1b084e4639d769
> Reviewed-on: https://chromium-review.googlesource.com/c/1330315
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=ynovikov@chromium.org,geofflang@chromium.org,jmadill@chromium.org,cnorthrop@google.com,tobine@google.com,courtneygo@google.com,ianelliott@google.com,timvp@google.com

Change-Id: If3a4e917973c56b858244a0ca7f1b164143524f5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2962
Reviewed-on: https://chromium-review.googlesource.com/c/1354099Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

This is a WebGL spec change:
https://github.com/KhronosGroup/WebGL/commit/bfbe124a7bb92eed34ea7cc18694167ed66b1030

Fixes conformance2/textures/misc/tex-mipmap-levels.html

Bug: chromium:898351
Change-Id: Ib20409e10bec598611be273577115a380a63b523
Reviewed-on: https://chromium-review.googlesource.com/c/1352385
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This patch changes arguments for MultiDrawElements and
MultiDrawElementsInstanced from from GLsizei *offsets to
const* GLvoid* indices.

Bug: chromium:890539

Change-Id: I2124cf2daeaa6af0f889f3c46aa2b8c77be200a6
Reviewed-on: https://chromium-review.googlesource.com/c/1352591Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>

Removes several TODOs. Only egl::Error remains.

Also slightly decreases binary size.

Bug: angleproject:2491
Change-Id: I3a9d1c22eb0884ca9e37362463fddd0083faf826
Reviewed-on: https://chromium-review.googlesource.com/c/1337462
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Update ANGLE Developer Options

Update ANGLE developer options to allow selecting the OpenGL driver
(default, ANGLE, native) for each app as well as forcing ANGLE for all
apps.

Bug: angleproject:2962
Test: Verify the default/ANGLE/native values are saved and applied and
used by the loader.

Change-Id: I6041e7e49ca5cc65f90fc8ae6f1b084e4639d769
Reviewed-on: https://chromium-review.googlesource.com/c/1330315
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Allows for better readability. Also sort the error strings by ID.

Bug: angleproject:2957
Change-Id: Ib3900a4c90507ac84496fd5ff916417eb768667b
Reviewed-on: https://chromium-review.googlesource.com/c/1337461
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

The GLenum was already mostly packed. There were just a few missing
values because of the exclusion of things like GL_QUADS and GL_POLYGON
from GLES.

Also update the PackedEnumMap initialization to take an intializer.
The initializer is a list of key/values which is much more robust to
changes in the packed map.

Improves draw call speed slightly as there is no conversion needed any
more for the mode enum.

Bug: angleproject:2966
Change-Id: Icae658272c6234f29335f6a57a63cf341cf5b2a0
Reviewed-on: https://chromium-review.googlesource.com/c/1346529
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This test flakes on many platforms.

BUG=angleproject:2408
BUG=angleproject:2407

Change-Id: I9e8ff8aedc02962656c1a336c3f34191920ae8c7
Reviewed-on: https://chromium-review.googlesource.com/c/1352222
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This applies git cl format --full to all ANGLE sources.

Bug: angleproject:2986
Change-Id: Ib504e618c1589332a37e97696cdc3515d739308f
Reviewed-on: https://chromium-review.googlesource.com/c/1351367Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

The EXT_color_buffer_half_float extension spec issue #2 states that none
of the added color buffer formats are required to be renderable and the
client must check for framebuffer completeness for using them.  Chrome
exposes the extension if at least RGBA16F is renderable for WebGL.

Replicate Chrome's behaviour by loosening our requirements to only
expose this extension if an explicit check for RGBA16F renderability
succeeds.

BUG=angleproject:2984

Change-Id: Id97f3043ebf3fd11b5e9e2d505e57b76baba9716
Reviewed-on: https://chromium-review.googlesource.com/c/1351350
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This patch adds the swizzle process if the swizzle node is the last node in
ssbo access chain.

Bug: angleproject:1951

Change-Id: Iecc95baa45e8cc40be9111a15398c7e858bfb99e
Reviewed-on: https://chromium-review.googlesource.com/c/1341234
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Implementing a WebGL spec change:
https://github.com/KhronosGroup/WebGL/pull/2658
Fixes WebGL 2 conformance test:
conformance2/transform_feedback/same-buffer-two-binding-points.html

Also applying the change to D3D backends because they can't support
multiple transform feedback outputs in one buffer.

Bug: chromium:866089
Change-Id: I8d7eda14225c13efb7ca1ed974239332be4e79a6
Reviewed-on: https://chromium-review.googlesource.com/c/1347749
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2958
Change-Id: Ifa40537bc6003486b37d5d2ac9a2b7f1f5c3d1c2
Reviewed-on: https://chromium-review.googlesource.com/c/1351115Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

BUG=angleproject:2909

Change-Id: Ie59c1206e2ce4940e27fed7887dbee665721049b
Reviewed-on: https://chromium-review.googlesource.com/c/1351354Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:2958
Change-Id: I3f77e694638b4dc060d20a149c3f9c8aed3692d1
Reviewed-on: https://chromium-review.googlesource.com/c/1351114Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

To allow for extern "C" declarations to not break on a brace. This
preserves the current code style.

Also add indented preprocessor definitions. This makes the formatting
of "platform.h" much nicer.

Bug: angleproject:2971
Change-Id: I392babe0c8d67539a8e026a36a023a7404bb63c2
Reviewed-on: https://chromium-review.googlesource.com/c/1347452
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

When calling glReadPixels on unsized sRGB textures, the data returned is
not linearized.  Using sized sRGB formats works around this problem.

Fix SRGBTextureTest assuming that unsized SRGB formats work in ES3.

BUG=angleproject:2977

Change-Id: I413c888ca0c3564ecdc364f3ea693e75ed4f8d6d
Reviewed-on: https://chromium-review.googlesource.com/c/1343138Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

When ANGLE exposes an ES2 context, there is often no way to create fence
objects because GL_NV_fence is not available.

BUG=882580

Change-Id: Ic18539e0243317a188545f3945f6b33d3401f1a8
Reviewed-on: https://chromium-review.googlesource.com/c/1348769Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Generating static objects within a function results in multithread safe
code. This code generates the static objects upon the first execution of the
line which declares the object. This results in high runtime cost for
synchronization and a bigger code size.

Instead introduce a new function uint32_t GetPackedTypeInfo(GLenum type)
which returns a packed representation for the Type class. This
representation is usually returned in a register on the assembly level.
As a result we save constant storage for the TypeInfo object and one
indirection when reading any value from this object. The Type constructor
accepts the packed representation and unpacks it an inline function. For
fields which are not used the compiler also applies dead code
elimination which reduces the cost furthermore.

As a result of this change the cost of GetTypeInfo is reduced by a
factor of 4-5.

Bug: angleproject:2974
Change-Id: I8ed0bf2f09d087fa4cffa04f82e3b7f8c183fe30
Reviewed-on: https://chromium-review.googlesource.com/c/1340221Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Update ScopedPerfEventHelper class to add systrace markers by default.
This change unifies ANGLE EVENT* macro system so that at the base level
in LoggingAnnotator class, systrace markers will be added by default.

Modify the base DebugLogger to use char* by default and move any
conversions to wchar_t to the Windows specializations where wchar is
used. This limits type conversions to only where they're needed.

This change also includes some new TRACE_EVENT() calls in the VK
backend which will result in systrace markers for those calls on the
Android platform.

The new build flag "angle_enable_trace" is added to enable the tracing
calls.

Bug: angleproject:2528
Change-Id: Icefc197d4407e1cd31338710e37865abae6a0b15
Reviewed-on: https://chromium-review.googlesource.com/c/1042785
Commit-Queue: Tobin Ehlis <tobine@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Below deqp cases already pass:
dEQP-GLES31.functional.layout_binding.ubo.*
dEQP-GLES31.functional.shaders.builtin_functions.*compute*

BUG=angleproject:1951, angleproject:2759, angleproject:2619

Change-Id: I5541840462b792e83b4745c50e3c3d2c94db7745
Reviewed-on: https://chromium-review.googlesource.com/c/1347750Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

While this is not exposed to the front end yet, this commit adds support
for creating Compute pipelines for internal usage.

Bug: angleproject:2959
Change-Id: I976eae1ce0f736c257b7b4ae0d1c3b2d9f4da5bb
Reviewed-on: https://chromium-review.googlesource.com/c/1333972
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Use gl::ShaderType instead.  For now, only GLES2 shaders are supported
in ProgramVk.

Bug: angleproject:2522
Change-Id: I17bc9afddb6d39cf45fb4dd37f34c7263a3ed515
Reviewed-on: https://chromium-review.googlesource.com/c/1333970Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Currently we initialize a variable using zero initializer. Take the
below variable for example:
    uint var[4];
We translate it to:
    uint var[4] = { 0, 0, 0, 0};
If the array size is large, we have to use very long zero initializer.
The problem is that it's very slow for D3D drivers to compile.

This CL uses the 'static' trick below to solve the problem:
    static uint _ANGLE_ZEROS_[256];
    ...
    uint var[516] = {_ANGLE_ZEROS_, _ANGLE_ZEROS_, 0, 0, 0, 0};

For 'static', if the declaration does not include an initializer, the
value is set to zero.
https://docs.microsoft.com/en-us/windows/desktop/direct3dhlsl/dx-graphics-hlsl-variable-syntax

Bug: chromium:898030

Change-Id: Ia3f6574b5ddaffa94bf971140eba95835ee105ee
Reviewed-on: https://chromium-review.googlesource.com/c/1332805Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>

Instead pass error code and error message directly to the Context. As
a side effect every validation error has an associated message now.

Reduces binary size by almost 100k.

Bug: angleproject:2957
Change-Id: I045e8ab57f8f9d787654a32f6f037011fe3a9f24
Reviewed-on: https://chromium-review.googlesource.com/c/1335890
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This allows for a few nice things. First and foremost it reduces the
size of the PipelineDesc, which is now 232 bytes. It also allows us
to completely forego pipeline caches for compute shaders.

We also allow sharing vertex and fragment shaders among multiple
programs for internal shaders. This is good for memory savings. To
allow this we keep the shaders as ref counted objects.

Bug: angleproject:2522
Change-Id: I2322be5061979d9669a0b25c152359561eeb80ee
Reviewed-on: https://chromium-review.googlesource.com/c/1344449
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>