Commits · e6a178d0d94ecc266cd21f396fa893a6446bbe8d · Chen Yisong / angle

03 Sep, 2020 5 commits

Roll Chromium from 09df13c25e1b to 5881c1ad6465 (369 revisions) · e6a178d0

authored Sep 03, 2020

https://chromium.googlesource.com/chromium/src.git/+log/09df13c25e1b..5881c1ad6465

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/c12a68d90b..62caf80991
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/c1a7e4af8e..4fb4ca5040
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/18c972d967..df62febd32
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: I2ebd25309aa71b3f50a4aa1decad2a3fc2ca869c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2390837Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e6a178d0

Roll SwiftShader from e1051cbaad46 to 75690ce7ef4a (4 revisions) · ca87ff9d

authored Sep 03, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/e1051cbaad46..75690ce7ef4a

2020-09-03 sugoi@google.com DescriptorPool error fix
2020-09-03 sugoi@google.com Only use clang specific directives when clang is used
2020-09-02 capn@google.com Skip texel address sample offset if zero
2020-09-02 srisser@google.com Fix enum-hashing build error on Ubuntu 16.04

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I6bf74f0992d776bdb2703bcf6a97efb8ba01b90c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391055Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ca87ff9d

Roll SPIRV-Tools from c278dada96d9 to 2c60d16a646b (2 revisions) · fc059c13

authored Sep 03, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c278dada96d9..2c60d16a646b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I73b49238c919ab04427e096fc89e0a1ffa805c98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391056Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

fc059c13

Vulkan: Fix resolve-with-subpass retaining resolve attachment · cba9bbbe

authored Sep 02, 2020

The temporary resolve attachment used to optimize blit was not removed
from the framebuffer and render pass descriptions, resulting in
subsequent draws to be resolved again.

Bug: b/159903491
Change-Id: I9a9c90d25cb07ba9a25999f808b164f9085387d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2390441
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

cba9bbbe

Vulkan: Remove accidental padding in push constants · 0c25fbe3

authored Sep 02, 2020

Bug: chromium:1124379
Change-Id: I45f4511c836858c70d4dae23c7b3954e0bc65ab4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391616Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

0c25fbe3

02 Sep, 2020 13 commits

Vulkan: Allow pbuffer usage if no window support · 84bd9dad

authored Aug 26, 2020

Vulkan allows rendering to non-swapchain images, so pbuffers can always
be supported on every config.  With this change, if the window system
does not support a configuration, EGL_WINDOW_BIT is removed from the
config instead of dropping the config entirely.

Bug: chromium:1034840
Change-Id: Ib972ed8ddf7660c327123fa83ae0674456cf2a35
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378921
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>

84bd9dad

Add a frontend feature to disable anisotropic filtering. · a568b7e3

authored Jun 30, 2020

This allows us to disable support for GL_EXT_texture_filter_anisotropic
at runtime and make performance comparisons.

Bug: b/167404532
Change-Id: Id80458e7f116e195366432fe73e8e776e9a3047b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2278024
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

a568b7e3

Vulkan: Don't break the RP on masked/scissored clears · b2944fcf

authored Sep 02, 2020

Bug: b/166809097
Change-Id: Iedd10a6528808e859c5693a2d30c98aca1a1159c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2390862
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

b2944fcf

Make copyTexImage2D robust when source area is out of bounds · d0d523f4

authored Sep 02, 2020

Whenever the source area of the texture being copied is out of
bounds and robust resource init is enabled, it is necessary to
clear the invalid portion of the source area to 0 in the copy
operation, EXCEPT if the source and the destination are the same,
in which case clearing the destination would also clear the source.

Bug: angleproject:3930
Change-Id: Ie9e0c52fff86b5626c82a511319688392b7b073b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2391281Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

d0d523f4

Vulkan: Fix resolve with different formats · d701eae2

authored Sep 02, 2020

vkCmdResolveImage and subpass resolve attachments cannot be used if the
source and destination formats aren't identical per Vulkan spec:

vkCmdResolveImage:
> srcImage and dstImage must have been created with the same image
> format

VkSubpassDescription:
> each resolve attachment that is not VK_ATTACHMENT_UNUSED must have the
> same VkFormat as its corresponding color attachment

Bug: chromium:1123524
Change-Id: Iaf7182dbcad0420483ac2c23d0acf8c109688565
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2390781Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d701eae2

Vulkan: Fix resolve-with-subpass with non-zero read attachment · 543a3962

authored Sep 02, 2020

The draw framebuffer's color index was used to get the read buffer of
the source framebuffer.

Bug: b/159903491
Change-Id: I7a1626e6732367c14d46f1e1be4057998fdbf011
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2390440Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

543a3962

Workaround to disable OES_get_program_binary · 6b2639b0

authored Aug 31, 2020

This is a useful workaround for testing/diagnostics.
Disabled by default.

Bug: angleproject:5007
Change-Id: If459f60ae7f8a2cd4ea934fe3e54d890387d57db
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2385933
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

6b2639b0

Gracefully fail end2end tests if no window support · fdb7874d

authored Aug 26, 2020

EGL_WINDOW_BIT is now specifically requested for tests that open a
window (those that aren't WithNoFixture).  This makes sure pbuffer-only
configs are not selected for the window.

Additionally, a few WithNoFixture tests are made more robust in the
presence of no-window configs.

In the context of crbug.com/1034840, this means that a subset of end2end
tests would be able to run in a remote desktop environment.  Tested on
Linux/X11 by turning a subset of configs PBUFFER-only.

Bug: chromium:1034840
Change-Id: I09fd149d43d3b865856fe6b9491c5f333f4a2efc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378922Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

fdb7874d

Revert "Make copyTexImage2D robust when source area is out of bounds" · e3db3d20

authored Sep 02, 2020

This reverts commit e1e6f294.

Reason for revert: This fix is incorrect, it ends up being a noop. Reverting this first before landing a different fix.

Original change's description:
> Make copyTexImage2D robust when source area is out of bounds
> 
> Whenever the source area of the texture being copied is out of
> bounds and robust resource init is enabled, it is necessary to
> clear the invalid portion of the source area to 0 in the copy
> operation.
> 
> Bug: angleproject:3930
> Change-Id: If1605b917097006c37e7d59c66babbc32d0ba6d8
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378004
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Alexis Hétu <sugoi@chromium.org>

TBR=sugoi@chromium.org,geofflang@chromium.org,jmadill@chromium.org,sugoi@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3930
Change-Id: I9e37a3f739eb7ce5d6d6ab5ca59d11ce9aae8483
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2388718Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

e3db3d20

Roll Chromium from 863342438ec1 to 09df13c25e1b (356 revisions) · 121d9856

authored Sep 02, 2020

https://chromium.googlesource.com/chromium/src.git/+log/863342438ec1..09df13c25e1b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/25864a085f..c12a68d90b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/463368f793..c1a7e4af8e
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/d53accfbd0..59187e10e9
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/fcef86e30a..03bacc3235
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: I7bea3acf53d8e936191dd688031bd2160ded4f07
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389417Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

121d9856

Roll Vulkan-ValidationLayers from f1315472247d to b0337a548273 (2 revisions) · f2cad891

authored Sep 02, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f1315472247d..b0337a548273

2020-09-01 locke@lunarg.com tests: Byte of push constants used in shader
2020-09-01 locke@lunarg.com layers: Check push constant used in shader

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I027d2308692c10d18d7dc04587cc509fca66a675
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389602Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f2cad891

Roll SPIRV-Tools from 8a0ebd40f86d to c278dada96d9 (5 revisions) · 3489de1d

authored Sep 02, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8a0ebd40f86d..c278dada96d9

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: If1fd7369e653478648b842dc630c886c8cb48e11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389604Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3489de1d

Roll SwiftShader from a2e6c1a149f4 to e1051cbaad46 (5 revisions) · bc53046b

authored Sep 02, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/a2e6c1a149f4..e1051cbaad46

2020-09-01 capn@google.com Fix undefined behavior in minifloat conversion
2020-09-01 capn@google.com Add unit test for 11/10-bit minifloat denormal underflow
2020-09-01 capn@google.com Assert multisample resolve has equal input and output formats
2020-09-01 jaebaek@google.com Handle OpenCL.DebugInfo.100 DebugOperation
2020-09-01 jaebaek@google.com Handle DebugGlobalVariable using DebugInfoNone

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I1c3888c362be44320adafa9bc0fec7f25c454cea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389603Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

bc53046b

01 Sep, 2020 9 commits

Support DXT textures with non-block sized mip levels. · 6eeb3d8b

authored Aug 07, 2020

The block size requirement for each mip level meant that all
DXT textures had to be POT sized. Relax these restrictions for
non-zero mip levels to allow NPOT DXT textures.

Increase the size of the D3D11 staging textures to the nearest
block size to make sure allocation succeeds.

Bug: angleproject:4841
Change-Id: I42fa295a0965241d77f81e57b17454091fda9376
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380237Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

6eeb3d8b

Implement EXT_shadow_samplers · 7e815c77

authored Jul 08, 2020

Bug: angleproject:4863,b/161716126
Change-Id: I6beb45d91f59a851787c9f40b40266fb985198d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2288330
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>

7e815c77

Check for "Radeon" in renderer string. · e5f188b2

authored Aug 31, 2020

AMD workarounds relied on the vendor string containing "AMD" or
"ATI". Some vendor strings only contain "Radeon", which lead to
workarounds not being enabled.

Bug: angleproject:5004
Change-Id: Ie32852212afd1df1f3f691c87a5459e1b53b74b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2385932
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e5f188b2

Rename ANGLE apk package to org.chromium.angle · 736c43a1

authored Aug 31, 2020

Bug: b/167223999
Change-Id: Iaa0b7c779bf744da17a0defba32c966225300a4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2385915Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

736c43a1

Roll Chromium from 1ca2f943e522 to 863342438ec1 (403 revisions) · c21fdb07

authored Sep 01, 2020

https://chromium.googlesource.com/chromium/src.git/+log/1ca2f943e522..863342438ec1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/2dbf41fec1..25864a085f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7f8ef3207a..463368f793
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/89d15db591..fcef86e30a
No update to Clang.

Bug: None
Tbr: cwallez@google.com
Change-Id: I1c0e4eb2e06e9f702dc0a6905fdd417217626875
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2387740Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c21fdb07

Roll SPIRV-Tools from f428aa39ca2b to 8a0ebd40f86d (1 revision) · 65b6332d

authored Sep 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f428aa39ca2b..8a0ebd40f86d

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Id9c2c30cb142fe4a4c20c5f63f90ac2896b7bac4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2387377Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

65b6332d

Roll Vulkan-ValidationLayers from 0e98e894a84c to f1315472247d (2 revisions) · 917ce292

authored Sep 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0e98e894a84c..f1315472247d

2020-08-31 bob@lunarg.com android: NDK 21d
2020-08-31 jzulauf@lunarg.com syncval: Fix range computation for 3D images

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ib8cb088525c5cea2b7dd5edde57fdd8c64f111f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2387378Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

917ce292

Roll Vulkan-Tools from 1b0bbd1550ed to 25d277579d1e (1 revision) · afe7d990

authored Sep 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1b0bbd1550ed..25d277579d1e

2020-08-31 bob@lunarg.com android: NDK 21d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I7807df296b6cd3a1be12b5e87da4dc7ea2efb529
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2387376Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

afe7d990

Vulkan: release the ImageHelper's staging buffer after flush · c0dda021

authored Aug 26, 2020

For mutable textures, right now glTexImage call and some of other cases,
we are still using the ImageHelper's staging buffer. This will release
the staging buffer after flush to reduce memory footprint.

Bug: b/164511310
Change-Id: Ie1e52865a1c3a8f235c88331c4bb83c50d3f04da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378179Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

c0dda021

31 Aug, 2020 11 commits

Fix GL_EXT_texture_compression_s3tc_srgb on macOS · 59d28532

authored Aug 27, 2020

GL_EXT_texture_compression_s3tc_srgb wasn't being exposed on macOS
because formatutilsgl.cpp was looking for GL_EXT_texture_sRGB, but
it was moved to core in 2.1 and the macOS driver doesn't report it
anymore.

Bug: angleproject:4997
Change-Id: Iae736fac6d315f567ff5d834a043134f91625e59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380516Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

59d28532

Vulkan: Optimize atomic counter buffer offset calculations · f7b607c6

authored Aug 29, 2020

Call writeAtomicCounterBufferDriverUniformOffsets method
only if there are valid atomic counter buffers

Bug: angleproject:3566
Change-Id: I03c3fd2095e30381597bfc66acae0ccbf828d401
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2383787
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

f7b607c6

Make copyTexImage2D robust when source area is out of bounds · e1e6f294

authored Aug 26, 2020

Whenever the source area of the texture being copied is out of
bounds and robust resource init is enabled, it is necessary to
clear the invalid portion of the source area to 0 in the copy
operation.

Bug: angleproject:3930
Change-Id: If1605b917097006c37e7d59c66babbc32d0ba6d8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378004Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

e1e6f294

Vulkan: Add transient flag to command pool · a25b165a

authored Aug 28, 2020

Add the VK_COMMAND_POOL_CREATE_TRANSIENT_BIT flag when creating the
PersistentCommandPool since the command buffers are only used once and
then reset. Update the tracking bugs.

Bug: b/166641492
Bug: b/166793850
Change-Id: I5827b5df7dd150756325421fc6ff0283bbd8b8e1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2381943Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

a25b165a

Suppress flaky failure on Win Intel OpenGL · a1d5ebbf

authored Aug 31, 2020

TBR=syoussefi@chromium.org
Bug: angleproject:5003
Change-Id: I4bc2c963d69ba529d62e01c21080540e54b46796
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2385497
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

a1d5ebbf

Remove Vulkan repos from export targets ignore list. · 7b543998

authored Aug 31, 2020

These were all fixed upstream.

Bug: angleproject:4077
Change-Id: Id67cfdb62ec9949b0e8cb249d5bb1696ad205376
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2378924Reviewed-by: back sept 10 - Jamie Madill <jmadill@chromium.org>
Commit-Queue: back sept 10 - Jamie Madill <jmadill@chromium.org>

7b543998

Roll Vulkan-ValidationLayers from af56d31487bb to 0e98e894a84c (2 revisions) · 6ec0b239

authored Aug 31, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/af56d31487bb..0e98e894a84c

2020-08-28 jmadill@chromium.org GN: Fix header dependencies.
2020-08-28 s.fricke@samsung.com layers: Label VUID 04145

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I698370988403ad0a0b6081d65d6a633bddef9417
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2384522Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6ec0b239

Roll Chromium from 84714fcf811e to 1ca2f943e522 (3121 revisions) · a3255db4

authored Aug 31, 2020

https://chromium.googlesource.com/chromium/src.git/+log/84714fcf811e..1ca2f943e522

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7076d3be06..2dbf41fec1
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b00ad0af63..ff93f3ea1a
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/855f6eb5b6..7f8ef3207a
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/24b0f49452..18c972d967
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/299e8a2339..89d15db591
No update to Clang.

Bug: angleproject:4846
Tbr: courtneygo@google.com
Change-Id: I8dacd86570bc49943f99b5c92bfd7004632f4e04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2384167Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a3255db4

Roll SPIRV-Tools from 08291a3a9e22 to f428aa39ca2b (1 revision) · d55a6c9c

authored Aug 31, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/08291a3a9e22..f428aa39ca2b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic2e61f80476639fbea4d4337397f7168a9e459cc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2384524Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d55a6c9c

Roll SwiftShader from ec3650f56ca2 to a2e6c1a149f4 (4 revisions) · b4c90eee

authored Aug 31, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/ec3650f56ca2..a2e6c1a149f4

2020-08-28 capn@google.com Optimize multisample resolve with SSE2 instructions
2020-08-28 capn@google.com Add a fast multisample resolve code path
2020-08-28 capn@google.com Make multisample resolve a Blitter method
2020-08-28 capn@google.com Work around std::is_trivially_copyable issue with MSVC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I4aa727c76999ca92b921aa9aa70a5d4ef7974a4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2384523Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b4c90eee

Vulkan: Re-enable fixed dEQP tests · 2f291c0b

authored Jul 31, 2020

The script that loads the entry point loaded
glRenderbufferStorageMultisampleEXT from
GL_EXT_multisampled_render_to_texture wrong.  This is fixed in
https://github.com/KhronosGroup/VK-GL-CTS/pull/221.

Bug: angleproject:4836
Change-Id: I843b359b12a042f08a63ba6723cf31bdb8509661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2331740Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2f291c0b

30 Aug, 2020 1 commit

Vulkan: Fool-proof usage of GL and VK level indices · a0d048a4

authored Aug 27, 2020

Using boxed types, this change allows the compiler to catch errors when
a level index in one space (e.g. GL) is mistakenly used in another space
(e.g. VK).

This change uncovered a number of bugs due to such mistakes which are
fixed.

Mistakes are still possible when the index is explicitly extracted, for
example to be given to a Vulkan command, or when it's created, for
example when retrieved from gl::ImageIndex::getLevelIndex.  Future work
can include using gl::LevelIndex in gl::ImageIndex directly to alleviate
the latter at least.

Bug: angleproject:4880
Change-Id: I6427c68c3bc096f771402f51c8554d8171758aa9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2380232
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

a0d048a4

29 Aug, 2020 1 commit

Revert "Convert unordered_map to absl::flat_hash_map for select files" · 8d412db2

authored Aug 29, 2020

This reverts commit 1acaf4ec.

Reason for revert: Fails when is_component_build is not set:

lld-link: error: <root>: undefined symbol: public: __cdecl absl::Condition::Condition<struct std::__1::atomic<bool> const>(bool (__cdecl *)(struct std::__1::atomic<bool> const *), struct std::__1::atomic<bool> const *)
<snip>

Original change's description:
> Convert unordered_map to absl::flat_hash_map for select files
> 
> This is the initial CL to start migrating to abseil in various places:
> - formatutils.h
> - FramebufferVk.h
> - Program.h
> - ProgramExecutableVk.h
> - RewriteRowMajorMatrices.cpp
> 
> This intentionally hits a couple different places in the code to make
> sure the abseil dependencies are added to the required targets.
> 
> Bug: angleproject:4873
> Change-Id: I68c7d067b6912b0cc0ecde231501dbed92f0b189
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2321735
> Commit-Queue: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Charlie Lao <cclao@google.com>

TBR=timvp@google.com,jmadill@chromium.org,cclao@google.com

Change-Id: I75041532fc5126b4c7cc5e0d4529883fb357e05b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4873
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2383870Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8d412db2