This patch fixes a bug in BlitGL::clearRenderbuffer() by removing
all the attachments of mScratchFBO before attaching the real
target of clear to keep mScratchFBO always being incomplete.

Without this fix, the WebGL CTS tests mentioned in issue 2760 will
fail on Intel OpenGL drivers when Chromium is using pass through
command buffer because when a multisampled depth renderbuffer is
attached to mScratchFBO, mScratchFBO will sometimes become
incomplete because it may already have a non-multisampled color
attachment.

Bug: angleproject:2760
Test: angle_end2end_tests
Change-Id: Id206fb4b338545ab46aba118e80d288158dcd8ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612305
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

on Win AMD OpenGL

Bug: angleproject:3478
Change-Id: I8f0ffeb0da31d08f4f4f45048d295c847cf095bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1626328Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Allow importing file descriptors into semaphores on linux. This can be
used to synchronize ANGLE's GL renderer with respect to vulkan
composition in chromium.

Bug: angleproject:3289

Change-Id: I04ba3bbb2e343baa000ff89c21c03ca36163a713
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1623812
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Add ARB_shader_viewport_layer_array support to
SH_SELECT_VIEW_IN_NV_GLSL_VERTEX_SHADER.

Bug: angleproject:3404
Change-Id: Ia89517d0cc92400ce47c9118e8c1abf8285aec41
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1585452Reviewed-by: Jamie Madill <jmadill@chromium.org>

When Stop is returned, the ProgramD3D::GetExecutableTask attempts to pop an
error that has not been set.  Returning Incomplete matches the other error
cases in program binary loading.

BUG=962439

Change-Id: I70895ddc706045620e3df219681982357b7b63e5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1620914Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

The sampler returns colors with components in the range 0-255.

Bug: chromium:963595
Change-Id: I7030ab9da6e0803e3aaf8aef4691ce7276636b10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1617778Reviewed-by: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This implements glGenSemaphoresEXT, glDeleteSemaphoresEXT, and
glIsSemaphoreEXT. It's not possible to do anything useful with them yet.

Bug: angleproject:3289

Change-Id: I20ad90dbcd3fc573a4650c8531d6e1b8ccf7ca9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1623811
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Add a new packed enum gl::ImageLayout which consists of the following
enum values:

  GL_LAYOUT_GENERAL_EXT
  GL_LAYOUT_COLOR_ATTACHMENT_EXT
  GL_LAYOUT_DEPTH_STENCIL_ATTACHMENT_EXT
  GL_LAYOUT_DEPTH_STENCIL_READ_ONLY_EXT
  GL_LAYOUT_SHADER_READ_ONLY_EXT
  GL_LAYOUT_TRANSFER_SRC_EXT
  GL_LAYOUT_TRANSFER_DST_EXT
  GL_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_EXT
  GL_LAYOUT_DEPTH_ATTACHMENT_STENCIL_READ_ONLY_EXT

Bug: angleproject:3289

Change-Id: Idc1615717d54fb1193e2f27c84a24993f6007d7b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1623810Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

This patch fixes two issues in the HLSL generated to sample an integer cube map.
The first issue was that an inappropriate major axis was selected when sampling
from corners of the cube map. In particular, the added test case demonstrates a
situation where a major axis of length 0 was selected, which lead to an infinite
LOD being calculated. The fix was to adjust inequalities such that always
exactly one of xMajor, yMajor and zMajor is true.
The second issue was that the derivative functions ddx and ddy were being used
on values that depended on the choice of major axis, which is not continuous at
the corners of a cube map. This lead to a finite but incorrect LOD being
calculated. The fix was to make sure major axis choice is not included when
estimating the scaling factor.

Bug: angleproject:3442
Change-Id: Ia3eb8c89f47d1bfdadc18aec989e8cbebc088ec0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601515
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47741f05043a..d9c00e1d2de1


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@d9c00e1d2de1

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I7d01bcf5c7ed218c3c6d095fd208f721a11c983c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1623927Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

UtilsVk::clearFramebuffer was not setting the sample count.

Bug: angleproject:3204
Change-Id: Iab7d385ec58b12f21d888c5dfc9e94b7846ac40c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1616858Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3464, angleproject:3470
Change-Id: Ie864118ceebfc0d72aa95928a02ef0939be5b89a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1620992Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

The new binary has the ability to optimize SPIR-V code.

Bug: angleproject:3432
Change-Id: I57ac99d2b1c5ee0678c3b6ab3db1e215a12bd08a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1620915Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

The new binary has the ability to optimize SPIR-V code.

Bug: angleproject:3432
Change-Id: I5953be6f207f153baaf2efe17380448aff374d60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1620913Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6e384fef6c0f..27ec91958501


Created with:
  gclient setdep -r ./third_party/glslang/src@27ec91958501

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I2a76cbdefe28e4122a16a7814c037dde80a1f361
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1621830Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9dfd4b835807..47741f05043a


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@47741f05043a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I4d1347d3fa7b089fa03012954de2660654b6d134
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1621847Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

$ export_targets.py <out_dir> <targets...>

Flattens all library targets under <targets...> and checks that all
includes in 'sources' are known to the build.

Firefox can use this as the first half of our ANGLE vendoring process.

Included additions to src/libGLESv2.gni were found with:
$ export_targets.py out //:libEGL

Eventually, it would be nice to have this as a presubmit check.

Bug: angleproject:3403
Change-Id: I0f455e8c37c4b0a9e17e9f843843422b6a32f588
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1584652
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

No behavior changes.

BUG=chromium:964411

Change-Id: I843757e65f110882c01514fe6bf4aed28e07dd21
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1617011
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Also includes a fix for case list paths on developer machines. Also
includes a test expectation update for GLES2.

Bug: angleproject:3353
Change-Id: Idb01eb8d806067739253a6676a6d2d8ee1199929
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1616853
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Checking against the max attribute count is not needed
as aliasing is implemented correctly below.  If not enough
locations are available, linking will fail.

This works for backends that support aliasing (Vulkan, GLES),
but not for D3D11, which asserts.  To handle this, add a
limitation that informs the frontend of aliased attribute support.

Bug: angleproject:3252
Bug: chromium:964404
Change-Id: Ib9ae5d381bbb2e6bf496272fc3d9e88467c17290
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1572817
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

A multisample image is created for the surface if multisampling is
enabled.  Prior to present, this multisample image is resolved into the
swapchain image.

FramebufferVk::readPixelsImpl similarly has got the ability to resolve
the region of interest into a temporary image prior to readback.

Tests are added to render a point, line and a triangle on a 4x
multisampled surface.

Bug: angleproject:3204
Change-Id: I34aca502fa1918b5cbf000ff11521c350372e051
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610188Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Update to new (public) sheet in chromium account.
Fix issue with python newline on concatenated string.
Ensure all tables are sorted by date.

Bug: angleproject:3435
Change-Id: I5de178409dec1e0dcf1467e4f0fe8cf85ea23c08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1609939Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Bug: angleproject:1944
Change-Id: Ifb8435c9e73f91acc69605e6a93c1d8e529db19f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1617010
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Per-stage uniform buffers are marked with the specific stage.  Program
uniform buffers and images are specified to be used in all graphics
stages.  Descriptors used in internal shaders are marked for use in
either compute or fragment stages.

Bug: angleproject:3220
Change-Id: Ifcac36a1224f0392ba5fba50660514e498256401
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595439
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

* Pipe webGL compatibility down to allow attribute aliasing.
* Reject aliasing if shader level is too high, or webGL is in use.

Bug: angleproject:3252
Change-Id: I3378fe707e3795a4b8a424989afccff42bc84344
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556538Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Our GN was using the incorrect path for the new test sets. This was
showing up as an isolate_tests failure when running the new tests.

Also fixes incorrect search paths for the case list directory when used
in a Chromium checkout. And adds a few other missing data dependencies.

Bug: angleproject:3353
Change-Id: I602db1e5debdad88b6eace76416fc2c10c059f8b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1616021Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4b0985f29277..9674a1a54754


Created with:
  gclient setdep -r ./third_party/spirv-headers/src@9674a1a54754

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I23c59c0273df539d1a9c0649dd2608550dd9c9f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1617361Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Few features are already implemented but the suppressions were not
removed.

Bug: angleproject:2392
Bug: angleproject:2394
Bug: angleproject:3199
Bug: angleproject:3219
Bug: angleproject:3423
Change-Id: Iefd6c10f5ec774e174901114b35410c0d397085f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614428
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This adds a few simple system utility functions. We can check if a
debugger is attached and break into the debugger.

Most of the code is adapted from Chromium's base/debug.

Bug: angleproject:3162
Change-Id: I9cb39d42865a543fbf3201222dd8227318b32ad5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1615353Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Due to complex and slow process of upstreaming it's easier to disable
this warning than to fix it upstream. Only happens in a Chromium build
because Chromium uses a specialized standard library.

Bug: angleproject:3353
Change-Id: I01607a00e469110c87458458d3b205fd59ea3db3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614426Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:1944
Change-Id: Ib0a9195ddaf5afc6f909631c859c7e0bd33d7a1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600050Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This reorganizes the dEQP build targets to allow for better reuse with
the new KHR test set. It also adds a single new test target called
"angle_deqp_khr_tests" that houses all the new test sets.

The new test targets can be compiled now but cannot yet be executed.
That new functionality will follow in a subsequent CL. Along with test
expectations and integration.

Uses a new template type in the build to conslidate GN customization.

Adds the GLES 2.0 and 3.0 tests for now. We can follow up with
additional work for the GLES 3.1+ tests. Also adds test expectations.

Bug: angleproject:3353
Change-Id: Ib0673e97f679c8aa46e27dfa616845a2014a75fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1604070
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:3199
Change-Id: I29fdf33ea5af37a66c2cfd5b3355d7ff32105d63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614781Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Some NVIDIA D3D11 drivers are buggy and interprets the level passed to
GetDimensions as being relative to 0, rather than the SRV's MostDetailedMip.
This affects integer cube maps because the dimensions are used for sample
position calculations, which leads to sampling outside the cube side textures
when the base level is non-zero.

Bug: angleproject:3441
Change-Id: I151f9336b9c6d8ec7012bf5010a2d45fb2951e73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1595688
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f815e6fe51af..9dfd4b835807


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@9dfd4b835807

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I036f558eed529ed640e0908e1fe30f50793646e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1614556Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Struct mapping consumes lots of time when the array lengh is very large.
And it's done unconditionally. This CL does struct mapping only if it's
a struct assignment or passing the struct to a function.

In the next step, we can use a function to do struct mapping instead of
struct array initialization.

Bug: angleproject:2967

Change-Id: Ie5a74fa05dbc0255ad664d6265dbb880a624f01e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1612978Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Refactor and cleanup only.

Bug: angleproject:3353
Change-Id: I2a01ddf71ba44b8f1a1fc2c4ccbac9edc7c80174
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613893Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This was previously a method in dEQP only. Cleanup change only.

Bug: angleproject:3353
Change-Id: I9ac58ab52516f75efbb08bddb39466a40c07cbb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1613892
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

ESSL 1.00 spec allows for variable with same name to override outer variable
inside of a nested scope. This change adds new scope to symbol table inside
of a function defintion, but after function parameters for ESSL 1.00
shaders (but not webGL). This prevents an error while parsing.

This also includes some new code in translator to rename any vars that are
redefined between the function body and the function parameters. This
prevents an error later on when the translated shader is then parsed as
a desktop GLSL version.

Bug: angleproject:3287
Change-Id: I3f025805cf8d65bf912283bb15e6dad6e5e9b967
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1601553
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Update the logic to compress ANGLE's symbols for Android to correctly
include the necessary symbols.

Bug: angleproject:3448
Test: Build and install APK, verify symbols are present during crash
Change-Id: Ibb995aa775d47fb9921e4ab11b956c63ac474c30
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1611750
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>