Commits · eb91ebc910bda1c67f103ee57fc91f0f1968bc1e · Chen Yisong / angle

11 May, 2021 4 commits

DEPS: Add Android tombstone resolution dependencies. · eb91ebc9

authored May 07, 2021

Add third_party/android_platform and tools/python from the Chromium git
to satisfy dependencies for the build/android/tombstones.py script.

Bug: angleproject:5933
Change-Id: Ie19eec46c8cab208cde5064118ae655303e12fa7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878848Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

eb91ebc9

Roll Chromium from 518c3462c0a9 to fff9d6fb8ddf (568 revisions) · e72fa36e

authored May 11, 2021

https://chromium.googlesource.com/chromium/src.git/+log/518c3462c0a9..fff9d6fb8ddf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9afdbde777..4ff4105cd8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/af6ff0bdef..504fae9f10
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1fbada9f29
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1039f6ca14..cb17bc6028
* third_party/r8: 9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C..gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/eb9ce8c993..618ddecd59
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbcffda598..e76c8f17cf
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9766067a3..df10bb0bf8
* tools/skia_goldctl/linux: UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC..EWfIod1MP71b48GlHnS5Rv9JpBzeTRQ6viIPDfFUSFEC
* tools/skia_goldctl/mac: aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC..5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC
* tools/skia_goldctl/win: OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC..O2WsBEJgyjTsib6LvzoNqqXwfSylJFfTRxEKYr-IsocC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: I70f2c157f5165905a9d3aca98dfccb7768b87d0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885448
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e72fa36e

Capture/Replay: reset CWD after the test ends · 2ba3763e

authored May 10, 2021

As suggested by Jamie

Bug: angleproject:5849
Change-Id: I3e548935a9119b7ca7ca392c50bcb0f58ae3e974
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882578
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2ba3763e

Skip EndWithDifferentProgram() on Vulkan+Pixel 2 · 2e84e59a

authored May 10, 2021

Skip the the test TransformFeedbackTest::EndWithDifferentProgram() on
Vulkan + Pixel 2 since it appears to be flaky.

Test: TransformFeedbackTest::EndWithDifferentProgram()
Bug: chromium:1207380
Change-Id: Iedfe1e96a204eca5954097be9e61820b775eb0b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2886358Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

2e84e59a

10 May, 2021 16 commits

samples: Use rpath on Linux/ChromeOS. · caf9742d

authored May 10, 2021

This will allow us to load ANGLE libraries without needing
LD_LIBRARY_PATH.

Bug: None
Change-Id: Iaa389b3a42fed37216e175bee080a9f8fde3eb0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2884418
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

caf9742d

Check angle_has_build before including runtime_deps. · 0639f7a9

authored May 10, 2021

This target doesn't exist in Skia.

Bug: angleproject:5940
Change-Id: I0095b771c0d57ec45bfd9294962c540d70679e6a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2884700Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

0639f7a9

Tests: Add --fixed-test-time option · 913bc473

authored May 07, 2021

Similar to --max-steps-performed, don't do any calibration and
just run flat out for a fixed amount of time.

Also rename --test-time to --max-trial-time to reflect what the
parameter actually does, limiting each trial to a ceiling.

Also remove a redundant check in doRunLoop.

Test: angle_perftests --fixed-test-time 20
Test: angle_perftests --max-trial-time 2
Bug: angleproject:5935
Change-Id: I854799a734cd6c019399f5a1444b4ef5f659ddf4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878937Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

913bc473

Tests: Run Android tests fullscreen · 74177f31

authored May 09, 2021

In order to hide the status bar and hopefully prevent any layers from
rendering on top of our traces, make all Android tests run fullscreen.

Test: angle_perftests
Bug: angleproject:5937
Change-Id: I649104a7d95b7f056b411e180632524a85b7c4f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880335Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

74177f31

Translator: Ensure structs and blocks are uniquely defined · daeac238

authored May 08, 2021

A new AST validation is added to ensure that the same TStructure or
TInterfaceBlock is not redundantly defined.  This helps with SPIR-V
generation by allowing the id to be used as key in a hash map that looks
up the corresponding SPIR-V type id.

A bug is fixed where the Vulkan driver uniform declaration created two
identical declarations for ANGLEDepthRangeParams.

A number of other bugs are also fixed in this change, where if a
variable declaration is eliminated (for example due to constant folding,
or inactive interface variable removal) and it contained a struct
specifier, the struct declaration was also removed.  OutputGLSLBase had
a hack where structs were declared on first encounter, which was
incorrect as the scope of the declaration could change.  Those bugs are
fixed and this hack is removed.

Bug: angleproject:2733
Bug: angleproject:4889
Bug: angleproject:5936
Change-Id: I8e13748c0bf552ae8b052249282769a1f0775603
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2881942Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

daeac238

Vulkan: Add device local fallback in findCompatibleMemoryIndex(...) · 84d22197

authored Apr 26, 2021

When finding a compatible memory index for an external buffer,
we need to have a fallback path that requires just the
VK_MEMORY_PROPERTY_DEVICE_LOCAL_BIT property.

Bug: angleproject:5909
Change-Id: Id3faffb3e357be2e5e6f5fce9e64f0f2889d199a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862561Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

84d22197

Remove Settings GUI from AOSP Builds and make product-specific · 417d912a

authored May 05, 2021

The Settings GUI is being removed from the AOSP build to turn the ANGLE
APK into essentially a container APK containing the necessary libraries.
This reduces the APK size and reduces the risk of users enabling ANGLE
by accident.

Additionally, ANGLE is being marked product-specific to remove it from
all AOSP builds.

Bug: b/187345862
Change-Id: I6e1acb9c6e07b419d40aee43d7260060027999ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876213Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

417d912a

infra: Remove duplicated trybots from the CQ. · 91429bb1

authored May 04, 2021

Removes duplicate Linux, Win and Mac testing.
These are superceded by the standalone bots now.
Android is still entirely Chromium-based.

Bug: angleproject:5114
Change-Id: I745758547b2eaa5f82779b11e7f3a8512c3cdd94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2872072Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

91429bb1

Roll SwiftShader from e839645bb9a6 to e260190edbd2 (2 revisions) · d6fc7cb0

authored May 10, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/e839645bb9a6..e260190edbd2

2021-05-07 sugoi@google.com Obtain all sampler parameters through SamplingRoutineCache::Key
2021-05-06 swiftshader.regress@gmail.com Regres: Update test lists @ 04c037ac

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I4d1a116358713f00ebd92d78ddb62e0a7b47baf6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883237
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d6fc7cb0

Roll vulkan-deps from 13d25088cdc6 to d3354ebca460 (6 revisions) · 16337b86

authored May 10, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/13d25088cdc6..d3354ebca460

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/41e39c615b..9431c53c84
* spirv-cross: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/72a2ec4c1b..418542eaef
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/3f437c4a94..9af411e83f
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/157c4bfe15..5ef1ec1b87

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com
Change-Id: I1d9cf668527a0d1e7f31ab2e212bebcd42fbcbeb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2883081
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

16337b86

Roll Chromium from 5f1f8ce65c68 to 518c3462c0a9 (330 revisions) · 8707d240

authored May 10, 2021

https://chromium.googlesource.com/chromium/src.git/+log/5f1f8ce65c68..518c3462c0a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/7ca66f4b1c..9afdbde777
* buildtools/linux64: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810
* buildtools/mac: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/5f51521620..767de317f9
* buildtools/win: git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5..git_revision:39a87c0b36310bdf06b692c098f199a0d97fc810
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/ce51767483..af6ff0bdef
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..98fd7ff368
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/360f981956..1039f6ca14
* tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431
* tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431
* tools/luci-go: git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d..git_revision:91769f0e2541d15de294dfc780205e98b49f7431
No update to Clang.

Bug: None
Tbr: ianelliott@google.com
Change-Id: I3d7b01d99898b9a087e62d4ec65a21837a7cb9cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882480
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8707d240

TracePerfTest: Delete offscreen objects only when initialized. · c0d42fd9

authored May 06, 2021

Delete Textures, Renderbuffers and Framebuffers that were created in the
SurfaceType::Offscreen case, when they were initialized.

This caused a crash when replaying traces using GLES 1 contexts
on native GLES Android implementations.

Bug: angleproject:5932
Change-Id: Ice4bcec620a6c3530044986ce39230b030a901ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877234Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

c0d42fd9

Capture/Replay: Add GLES1 test expectations. · a83fe36d

authored Mar 09, 2021

Add failing OpenGL ES 1.0 capture / replay tests to expectations list.
The remainging 65 test pass on ES1 SwiftShader.

Test: python3 src/tests/capture_replay_tests.py --gtest_filter="*/ES1_Vulkan_SwiftShader"
Bug: angleproject:5751
Change-Id: If5157a3ac0ccebc904316ae08c54e670119384e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877233Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

a83fe36d

samples: Add TorusLighting sample. · d1da88ee

authored Apr 28, 2021

Add a vertex buffer example for GLES1 and 2.

Bug: angleproject:5751
Change-Id: If039451ff85dfffd8915497e9aaaab6e4ff71181
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859827
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d1da88ee

Update entry points for GL_EXT_texture_sRGB_RG8 · bca7c408

authored May 09, 2021

Bug: angleproject:4932
Change-Id: Ie210a9dd342581adb71af4782383be2bb3ffd6a3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880667Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

bca7c408

FrameCapture: Capture GLES1 vertex buffer pointers. · 78fb9314

authored Apr 29, 2021

CaptureVertexPointerGLES1 was expecting only client-side vertex arrays
and not checking whether a vertex buffer was bound. This patch fixes
offsets in vertex buffers for GLES1, which can be seen in apps like
Dr. Driving.
The mClientVertexArrayMap index is now retrieved by entrypoint name, as
the arrayClientPointerIndex is unset in the vertex buffer case.

Bug: angleproject:5751
Change-Id: If40cae56bcdbed57885e83c49291cb000a884b0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859826Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

78fb9314

08 May, 2021 3 commits

Translator: remove image2DRect · d469dcb1

authored May 06, 2021

There is no such thing as image2DRect in GLSL. imageRect (the right
type) is present, but the code was mistakenly using image2DRect.

Bug: angleproject:4889
Change-Id: I42bacd2ad8866c715af0d9711bebc95897607354
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878095Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d469dcb1

Vulkan: Cleanup buffer format fallbacks · 7828506a

authored Apr 06, 2021

- Fallbacks for formats that have required vertex attribute support are
  removed.
- Fallbacks are changed to ones with smaller sizes
- A bug is fixed where CopyNativeVertexData wasn't initializing the
  alpha channel appropriately, which was not exercised due to fallback
  to 32-bit float formats.

Bug: b/184163871
Change-Id: Icd9afa49d94c65545d1f3fcf521881726d64529d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809441Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7828506a

Use ANGLE GL for Lacros Chrome · 730bbcbb

authored May 06, 2021

Currently, no ANGLE platform flag is enabled for Lacros Chrome.
GL is selected as default by this change for ChromeOS in general.

Based on change by Eriko Kurimoto <elkurin@chromium.org>

Bug: chromium:1203176
Change-Id: I539a459b6d3db60da191570e933afd8d06d3c3eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877010Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

730bbcbb

07 May, 2021 4 commits

Roll Chromium from f4228a4b663d to 5f1f8ce65c68 (809 revisions) · b33a8279

authored May 07, 2021

https://chromium.googlesource.com/chromium/src.git/+log/f4228a4b663d..5f1f8ce65c68

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC ianelliott@google.com,ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/a5d4757ed0..7ca66f4b1c
* buildtools/linux64: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5
* buildtools/mac: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5
* buildtools/win: git_revision:6771ce569fb4803dad7a427aa2e2c23e960b917e..git_revision:7b23bd91f996722e5e55e0ccf0c80c0a984efca5
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/7359f2c06d..ce51767483
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c92267a4b7
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5009fd68ac..360f981956
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/24e310554f..b7bef8c05b
* tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d
* tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d
* tools/luci-go: git_revision:1b257aacd4934e5a8b2508b240ffc7d866df9273..git_revision:fa78eb7ab25ca5d574c0741c8c1a02d6fd7ed66d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/9c6e20569c..d9766067a3
* tools/skia_goldctl/linux: qFSgTPN6Qn1vdxIOe4gDnS7rsfvJpQ63e0fEOHdwwK8C..UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC
* tools/skia_goldctl/mac: wEpZZg5Ap8EImS0KyVLAaILjjArMqHjI4T4y2MKKd5MC..aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC
* tools/skia_goldctl/win: kT3OqAqb0i8bSfls2rf77GfIiw0YSfqm97knAwMxkCcC..OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC
No update to Clang.

Bug: None
Tbr: ianelliott@google.com,ynovikov@google.com
Change-Id: I0ec0452805b7872f52ca997bb83f4ca8adcbc739
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878570
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

b33a8279

Vulkan: Don't assume host visibility for external buffers · 2d5df9d9

authored May 01, 2021

When importing external buffers, Vulkan ICDs could choose to
import the memory into a memoryType that doesn't support the
VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT property. Account for this
possibility.

Bug: angleproject:5073
Bug: angleproject:5909
Change-Id: Ied063b38fa48d0c8508c4aaca9214cc526f393ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2783669
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2d5df9d9

infra: Re-enable swarming tests. · e61909f6

authored May 06, 2021

Changes since the revert:

 - Include runtime_deps: http://crrev.com/c/2878093
 - Add missing perf scripts: http://crrev.com/c/2877011
 - Include build_properties: http://crrev.com/c/2878373

Bug: angleproject:5114
Change-Id: If7d1e5693c4ade72d3f45f5d60635cb27de7599e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877012Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e61909f6

Remove redundant OpenCL ICD library · 39ba247d

authored May 06, 2021

Removed redundant OpenCL ICD library, using regular OpenCL library
instead.

Bug: angleproject:5908
Change-Id: I1ecf5347557106511aed3c5c4a4bfa35590a559a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877240Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

39ba247d

06 May, 2021 13 commits

capture_gles_1_0: Implement ES1 capture functions. · abab4739

authored Apr 28, 2021

Capture glLight, glLightModel and glMaterial and adjust size by enum.

Bug: angleproject:5751
Change-Id: I2fcf35575e344703033bf426c3ed0046dfe93337
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2859825Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

abab4739

Vulkan: Handle GL_MAP_PERSISTENT_BIT_EXT for external buffer · cc3e7b5d

authored Apr 26, 2021

When user specifies GL_MAP_PERSISTENT_BIT_EXT bit for an external
buffer but we are unable to import it into a memoryType that supports
host visibility, error out with GL_INVALID_OPERATION error.

Bug: angleproject:5073
Bug: angleproject:5909
Change-Id: I03e5477266dfb705bfb0a1bce5ca003049ef4c7a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862560
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

cc3e7b5d

Add missing perf results merger scripts. · eb6548bb

authored May 06, 2021

While waiting for the git mirror to become available we need to clone
these scripts into ANGLE. These scripts are required for the merge
step to work properly.

Bug: angleproject:5114
Change-Id: Ie917149972c8339419b1e3a6d0cf6712fb9888d5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877011
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

eb6548bb

Allow translator to use headers from common/spirv · 81f03cc0

authored Apr 07, 2021

Bug: angleproject:4889
Change-Id: Ia297888a97c0ba9cec1283db7f94f2e5b362c27e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815179
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

81f03cc0

Explicitly include "runtime_deps" on Windows. · 08805e35

authored May 06, 2021

For applications and tests, we need the runtime deps for component
builds. It still like this omission was causing test failures on
Intel in standalone.

Bug: angleproject:5114
Change-Id: Ifd9e90b28f985e4d2d1392a97ecb75907290f5ff
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878093
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

08805e35

Vulkan: Honor mapRangeImpl and unmapImpl abstraction · fc0c8d18

authored Apr 27, 2021

All BufferVk methods need to honor the abstraction provided by
mapRangeImpl and unmapImpl. Do not map BufferVk::mBuffer directly,
this is needed for when we support device local buffers that
cannot be CPU mapped.

Bug: angleproject:5909
Change-Id: I520e5cc0994560a3784b8978e349550211dc2cde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2862559Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

fc0c8d18

Roll VK-GL-CTS from 9698f0db4cd5 to dab93ea8f88c (1 revision) · cffd5d87

authored May 06, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/9698f0db4cd5..dab93ea8f88c

2021-05-06 alexander.galazin@arm.com Merge pull request #261 from Joshua-Ashton/mingw-support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com
Change-Id: I51fd5c99bf9ae6e0c4542543137c020b8c6cef2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876681
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cffd5d87

[Fuchsia] Disable Vulkan validation · c59b9a33

authored May 05, 2021

Vulkan is being updated on Fuchsia. Disable validation to unblock it.

Bug: fuchsia:73208
Change-Id: I8a6eecc16ef021d379cfcca8795896a6e6dae11c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876070Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c59b9a33

Add warning messages for not (yet) supported CL commands · dc92d881

authored May 04, 2021

Bug: angleproject:5904
Change-Id: I24e6a4d5cf4cc824751ff45e962bee16489fdbdd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2871450
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

dc92d881

infra: Temporarily disable all swarming tests. · 1572c372

authored May 06, 2021

There seem to be some unusal failures on CI. Maybe Try as well.

Bug: angleproject:5114
Change-Id: Ia681d6fdb8575b851dd526c1ab9463ad047735c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875767Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1572c372

Revert "Temporarily remove standalone tester bots from CQ." · c75969e1

authored May 06, 2021

This reverts commit 8f26346b.

Reason for revert: Should be fixed by updated exclusion spec.

Original change's description:
> Temporarily remove standalone tester bots from CQ.
>
> Due to RECIPE CRASH, e.g.
> https://ci.chromium.org/ui/p/angle/builders/try/linux-clang-rel/21245/overview
>
> No-try: true
> Bug: angleproject:5114
> Change-Id: I42f76fb370ee5423430955643bffb8c2204fa25f
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2875717
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:5114
Change-Id: I781a5a409a9ede005feaf0f3d7bcedac31eaa036
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876986Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c75969e1

infra: Fix exclusion spec JSON. · aa19de17

authored May 06, 2021

The extra comma caused the CQ to fail reading the file.

Bug: angleproject:5114
Change-Id: I5d36f1ae7c4dc5ebcb5599d5cd37471ee4085990
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2876985Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

aa19de17

Add loader for CL pass-through back end · dfe208f1

authored Apr 28, 2021

Bug: angleproject:5904
Change-Id: If4960f3150f6bbc85a30f0f6ac5c9e668e6ff756
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2864022
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

dfe208f1