- 14 Sep, 2020 14 commits
-
-
Jamie Madill authored
Bug: angleproject:5040 Change-Id: I64f762b4eb5734f0768054a330a36e20ff9ba93e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408713 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Charlie Lao authored
When draw buffers set to GL_NONE, instead of remove the attachment from renderpass which breaks renderpass, we force vulkan's per buffer color mask to false while keep the disabled draw buffer attached. This CL also always create FrameBuffer with all color attachments regardless it is enabled or not. Bug: b/167301719 Change-Id: Ice9fca9aacf774a47d13b749f822b222cc050174 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2389007Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
glRenderbufferStorageMultisampleEXT is special in that it doesn't have the same semantics as glRenderbufferStorageMultisample, but is aliased in gl.xml for the sake of desktop GL (where it does have the same semantics). This change special-cases this function so multisampled-render-to-texture renderbuffers can be supported. Bug: angleproject:4881 Change-Id: Iaa321dd0671dd82ea802df22a1ae935942789c21 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405395Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Le Hoang Quyen authored
Bug: angleproject:2634 Change-Id: I36e5a6a4cb11d82f666c410b33fdb39ad35a5e80 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336557Reviewed-by:
-
Jamie Madill authored
This will allow the isolation scripts to correctly package the trace data GZ file. Bug: angleproject:5040 Change-Id: I9e0229701eb10ea5e46b79304c8da47a42ba552d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408718 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This allows us to use the sample for benchmarking. Bug: angleproject:5040 Change-Id: I9177d04b270a0588dc5f261918eb27b0bc734256 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408716 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
This moves the debug callback code into a common location. For ease of access it's in shader_utils since that file has access to the GL API. Bug: angleproject:5040 Change-Id: Iab9de47c2d520a5618ea6825852f8afa63565c8a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2408715 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
Amy Liu authored
The input coordinates of blitResolveStencil compute shader start from 0,we need to align the sample position to start from 0 if x/y is flipped. Test: dEQP-GLES3.functional.fbo.invalidate.*.unbind_blit_msaa_* Bug: b/159995959 Change-Id: If0c9f5b7cacddbe1a2d7062469a757a63bcc1378 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392162 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Ian Elliott <ianelliott@google.com> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41974f57973e..dc552fcef1fe 2020-09-11 capn@google.com Drop the float literal suffix If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I30a1c103cea3d1b53a3af8d03ab611c545bbf0e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409384Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/45f2f18a69eb..399f7fd741f7 2020-09-11 pdaniell@nvidia.com loader Fix issues with physical device sorting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I6e7d4257242966479d0b36beecc8432f8086bc4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409383Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/3114c91b037b..e59713d4edda 2020-09-12 mark@lunarg.com corechecks: Remove memory shadow copies 2020-09-11 jzulauf@lunarg.com syncval: Add missing WAW suppression 2020-09-11 tony@lunarg.com gpu: Pass-through driver-returned PipelineFeedback data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I80145595ddb4f398a7621598aad0155c743f7bce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409381Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2de7d3af0c0e..726af6f78f80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I26842b1895871dd0922bd8be0a1f9c81d2cac537 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409382Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6a6e311d81dd..f8a5602c5560 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jmadill@google.com Change-Id: I2a2331f1be2bd6f712de60d9699bcd9fa7e037b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409380Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/fe51fcb522cc..1960f3b23408 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/41b95e3b54..dc90e7d103 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/64f2e1cf55..598b9bd5a4 * third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9d4f8005bc..8ca19625de * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/97d6ab3da3..bf815f1a74 No update to Clang. Bug: None Tbr: ianelliott@google.com Change-Id: I3f240027d8bf02aac6a9bef69bf6aea49751beef Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2409194Reviewed-by:
-
- 12 Sep, 2020 3 commits
-
-
Jamie Madill authored
This will allow the Android test runner to work seamlessly with the ANGLE GTest runner script. Bug: angleproject:3162 Change-Id: Id20d2fd05eb01e90a5a884891d9a1aa609ca744d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407837Reviewed-by:
-
Mohan Maiya authored
When an image is backed by an external source like an AHB we need to refcount the buffer appropriately to prevent deletion of the buffer while in use. Bug: angleproject:5018 Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceAHBTarget2DEarlyDelete* Change-Id: Ib6318fc3dc442460d1a2bdd6d75a4458895667bb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406615 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Jamie Madill authored
These were missing from debe4683. Also fixes a misnamed "perf" parameter. Bug: angleproject:3162 Change-Id: Iad4c4d8d35cc8a08d0e30d50dd9bbf159a4a7ab9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2407833 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
- 11 Sep, 2020 16 commits
-
-
Mohan Maiya authored
During cleanup, we were incorrectly calling glDeleteRenderbuffers on a texture object. Also update comments to correctly reflect intent. Bug: angleproject:5018 Change-Id: I28eaf6a23056f3b09eebb7331620e6a27cb14302 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2406614Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/a48ed7c29144..b045bf7d3b6a 2020-09-11 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/master 2020-09-11 ari.suonpaa@siru.fi Add coverage for uniform texel buffer SNORM formats 2020-09-11 gleese@broadcom.com Test OpVectorShuffle with index -1 2020-09-11 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master 2020-09-11 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/master 2020-09-10 lionel.g.landwerlin@intel.com Test imported signaled sync fd for VkSemaphore 2020-09-10 slawomir.cygan@intel.com Make pipeline destruction exception aware in subgroups tests 2020-09-10 venni.ihanakangas@siru.fi Check support for sampleRateShading 2020-09-07 alexander.galazin@arm.com Update Vulkan headers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll Please CC ianelliott@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com,angle-bots+autoroll-info@google.com Change-Id: I00ec89b97722894e6ee357451d5b71f4a70fd446 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405394Reviewed-by:
-
Jamie Madill authored
Stresses the RenderPass buffer tracking in the Vulkan back-end. Bug: angleproject:4950 Change-Id: I33d38d8703d0e333d0092195d34228d90f1af52a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358522Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Shahbaz Youssefi authored
Semantic revert of 78304b47 and 7bce5194. 7bce5194 assumed that a read transition between same layouts is a noop, but that's not true if said layout is GENERAL. This is only possible if an image is simultaneously bound as storage and sampled image. This bug was discovered by the new syncval VVL warning. Bug: b/156661359 Change-Id: I05f94160ca1b05b715701564e27fccee31a8aa45 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404742 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Geoff Lang authored
StandardQueryGL flushes with every pause/resume/end operation to make sure the list of pending queries does not grow too large. This ended up trying to flush the queries as soon as they were ended and unlikely to have results ready. Add a threshold of pending queries before flushing, hopefully delaying the flush calls until the queries are ready. This is a speculative fix for a GPU hang in query flushing. Bug: chromium:1078754 Change-Id: I38300995ee6576dee8c8c26fa9ccad26e269337a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401178Reviewed-by:
-
Courtney Goeltzenleuchter authored
We were using a passed in commandBuffer in ImageHelper::flushStagedUpdates which became invalid during the process of handling the flush upon which subsequent uses could cause problems when threading is enabled (and maybe when it's not as well, just harder to see.) Have ImageHelper::flushStagedUpdates use the current OutsideRenderPassCommandBuffer and the code will use the proper one. Bug: b/168144059 Change-Id: Ib9849efe9366cf61df5e68fd25d17df165dbd3a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2402354Reviewed-by:
-
Courtney Goeltzenleuchter authored
This enables precision qualifiers to be included in the translated GLSL and the generated SPIR-V. We do not enable precision qualifiers on Pixel 2 with Android Q due to bugs in the Vulkan driver. Issues appear to be fixed with later Android releases and later devices. Bug: angleproject:3078 Change-Id: Ia5f40befc7ec80fbb63fb6bbe88600301967f9c9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2350583 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/fcb7ecbe49c5..3114c91b037b 2020-09-10 lionel.g.landwerlin@intel.com layers: CodeGen VkPerformanceConfigurationINTEL validation 2020-09-10 s.fricke@samsung.com scripts: Add SPIRV-Tool option to stats 2020-09-10 locke@lunarg.com layers: Remove VUID-vkCmdDraw-None-02698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ida1733b8a6562b7affed4de5d41f71d92e4e0486 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405967Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b24900a1aa39..41974f57973e 2020-09-10 jaebaek@google.com Allow OpTypeVoid for debug function return type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I03a77041e3fe88df2f8b172df5e92afe45fd7d14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405970Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/ccab4cc42372..d19622688af4 2020-09-10 shannon@lunarg.com build: Update known-good files for 1.2.153 header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: Ic6110d1ece16436a7bd613c8bb02b1a10ec801ed Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405969Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/30a5da059e5d..fe51fcb522cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/8984f7a2c3..41b95e3b54 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/e4f04cd4f5..64f2e1cf55 * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/de8d9210e5..9967a97317 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/898c6c0dd9..f8517bd629 No update to Clang. Bug: angleproject:4846 Tbr: ianelliott@google.com Change-Id: If0d924a9a1093b5798e2e95951b894b390c38dc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2405784Reviewed-by:
-
Jiawei Shao authored
Previously on the OpenGL backend we get the device ID with funtion GetDeviceID() which just supports a few types of devices. This patch fixes this issue by using angle::GetSystemInfo() instead. Bug: angleproject:5011 Change-Id: Ief0e1228bb1871a73755f05f2debd3a8e5c75597 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2392634Reviewed-by:
Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
-
Jamie Madill authored
Needs one suppression due to Clang warning about multiple vtables in a cpp file. Bug: skia:7647 Change-Id: If7f318b7539d23f783b0ef6d6478ce24a0b72bc7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404746 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Courtney Goeltzenleuchter authored
GLSL allows varyings passed from one stage to another to not match in precision (e.g. float & half-float). Vulkan doesn't allow that so adjust those mismatches to use the higher precision. To fix we keep track of the precision of varyings and in the Vulkan backend if we see they are different patch up the SPIR-V to make them match. Bug: angleproject:3078 Change-Id: I385d31e082da46ccdd4817b6612f5f9d9cbce17c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2337755 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
Courtney Goeltzenleuchter authored
Follow-on CL needs the ProgramMergedVaryings in the Vulkan backend to generate valid SPIRV. Bug: angleproject:3078 Change-Id: Ic442a3e0bd713fec36bd6b9420f67f3b1118e5ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404336Reviewed-by:
-
Jamie Madill authored
Bug: skia:7647 Change-Id: I568cb63118c944c7eca7efcd2445718dc7fda350 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404745Reviewed-by:
-
- 10 Sep, 2020 7 commits
-
-
Jonah Ryan-Davis authored
This workaround should also clear the shader binary formats. Also, we can use this workaround when disabling program binaries for capture/replay. Bug: angleproject:5007 Change-Id: I57c78e2cc95e7148cb8a1e7fb9bf3ed958fa69c8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404383 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Hidehiko Abe authored
Currently is_linux is set to true on Chrome OS build, but it is planned to set to false. This CL is the preparation to keep the current behavior. Bug: chromium:1110266 Test: Built locally. Tryjob. Change-Id: I4124dfb251d68a519fed3e08555d1aa5a694c77c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404500Reviewed-by:
-
Alexis Hetu authored
Used angle::CheckedNumeric to make sure none of the additions in ClipRectangle produces an integer overflow. Bug: chromium:1091364 Change-Id: I23b7943259010bb6bfde3d8ebc41e87a04f5b4f6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2404441Reviewed-by:
-
Shahbaz Youssefi authored
This shrinks the size of the mask for use in cache key classes. Bug: angleproject:4881 Change-Id: I87c234832c61e6a663c609b7f6da5d69977b21c7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2399182Reviewed-by:
-
Maksim Ivanov authored
Drop std::move() calls in places where there's no actual moving happing, and only the "bugprone-use-after-move" clang-tidy warning is triggered. Bug: chromium:1122844 Change-Id: I692da5af4f96305f09008d1c7fd18f9be7f6273f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2401241 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Tim Van Patten authored
We unconditionally link to $angle_spirv_tools_dir:spvtools_val, but we only use SPIR-V validation with ASSERTs. This CL removes this dependency when ASSERTs are disabled. Bug: angleproject:4887 Test: CQ Change-Id: Ic403b78196ecd895e4a0cdefb54ab4497651ccac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2375872 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4ede8ee6e2ec..fcb7ecbe49c5 2020-09-09 shannon@lunarg.com build: Update known-good files for 1.2.153 header 2020-09-09 shannon@lunarg.com build: Resolve last 1.2.152 VUID inconsistency 2020-09-09 tony@lunarg.com gpu: Intercept CmdDispatchBase to allocate input buffers 2020-09-09 s.fricke@samsung.com layers: Removed incorrect cmdDraw warnings 2020-09-09 baldurk@baldurk.org layers: Add a couple of missing % to printf specifiers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ianelliott@google.com Change-Id: I2eb5a218a9ede986c5a5c4c27dcba68b1380188e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2403052Reviewed-by:
-
