Skip to content

A
angle
Switch branch/tag
  1. 25 May, 2020 1 commit
  3. 24 May, 2020 1 commit
  5. 22 May, 2020 4 commits
  7. 21 May, 2020 14 commits
  9. 20 May, 2020 8 commits
  11. 19 May, 2020 10 commits
  13. 18 May, 2020 1 commit
    • Revert "Vulkan: Try to merge barriers if possible" · 8a90905c
      Charlie Lao authored 
      This reverts commit 153c14cb.

Reason for revert: The dependencyStrongerThan logic is incorrect and causing perf regression on ARM.

Original change's description:
> Vulkan: Try to merge barriers if possible
>
> This is try to reduce the number of vkCmdPipelineBarrier API calls into
> driver. It should not affect the actual barriers.
>
> Bug: b/155341891
> Change-Id: I57b8b8cdad50d494c76a008006bd54961170c8bc
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2194841
> Commit-Queue: Charlie Lao <cclao@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=courtneygo@google.com,timvp@google.com,syoussefi@chromium.org,jmadill@chromium.org,cclao@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/155341891
Change-Id: I8ebe7481b299af446dfd488874e64e6e60b4f764

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I8ebe7481b299af446dfd488874e64e6e60b4f764
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2205433
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: 's avatarCharlie Lao <cclao@google.com>
  15. 16 May, 2020 1 commit
    • Vulkan: Save linked ProgramExecutable data · d34ab323
      Tim Van Patten authored 
      PPOs need to support drawing with Programs that failed their last
linkProgram() if they had previously successfully linked. This requires
saving the ProgramExecutable when linkProgram() succeeds, and not
overwriting it with subsequent linkProgram() calls unil the next
successful one.

To achieve this, the new member ProgramState::mLinkedExecutable will
point to the last successfully linked ProgramExecutable and
ProgramState::mExecutable will point to a new ProgramExecutable when the
next linkProgram() is attempted. If the link fails, the newly allocated
ProgramExecutable will be delete()'ed and mExecutable will point to the
previous 'good' ProgramExecutable still being tracked by
mLinkedExecutable. If it succeeds, the old mLinkedExecutable will be
delete()'ed and mLinkedExecutable will be updated to point to the ne
one.

Bug: angleproject:4514
Test: KHR-GLES31.core.sepshaderobjs.StateInteraction
Change-Id: I0677602a6d652a055404667ec9e9305fed5b4177
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2181450
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>