Commits · ef9d63ec5a38ac6d41c0a3ba0ee9bde42090da54 · Chen Yisong / angle

22 Aug, 2014 3 commits

Move the index range cache to gl::Buffer. · ef9d63ec

authored Aug 04, 2014

Because we want to move all validation to the API layer, we need to
move the index validation to the API layer. This means exposing the
index cache to the validation layer.

In the future we will probably want a way to skip index validation
when it's not necessary, or the chosen back-end handles index
validation on its own.

BUG=angle:571

Change-Id: Iee1618e669bc28abf7e0709ca4a03b4727b1383e
Reviewed-on: https://chromium-review.googlesource.com/210646Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ef9d63ec

Fix std140 UBO layouts. · 33a74bde

authored Aug 18, 2014

A call to "prePadding" instaed of "prePaddingString" was confusing
the HLSL output engine.

A separate bug was causing HLSL errors because HLSL puts all cbuffer
members in a flattened namespace, which caused our internal padding
variables to overlap.

BUG=angle:725

Change-Id: I69a01fefa430a83e433385c64a532a69e6851ae8
Reviewed-on: https://chromium-review.googlesource.com/212930Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

33a74bde

Prevent accessing more arguments than provided. · ffd7387a

authored Aug 21, 2014

BUG=390111

Change-Id: Iecc2ac2354a82cca937a823e5c588c662264e36c
Reviewed-on: https://chromium-review.googlesource.com/213551Tested-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ffd7387a

21 Aug, 2014 9 commits

Use Range type for index ranges. · 39b43463

authored Aug 18, 2014

This compacts a lot of parameter passing. Refactoring patch only.

BUG=angle:571

Change-Id: Ic918478d0c6b81093bfea6154ce0f6bf1d2b5be2
Reviewed-on: https://chromium-review.googlesource.com/210645Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

39b43463

Split vertex translation into helper methods. · f41522b6

authored Aug 18, 2014

Refactoring patch only.

BUG=angle:571

Change-Id: I17e8c1eb80bdf7c3ec7cc4bad4e70e81590e4a89
Reviewed-on: https://chromium-review.googlesource.com/210644Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f41522b6

Fix "Reize" to "Re*s*izeWindow". · 39e7bc05

authored Aug 21, 2014

BUG=angle:730

Change-Id: I7d4e5a36cec2b3a5c61ae768ec4c816553031baf
Reviewed-on: https://chromium-review.googlesource.com/213292Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

39e7bc05

Make the EGLDisplay a non-static member of ANGLETest. · db74f18e

authored Aug 21, 2014

We would create and destroy the display with every test, as it
was not part of the environment.

BUG=angle:730

Change-Id: Iae003f13c8e975ae57d3af2d74f9f058a560046f
Reviewed-on: https://chromium-review.googlesource.com/213291Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

db74f18e

Make the sample app own the OS Window object. · 586666ce

authored Aug 21, 2014

This allows us to use OS Windows and EGL contexts differently
for different implementations - eg, tests and samples.

BUG=angle:730

Change-Id: I65e69fd829c3dbf2f1b406d90045bc296798ebb6
Reviewed-on: https://chromium-review.googlesource.com/213290Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

586666ce

Add a util project to share between samples and tests. · 1cfaaf8a

authored Aug 21, 2014

This code shares the Window and EGL logic between the two
projects.

BUG=angle:730

Change-Id: I8940371226a8f7b02579c332f51679c4a5d0e2a5
Reviewed-on: https://chromium-review.googlesource.com/212799Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

1cfaaf8a

Only set declaration operator if not already set. · 5f438061

authored Aug 20, 2014

This allows us to return different operators from single
declarations, which will be useful for treating invariant
declarations as different operators.

BUG=angle:711

Change-Id: Id278b91854bbefe8e635380d7b27198198236fef
Reviewed-on: https://chromium-review.googlesource.com/212939Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

5f438061

Add a helper method to parse invariant declarations. · 47e3ec08

authored Aug 20, 2014

This pulls out more functionality from the grammar into simple
c++ source files.

BUG=angle:711

Change-Id: I19121d710dc1543585361cb53a0deb2ea0479db9
Reviewed-on: https://chromium-review.googlesource.com/212938Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

47e3ec08

Add a getNamedVariable helper method to TParseContext. · 5c09702f

authored Aug 20, 2014

This method will be useful in more than one place, since we need
to get a TType from an indentifier when parsing invariant
declarations.

BUG=angle:711

Change-Id: I1c1befbdcc93ea626428fb4e313b8c6326c158f6
Reviewed-on: https://chromium-review.googlesource.com/212937Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

5c09702f

20 Aug, 2014 8 commits

Moved some validation back to Texture, unified all TextureImpl variants · 6053a52e

authored Jul 25, 2014

BUG=angle:688
Change-Id: Ie2df18277c84345fceaa31d4f63f5cbbb47540c6
Reviewed-on: https://chromium-review.googlesource.com/211387Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>

6053a52e

Rename intermediate.h to Intermediate.h. · b9b5c105

authored Aug 20, 2014

This was breaking the Linux build.

Change-Id: I8f63527cfa37ee774ea5d1e6eb0043a4c7ccc734
Reviewed-on: https://chromium-review.googlesource.com/213300Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

b9b5c105

Call addRef when creating a new Fence Sync object. · cfa33e62

authored Aug 19, 2014

BUG=angle:728

Change-Id: Iafd838c3ceb1a88afd4d3b0994e8d841945df499
Reviewed-on: https://chromium-review.googlesource.com/213142Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

cfa33e62

Rename compiler intermediate source files. · b1a85f48

authored Aug 19, 2014

This prevents confusion between "TIntermediate" and "TIntermNode".

BUG=angle:711

Change-Id: Ib7a086382a479db3f77bf2ab06ce321aa7b35d13
Reviewed-on: https://chromium-review.googlesource.com/212936Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

b1a85f48

Fix reversed shift in the huge SetData test. · 4f2bf3a5

authored Aug 20, 2014

BUG=angle:716

Change-Id: I1b621668b78373e0566f6eab6034993ec09aa4b9
Reviewed-on: https://chromium-review.googlesource.com/213221Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4f2bf3a5

Fix swizzle formats being assigned incorrectly. · 299fcf29

authored Aug 06, 2014

* Non-4 component formats cannot be used as swizzle formats.
* Unsized formats should not have swizzle formats.

BUG=angle:721

Change-Id: Ic4e2642f5dc4c9811768961fbab00f6edd200ce1
Reviewed-on: https://chromium-review.googlesource.com/211241Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

299fcf29

Remove the gclient file, it should be generated now. · 592dbb8e

authored Aug 05, 2014

BUG=angle:713

Change-Id: Icd3e9c5212baf4c1dc781df6fef68c078b054e1a
Reviewed-on: https://chromium-review.googlesource.com/210883Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

592dbb8e

Simplify the creation of OS-specific windows and timers in the samples. · 8def9aac

authored Aug 05, 2014

BUG=angle:521

Change-Id: I9550269e9cd67fc24246853bec3c1f67cb16da2a
Reviewed-on: https://chromium-review.googlesource.com/211130Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8def9aac

18 Aug, 2014 1 commit

Amend comment about nameless structs & layout qualifiers · b8c0a832

authored Aug 15, 2014

Change-Id: I1177c808bffd2beba7d52bd8f8869125a1624698
Reviewed-on: https://chromium-review.googlesource.com/212700Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

b8c0a832

15 Aug, 2014 1 commit

Minor cleanup to Query constructor to normalize it with other interfaces · 3b579e36

authored Aug 08, 2014

Change-Id: I562245cf6323edc7a127480e8de6ac16c6f97c03
Reviewed-on: https://chromium-review.googlesource.com/211641Tested-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

3b579e36

11 Aug, 2014 3 commits

Initialize TranslatedAttributes · 20ba154c

authored Aug 11, 2014

BUG=398337

Uninitialized TranslatedAttributes were causing false positives
in checks for nonzero attrib divisor.

Change-Id: I44655d3fbe4f5478ca3757e05db38799d014e4c7
Reviewed-on: https://chromium-review.googlesource.com/211931Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

20ba154c

Fix application of vertex divisor for non-instanced draws in D3D9 · 09cf736b

authored Aug 08, 2014

BUG=398337

*Re-land*

ANGLE_instanced_arrays defines the behavior of the non-instanced
draw calls (glDrawArrays, glDrawElements) such that they behave as
single-instance draws, so the vertex divisor should still apply. We
were handling this correctly in D3D11, but not D3D9.

This fixes a new WebGL conformance test:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/angle-instanced-arrays.html

Change-Id: I5ed09d41229c8996a78a3b55893c6a655a423644
Reviewed-on: https://chromium-review.googlesource.com/211930Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

09cf736b

Fix nameless struct handling. · bc75f36b

authored Aug 11, 2014

BUG=401296

The addition of layout qualifier handling in es3 development inadvertently
broke handling of nameless structs.

Change-Id: I805bab7a981d1f7f6227ae043720296fc3454662
Reviewed-on: https://chromium-review.googlesource.com/211860Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

bc75f36b

10 Aug, 2014 1 commit

Revert "Fix application of vertex divisor for non-instanced draws in D3D9" · 6f4423af

authored Aug 10, 2014

Other issues turn up on the FYI bots with this patch applied; reverting until this is investigated further.

This reverts commit 9f6907bf.

Change-Id: Ib30c51b2c905e87973c73b06baa4b8ebba31d210
Reviewed-on: https://chromium-review.googlesource.com/211683Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

6f4423af

08 Aug, 2014 3 commits

Fix application of vertex divisor for non-instanced draws in D3D9 · 9f6907bf

authored Aug 08, 2014

BUG=398337

ANGLE_instanced_arrays defines the behavior of the non-instanced
draw calls (glDrawArrays, glDrawElements) such that they behave as
single-instance draws, so the vertex divisor should still apply. We
were handling this correctly in D3D11, but not D3D9.

This fixes a new WebGL conformance test:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/angle-instanced-arrays.html

Change-Id: Ib50e189d866d6dc97612e46460db4ca1723b3662
Reviewed-on: https://chromium-review.googlesource.com/211445Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

9f6907bf

Regenerate default projects for recently added shader translator changes. · baa34bea

authored Aug 08, 2014

Change-Id: Ic9b8758477d334a0dcd564f5f2548b5a64584fc7
Reviewed-on: https://chromium-review.googlesource.com/211444Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

baa34bea

For SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS, assign precision to temp variables. · daf56572

authored Aug 06, 2014

Otherwise on Windows or other platforms with GLES backend, using this workaround
will trigger shader compile failure.

For the moment, to simplify the workaround, for any missing precisions in float,
we always assign the highest available precion to it.

BUG=angle:695
TEST=webgl conformance tests

Change-Id: I810579442bc7fc61d6a52b76aff31a779046fa22
Reviewed-on: https://chromium-review.googlesource.com/211253Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

daf56572

07 Aug, 2014 3 commits

Unifying the various texture interfaces where possible · cef06ff2

authored Aug 05, 2014

Also fixed diamond inheritance pattern that was causing trouble
on Windows 8

BUG=angle:688, angle:720
Change-Id: I678826bd4f3927c68ca1eb2e018dbb5aad33a8cc
Reviewed-on: https://chromium-review.googlesource.com/211037Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

cef06ff2

Fix GN build with missing ShaderVars.cpp. · e5c97abd

authored Aug 07, 2014

Change-Id: I29be6cdda643f83a40a6adc9b76153667aafcc51
Reviewed-on: https://chromium-review.googlesource.com/211400Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

e5c97abd

Add compiler option SH_REGENERATE_STRUCT_NAMES. · e740addb

authored Jul 18, 2014

BUG=angle:701
TEST=webgl conformance tests

Change-Id: I13b35900956e7d840d5891a5bab90a400347cd6f
Reviewed-on: https://chromium-review.googlesource.com/209229Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

e740addb

06 Aug, 2014 1 commit

Export shader variables from the translator DLL. · a2ad4e8a

authored Jul 17, 2014

This will allow us to use these methods when compiling the translator
as a DLL.

BUG=angle:466,697

Change-Id: Ic9169fb7c69fe0bf5f98addfc128a30ee6b2159d
Reviewed-on: https://chromium-review.googlesource.com/208752Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

a2ad4e8a

05 Aug, 2014 3 commits

Move implementation of hasMappedBuffer to State. · d9ba4f73

authored Aug 04, 2014

Refactoring patch only.

BUG=angle:571

Change-Id: Ib9f3145eaa457d94e488fd42eb4c4b9133768996
Reviewed-on: https://chromium-review.googlesource.com/210643Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

d9ba4f73

Fix incorrect validation of ES3 internal format/format/type combinations. · baadf23a

authored Aug 04, 2014

* Fix wrong internal format being passed to ValidateTexImageFormatCombination.
* Fix ValidateTexImageFormatCombination validating the format instead of
  internal format for general support.
* Fix support checks for format and type comparing with wrong format and
  type fields.
* Add an early-out in format and type check loop to reduce iterations.

BUG=angle:658

Change-Id: I05e1b9f58b2e5ac4b5e1c0fa5a45cf37fb6a4ccd
Reviewed-on: https://chromium-review.googlesource.com/210884Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

baadf23a

Generate VS2013 public projects. · eb10f1c8

authored Aug 04, 2014

Allows us to support 64 bit builds in the packaged project files.

BUG=angle:714

Change-Id: I7e2f57ec87d1c46b348a4821821d1e21be671e49
Reviewed-on: https://chromium-review.googlesource.com/210825Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

eb10f1c8

04 Aug, 2014 4 commits

Remove the unusused Renderer::getSRGBSupport method. · 366ac1e3

authored Jul 07, 2014

BUG=angle:658

Change-Id: I3c8331dfc9c1046b528e9c4a7da3411d84f8ae3c
Reviewed-on: https://chromium-review.googlesource.com/207120Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

366ac1e3

Fix wrong comparison in Buffer ASSERT. · f049e804

authored Aug 04, 2014

We were using >1 instead of <=1. Caused false errors in Debug.

BUG=angle:716

Change-Id: I7072df99f208bd2e0a687143faeef6c9be79728e
Reviewed-on: https://chromium-review.googlesource.com/210990Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f049e804

Make the HugeSetDataTest more robust. · 18afd77e

authored Aug 04, 2014

By starting from a near-maximum size, and trying until we reach a
a valid allocatable size, we can guarantee the test can run.
Previously the allocation could fail under some systems and
succeded in others, leading to flakiness.

BUG=angle:716

Change-Id: If1690349f7028c4e6a88f20649fb255ea2dd2587
Reviewed-on: https://chromium-review.googlesource.com/210992Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

18afd77e

Simplify formatutils9 by exposing the internal structures. · 91fa9ce4

authored Jul 04, 2014

BUG=angle:658

Change-Id: I8134cde4d72796c51613594e15aded86e83c4af7
Reviewed-on: https://chromium-review.googlesource.com/206837Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

91fa9ce4