1. 01 Feb, 2020 2 commits
    • Fuchsia: Limit number of concurrent presents in ScenicWindow · f63fbcd5
      Michael Spang authored
      The test suite occasionally runs into the following error:
      
      [02036.794449][326733][326738][klog] INFO: [ERROR:src/ui/scenic/lib/scenic/session.cc(412)] Scenic session error (session_id: 1): Present2() called with no more present calls allowed. Terminating session.
      
      This is actually a problem with the test harness as resetting the window
      triggers a present with no fences and no OnFramePresentedCallback which
      means there is no way to know if we will exceed the limit.
      
      Add an OnFramePresentedCallback and count presents to stay under the
      limit. This blocks if there's more than 2 in flight presents. A dedicated
      async loop is used to avoid re-entering other code while waiting to
      present (there is no such case in the ANGLE test suite currently, but
      better safe than sorry).
      
      Typically if we run the whole suite there will be a failure in the
      middle, but re-trying the test that failed won't repro the issue. Add a
      test that reliably exhausts the limit by calling resetNativeWindow() in a
      loop.
      
      Bug: angleproject:4360
      Change-Id: I24eb01fd72fc0be57c36e49b5875023a80d6ab91
      Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2027934
      Commit-Queue: Michael Spang <spang@chromium.org>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Mark MemoryBuffer allocation functions as NO_DISCARD · a36f8bd4
      Geoff Lang authored
      Not all call sites were checking the return value of
      MemoryBuffer::resize, mark the return value as NO_DISCARD and fix all
      the warnings.
      
      BUG=chromium:1030835
      
      Change-Id: I762796e3d11efc131a814069d78a195b0d4c9f8f
      Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2028151
      Commit-Queue: Geoff Lang <geofflang@chromium.org>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
  2. 31 Jan, 2020 13 commits
  3. 30 Jan, 2020 4 commits
  4. 29 Jan, 2020 21 commits