- 03 Apr, 2019 10 commits
-
-
Shahbaz Youssefi authored
This allows issuing draw calls which only manipulate depth/stencil. Bug: angleproject:3241 Change-Id: I62ab18a185ea5b234d3559f30c5b2b8ecb317bbb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550900 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Prints more info when a particular file is not found. Bug: angleproject:3333 Change-Id: I11ceb0d319023cd1fd23fd25297e5367030342a0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550899Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
Jamie Madill authored
This should prevent CLs failing presubmit checks from landing. Bug: angleproject:3288 Change-Id: I7d4ee56bd2cbe0089248d1737275aaeac8394d96 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551839Reviewed-by:
-
Jamie Madill authored
We were not properly adding the offset to compute the right bounds. Bug: chromium:943709 Change-Id: I93e714b46dd366d5833fffa858ea3ab0322ffa92 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548441 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Shahbaz Youssefi authored
The tests crash on Nvidia in the driver. Bug: 945415 Change-Id: I0f635eb5d99ecaeeaff055793b1b5fd3a314b055 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548440 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
Jamie Madill authored
Possible driver bug. Bug: angleproject:3342 Change-Id: Ia171a7ac0d764859c4440b1fe2986aa931ff75c2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550799Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e0d59bbe1857..ef807f4bc543 Created with: gclient setdep -r ./third_party/glslang/src@ef807f4bc543 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: I6d65dfbb90b5b8deee9e90c873d5d2ac03a14afe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550141Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/320a7de5c9a5..e2ddb9371edb Created with: gclient setdep -r ./third_party/spirv-tools/src@e2ddb9371edb The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=syoussefi@google.com Change-Id: Ib84307d822bafaec4d9185e75c830266d72bd6d3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1550083Reviewed-by:
-
jchen10 authored
This parallelizes the compiling and linking for compute shaders on the D3D backend. Bug: chromium:849576 Change-Id: Idd6b418cb9c2448209c15eab2756599f8ff7af4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1415725Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
-
James Darpinian authored
Bug: angleproject:2764 Change-Id: I3fdab330b59ed996f68e3063debca29323a66cf0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542599 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
- 02 Apr, 2019 10 commits
-
-
Geoff Lang authored
Chaining of submit semaphores is only needed for window surfaces because they are required for the first usage of the swap chain image and final present of the image. Move ownership of the submit semaphores from RendererVk to WindowSurfaceVk and update all calls to finish and flush to be piped through a ContextVk which tracks the currently bound window surface. BUG=angleproject:2464 Change-Id: I4b3083124d7910a5dee297afc219e3a3f28057f2 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542257 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Jeff Gilbert authored
Bug: angleproject:3336 Change-Id: If2075b3ed2fe0be95ab2ec9cd0398afef691dee8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548433Reviewed-by:
-
Shahbaz Youssefi authored
Refactors FramebufferVk::clear such that specific render targets could be cleared, with clear values not necessarily set through glClearColor etc. FramebufferVk::clearWithRenderPassOp is modified so that loadOp and clear values are set after the render pass has been registered in the graph. This allows multiple glClearBuffer calls to coalesce into the same render pass. glClearBuffer calls are then implemented simply as calls to the refactored clear function with the appropriate parameters. Bug: angleproject:3187 Change-Id: I2fdfcbea5bf244f63ec981b91caca47f5ee3cd3a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545204 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jonah Ryan-Davis authored
More flaky failures that were being hidden by test retries. Might take a few more patches in order to disable test retries. Bug: angleproject:3271 Bug: angleproject:1729 Change-Id: I97eb02d6e93892a04db8b09992f32c4c20dbd49b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1549314Reviewed-by:
-
Geoff Lang authored
BUG=948286 Change-Id: I85f44622efaf4f018d00046e4fc5dc0757f38539 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545127Reviewed-by:
-
Shahbaz Youssefi authored
This test is to ensure the upcoming Vulkan implementation can coalesce all the calls into a single render pass clear. Bug: angleproject:2361 Change-Id: I816907b3512715c1d3217689413b6c8e9842a37a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544973 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
This test is to ensure the upcoming Vulkan implementation uses the right colors for each render target. Bug: angleproject:2361 Change-Id: Ibc6f8b474ac598a20d8cc9ac1c7fd18667370cbf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544972Reviewed-by:
-
Jamie Madill authored
This file changes a lot less than git HEAD. And it should guard against the same changes. Should reduce the instances of developer confusion regarding run_code_generation being out of data. Also update the presubmit check to print a more helpful message in the case where the code does need to be regenerated. Bug: angleproject:3333 Change-Id: I190dab5be50fc42512bdfc11c2d200f34f3b2092 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545123 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Jamie Madill authored
The ci section is for continuous integration. This change should allow for the presubmit tester to show up on the list of additional trybots. Bug: angleproject:3288 Change-Id: I95ac359434557a76cb4f87a1d38aaec90879e406 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545527Reviewed-by:
-
Shahbaz Youssefi authored
Done after noticing a bug in the Vulkan backend where masked (and possibly scissored) color clears were only clearing the first attachment. Bug: angleproject:2361 Change-Id: I471d337b1c3a3a5e17748690ae2222a6351773ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544971Reviewed-by:
-
- 01 Apr, 2019 8 commits
-
-
Jamie Madill authored
This runs the run_presubmit canned recipe. It should work the same as it would in Chromium or Dawn or most other repos. It should prevent rollers and devs from landing several common types of dirty changes. This CL adds the builder that then we can test manually before adding it to the CQ. Bug: angleproject:3288 Change-Id: I45e78669d0b6c34cef50ab9cb45c33a1b8bb6aca Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548293Reviewed-by:
-
Geoff Lang authored
The NULL backend exposes the CHROMIUM_copy_texture extension but would hit UNIMPLEMENTEDs when trying to call these functions. BUG=945596 Change-Id: Ia845e48b21e6004946edb47b6f4f0573df1f70a4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545525Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
-
Jacek Caban authored
This is needed for building on MinGW. Bug: angleproject:3330 Change-Id: I4a7e7d6f6e14be7e1ba67d3ceb45b11d00585119 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544749Reviewed-by:
-
Jonah Ryan-Davis authored
Flaky failures were being hidden by test retries. Should be ignored so we can disable test retries. Bug: angleproject:3271 Change-Id: I17708f96e2299b9828f5f979f68187b3cd99ecb3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542259Reviewed-by:
-
Shahbaz Youssefi authored
Other than for a Qualcomm driver bug workaround, this makes a few fallbacks unnecessary. Bug: angleproject:2361 Change-Id: I8bdc8efba69527ca89bfa7b646a9d41e07f4f895 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541669Reviewed-by:
-
Yuly Novikov authored
gl::State::mDirtyCurrentValues is a second tier of gl::State::DIRTY_BIT_CURRENT_VALUES bit. Marking mDirtyCurrentValues dirty during context switches treats them in the same way as other gl::State::mDirtyBits are treated. This has regressed in https://chromium-review.googlesource.com/c/angle/angle/+/722423 where individual current values bits were squashed into one. Bug: chromium:920033 Change-Id: I778515f11c975f8d88bd2d8c08c49160fd011497 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545009Reviewed-by:
-
Jamie Madill authored
The texture cache could become out of sync. And we could end up dereferencing an invalid pointer. Bug: chromium:943538 Change-Id: I6a99a04e80fc551b6177e25b7bee09c6ae226340 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541718Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fcb845310450..320a7de5c9a5 Created with: gclient setdep -r ./third_party/spirv-tools/src@320a7de5c9a5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jonahr@google.com Change-Id: Ic4d16559f207d3c6f00c228c1a1ebb56fb49367a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1546448Reviewed-by:
-
- 29 Mar, 2019 3 commits
-
-
Yuly Novikov authored
Bug: angleproject:3333 Change-Id: Ib21d863ada0d9f23a84647265b692cd5485a064d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545994Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2ff54e34ed37..fcb845310450 Created with: gclient setdep -r ./third_party/spirv-tools/src@fcb845310450 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jonahr@google.com Change-Id: I7aa44ede3a9f7c4e3b68dbcd5c2b3962cd1ce7e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545971Reviewed-by:
-
Jeff Gilbert authored
Bug: angleproject:3332 Change-Id: Ia937727062d3296af9691a95d296c89b8e9476ac Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1544779Reviewed-by:
-
- 28 Mar, 2019 9 commits
-
-
Jeff Gilbert authored
This is desired for implementing WEBGL_color_buffer_float support on WebGL1 on ANGLE's ES2 driver, for Firefox. Bug: angleproject:3322 Change-Id: I599f86db62402333d3ef9235956c63e667f1513d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541722Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Tobin Ehlis authored
We were casting stencil ref value instead of clamping it as the spec requires. Fixing that which allows a number of new dEQP tests to pass. Bug: angleproject:3244 Bug: angleproject:3245 Bug: angleproject:3247 Bug: angleproject:3248 Change-Id: I59242d59982b990e82395f5a1e77b9a54254dc2b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541751 Commit-Queue: Tobin Ehlis <tobine@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2ac348b5c0a5..2ff54e34ed37 Created with: gclient setdep -r ./third_party/spirv-tools/src@2ff54e34ed37 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jonahr@google.com Change-Id: Ic241dffc79ae1f24eb61e2c28fc184c9cebceaaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541749Reviewed-by:
-
Courtney Goeltzenleuchter authored
The dEQP-GLES2.functional.fbo.render.texsubimage.between_render_tex2d* test was failing because a TexSubImage call modifying the framebuffer wasn't being applied before a subsequent DrawElements call and thus getting an incorrect result. Bug: angleproject:3249 Test: angle_deqp_gles2_tests --gtest_filter=dEQP.GLES2/functional_fbo_render_texsubimage_between_render_tex2d_rgb --use-angle=vulkan Change-Id: I90f791957e6536c5c62fb731d52cd486ab5c05c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542361 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/5efb004d5960..e0d59bbe1857 Created with: gclient setdep -r ./third_party/glslang/src@e0d59bbe1857 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=jonahr@google.com Change-Id: Ifa2bf394fe4b895046d50c434db473057bf1b90b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1541750Reviewed-by:
-
Shahbaz Youssefi authored
On tiling GPUs, render pass loadOp and stencilLoadOp can be used to very cheaply clear an image as it is being render to. This change uses this feature to clear render targets when possible. Bug: angleproject:2361 Change-Id: Ic4bdc908873f4802760d549f4893f84a47beac0f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1500576 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Geoff Lang authored
The EGL_KHR_fence_sync spec says that if a flush is needed before waiting on the sync, it's done on the current context for the current thread. This helps simplify the multithreading design, we don't need to worry about flusing on a context that may no longer exist or is executing on a different thread. It does allow infinite waits because the context with the fence is never flushed but the spec allows this. BUG=angleproject:2464 Change-Id: I8bf2f93c408fee2dae95caa5bb9c76ba67687931 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542256Reviewed-by:
-
Jamie Madill authored
Bug: angleproject:3317 Change-Id: Ie60ad9670d19d0eae9926bcf14f65fc2e84215d8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1542602Reviewed-by:
-
Shahbaz Youssefi authored
This is possible thanks to SecondaryCommandBuffer. Makes life easier when debugging by not just showing resource type in the nodes, but actual stream of commands recorded in each. Bug: angleproject:3136 Change-Id: I125a32ec2966a55330e60930ca088d1a3673a8ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1538832 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
