Commits · fad925108c9e15b6634fff4febab19ad01683a86 · Chen Yisong / angle

21 Sep, 2020 1 commit

[Merge M86] Workaround bogus MscRate reported by some XWayland drivers. · fad92510

authored Sep 01, 2020

XWayland defaults to a 1hz refresh rate when the surface is not
visible, but this can sometimes cause issues in Chrome. If we see
a bogus rate like that, ANGLE can just report 30hz.

Bug: chromium:1042393
Change-Id: I554b05b4107cea528525ced6e95a5ce529eec3b1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2422084Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

fad92510

08 Sep, 2020 1 commit

Rename ANGLE apk package to org.chromium.angle · 540debac

authored Aug 31, 2020

Bug: b/167223999
Change-Id: Iaa0b7c779bf744da17a0defba32c966225300a4c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2398833Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

540debac

31 Aug, 2020 1 commit

Vulkan: Use 4 MB as preferredLargeHeapBlockSize for allocator. · ec73f889

authored Aug 26, 2020

This reduces preferredLargeHeapBlockSize from the default
value of 256 MB to 4 MB, which reduces the initial block
size from 32 MB to 512 KB.

4 MB is the same size as used by Chromium and Skia. It seems
to be a good compromise of not wasting unused allocated space
and not making too many small allocations.

This change is limited to non-Qualcomm GPUs as a number of
tests are failing on Qualcomm after this change and the
initial investigation indicates a potential driver bug. See
http://anglebug.com/4995 for more details.

Bug: chromium:1122718
Bug: fuchsia:58959
Change-Id: Ifdaf863ef38e72098a04ee57dec46ee71cab6ac3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2376891Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: David Reveman <reveman@chromium.org>
(cherry picked from commit 9a19a996)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2385917Reviewed-by: Geoff Lang <geofflang@chromium.org>

ec73f889

20 Aug, 2020 9 commits

Roll Vulkan-ValidationLayers from c97acd1d3e07 to 0d6b4440549b (6 revisions) · c060d8d6

authored Aug 20, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/c97acd1d3e07..0d6b4440549b

2020-08-20 locke@lunarg.com tests: Push constants and image subresources
2020-08-20 locke@lunarg.com layers: Add VUID-vkCmdDraw-None-02687
2020-08-20 locke@lunarg.com layers: Add VUID-vkCmdDraw-None-02698
2020-08-19 mark@lunarg.com docs: Clarify use of BUILD_LAYER_SUPPORT_FILES
2020-08-19 s.fricke@samsung.com layers: Remove double destroy VUID
2020-08-18 shannon@lunarg.com build: Update known-good files for 1.2.151 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I72c8ed763ee7de32272c5bc34806440eac6d6b5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2366566Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c060d8d6

Roll SPIRV-Tools from 3434cb0b006d to a711c594b8cc (2 revisions) · 08587bcb

authored Aug 20, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3434cb0b006d..a711c594b8cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I106e7a18a3b2ed1b9bcb44a7905e72729c758bea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2366567Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

08587bcb

Roll Vulkan-Loader from 30b3f3857835 to 2979391e5b0c (1 revision) · a6bf6a72

authored Aug 20, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/30b3f3857835..2979391e5b0c

2020-08-19 nathbappai@gmail.com loader: Fix some non-msvc compiler warnings

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Ic0c9fa5e93c83901b8e7e94af775210e74e99de7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2366568Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a6bf6a72

Vulkan: Optimize MSAA using subpass resolve attachments · dff47d5f

authored Jul 14, 2020

If a user is performing a blit to resolve a multisample color buffer
into a single attachment, ANGLE can use subpass resolve attachments to
resolve directly into the destination buffer as part of the render pass.
This allows the data to remain in tiler memory and reduce the extra
bandwidth required to write the multisampled data back to perform the
copy.

This work also requires restoring/reopening a render pass if it has been
finished already, assuming the finished render pass was started and for
the framebuffer that is the source for the blit command. Other objects
that were created when the render pass was started need to be updated as
well, such as the source FramebufferVk's resolve attachment, the
CommandBufferHelper's vk::Framebuffer and vk::RenderPassDesc, etc.

While this is better than performing vkCmdResolveImage(), there is still
another major part of optimizing MSAA using resolve attachments not
implemented here: discarding the multisampled image rather than writing
it to GMEM, which requires the user to invalidate the read FBO after the
blit.

This CL was verified with AGI to make sure there are no explicit blits
to resolve the multiple sampled image.

Bug: b/159903491
Test: FramebufferTest_ES31.*Blit*
Test: VulkanPerformanceCounterTest_ES31.MultisampleResolveWithBlit
Change-Id: I320a26088d8f614a295e7feec275d71310391806
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2298663
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

dff47d5f

Roll chromium_revision c8c2c64629..84714fcf81 (796654:799900) · 5dff6075

authored Aug 19, 2020

Change log: https://chromium.googlesource.com/chromium/src/+log/c8c2c64629..84714fcf81
Full diff: https://chromium.googlesource.com/chromium/src/+/c8c2c64629..84714fcf81

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/1130766620..7076d3be06
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e227df9cd5..855f6eb5b6
* third_party/Python-Markdown: https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/31ac00b010..ad4fc19d61
* third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/0241a1304f..9d4f8005bc
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/7492de9a52..d53accfbd0
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/faabb9a8ea..299e8a2339
* tools/md_browser: https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/7e75775447..60141af360
* tools/memory: https://chromium.googlesource.com/chromium/src/tools/memory/+log/89552acb6e..ee1e244813
DEPS diff: https://chromium.googlesource.com/chromium/src/+/c8c2c64629..84714fcf81/DEPS

No update to Clang.

TBR=ynovikov@chromium.org,
BUG=None

Change-Id: Ib0a7b120da430668075b0202456d4c0e170666bf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2366112Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

5dff6075

Re-land "Feedback Loop Redesign 2/3: Track bound FBOs in Texture." · 185d9d08

authored Aug 14, 2020

Re-land fixes the crash when drawing with no bound Program executable.

Currently we track feedback loops by counting the times a Texture is
bound as a sampler or image in a particular context. This is a bit
tricky because Texture bindings change frequently. Relative to the
number of times we need to check for a feedback loop this causes excess
overhead.

Usually Framebuffers have a low number of Textures bound (in many cases
just 1). And Textures aren't usually bound to many different FBOs. So
instead of counting the number of times a Texture is bound as a sampler
or image we will track the Framebuffers that the Texture is bound to.

This CL adds a small vector class to gl::Texture which tracks all the
Framebufer Serials of its bound Framebuffers. We can use this set to
quickly check if there's any potential feedback loop between the a FBO
and this Texture.

We also update the feedback loop check to use this new method. We will
be able to remove the old counting method when we switch the Vulkan
feedback loop handling to use the new tracking in this CL.

Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: If2bd25b08298a99f5e64b4055137f9154b0f0860
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2365595Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

185d9d08

Silence Control Flow Integrity (cfi) errors · a20f5b17

authored Aug 18, 2020

The cfi bot is throwing 3 different errors with ANGLE when using
the Vulkan backend:
- ChoosePhysicalDevice causes a "function with wrong dynamic type"
  error when using vkGetPhysicalDeviceProperties
- In volk.c, using vkGetInstanceProcAddr and vkGetDeviceProcAddr
  also causes a "function with wrong dynamic type" error
- In vk_mem_alloc.h, included from vk_mem_alloc_wrapper.cpp,
  GetAllocationCallbacks() causes a "unrelated cast" error

This cl silences all 3 cfi errors.

Bug: chromium:1116053
Change-Id: I864ec8d9e2acaec493f472e01b3987dcc641c58f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2363209Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

a20f5b17

Fix manual roll mode of roll_chromium_deps.py · a357cbab

authored Aug 19, 2020

Got broken while working on autoroll mode in
https://chromium-review.googlesource.com/c/angle/angle/+/2363212

Bug: skia:10572
Change-Id: I0c851aed758e568b080d6c222762f35b8c7adae4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2365597Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

a357cbab

Fix manual, disable automatic rolling of googletest and jsoncpp · 7d38b0ba

authored Aug 19, 2020

roll_chromium_deps.py didn't handle properly rolling recursedeps for
these 2 repos, only rolling the top level repo but not internal.

Temporarily disable rolling these 2 repos in roll_chromium_deps.py and
roll them properly to the latest revision used by Chrome.

Change log:
https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/e3c3f879eee34ec81b1e562d8fecd207716d8945..c20c5a3085ab4d90fdb403e3ac98e7991317dd27
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f2fb48c3b3d79a75a88a99fba6576b25d42ec528..4fe018038f87675c083d0cfb6a6b57c274fb1753
https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/ec647b85b61f525a1a74e4da7477b0c5371c50f4..30a6ac108e24dabac7c2e0df4d33d55032af4ee7

No change to
https://chromium.googlesource.com/external/github.com/open-source-parsers/jsoncpp.git/+/645250b6690785be60ab6780ce4b58698d884d11

Bug: angleproject:4973
Change-Id: Ie164c5b1adb8684b875f1be4924b295033e2fb4a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2365023
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7d38b0ba

19 Aug, 2020 16 commits

Revert "Feedback Loop Redesign 2/3: Track bound FBOs in Texture." · f6fb6da8

authored Aug 19, 2020

This reverts commit 699bcde0.

Reason for revert: Breaking GLES2WebGLDecoderPassthroughTest.DrawArraysInstancedANGLEEnablement. Here is a sample build : https://ci.chromium.org/p/chromium/builders/ci/Win10%20FYI%20x64%20Release%20%28NVIDIA%29/4240

Original change's description:
> Feedback Loop Redesign 2/3: Track bound FBOs in Texture.
> 
> Currently we track feedback loops by counting the times a Texture is
> bound as a sampler or image in a particular context. This is a bit
> tricky because Texture bindings change frequently. Relative to the
> number of times we need to check for a feedback loop this causes excess
> overhead.
> 
> Usually Framebuffers have a low number of Textures bound (in many cases
> just 1). And Textures aren't usually bound to many different FBOs. So
> instead of counting the number of times a Texture is bound as a sampler
> or image we will track the Framebuffers that the Texture is bound to.
> 
> This CL adds a small vector class to gl::Texture which tracks all the
> Framebufer Serials of its bound Framebuffers. We can use this set to
> quickly check if there's any potential feedback loop between the a FBO
> and this Texture.
> 
> We also update the feedback loop check to use this new method. We will
> be able to remove the old counting method when we switch the Vulkan
> feedback loop handling to use the new tracking in this CL.
> 
> Bug: angleproject:4500
> Bug: angleproject:4959
> Change-Id: I84a2f0ed8480d1da63d5879e0e56a8be4af4e735
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358850
> Reviewed-by: Tobin Ehlis <tobine@google.com>
> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
> Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=tobine@google.com,courtneygo@google.com,jonahr@google.com,jmadill@chromium.org

Change-Id: Ica795036895652add37ac8ed319031f9d5a321ac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:4500
Bug: angleproject:4959
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2365077Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>

f6fb6da8

Adjust roll_chromium_deps.py to work with autoroller. · 0f33d01e

authored Aug 18, 2020

Add --autoroll option which expects an existing git commit by the
autoroller, which updates chromium_revision.
roll_chromium_deps.py then updates other ANGLE dependencies to the
revision of their Chromium counterparts and amends autoroller's commit.

Bug: skia:10572
Change-Id: Iddb9296bd1470f4a2113563c5ed3a1c27e16f128
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2363212
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0f33d01e

Fix language inclusivity for SurfaceMtl.mm · b8c32424

authored Aug 19, 2020

He->they

Bug: b/162834212
Change-Id: I8559120ad77006aaa839b70e00b4c8f12e9e8a44
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364192Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

b8c32424

Vulkan: Enable VK_KHR_bind_memory2 extension · 78d10017

authored Aug 16, 2020

Don't assume support for VK_KHR_bind_memory2,
enable the extension, if supported, during device creation.

Also initialize all required extension functions for the
memory allocator.

Bug: angleproject:4966
Change-Id: I878939fb3324723675a2b7dec18ab453b2a9fc77
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359529
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

78d10017

Fix typo in test harness README · 831056bf

authored Aug 19, 2020

Larget->larger

Bug: angleproject:3162
Change-Id: I7ee84b714af179f97db1aa61b58ed946b28373bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364191Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

831056bf

Metal: autogen for EXT_draw_buffers & ANGLE_framebuffer_blit · defeda29

authored Aug 04, 2020

Bug: angleproject:2634
Change-Id: I8f8ee91fb673301b8bd97c359ee39c411e2bf8da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2336124
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

defeda29

Delete extra initialization in spirv shader. · add9b677

authored Aug 17, 2020

Only webgl requires initialization of local variables,others don't.
Extra initialization in spirv shader may affect performance.

Bug: angleproject:4952
Change-Id: I004761779067748d43c1ea2630794491f1389492
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2359608
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

add9b677

Vulkan: Check aggregate barrier feature instead of caching. · 27a24f6d

authored Aug 17, 2020

Bug: b/157508684
Change-Id: I6c98cb017d44c1279439d815e77f6ad1a32133e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360903
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>

27a24f6d

Vulkan: Name image layouts. · ea1bda26

authored Aug 17, 2020

Can be useful for debugging logging.

Bug: angleproject:4959
Change-Id: I4bdb72b4c07979fecc2af0ca2a2b2e7cdab36b9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360902
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ea1bda26

Roll Vulkan-Tools from 1590d46aaaeb to eceb318c06a2 (1 revision) · 6133bb4d

authored Aug 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/1590d46aaaeb..eceb318c06a2

2020-08-18 shannon@lunarg.com build: Update known-good files for 1.2.151 header

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I8bb85820739d3f9d881e2559f167f05f7d3ee2ae
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364248Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6133bb4d

Roll SwiftShader from 6f74415e2f74 to cbfd396756c6 (1 revision) · 330eb73f

authored Aug 19, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/6f74415e2f74..cbfd396756c6

2020-08-18 sugoi@google.com Control Flow Integrity (cfi) fix

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I04196ff58d26afae7c52d4aebc2a962909a9b846
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364247Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

330eb73f

Roll Vulkan-ValidationLayers from 9d431ae2eeb4 to c97acd1d3e07 (1 revision) · e16e2cf4

authored Aug 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/9d431ae2eeb4..c97acd1d3e07

2020-08-18 mark@lunarg.com layers: Fix whitespace error in layer settings file

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I82f83a33bffee7ff6f5ffebca1bd59f726e85012
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364249Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e16e2cf4

Roll SPIRV-Tools from e28436f2b8a2 to 3434cb0b006d (2 revisions) · 9e17caba

authored Aug 19, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e28436f2b8a2..3434cb0b006d

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I98c5ba5b5a5ad87051cdadd89ae431412b003405
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2364250Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9e17caba

Vulkan: Track RP's read/write access for depth/stencil. · d286daf1

authored Aug 16, 2020

This generalizes the read tracking into read/write. Knowing the write
access can let us determine if we can switch a RenderPass to a read-
only mode. And switching to read-only will let us combine some
RenderPasses in Manhattan.

Bug: angleproject:4959
Change-Id: Ic97547e84fef4a2670437677000d4525006ef69f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358771
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

d286daf1

Feedback Loop Redesign 2/3: Track bound FBOs in Texture. · 699bcde0

authored Aug 14, 2020

Currently we track feedback loops by counting the times a Texture is
bound as a sampler or image in a particular context. This is a bit
tricky because Texture bindings change frequently. Relative to the
number of times we need to check for a feedback loop this causes excess
overhead.

Usually Framebuffers have a low number of Textures bound (in many cases
just 1). And Textures aren't usually bound to many different FBOs. So
instead of counting the number of times a Texture is bound as a sampler
or image we will track the Framebuffers that the Texture is bound to.

This CL adds a small vector class to gl::Texture which tracks all the
Framebufer Serials of its bound Framebuffers. We can use this set to
quickly check if there's any potential feedback loop between the a FBO
and this Texture.

We also update the feedback loop check to use this new method. We will
be able to remove the old counting method when we switch the Vulkan
feedback loop handling to use the new tracking in this CL.

Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: I84a2f0ed8480d1da63d5879e0e56a8be4af4e735
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358850Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

699bcde0

Vulkan: Add overlay widget for RP buffer count. · 5b4f6e31

authored Aug 15, 2020

Can help evaluate when scenes stress out the resource tracking in the
RenderPass command buffer.

Bug: angleproject:4950
Bug: angleproject:4965
Change-Id: I7da2ad0101a840c5441f2112db4bb61f564afcef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358521
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

5b4f6e31

18 Aug, 2020 12 commits

Feedback Loop Redesign 1/3: Framebuffer Serials. · d0b270e6

authored Aug 14, 2020

Currently we track feedback loops by counting the times a Texture is
bound as a sampler or image in a particular context. This is a bit
tricky because Texture bindings change frequently. Relative to the
number of times we need to check for a feedback loop this causes excess
overhead.

Usually Framebuffers have a low number of Textures bound (in many cases
just 1). And Textures aren't usually bound to many different FBOs. So
instead of counting the number of times a Texture is bound as a sampler
or image we will track the Framebuffers that the Texture is bound to.

Because FBOs are unique to a Context, a Texture could be bound to two
different FBOs with the same ID. In this CL we introduce a new Serial
for the FBO which is unique to an EGL Share Group. This way we can
ensure we don't make the wrong call when a Texture is referenced by a
Framebuffer. It also replaces the old FB serial which was again only
unique to a particular Context.

Bug: angleproject:4500
Bug: angleproject:4959
Change-Id: I0a9989d861a4132bd3b7ed85f699a4448ff37a4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358849Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d0b270e6

Metal: autogen format caps from json · 85919ef7

authored Aug 08, 2020

Bug: angleproject:4940
Bug: angleproject:2634
Change-Id: I1e107e856a50a7eaf685296dd7464af9ad5bcec4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2342522
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

85919ef7

Vulkan: Add DS ReadOnly mode to Framebuffer/RP caches. · 594e0e14

authored Aug 15, 2020

Allows ANGLE to create Framebuffers and RenderPasses with a read-
only depth/stencil layout. Also allows us to transition our Images
to this new DepthStencilReadOnly layout.

Internal code redesign. No functional change to our command stream.

Bug: angleproject:4959
Change-Id: I9b80063bdaec8f5d6c89037e0618c85e1c11b78d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2354280Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

594e0e14

Metal: Fix missing image view for texture from IOSurface. · a13f1061

authored Aug 14, 2020

Image view is used by glTexSubImage*, glCopySubImage* and
glCopySubTexture*.
This fixed some failed WebGL tests that make use of IOSurface.

Bug: angleproject:4846
Bug: angleproject:2634
Change-Id: Iebcf840fdc1be2794feab766957b5848a361a63c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2356107
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a13f1061

Auto-gen more Overlay code. · 57393152

authored Aug 16, 2020

We add a new header where we auto-generate the Widget ID. We also use
a new X macro to generate per-widget arrays and tables.

Bug: angleproject:4965
Change-Id: Ic53e5d1c47d5712a63c98c481c15f550f1f99692
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358520
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

57393152

Clean up Overlay code duplication. · 4cf01e3e

authored Aug 18, 2020

Adds common helper functions for Running Graphs and Histograms.

Bug: angleproject:4965
Change-Id: I8c7295217c637e377b74b4a336eb151b8a7c9596
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2358518
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

4cf01e3e

Vulkan: Clean up ImageLayout enum. · ee0a9a34

authored Aug 13, 2020

Remove the redundant manual numbering. Also rename
AllGraphicsShadersReadWrite to AllGraphicsShadersWrite for consistency.

Refactoring change only.

Bug: angleproject:4959
Change-Id: I2e7ca00993f192897bbf88f4bdc3f1610bcb345f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2354279
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>

ee0a9a34

Tests: Add COD:Mobile trace · c4a82aaa

authored Aug 17, 2020

Test: angle_perftests --gtest_filter=TracePerfTest.Run/*cod_mobile*
Bug: b/164426913
Bug: angleproject:4048
Change-Id: I306714632b635c728fa212ed793f076c6b889227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2360047
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c4a82aaa

Roll Vulkan-Headers from 99638d8d7fc6 to 834673eaa34a (1 revision) · 0d421b60

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/99638d8d7fc6..834673eaa34a

2020-08-17 mchock@nvidia.com Add VI WSI platform support to vk_icd.h

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Change-Id: I675172be28aaee839ca2ab0547e59b59e2db17b4
Bug: None
Tbr: cnorthrop@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361863Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0d421b60

Roll glslang from 758b30727efc to f257e0ea6b9a (2 revisions) · a14f1c8a

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/758b30727efc..f257e0ea6b9a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I17cf464de87a81fa085918f68322425b1b95203b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361765Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

a14f1c8a

Roll SPIRV-Tools from b8de4f57e983 to e28436f2b8a2 (3 revisions) · 8150670d

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b8de4f57e983..e28436f2b8a2

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: If8a90870cbf6cc3b0a3a910c12e35524db3de232
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361526Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8150670d

Roll Vulkan-Loader from 527e67e9d933 to 30b3f3857835 (13 revisions) · 4bf2e254

authored Aug 18, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/527e67e9d933..30b3f3857835

2020-08-17 cnorthrop@google.com loader: Fixes for gn build
2020-08-17 shannon@lunarg.com build: Update known-good files for 1.2.151 header
2020-08-17 Neonfxsh@gmail.com docs: Remove COPYRIGHT.txt from the readme
2020-08-14 lenny@lunarg.com repo: Set appveyor build to use Win10 SDK
2020-08-14 lenny@lunarg.com loader: Move tag to avoid linux warning
2020-08-14 piotr.bialecki@intel.com loader: Fix physical device sorting crash
2020-08-14 lenny@lunarg.com loader: Remove illegal asssignment
2020-08-14 lenny@lunarg.com loader: Fix variable name
2020-08-14 lenny@lunarg.com loader: Fixpossible memory corruption
2020-08-14 lenny@lunarg.com loader: Add reporting for physical device sorting
2020-08-14 lenny@lunarg.com docs: Update loader doc with device sorting info
2020-08-14 lenny@lunarg.com loader: Sort physical devices on Windows
2020-08-14 shannon@lunarg.com build: Update known-good files for 1.2.150 header

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I0e3d7b270fc9e659ecb1862883cc8231021b89da
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2361766Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4bf2e254