| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| common | ||
| compiler | ||
| gpu_info_util | ||
| image_util | ||
| libANGLE | ||
| libEGL | ||
| libGLESv2 | ||
| tests | ||
| third_party | ||
| vulkan_support | ||
| angle.gyp | ||
| commit.h | ||
| commit_id.py | ||
| compiler.gypi | ||
| copy_compiler_dll.bat | ||
| libEGL.gypi | ||
| libGLESv2.gypi |
While compiling ESSL1 shaders, with the compiler having both SH_INITIALIZE_BUILTINS_FOR_INSTANCED_MULTIVIEW and SH_VARIABLES set, variable collection terminates with an assertion failure. The reason behind this is that SH_INITIALIZE_BUILTINS_FOR_INSTANCED_MULTIVIEW adds gl_InstanceID to the AST to initialize the multiview builtins, but the variable collection pass cannot find gl_InstanceID information in the symbol table because the builtin is only available in ESSL 3.00 and greater. To address this the patch populates the gl_InstanceID attribute information explicitly in the variable collection pass instead of retrieving it from the symbol table. BUG=angleproject:2062 TEST=angle_unittests Change-Id: I5ecb9967ebe6658e956d17a2637090f9b685ef33 Reviewed-on: https://chromium-review.googlesource.com/559669Reviewed-by:Olli Etuaho <oetuaho@nvidia.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| common | Loading commit data... | |
| compiler | Loading commit data... | |
| gpu_info_util | Loading commit data... | |
| image_util | Loading commit data... | |
| libANGLE | Loading commit data... | |
| libEGL | Loading commit data... | |
| libGLESv2 | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| vulkan_support | Loading commit data... | |
| angle.gyp | Loading commit data... | |
| commit.h | Loading commit data... | |
| commit_id.py | Loading commit data... | |
| compiler.gypi | Loading commit data... | |
| copy_compiler_dll.bat | Loading commit data... | |
| libEGL.gypi | Loading commit data... | |
| libGLESv2.gypi | Loading commit data... |