D3D9 has a special limitation on varying packing, where each variable takes up a full register width, and cannot share space with other packed varyings. A bug was counting registers incorrectly on D3D9. Fix this by introducing a new limitation exposed to the ANGLE front-end via the gl::Limitations structure. Now varying packing will fail correctly in the ANGLE linking front-end with a more descriptive error message, as such: "Could not pack varying blah" "Note: Additional non-conformant packing restrictions are enforced on D3D9." Also change the packing so that input built-in variables are counted towards varying limits (e.g. gl_PointSize), except for gl_Position. On D3D9 we don't pack gl_PointSize, since it is used in a special extra PSIZE register. Also update some tests to be more robust. Bug: chromium:804799 Change-Id: I9027266a8b66a28626f038f259bff42ebf09dcd2 Reviewed-on: https://chromium-review.googlesource.com/889898 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:Geoff Lang <geofflang@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| d3d | Loading commit data... | |
| gl | Loading commit data... | |
| null | Loading commit data... | |
| vulkan | Loading commit data... | |
| BufferImpl.h | Loading commit data... | |
| BufferImpl_mock.h | Loading commit data... | |
| CompilerImpl.h | Loading commit data... | |
| ContextImpl.cpp | Loading commit data... | |
| ContextImpl.h | Loading commit data... | |
| DeviceImpl.cpp | Loading commit data... | |
| DeviceImpl.h | Loading commit data... | |
| DisplayImpl.cpp | Loading commit data... | |
| DisplayImpl.h | Loading commit data... | |
| EGLImplFactory.h | Loading commit data... | |
| FenceNVImpl.h | Loading commit data... | |
| Format.h | Loading commit data... | |
| Format_ID_autogen.inl | Loading commit data... | |
| Format_table_autogen.cpp | Loading commit data... | |
| FramebufferAttachmentObjectImpl.h | Loading commit data... | |
| FramebufferImpl.h | Loading commit data... | |
| FramebufferImpl_mock.h | Loading commit data... | |
| GLImplFactory.h | Loading commit data... | |
| ImageImpl.h | Loading commit data... | |
| ImageImpl_mock.h | Loading commit data... | |
| PathImpl.h | Loading commit data... | |
| ProgramImpl.h | Loading commit data... | |
| ProgramImpl_mock.h | Loading commit data... | |
| ProgramPipelineImpl.h | Loading commit data... | |
| QueryImpl.h | Loading commit data... | |
| RenderbufferImpl.h | Loading commit data... | |
| RenderbufferImpl_mock.h | Loading commit data... | |
| SamplerImpl.h | Loading commit data... | |
| ShaderImpl.h | Loading commit data... | |
| StreamProducerImpl.h | Loading commit data... | |
| SurfaceImpl.cpp | Loading commit data... | |
| SurfaceImpl.h | Loading commit data... | |
| SyncImpl.h | Loading commit data... | |
| TextureImpl.cpp | Loading commit data... | |
| TextureImpl.h | Loading commit data... | |
| TextureImpl_mock.h | Loading commit data... | |
| TransformFeedbackImpl.h | Loading commit data... | |
| TransformFeedbackImpl_mock.h | Loading commit data... | |
| VertexArrayImpl.h | Loading commit data... | |
| angle_format.py | Loading commit data... | |
| angle_format_data.json | Loading commit data... | |
| angle_format_map.json | Loading commit data... | |
| driver_utils.cpp | Loading commit data... | |
| driver_utils.h | Loading commit data... | |
| gen_angle_format_table.py | Loading commit data... | |
| gen_load_functions_table.py | Loading commit data... | |
| load_functions_data.json | Loading commit data... | |
| load_functions_table.h | Loading commit data... | |
| load_functions_table_autogen.cpp | Loading commit data... | |
| renderer_utils.cpp | Loading commit data... | |
| renderer_utils.h | Loading commit data... |