::testing::WithParamInterface ends up calling deleting an object with the type of the template parameter, and the pointer it deletes could arguably point to a subclass of the param object -- so clang warns that there's a delete on a class with a virtual method but without a virtual dtor. Make the param classes final to let the compiler know that this can't happen in practice. BUG=chromium:82385 Change-Id: I49a4120b15670d876613b22ba709d50bf4685006 Reviewed-on: https://chromium-review.googlesource.com/261965Reviewed-by:Jamie Madill <jmadill@chromium.org> Tested-by:
Nico Weber <thakis@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| build | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| samples | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| util | Loading commit data... | |
| .gitattributes | Loading commit data... | |
| .gitignore | Loading commit data... | |
| AUTHORS | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CONTRIBUTORS | Loading commit data... | |
| DEPS | Loading commit data... | |
| LICENSE | Loading commit data... | |
| README.chromium | Loading commit data... | |
| README.md | Loading commit data... | |
| angle.isolate | Loading commit data... | |
| codereview.settings | Loading commit data... | |
| enumerate_files.py | Loading commit data... | |
| generate_winrt_projects.py | Loading commit data... |