This reverts commit fd97c334. Reason for revert: The specialization constant for rotation causes performance regression with older qualcomm driver. We need to keep the driver uniform code path for the older driver. Original change's description: > Vulkan: Remove rotation related data from driver uniform > > Rotation is now handled in the shader compiler with specialization > constant, it should be removed from driver uniforms. Since Metal is > using the flipXY, flipXY/negFlipXY are still kept in the shader side > implementation, but have moved to TranslatorMetal in this CL. > > Bug: b/171750979 > Change-Id: Ie8d15ef227cb52a6e19e4319ecc9f09bda42e667 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2519863 > Reviewed-by: Ian Elliott <ianelliott@google.com> > Reviewed-by: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Charlie Lao <cclao@google.com> TBR=ianelliott@google.com,timvp@google.com,jmadill@chromium.org,cclao@google.com Bug: b/171750979 Change-Id: Iff9cffb28851ade1d9c5cd23fde73910a19867ce Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2547808Reviewed-by:Ian Elliott <ianelliott@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BuiltIn.h | Loading commit data... | |
| BuiltIn_ESSL_autogen.h | Loading commit data... | |
| BuiltIn_complete_autogen.h | Loading commit data... | |
| DriverUniform.cpp | Loading commit data... | |
| DriverUniform.h | Loading commit data... | |
| FindFunction.cpp | Loading commit data... | |
| FindFunction.h | Loading commit data... | |
| FindMain.cpp | Loading commit data... | |
| FindMain.h | Loading commit data... | |
| FindSymbolNode.cpp | Loading commit data... | |
| FindSymbolNode.h | Loading commit data... | |
| FlipRotateSpecConst.cpp | Loading commit data... | |
| FlipRotateSpecConst.h | Loading commit data... | |
| IntermNodePatternMatcher.cpp | Loading commit data... | |
| IntermNodePatternMatcher.h | Loading commit data... | |
| IntermNode_util.cpp | Loading commit data... | |
| IntermNode_util.h | Loading commit data... | |
| IntermTraverse.cpp | Loading commit data... | |
| IntermTraverse.h | Loading commit data... | |
| NodeSearch.h | Loading commit data... | |
| ReplaceArrayOfMatrixVarying.cpp | Loading commit data... | |
| ReplaceArrayOfMatrixVarying.h | Loading commit data... | |
| ReplaceClipDistanceVariable.cpp | Loading commit data... | |
| ReplaceClipDistanceVariable.h | Loading commit data... | |
| ReplaceShadowingVariables.cpp | Loading commit data... | |
| ReplaceShadowingVariables.h | Loading commit data... | |
| ReplaceVariable.cpp | Loading commit data... | |
| ReplaceVariable.h | Loading commit data... | |
| RunAtTheEndOfShader.cpp | Loading commit data... | |
| RunAtTheEndOfShader.h | Loading commit data... | |
| Visit.h | Loading commit data... |