Compile error on clang:
src/libANGLE/Display.cpp:259:23: error: allocation of incomplete type 'egl::Device'
mDevice = new Device(this, impl);
^~~~~~
src/libANGLE/Display.h:36:7: note: forward declaration of 'egl::Device'
class Device;
^
In file included from src/libANGLE/Display.cpp:11:
In file included from src/libANGLE/Display.h:17:
In file included from src/libANGLE/Error.h:80:
In file included from src/libANGLE/Error.inl:9:
src/common/angleutils.h:66:5: error: deleting pointer to incomplete type 'egl::Device' may cause undefined behavior [-Werror,-Wdelete-incomplete]
delete resource;
^ ~~~~~~~~
src/libANGLE/Display.cpp:209:5: note: in instantiation of function template specialization 'SafeDelete<egl::Device>' requested here
SafeDelete(mDevice);
^
src/libANGLE/Display.h:36:7: note: forward declaration of 'egl::Device'
class Device;
^
2 errors generated.
This reverts commit 6dacaff4.
Change-Id: Ide348e156324a5af668604362c0b249ea73b6083
Reviewed-on: https://chromium-review.googlesource.com/265626Reviewed-by:
Geoff Lang <geofflang@chromium.org>
Tested-by:
Geoff Lang <geofflang@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| d3d | Loading commit data... | |
| gl | Loading commit data... | |
| BufferImpl.h | Loading commit data... | |
| CompilerImpl.h | Loading commit data... | |
| DisplayImpl.cpp | Loading commit data... | |
| DisplayImpl.h | Loading commit data... | |
| FenceNVImpl.h | Loading commit data... | |
| FenceSyncImpl.h | Loading commit data... | |
| FramebufferImpl.h | Loading commit data... | |
| ImplFactory.h | Loading commit data... | |
| IndexRangeCache.cpp | Loading commit data... | |
| IndexRangeCache.h | Loading commit data... | |
| ProgramImpl.cpp | Loading commit data... | |
| ProgramImpl.h | Loading commit data... | |
| QueryImpl.h | Loading commit data... | |
| RenderbufferImpl.cpp | Loading commit data... | |
| RenderbufferImpl.h | Loading commit data... | |
| Renderer.cpp | Loading commit data... | |
| Renderer.h | Loading commit data... | |
| ShaderImpl.h | Loading commit data... | |
| SurfaceImpl.cpp | Loading commit data... | |
| SurfaceImpl.h | Loading commit data... | |
| TextureImpl.h | Loading commit data... | |
| TransformFeedbackImpl.h | Loading commit data... | |
| VertexArrayImpl.h | Loading commit data... | |
| Workarounds.h | Loading commit data... | |
| generate_new_renderer.py | Loading commit data... |