Warning in the Linux/Mac builders:
In file included from ../../third_party/angle/src/tests/preprocessor_tests/input_test.cpp:7:
In file included from ../../third_party/angle/src/tests/preprocessor_tests/PreprocessorTest.h:7:
../../testing/gtest/include/gtest/gtest.h:1392:16: error: comparison of integers of different signs: 'const int' and 'const unsigned long' [-Werror,-Wsign-compare]
if (expected == actual) {
~~~~~~~~ ^ ~~~~~~
../../testing/gtest/include/gtest/gtest.h:1422:12: note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<int, unsigned long>' requested here
return CmpHelperEQ(expected_expression, actual_expression, expected,
^
../../third_party/angle/src/tests/preprocessor_tests/input_test.cpp:171:5: note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<int, unsigned long>' requested here
EXPECT_EQ(3, input.read(buf, maxSize, &lineNo));
^
BUG=angleproject:1125
This reverts commit c1157d19.
Change-Id: Ic6fa286d190b006cccc5154d86e21ecc03175763
Reviewed-on: https://chromium-review.googlesource.com/294080Reviewed-by:
Jamie Madill <jmadill@chromium.org>
Tested-by:
Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| 64bit-tokenizer-safety.patch | Loading commit data... | |
| DiagnosticsBase.cpp | Loading commit data... | |
| DiagnosticsBase.h | Loading commit data... | |
| DirectiveHandlerBase.cpp | Loading commit data... | |
| DirectiveHandlerBase.h | Loading commit data... | |
| DirectiveParser.cpp | Loading commit data... | |
| DirectiveParser.h | Loading commit data... | |
| ExpressionParser.cpp | Loading commit data... | |
| ExpressionParser.h | Loading commit data... | |
| ExpressionParser.y | Loading commit data... | |
| Input.cpp | Loading commit data... | |
| Input.h | Loading commit data... | |
| Lexer.cpp | Loading commit data... | |
| Lexer.h | Loading commit data... | |
| Macro.cpp | Loading commit data... | |
| Macro.h | Loading commit data... | |
| MacroExpander.cpp | Loading commit data... | |
| MacroExpander.h | Loading commit data... | |
| Preprocessor.cpp | Loading commit data... | |
| Preprocessor.h | Loading commit data... | |
| SourceLocation.h | Loading commit data... | |
| Token.cpp | Loading commit data... | |
| Token.h | Loading commit data... | |
| Tokenizer.cpp | Loading commit data... | |
| Tokenizer.h | Loading commit data... | |
| Tokenizer.l | Loading commit data... | |
| generate_parser.sh | Loading commit data... | |
| numeric_lex.h | Loading commit data... | |
| pp_utils.h | Loading commit data... |