This patch intends to fix a crash issue in the win-clang build of ANGLE by adding the missing currentValueAttrib->binding assignment in StateManager11.cpp::updateCurrentValueAttribs(). In D3D11 all vertex attributes (VertexAttribute and its VertexBinding) should be treated as a whole, so we should always ensure these two parts are availabe. This patch also add ASSERTs before using *translated->attrib and *translated->binding to prevent a TranslatedAttribute object having a null attrib or binding. BUG=chromium:721783, angleproject:1593 Change-Id: Id11d6f1d4c37daabad2265e01ea38eb51046b9cb Reviewed-on: https://chromium-review.googlesource.com/505928Reviewed-by:Geoff Lang <geofflang@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| shaders | Loading commit data... | |
| win32 | Loading commit data... | |
| winrt | Loading commit data... | |
| Blit11.cpp | Loading commit data... | |
| Blit11.h | Loading commit data... | |
| Buffer11.cpp | Loading commit data... | |
| Buffer11.h | Loading commit data... | |
| Clear11.cpp | Loading commit data... | |
| Clear11.h | Loading commit data... | |
| Context11.cpp | Loading commit data... | |
| Context11.h | Loading commit data... | |
| DebugAnnotator11.cpp | Loading commit data... | |
| DebugAnnotator11.h | Loading commit data... | |
| Fence11.cpp | Loading commit data... | |
| Fence11.h | Loading commit data... | |
| Framebuffer11.cpp | Loading commit data... | |
| Framebuffer11.h | Loading commit data... | |
| Image11.cpp | Loading commit data... | |
| Image11.h | Loading commit data... | |
| IndexBuffer11.cpp | Loading commit data... | |
| IndexBuffer11.h | Loading commit data... | |
| InputLayoutCache.cpp | Loading commit data... | |
| InputLayoutCache.h | Loading commit data... | |
| NativeWindow11.h | Loading commit data... | |
| PixelTransfer11.cpp | Loading commit data... | |
| PixelTransfer11.h | Loading commit data... | |
| Query11.cpp | Loading commit data... | |
| Query11.h | Loading commit data... | |
| RenderStateCache.cpp | Loading commit data... | |
| RenderStateCache.h | Loading commit data... | |
| RenderTarget11.cpp | Loading commit data... | |
| RenderTarget11.h | Loading commit data... | |
| Renderer11.cpp | Loading commit data... | |
| Renderer11.h | Loading commit data... | |
| ShaderExecutable11.cpp | Loading commit data... | |
| ShaderExecutable11.h | Loading commit data... | |
| StateManager11.cpp | Loading commit data... | |
| StateManager11.h | Loading commit data... | |
| StreamProducerNV12.cpp | Loading commit data... | |
| StreamProducerNV12.h | Loading commit data... | |
| SwapChain11.cpp | Loading commit data... | |
| SwapChain11.h | Loading commit data... | |
| TextureStorage11.cpp | Loading commit data... | |
| TextureStorage11.h | Loading commit data... | |
| TransformFeedback11.cpp | Loading commit data... | |
| TransformFeedback11.h | Loading commit data... | |
| Trim11.cpp | Loading commit data... | |
| Trim11.h | Loading commit data... | |
| VertexArray11.cpp | Loading commit data... | |
| VertexArray11.h | Loading commit data... | |
| VertexBuffer11.cpp | Loading commit data... | |
| VertexBuffer11.h | Loading commit data... | |
| copyvertex.h | Loading commit data... | |
| copyvertex.inl | Loading commit data... | |
| dxgi_format_data.json | Loading commit data... | |
| dxgi_format_map_autogen.cpp | Loading commit data... | |
| dxgi_support_data.json | Loading commit data... | |
| dxgi_support_table.cpp | Loading commit data... | |
| dxgi_support_table.h | Loading commit data... | |
| formatutils11.cpp | Loading commit data... | |
| formatutils11.h | Loading commit data... | |
| gen_dxgi_format_table.py | Loading commit data... | |
| gen_dxgi_support_tables.py | Loading commit data... | |
| gen_texture_format_table.py | Loading commit data... | |
| renderer11_utils.cpp | Loading commit data... | |
| renderer11_utils.h | Loading commit data... | |
| texture_format_data.json | Loading commit data... | |
| texture_format_map.json | Loading commit data... | |
| texture_format_table.cpp | Loading commit data... | |
| texture_format_table.h | Loading commit data... | |
| texture_format_table_autogen.cpp | Loading commit data... | |
| texture_format_table_utils.h | Loading commit data... |