When a EGL pbuffer is created based on a D3D SRGB texture using EGL_ANGLE_d3d_texture_client_buffer, SRGB conversions are performed as if it was an SRGB surface. The value of EGL_GL_COLORSPACE now reflects that correctly. If the pbuffer is bound to a texture and used as a framebuffer attachment, querying GL_FRAMEBUFFER_COLOR_ATTACHMENT also reflects that correctly. The behavior is the same on both the D3D backend, where there is no native interop involved, and on the GL backend using WGL_NV_DX_interop(2). There are a few limitations on the GL backend that relies on native interop: 1. SRGB conversion for textures created this way can't be disabled using the GL_FRAMEBUFFER_SRGB_EXT toggle that's exposed in ANGLE through EXT_sRGB_write_control. This is now documented in the EGL_ANGLE_d3d_texture_client_buffer spec. On the D3D backend this is not a problem since EXT_sRGB_write_control is not supported either way. 2. Creating a pbuffer out of a D3D11 texture with the format DXGI_FORMAT_B8G8R8A8_UNORM_SRGB does not work, even though it was listed as one of the supported formats in the EGL_ANGLE_d3d_texture_client_buffer spec. It's now mentioned that support for this format is optional. BUG=angleproject:2300 TEST=angle_white_box_tests Change-Id: I70ee0646680805e4469291a5b2ce59e92fda009e Reviewed-on: https://chromium-review.googlesource.com/866743Reviewed-by:Geoff Lang <geofflang@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| shaders | Loading commit data... | |
| win32 | Loading commit data... | |
| winrt | Loading commit data... | |
| Blit11.cpp | Loading commit data... | |
| Blit11.h | Loading commit data... | |
| Buffer11.cpp | Loading commit data... | |
| Buffer11.h | Loading commit data... | |
| Clear11.cpp | Loading commit data... | |
| Clear11.h | Loading commit data... | |
| Context11.cpp | Loading commit data... | |
| Context11.h | Loading commit data... | |
| DebugAnnotator11.cpp | Loading commit data... | |
| DebugAnnotator11.h | Loading commit data... | |
| Fence11.cpp | Loading commit data... | |
| Fence11.h | Loading commit data... | |
| Framebuffer11.cpp | Loading commit data... | |
| Framebuffer11.h | Loading commit data... | |
| Image11.cpp | Loading commit data... | |
| Image11.h | Loading commit data... | |
| IndexBuffer11.cpp | Loading commit data... | |
| IndexBuffer11.h | Loading commit data... | |
| InputLayoutCache.cpp | Loading commit data... | |
| InputLayoutCache.h | Loading commit data... | |
| NativeWindow11.h | Loading commit data... | |
| PixelTransfer11.cpp | Loading commit data... | |
| PixelTransfer11.h | Loading commit data... | |
| ProgramPipeline11.cpp | Loading commit data... | |
| ProgramPipeline11.h | Loading commit data... | |
| Query11.cpp | Loading commit data... | |
| Query11.h | Loading commit data... | |
| RenderStateCache.cpp | Loading commit data... | |
| RenderStateCache.h | Loading commit data... | |
| RenderTarget11.cpp | Loading commit data... | |
| RenderTarget11.h | Loading commit data... | |
| Renderer11.cpp | Loading commit data... | |
| Renderer11.h | Loading commit data... | |
| ResourceManager11.cpp | Loading commit data... | |
| ResourceManager11.h | Loading commit data... | |
| ShaderExecutable11.cpp | Loading commit data... | |
| ShaderExecutable11.h | Loading commit data... | |
| StateManager11.cpp | Loading commit data... | |
| StateManager11.h | Loading commit data... | |
| StreamProducerD3DTexture.cpp | Loading commit data... | |
| StreamProducerD3DTexture.h | Loading commit data... | |
| SwapChain11.cpp | Loading commit data... | |
| SwapChain11.h | Loading commit data... | |
| TextureStorage11.cpp | Loading commit data... | |
| TextureStorage11.h | Loading commit data... | |
| TransformFeedback11.cpp | Loading commit data... | |
| TransformFeedback11.h | Loading commit data... | |
| Trim11.cpp | Loading commit data... | |
| Trim11.h | Loading commit data... | |
| VertexArray11.cpp | Loading commit data... | |
| VertexArray11.h | Loading commit data... | |
| VertexBuffer11.cpp | Loading commit data... | |
| VertexBuffer11.h | Loading commit data... | |
| copyvertex.h | Loading commit data... | |
| copyvertex.inl | Loading commit data... | |
| dxgi_format_data.json | Loading commit data... | |
| dxgi_format_map_autogen.cpp | Loading commit data... | |
| dxgi_support_data.json | Loading commit data... | |
| dxgi_support_table.cpp | Loading commit data... | |
| dxgi_support_table.h | Loading commit data... | |
| formatutils11.cpp | Loading commit data... | |
| formatutils11.h | Loading commit data... | |
| gen_dxgi_format_table.py | Loading commit data... | |
| gen_dxgi_support_tables.py | Loading commit data... | |
| gen_texture_format_table.py | Loading commit data... | |
| renderer11_utils.cpp | Loading commit data... | |
| renderer11_utils.h | Loading commit data... | |
| texture_format_data.json | Loading commit data... | |
| texture_format_map.json | Loading commit data... | |
| texture_format_table.cpp | Loading commit data... | |
| texture_format_table.h | Loading commit data... | |
| texture_format_table_autogen.cpp | Loading commit data... | |
| texture_format_table_utils.h | Loading commit data... |