When using a vertex buffer with DYNAMIC usage, with robust buffer access enabled, we would sometimes read out-of-bounds when using very large values for the index range. An unchecked signed addition would overflow and lead to reading a negative offset. Fix this problem by keeping the value size_t whenever possible. Also do clamped casts when converting to a smaller values. Also adds a regression test. Bug: chromium:842028 Change-Id: Ie630ac857c6acfc0bace849a03eebfbaa2fbe89a Reviewed-on: https://chromium-review.googlesource.com/1055928 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:Geoff Lang <geofflang@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| third_party/perf | Loading commit data... | |
| ANGLEPerfTest.cpp | Loading commit data... | |
| ANGLEPerfTest.h | Loading commit data... | |
| BindingPerf.cpp | Loading commit data... | |
| BitSetIteratorPerf.cpp | Loading commit data... | |
| BlitFramebufferPerf.cpp | Loading commit data... | |
| BufferSubData.cpp | Loading commit data... | |
| CompilerPerf.cpp | Loading commit data... | |
| DispatchComputePerf.cpp | Loading commit data... | |
| DrawCallPerf.cpp | Loading commit data... | |
| DrawCallPerfParams.cpp | Loading commit data... | |
| DrawCallPerfParams.h | Loading commit data... | |
| DrawElementsPerf.cpp | Loading commit data... | |
| DynamicPromotionPerfTest.cpp | Loading commit data... | |
| EGLInitializePerf.cpp | Loading commit data... | |
| IndexConversionPerf.cpp | Loading commit data... | |
| IndexDataManagerTest.cpp | Loading commit data... | |
| InstancingPerf.cpp | Loading commit data... | |
| InterleavedAttributeData.cpp | Loading commit data... | |
| LinkProgramPerfTest.cpp | Loading commit data... | |
| MultiviewPerf.cpp | Loading commit data... | |
| PointSprites.cpp | Loading commit data... | |
| TexSubImage.cpp | Loading commit data... | |
| TextureSampling.cpp | Loading commit data... | |
| TexturesPerf.cpp | Loading commit data... | |
| UniformsPerf.cpp | Loading commit data... | |
| VulkanPipelineCachePerf.cpp | Loading commit data... |