A call to glDrawElements results in a calling depth of up to 4 * glDrawElements * gl::Context::DrawElements * rx::ContextGL::DrawElements * VertexArrayGL::syncDrawState. Each function call has to save/restore a lot of registers which results in a stall in the prologue of rx::ContextGL::DrawElements due to memory bandwidth limitations. The main change is the function gl::Context::DrawElements being inlined to reduce the calling depth by one. In addition the call to ContextGL::syncDrawElementsState is now protected so that it gets called only if it's required. Finally a few small getter functions have been inlined where the calling code was bigger than the actual function. In total this change improves performance of the DrawElementsPerfBenchmark.Run/gl benchmark by 16%. Bug: angleproject:2966 Change-Id: I423d18452f2f5b520ab52850fda2054e1da86991 Reviewed-on: https://chromium-review.googlesource.com/c/1389988Reviewed-by:Jamie Madill <jmadill@chromium.org> Commit-Queue: Markus Tavenrath <matavenrath@nvidia.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| bmp_to_nv12.py | Loading commit data... | |
| bootstrap.py | Loading commit data... | |
| egl.xml | Loading commit data... | |
| egl_angle_ext.xml | Loading commit data... | |
| entry_point_packed_gl_enums.json | Loading commit data... | |
| gen_angle_gn_info_json.py | Loading commit data... | |
| generate_entry_points.py | Loading commit data... | |
| generate_loader.py | Loading commit data... | |
| generate_new_renderer.py | Loading commit data... | |
| generate_vulkan_layers_json.py | Loading commit data... | |
| gl.xml | Loading commit data... | |
| gl_angle_ext.xml | Loading commit data... | |
| msvs_projects.py | Loading commit data... | |
| perf_test_runner.py | Loading commit data... | |
| registry_xml.py | Loading commit data... | |
| remove_file_if_exists.py | Loading commit data... | |
| run_code_generation.py | Loading commit data... | |
| run_code_generation_hashes.json | Loading commit data... | |
| update_canary_angle.py | Loading commit data... | |
| vk_mandatory_format_support_capture_to_json.js | Loading commit data... |