WebGL requires that drawing produces INVALID_OPERATION if a texture's format doesn't match the sampler type it is bound to. This is a little confusing because samplers have two attributes that could be called "type": addressing mode (2D/3D/Cube), and component format (float/signed/unsigned/shadow). ANGLE already handled checking the addressing mode; this change adds checking for the component format. Fixes WebGL conformance test conformance2/uniforms/incompatible-texture-type-for-sampler.html Bug: chromium:809237 Change-Id: I52ebfecd92625e3ee10274cb5f548d7e53de72dd Reviewed-on: https://chromium-review.googlesource.com/c/1377611Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| bmp_to_nv12.py | Loading commit data... | |
| bootstrap.py | Loading commit data... | |
| egl.xml | Loading commit data... | |
| egl_angle_ext.xml | Loading commit data... | |
| entry_point_packed_gl_enums.json | Loading commit data... | |
| gen_angle_gn_info_json.py | Loading commit data... | |
| generate_entry_points.py | Loading commit data... | |
| generate_loader.py | Loading commit data... | |
| generate_new_renderer.py | Loading commit data... | |
| generate_vulkan_layers_json.py | Loading commit data... | |
| gl.xml | Loading commit data... | |
| gl_angle_ext.xml | Loading commit data... | |
| msvs_projects.py | Loading commit data... | |
| perf_test_runner.py | Loading commit data... | |
| registry_xml.py | Loading commit data... | |
| remove_file_if_exists.py | Loading commit data... | |
| run_code_generation.py | Loading commit data... | |
| run_code_generation_hashes.json | Loading commit data... | |
| update_canary_angle.py | Loading commit data... | |
| vk_mandatory_format_support_capture_to_json.js | Loading commit data... | |
| wgl.xml | Loading commit data... |