Previously the enum conversion script would convert all enums in gl.xml including those for desktop GL. When replaying from a CPP file we would sometimes try to use enum values that only are exposed in desktop GL. One example is GL_TEXTURE_MAX_ANISOTROPY/GL_TEXTURE_MAX_ANISOTROPY_EXT. GLES only has the "EXT" version. Desktop uses the core version. This was breaking a replay sample that used the EXT enum. Fix this by a) including the anisotropy extension in registry_xml and b) updating the enum script to only parse GLES 2 entries. In the future we could improve the situation by auto-generating a header that defines exactly the enums we need for ANGLE. Also updates the enum helper to use uppercase enum values. Bug: angleproject:3611 Change-Id: I1e01608bc8af282dc078d5a19ac4eba659c96b57 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1894143 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:Tim Van Patten <timvp@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| code_generation_hashes | Loading commit data... | |
| apply_clang_format_on_all_sources.py | Loading commit data... | |
| bmp_to_nv12.py | Loading commit data... | |
| bootstrap.py | Loading commit data... | |
| egl.xml | Loading commit data... | |
| egl_angle_ext.xml | Loading commit data... | |
| entry_point_packed_gl_enums.json | Loading commit data... | |
| export_targets.py | Loading commit data... | |
| file_exists.py | Loading commit data... | |
| gen_angle_gn_info_json.py | Loading commit data... | |
| gen_gl_enum_utils.py | Loading commit data... | |
| gen_proc_table.py | Loading commit data... | |
| generate_entry_points.py | Loading commit data... | |
| generate_loader.py | Loading commit data... | |
| generate_new_renderer.py | Loading commit data... | |
| generate_stats.py | Loading commit data... | |
| generate_vulkan_layers_json.py | Loading commit data... | |
| gl.xml | Loading commit data... | |
| gl_angle_ext.xml | Loading commit data... | |
| msvs_projects.py | Loading commit data... | |
| perf_test_runner.py | Loading commit data... | |
| registry_xml.py | Loading commit data... | |
| remove_files.py | Loading commit data... | |
| roll_deps.py | Loading commit data... | |
| run_code_generation.py | Loading commit data... | |
| trigger.bat | Loading commit data... | |
| trigger.py | Loading commit data... | |
| update_canary_angle.py | Loading commit data... | |
| vk_mandatory_format_support_capture_to_json.js | Loading commit data... | |
| wgl.xml | Loading commit data... |