When copying via glTexSubImage2D to a non-renderable format, GL_RGB9_E5, ANGLE's TextureVk::copySubTextureImpl will use the read-back and copy method. This path was ignoring the source offset in the source area computation. Fixes the following WebGL tests: conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-float.html conformance2/textures/canvas_sub_rectangle/tex-2d-rgb9_e5-rgb-half_float.html Bug: b/157744725 Change-Id: I714f8d3b8f1490edab5e7578445e9623215ce229 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2225611Reviewed-by:Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| runner | Loading commit data... | |
| third_party | Loading commit data... | |
| ANGLETest.cpp | Loading commit data... | |
| ANGLETest.h | Loading commit data... | |
| ConstantFoldingTest.cpp | Loading commit data... | |
| ConstantFoldingTest.h | Loading commit data... | |
| MultiviewTest.cpp | Loading commit data... | |
| MultiviewTest.h | Loading commit data... | |
| ShaderCompileTreeTest.cpp | Loading commit data... | |
| ShaderCompileTreeTest.h | Loading commit data... | |
| ShaderExtensionTest.h | Loading commit data... | |
| VulkanExternalHelper.cpp | Loading commit data... | |
| VulkanExternalHelper.h | Loading commit data... | |
| angle_test_configs.cpp | Loading commit data... | |
| angle_test_configs.h | Loading commit data... | |
| angle_test_instantiate.cpp | Loading commit data... | |
| angle_test_instantiate.h | Loading commit data... | |
| angle_test_instantiate_apple.h | Loading commit data... | |
| angle_test_instantiate_apple.mm | Loading commit data... | |
| angle_test_platform.cpp | Loading commit data... | |
| angle_test_platform.h | Loading commit data... | |
| compiler_test.cpp | Loading commit data... | |
| compiler_test.h | Loading commit data... | |
| draw_call_perf_utils.cpp | Loading commit data... | |
| draw_call_perf_utils.h | Loading commit data... | |
| gl_raii.h | Loading commit data... |