It is valid for an attribute and a uniform to have the same name
as long as they are declared in different stages.
Prior to this patch, if any shader stage declares a uniform we
disallowed reusing that name for an attribute.
From GLSL ES Spec 3.00.6, section 4.3.5:
If a uniform variable name is declared in one stage (e.g., a vertex
shader) but not in another (e.g., a fragment shader), then that name
is still available in the other stage for a different use.
This change allows Egginc game to work with ANGLE
Bug: angleproject:5497
Tests: angle_end2end_tests -
*UniformVariableNameReuseAcrossStages*
*GlobalNamesConflict*
Change-Id: I8f5657d40a213600d6fb48f63e37e4cdbae120b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2608865Reviewed-by:
Jamie Madill <jmadill@chromium.org>
Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| android | Loading commit data... | |
| build_overrides | Loading commit data... | |
| doc | Loading commit data... | |
| extensions | Loading commit data... | |
| gni | Loading commit data... | |
| include | Loading commit data... | |
| infra | Loading commit data... | |
| samples | Loading commit data... | |
| scripts | Loading commit data... | |
| src | Loading commit data... | |
| third_party | Loading commit data... | |
| tools | Loading commit data... | |
| util | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .gitattributes | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gn | Loading commit data... | |
| .style.yapf | Loading commit data... | |
| .vpython | Loading commit data... | |
| .vpython3 | Loading commit data... | |
| .yapfignore | Loading commit data... | |
| AUTHORS | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CONTRIBUTORS | Loading commit data... | |
| DEPS | Loading commit data... | |
| LICENSE | Loading commit data... | |
| OWNERS | Loading commit data... | |
| PRESUBMIT.py | Loading commit data... | |
| README.chromium | Loading commit data... | |
| README.md | Loading commit data... | |
| WATCHLISTS | Loading commit data... | |
| additional_readme_paths.json | Loading commit data... | |
| codereview.settings | Loading commit data... | |
| dotfile_settings.gni | Loading commit data... |