This CL contains two changes. One to how we print out GLboolean
values, and another to how we capture GLbooleans.
According to the spec, anything non-zero can be considered
GL_TRUE when setting state:
When the type of internal state is boolean, zero integer or
floating-point values are converted to FALSE and non-zero values
are converted to TRUE.
Dota Underlords is using 0xFF for GL_TRUE.
Before the change, this manifested as:
// logcat
glColorMask(context = 4, red = kUnknownGLenumString,
green = kUnknownGLenumString,
blue = kUnknownGLenumString,
alpha = GL_FALSE)
// trace
glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE);
After:
// logcat
glColorMask(context = 4, red = 0x00FF,
green = 0x00FF,
blue = 0x00FF,
alpha = GL_FALSE)
// trace
glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE);
Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by:
Tim Van Patten <timvp@google.com>
Reviewed-by:
Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| FrameCapture.cpp | Loading commit data... | |
| FrameCapture.h | Loading commit data... | |
| FrameCapture_mock.cpp | Loading commit data... | |
| OWNERS | Loading commit data... | |
| capture_gles_1_0_autogen.cpp | Loading commit data... | |
| capture_gles_1_0_autogen.h | Loading commit data... | |
| capture_gles_1_0_params.cpp | Loading commit data... | |
| capture_gles_2_0_autogen.cpp | Loading commit data... | |
| capture_gles_2_0_autogen.h | Loading commit data... | |
| capture_gles_2_0_params.cpp | Loading commit data... | |
| capture_gles_3_0_autogen.cpp | Loading commit data... | |
| capture_gles_3_0_autogen.h | Loading commit data... | |
| capture_gles_3_0_params.cpp | Loading commit data... | |
| capture_gles_3_1_autogen.cpp | Loading commit data... | |
| capture_gles_3_1_autogen.h | Loading commit data... | |
| capture_gles_3_1_params.cpp | Loading commit data... | |
| capture_gles_3_2_autogen.cpp | Loading commit data... | |
| capture_gles_3_2_autogen.h | Loading commit data... | |
| capture_gles_3_2_params.cpp | Loading commit data... | |
| capture_gles_ext_autogen.cpp | Loading commit data... | |
| capture_gles_ext_autogen.h | Loading commit data... | |
| capture_gles_ext_params.cpp | Loading commit data... | |
| frame_capture_replay_autogen.cpp | Loading commit data... | |
| frame_capture_utils.cpp | Loading commit data... | |
| frame_capture_utils.h | Loading commit data... | |
| frame_capture_utils_autogen.cpp | Loading commit data... | |
| frame_capture_utils_autogen.h | Loading commit data... | |
| frame_capture_utils_mock.cpp | Loading commit data... | |
| gl_enum_utils.cpp | Loading commit data... | |
| gl_enum_utils.h | Loading commit data... | |
| gl_enum_utils_autogen.cpp | Loading commit data... | |
| gl_enum_utils_autogen.h | Loading commit data... | |
| trace_fixture.cpp | Loading commit data... | |
| trace_fixture.h | Loading commit data... |