Compute dispatch commands must be submitted outside a renderpass, but their associated debug event markers were being submitted on the renderpass commandbuffer. The dispatch debug event markers are now handled separately from those for draw calls and are now submitted on the correct commandbuffer. Failure manifested in malformed AGI traces for Ragnarok M: Eternal Love Bug: b/181611786 Change-Id: I768eeccd76be38818fc99d6d56f5899290c8fc5b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2930818Reviewed-by:Ian Elliott <ianelliott@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| android | Loading commit data... | |
| display | Loading commit data... | |
| doc | Loading commit data... | |
| fuchsia | Loading commit data... | |
| ggp | Loading commit data... | |
| headless | Loading commit data... | |
| mac | Loading commit data... | |
| shaders | Loading commit data... | |
| win32 | Loading commit data... | |
| xcb | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| BufferVk.cpp | Loading commit data... | |
| BufferVk.h | Loading commit data... | |
| CLCommandQueueVk.cpp | Loading commit data... | |
| CLCommandQueueVk.h | Loading commit data... | |
| CLContextVk.cpp | Loading commit data... | |
| CLContextVk.h | Loading commit data... | |
| CLDeviceVk.cpp | Loading commit data... | |
| CLDeviceVk.h | Loading commit data... | |
| CLEventVk.cpp | Loading commit data... | |
| CLEventVk.h | Loading commit data... | |
| CLKernelVk.cpp | Loading commit data... | |
| CLKernelVk.h | Loading commit data... | |
| CLMemoryVk.cpp | Loading commit data... | |
| CLMemoryVk.h | Loading commit data... | |
| CLPlatformVk.cpp | Loading commit data... | |
| CLPlatformVk.h | Loading commit data... | |
| CLProgramVk.cpp | Loading commit data... | |
| CLProgramVk.h | Loading commit data... | |
| CLSamplerVk.cpp | Loading commit data... | |
| CLSamplerVk.h | Loading commit data... | |
| CommandProcessor.cpp | Loading commit data... | |
| CommandProcessor.h | Loading commit data... | |
| CompilerVk.cpp | Loading commit data... | |
| CompilerVk.h | Loading commit data... | |
| ContextVk.cpp | Loading commit data... | |
| ContextVk.h | Loading commit data... | |
| DebugAnnotatorVk.cpp | Loading commit data... | |
| DebugAnnotatorVk.h | Loading commit data... | |
| DeviceVk.cpp | Loading commit data... | |
| DeviceVk.h | Loading commit data... | |
| DisplayVk.cpp | Loading commit data... | |
| DisplayVk.h | Loading commit data... | |
| DisplayVk_api.h | Loading commit data... | |
| FenceNVVk.cpp | Loading commit data... | |
| FenceNVVk.h | Loading commit data... | |
| FramebufferVk.cpp | Loading commit data... | |
| FramebufferVk.h | Loading commit data... | |
| GlslangWrapperVk.cpp | Loading commit data... | |
| GlslangWrapperVk.h | Loading commit data... | |
| ImageVk.cpp | Loading commit data... | |
| ImageVk.h | Loading commit data... | |
| MemoryObjectVk.cpp | Loading commit data... | |
| MemoryObjectVk.h | Loading commit data... | |
| OWNERS | Loading commit data... | |
| OverlayVk.cpp | Loading commit data... | |
| OverlayVk.h | Loading commit data... | |
| PersistentCommandPool.cpp | Loading commit data... | |
| PersistentCommandPool.h | Loading commit data... | |
| ProgramExecutableVk.cpp | Loading commit data... | |
| ProgramExecutableVk.h | Loading commit data... | |
| ProgramPipelineVk.cpp | Loading commit data... | |
| ProgramPipelineVk.h | Loading commit data... | |
| ProgramVk.cpp | Loading commit data... | |
| ProgramVk.h | Loading commit data... | |
| QueryVk.cpp | Loading commit data... | |
| QueryVk.h | Loading commit data... | |
| README.md | Loading commit data... | |
| RenderTargetVk.cpp | Loading commit data... | |
| RenderTargetVk.h | Loading commit data... | |
| RenderbufferVk.cpp | Loading commit data... | |
| RenderbufferVk.h | Loading commit data... | |
| RendererVk.cpp | Loading commit data... | |
| RendererVk.h | Loading commit data... | |
| ResourceVk.cpp | Loading commit data... | |
| ResourceVk.h | Loading commit data... | |
| SamplerVk.cpp | Loading commit data... | |
| SamplerVk.h | Loading commit data... | |
| SecondaryCommandBuffer.cpp | Loading commit data... | |
| SecondaryCommandBuffer.h | Loading commit data... | |
| SemaphoreVk.cpp | Loading commit data... | |
| SemaphoreVk.h | Loading commit data... | |
| ShaderVk.cpp | Loading commit data... | |
| ShaderVk.h | Loading commit data... | |
| SurfaceVk.cpp | Loading commit data... | |
| SurfaceVk.h | Loading commit data... | |
| SyncVk.cpp | Loading commit data... | |
| SyncVk.h | Loading commit data... | |
| TextureVk.cpp | Loading commit data... | |
| TextureVk.h | Loading commit data... | |
| TransformFeedbackVk.cpp | Loading commit data... | |
| TransformFeedbackVk.h | Loading commit data... | |
| UtilsVk.cpp | Loading commit data... | |
| UtilsVk.h | Loading commit data... | |
| VertexArrayVk.cpp | Loading commit data... | |
| VertexArrayVk.h | Loading commit data... | |
| cl_types.h | Loading commit data... | |
| gen_vk_format_table.py | Loading commit data... | |
| gen_vk_internal_shaders.py | Loading commit data... | |
| gen_vk_mandatory_format_support_table.py | Loading commit data... | |
| vk_cache_utils.cpp | Loading commit data... | |
| vk_cache_utils.h | Loading commit data... | |
| vk_caps_utils.cpp | Loading commit data... | |
| vk_caps_utils.h | Loading commit data... | |
| vk_format_map.json | Loading commit data... | |
| vk_format_table_autogen.cpp | Loading commit data... | |
| vk_format_utils.cpp | Loading commit data... | |
| vk_format_utils.h | Loading commit data... | |
| vk_helpers.cpp | Loading commit data... | |
| vk_helpers.h | Loading commit data... | |
| vk_internal_shaders_autogen.cpp | Loading commit data... | |
| vk_internal_shaders_autogen.gni | Loading commit data... | |
| vk_internal_shaders_autogen.h | Loading commit data... | |
| vk_mandatory_format_support_data.json | Loading commit data... | |
| vk_mandatory_format_support_table_autogen.cpp | Loading commit data... | |
| vk_mem_alloc_wrapper.cpp | Loading commit data... | |
| vk_mem_alloc_wrapper.h | Loading commit data... | |
| vk_utils.cpp | Loading commit data... | |
| vk_utils.h | Loading commit data... | |
| vk_wrapper.h | Loading commit data... |