CaptureMidExecutionSetup() hits an assert while capturing "World War
Doh":
ANGLE : FATAL: FrameCapture.cpp:2876 (CaptureMidExecutionSetup):
! Assert failed [[[...]]] attrib.location != -1
This is due to CaptureMidExecutionSetup() enforcing that all attributes,
including built-ins, have a location. However, in the case of "World War
Doh", the built-in 'gl_GlobalInvocationID' does not have a location.
Moving the assert to after the gl::IsBuiltInName() check allows the
capture to complete without hitting any asserts.
Bug: angleproject:4048
Test: Capture "World War Doh"
Change-Id: Ice96dec629b1477b11a710283c4ec4bf1c95c6e2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2606807Reviewed-by:
Jamie Madill <jmadill@chromium.org>
Reviewed-by:
Cody Northrop <cnorthrop@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| android | Loading commit data... | |
| build_overrides | Loading commit data... | |
| doc | Loading commit data... | |
| extensions | Loading commit data... | |
| gni | Loading commit data... | |
| include | Loading commit data... | |
| infra | Loading commit data... | |
| samples | Loading commit data... | |
| scripts | Loading commit data... | |
| src | Loading commit data... | |
| third_party | Loading commit data... | |
| tools | Loading commit data... | |
| util | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .gitattributes | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gn | Loading commit data... | |
| .style.yapf | Loading commit data... | |
| .vpython | Loading commit data... | |
| .vpython3 | Loading commit data... | |
| .yapfignore | Loading commit data... | |
| AUTHORS | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CONTRIBUTORS | Loading commit data... | |
| DEPS | Loading commit data... | |
| LICENSE | Loading commit data... | |
| OWNERS | Loading commit data... | |
| PRESUBMIT.py | Loading commit data... | |
| README.chromium | Loading commit data... | |
| README.md | Loading commit data... | |
| WATCHLISTS | Loading commit data... | |
| additional_readme_paths.json | Loading commit data... | |
| codereview.settings | Loading commit data... | |
| dotfile_settings.gni | Loading commit data... |