This reverts commit c13bda86. Reason for revert: May have broken LibFuzzer and AFL builds: https://ci.chromium.org/buildbot/chromium.fyi/Afl%20Upload%20Linux%20ASan/7718 https://build.chromium.org/deprecated/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20ASan/builds/8691 In file included from ../../third_party/angle/src/compiler/translator/TextureFunctionHLSL.cpp:12: In file included from ../../third_party/angle/src/compiler/translator/TextureFunctionHLSL.h:19: ../../third_party/angle/src/compiler/translator/InfoSink.h:40:16: error: call to function 'operator<<' that is neither visible in the template definition nor found by argument-dependent lookup stream << t; ^ ../../third_party/angle/src/compiler/translator/TextureFunctionHLSL.cpp:111:9: note: in instantiation of function template specialization 'sh::TInfoSinkBase::operator<<<sh::ImmutableString>' requested here out << textureReference; ^ ../../third_party/angle/src/compiler/translator/ImmutableString.h:76:15: note: 'operator<<' should be declared prior to the call site or in namespace 'sh' std::ostream &operator<<(std::ostream &os, const sh::ImmutableString &str); ^ 1 error generated. Bug: chromium:806619 Original change's description: > Use ImmutableString for HLSL texture references > > This also adds ImmutableStringBuilder class, which can be used to > build ImmutableStrings in place without extra allocations if the > maximum length is known in advance. > > BUG=angleproject:2267 > TEST=angle_unittests > > Change-Id: I4dfb78adeb0cffcfad0d25753fb8063466012c92 > Reviewed-on: https://chromium-review.googlesource.com/886362 > Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=jmadill@chromium.org,cwallez@chromium.org,oetuaho@nvidia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:2267 Change-Id: I445f5a786f8b16c3f40f28df09d45fcb215a9c88 Reviewed-on: https://chromium-review.googlesource.com/890542Reviewed-by:Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| 64bit-lexer-safety.patch | Loading commit data... | |
| ASTMetadataHLSL.cpp | Loading commit data... | |
| ASTMetadataHLSL.h | Loading commit data... | |
| AddAndTrueToLoopCondition.cpp | Loading commit data... | |
| AddAndTrueToLoopCondition.h | Loading commit data... | |
| AddDefaultReturnStatements.cpp | Loading commit data... | |
| AddDefaultReturnStatements.h | Loading commit data... | |
| ArrayReturnValueToOutParameter.cpp | Loading commit data... | |
| ArrayReturnValueToOutParameter.h | Loading commit data... | |
| BaseTypes.h | Loading commit data... | |
| BreakVariableAliasingInInnerLoops.cpp | Loading commit data... | |
| BreakVariableAliasingInInnerLoops.h | Loading commit data... | |
| BuiltInFunctionEmulator.cpp | Loading commit data... | |
| BuiltInFunctionEmulator.h | Loading commit data... | |
| BuiltInFunctionEmulatorGLSL.cpp | Loading commit data... | |
| BuiltInFunctionEmulatorGLSL.h | Loading commit data... | |
| BuiltInFunctionEmulatorHLSL.cpp | Loading commit data... | |
| BuiltInFunctionEmulatorHLSL.h | Loading commit data... | |
| CallDAG.cpp | Loading commit data... | |
| CallDAG.h | Loading commit data... | |
| ClampFragDepth.cpp | Loading commit data... | |
| ClampFragDepth.h | Loading commit data... | |
| ClampPointSize.cpp | Loading commit data... | |
| ClampPointSize.h | Loading commit data... | |
| CodeGen.cpp | Loading commit data... | |
| CollectVariables.cpp | Loading commit data... | |
| CollectVariables.h | Loading commit data... | |
| Common.h | Loading commit data... | |
| Compiler.cpp | Loading commit data... | |
| Compiler.h | Loading commit data... | |
| ConstantUnion.cpp | Loading commit data... | |
| ConstantUnion.h | Loading commit data... | |
| Declarator.cpp | Loading commit data... | |
| Declarator.h | Loading commit data... | |
| DeclareAndInitBuiltinsForInstancedMultiview.cpp | Loading commit data... | |
| DeclareAndInitBuiltinsForInstancedMultiview.h | Loading commit data... | |
| DeferGlobalInitializers.cpp | Loading commit data... | |
| DeferGlobalInitializers.h | Loading commit data... | |
| Diagnostics.cpp | Loading commit data... | |
| Diagnostics.h | Loading commit data... | |
| DirectiveHandler.cpp | Loading commit data... | |
| DirectiveHandler.h | Loading commit data... | |
| EmulateGLFragColorBroadcast.cpp | Loading commit data... | |
| EmulateGLFragColorBroadcast.h | Loading commit data... | |
| EmulatePrecision.cpp | Loading commit data... | |
| EmulatePrecision.h | Loading commit data... | |
| ExpandIntegerPowExpressions.cpp | Loading commit data... | |
| ExpandIntegerPowExpressions.h | Loading commit data... | |
| ExtensionBehavior.cpp | Loading commit data... | |
| ExtensionBehavior.h | Loading commit data... | |
| ExtensionGLSL.cpp | Loading commit data... | |
| ExtensionGLSL.h | Loading commit data... | |
| FindMain.cpp | Loading commit data... | |
| FindMain.h | Loading commit data... | |
| FindSymbolNode.cpp | Loading commit data... | |
| FindSymbolNode.h | Loading commit data... | |
| FlagStd140Structs.cpp | Loading commit data... | |
| FlagStd140Structs.h | Loading commit data... | |
| FoldExpressions.cpp | Loading commit data... | |
| FoldExpressions.h | Loading commit data... | |
| HashNames.cpp | Loading commit data... | |
| HashNames.h | Loading commit data... | |
| ImageFunctionHLSL.cpp | Loading commit data... | |
| ImageFunctionHLSL.h | Loading commit data... | |
| ImmutableString.h | Loading commit data... | |
| InfoSink.cpp | Loading commit data... | |
| InfoSink.h | Loading commit data... | |
| Initialize.cpp | Loading commit data... | |
| Initialize.h | Loading commit data... | |
| InitializeDll.cpp | Loading commit data... | |
| InitializeDll.h | Loading commit data... | |
| InitializeGlobals.h | Loading commit data... | |
| InitializeVariables.cpp | Loading commit data... | |
| InitializeVariables.h | Loading commit data... | |
| IntermNode.cpp | Loading commit data... | |
| IntermNode.h | Loading commit data... | |
| IntermNodePatternMatcher.cpp | Loading commit data... | |
| IntermNodePatternMatcher.h | Loading commit data... | |
| IntermNode_util.cpp | Loading commit data... | |
| IntermNode_util.h | Loading commit data... | |
| IntermTraverse.cpp | Loading commit data... | |
| IntermTraverse.h | Loading commit data... | |
| IsASTDepthBelowLimit.cpp | Loading commit data... | |
| IsASTDepthBelowLimit.h | Loading commit data... | |
| NodeSearch.h | Loading commit data... | |
| Operator.cpp | Loading commit data... | |
| Operator.h | Loading commit data... | |
| OutputESSL.cpp | Loading commit data... | |
| OutputESSL.h | Loading commit data... | |
| OutputGLSL.cpp | Loading commit data... | |
| OutputGLSL.h | Loading commit data... | |
| OutputGLSLBase.cpp | Loading commit data... | |
| OutputGLSLBase.h | Loading commit data... | |
| OutputHLSL.cpp | Loading commit data... | |
| OutputHLSL.h | Loading commit data... | |
| OutputTree.cpp | Loading commit data... | |
| OutputTree.h | Loading commit data... | |
| OutputVulkanGLSL.cpp | Loading commit data... | |
| OutputVulkanGLSL.h | Loading commit data... | |
| ParamType.h | Loading commit data... | |
| ParseContext.cpp | Loading commit data... | |
| ParseContext.h | Loading commit data... | |
| PoolAlloc.cpp | Loading commit data... | |
| PoolAlloc.h | Loading commit data... | |
| Pragma.h | Loading commit data... | |
| PruneNoOps.cpp | Loading commit data... | |
| PruneNoOps.h | Loading commit data... | |
| QualifierTypes.cpp | Loading commit data... | |
| QualifierTypes.h | Loading commit data... | |
| RecordConstantPrecision.cpp | Loading commit data... | |
| RecordConstantPrecision.h | Loading commit data... | |
| RegenerateStructNames.cpp | Loading commit data... | |
| RegenerateStructNames.h | Loading commit data... | |
| RemoveArrayLengthMethod.cpp | Loading commit data... | |
| RemoveArrayLengthMethod.h | Loading commit data... | |
| RemoveDynamicIndexing.cpp | Loading commit data... | |
| RemoveDynamicIndexing.h | Loading commit data... | |
| RemoveEmptySwitchStatements.cpp | Loading commit data... | |
| RemoveEmptySwitchStatements.h | Loading commit data... | |
| RemoveInvariantDeclaration.cpp | Loading commit data... | |
| RemoveInvariantDeclaration.h | Loading commit data... | |
| RemoveNoOpCasesFromEndOfSwitchStatements.cpp | Loading commit data... | |
| RemoveNoOpCasesFromEndOfSwitchStatements.h | Loading commit data... | |
| RemovePow.cpp | Loading commit data... | |
| RemovePow.h | Loading commit data... | |
| RemoveSwitchFallThrough.cpp | Loading commit data... | |
| RemoveSwitchFallThrough.h | Loading commit data... | |
| RemoveUnreferencedVariables.cpp | Loading commit data... | |
| RemoveUnreferencedVariables.h | Loading commit data... | |
| ReplaceVariable.cpp | Loading commit data... | |
| ReplaceVariable.h | Loading commit data... | |
| RewriteDoWhile.cpp | Loading commit data... | |
| RewriteDoWhile.h | Loading commit data... | |
| RewriteElseBlocks.cpp | Loading commit data... | |
| RewriteElseBlocks.h | Loading commit data... | |
| RewriteTexelFetchOffset.cpp | Loading commit data... | |
| RewriteTexelFetchOffset.h | Loading commit data... | |
| RewriteUnaryMinusOperatorFloat.cpp | Loading commit data... | |
| RewriteUnaryMinusOperatorFloat.h | Loading commit data... | |
| RewriteUnaryMinusOperatorInt.cpp | Loading commit data... | |
| RewriteUnaryMinusOperatorInt.h | Loading commit data... | |
| RunAtTheEndOfShader.cpp | Loading commit data... | |
| RunAtTheEndOfShader.h | Loading commit data... | |
| ScalarizeVecAndMatConstructorArgs.cpp | Loading commit data... | |
| ScalarizeVecAndMatConstructorArgs.h | Loading commit data... | |
| SeparateArrayConstructorStatements.cpp | Loading commit data... | |
| SeparateArrayConstructorStatements.h | Loading commit data... | |
| SeparateArrayInitialization.cpp | Loading commit data... | |
| SeparateArrayInitialization.h | Loading commit data... | |
| SeparateDeclarations.cpp | Loading commit data... | |
| SeparateDeclarations.h | Loading commit data... | |
| SeparateExpressionsReturningArrays.cpp | Loading commit data... | |
| SeparateExpressionsReturningArrays.h | Loading commit data... | |
| Severity.h | Loading commit data... | |
| ShaderLang.cpp | Loading commit data... | |
| ShaderVars.cpp | Loading commit data... | |
| SimplifyLoopConditions.cpp | Loading commit data... | |
| SimplifyLoopConditions.h | Loading commit data... | |
| SplitSequenceOperator.cpp | Loading commit data... | |
| SplitSequenceOperator.h | Loading commit data... | |
| StaticType.cpp | Loading commit data... | |
| StaticType.h | Loading commit data... | |
| StructureHLSL.cpp | Loading commit data... | |
| StructureHLSL.h | Loading commit data... | |
| Symbol.cpp | Loading commit data... | |
| Symbol.h | Loading commit data... | |
| SymbolTable.cpp | Loading commit data... | |
| SymbolTable.h | Loading commit data... | |
| SymbolUniqueId.cpp | Loading commit data... | |
| SymbolUniqueId.h | Loading commit data... | |
| TextureFunctionHLSL.cpp | Loading commit data... | |
| TextureFunctionHLSL.h | Loading commit data... | |
| TranslatorESSL.cpp | Loading commit data... | |
| TranslatorESSL.h | Loading commit data... | |
| TranslatorGLSL.cpp | Loading commit data... | |
| TranslatorGLSL.h | Loading commit data... | |
| TranslatorHLSL.cpp | Loading commit data... | |
| TranslatorHLSL.h | Loading commit data... | |
| TranslatorVulkan.cpp | Loading commit data... | |
| TranslatorVulkan.h | Loading commit data... | |
| Types.cpp | Loading commit data... | |
| Types.h | Loading commit data... | |
| UnfoldShortCircuitAST.cpp | Loading commit data... | |
| UnfoldShortCircuitAST.h | Loading commit data... | |
| UnfoldShortCircuitToIf.cpp | Loading commit data... | |
| UnfoldShortCircuitToIf.h | Loading commit data... | |
| UniformHLSL.cpp | Loading commit data... | |
| UniformHLSL.h | Loading commit data... | |
| UseInterfaceBlockFields.cpp | Loading commit data... | |
| UseInterfaceBlockFields.h | Loading commit data... | |
| UtilsHLSL.cpp | Loading commit data... | |
| UtilsHLSL.h | Loading commit data... | |
| ValidateGlobalInitializer.cpp | Loading commit data... | |
| ValidateGlobalInitializer.h | Loading commit data... | |
| ValidateLimitations.cpp | Loading commit data... | |
| ValidateLimitations.h | Loading commit data... | |
| ValidateMaxParameters.cpp | Loading commit data... | |
| ValidateMaxParameters.h | Loading commit data... | |
| ValidateOutputs.cpp | Loading commit data... | |
| ValidateOutputs.h | Loading commit data... | |
| ValidateSwitch.cpp | Loading commit data... | |
| ValidateSwitch.h | Loading commit data... | |
| ValidateVaryingLocations.cpp | Loading commit data... | |
| ValidateVaryingLocations.h | Loading commit data... | |
| VariablePacker.cpp | Loading commit data... | |
| VariablePacker.h | Loading commit data... | |
| VectorizeVectorScalarArithmetic.cpp | Loading commit data... | |
| VectorizeVectorScalarArithmetic.h | Loading commit data... | |
| VersionGLSL.cpp | Loading commit data... | |
| VersionGLSL.h | Loading commit data... | |
| WrapSwitchStatementsInBlocks.cpp | Loading commit data... | |
| WrapSwitchStatementsInBlocks.h | Loading commit data... | |
| blocklayout.cpp | Loading commit data... | |
| blocklayout.h | Loading commit data... | |
| blocklayoutHLSL.cpp | Loading commit data... | |
| blocklayoutHLSL.h | Loading commit data... | |
| emulated_builtin_function_data_hlsl.json | Loading commit data... | |
| emulated_builtin_functions_hlsl_autogen.cpp | Loading commit data... | |
| gen_emulated_builtin_function_tables.py | Loading commit data... | |
| generate_parser.sh | Loading commit data... | |
| glslang.h | Loading commit data... | |
| glslang.l | Loading commit data... | |
| glslang.y | Loading commit data... | |
| glslang_lex.cpp | Loading commit data... | |
| glslang_tab.cpp | Loading commit data... | |
| glslang_tab.h | Loading commit data... | |
| length_limits.h | Loading commit data... | |
| util.cpp | Loading commit data... | |
| util.h | Loading commit data... |