This reverts commit de335c16. Reason for revert: Might actually regress CPU overhead perf. Unsure but it's possible the reported perf improvement was due to variance. Original change's description: > Vulkan: Implement a SharedResourceUse pool > > When adding a Resource to the ResourceUseList of ContextVk > we constructed a new SharedResourceUse object for tracking > and update of the Resource's Serial. We would then delete > it after releasing the resource. This incurs repeated > memory operation costs. > > Instead we now allocate a pool of SharedResourceUse objects > and acquire and release from this pool as needed. > > VTune profile of the Manhattan 30 offscreen benchmark > shows the CPU occupancy of bufferRead decrease from an > average of 0.9% -> 0.6% and imageRead decreases from > an average of 0.4% -> 0.3%. The bottleneck for both > these methods is the retain() method that leverages > the new SharedResourceUse pool. > > Bug: angleproject:4950 > Change-Id: Ib4f67c6f101d4b2de118014546e6cc14ad108703 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396597 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Mohan Maiya <m.maiya@samsung.com> TBR=syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:4950 Change-Id: I40081551c3db67d6e55182fea40119946ed16ac3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2426479Reviewed-by:Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| android | Loading commit data... | |
| doc | Loading commit data... | |
| fuchsia | Loading commit data... | |
| ggp | Loading commit data... | |
| mac | Loading commit data... | |
| shaders | Loading commit data... | |
| win32 | Loading commit data... | |
| xcb | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| BufferVk.cpp | Loading commit data... | |
| BufferVk.h | Loading commit data... | |
| CommandProcessor.cpp | Loading commit data... | |
| CommandProcessor.h | Loading commit data... | |
| CompilerVk.cpp | Loading commit data... | |
| CompilerVk.h | Loading commit data... | |
| ContextVk.cpp | Loading commit data... | |
| ContextVk.h | Loading commit data... | |
| DeviceVk.cpp | Loading commit data... | |
| DeviceVk.h | Loading commit data... | |
| DisplayVk.cpp | Loading commit data... | |
| DisplayVk.h | Loading commit data... | |
| DisplayVk_api.h | Loading commit data... | |
| FenceNVVk.cpp | Loading commit data... | |
| FenceNVVk.h | Loading commit data... | |
| FramebufferVk.cpp | Loading commit data... | |
| FramebufferVk.h | Loading commit data... | |
| GlslangWrapperVk.cpp | Loading commit data... | |
| GlslangWrapperVk.h | Loading commit data... | |
| ImageVk.cpp | Loading commit data... | |
| ImageVk.h | Loading commit data... | |
| MemoryObjectVk.cpp | Loading commit data... | |
| MemoryObjectVk.h | Loading commit data... | |
| OWNERS | Loading commit data... | |
| OverlayVk.cpp | Loading commit data... | |
| OverlayVk.h | Loading commit data... | |
| PersistentCommandPool.cpp | Loading commit data... | |
| PersistentCommandPool.h | Loading commit data... | |
| ProgramExecutableVk.cpp | Loading commit data... | |
| ProgramExecutableVk.h | Loading commit data... | |
| ProgramPipelineVk.cpp | Loading commit data... | |
| ProgramPipelineVk.h | Loading commit data... | |
| ProgramVk.cpp | Loading commit data... | |
| ProgramVk.h | Loading commit data... | |
| QueryVk.cpp | Loading commit data... | |
| QueryVk.h | Loading commit data... | |
| README.md | Loading commit data... | |
| RenderTargetVk.cpp | Loading commit data... | |
| RenderTargetVk.h | Loading commit data... | |
| RenderbufferVk.cpp | Loading commit data... | |
| RenderbufferVk.h | Loading commit data... | |
| RendererVk.cpp | Loading commit data... | |
| RendererVk.h | Loading commit data... | |
| ResourceVk.cpp | Loading commit data... | |
| ResourceVk.h | Loading commit data... | |
| SamplerVk.cpp | Loading commit data... | |
| SamplerVk.h | Loading commit data... | |
| SecondaryCommandBuffer.cpp | Loading commit data... | |
| SecondaryCommandBuffer.h | Loading commit data... | |
| SemaphoreVk.cpp | Loading commit data... | |
| SemaphoreVk.h | Loading commit data... | |
| ShaderVk.cpp | Loading commit data... | |
| ShaderVk.h | Loading commit data... | |
| SurfaceVk.cpp | Loading commit data... | |
| SurfaceVk.h | Loading commit data... | |
| SyncVk.cpp | Loading commit data... | |
| SyncVk.h | Loading commit data... | |
| TextureVk.cpp | Loading commit data... | |
| TextureVk.h | Loading commit data... | |
| TransformFeedbackVk.cpp | Loading commit data... | |
| TransformFeedbackVk.h | Loading commit data... | |
| UtilsVk.cpp | Loading commit data... | |
| UtilsVk.h | Loading commit data... | |
| VertexArrayVk.cpp | Loading commit data... | |
| VertexArrayVk.h | Loading commit data... | |
| gen_vk_format_table.py | Loading commit data... | |
| gen_vk_internal_shaders.py | Loading commit data... | |
| gen_vk_mandatory_format_support_table.py | Loading commit data... | |
| vk_cache_utils.cpp | Loading commit data... | |
| vk_cache_utils.h | Loading commit data... | |
| vk_caps_utils.cpp | Loading commit data... | |
| vk_caps_utils.h | Loading commit data... | |
| vk_format_map.json | Loading commit data... | |
| vk_format_table_autogen.cpp | Loading commit data... | |
| vk_format_utils.cpp | Loading commit data... | |
| vk_format_utils.h | Loading commit data... | |
| vk_helpers.cpp | Loading commit data... | |
| vk_helpers.h | Loading commit data... | |
| vk_internal_shaders_autogen.cpp | Loading commit data... | |
| vk_internal_shaders_autogen.gni | Loading commit data... | |
| vk_internal_shaders_autogen.h | Loading commit data... | |
| vk_mandatory_format_support_data.json | Loading commit data... | |
| vk_mandatory_format_support_table_autogen.cpp | Loading commit data... | |
| vk_mem_alloc_wrapper.cpp | Loading commit data... | |
| vk_mem_alloc_wrapper.h | Loading commit data... | |
| vk_utils.cpp | Loading commit data... | |
| vk_utils.h | Loading commit data... | |
| vk_wrapper.h | Loading commit data... |